Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | removed the default_scope deprecations and updated the docs and tests to ↵ | Josh Kalderimis | 2011-04-28 | 1 | -14/+6 | |
| | | | | | | | | reflect its use cases | |||||
* | | assert_difference can take a callable piece of code rather than just evaling ↵ | Aaron Patterson | 2011-05-01 | 1 | -4/+4 | |
| | | | | | | | | a string | |||||
* | | fixing more test warnings in 1.9.3 | Aaron Patterson | 2011-04-30 | 3 | -6/+6 | |
| | | ||||||
* | | fixing test warnings | Aaron Patterson | 2011-04-30 | 1 | -7/+1 | |
| | | ||||||
* | | making sure the `create_fixtures` method works to prevent regressions | Aaron Patterson | 2011-04-29 | 1 | -0/+5 | |
| | | ||||||
* | | supporting nil when passed in as an IN clause | Aaron Patterson | 2011-04-29 | 1 | -3/+4 | |
| | | ||||||
* | | Test that passing nil member of array in conditions retrieves records with nil | gmile | 2011-04-29 | 1 | -0/+22 | |
|/ | | | | value on a selected field. | |||||
* | some test renaming to avoid collisions, and some annoying issues between dbs | Josh Kalderimis | 2011-04-27 | 1 | -7/+7 | |
| | ||||||
* | final corrections to the mass-assignment security tests | Josh Kalderimis | 2011-04-27 | 1 | -4/+4 | |
| | ||||||
* | fix mass-assignment security tests, this was due to a string column limit ↵ | Josh Kalderimis | 2011-04-27 | 2 | -15/+15 | |
| | | | | which doesn't cause issues on sqlite | |||||
* | AR update_attributes api is updated to reflect the addition of assign_attributes | Josh Kalderimis | 2011-04-26 | 1 | -0/+40 | |
| | ||||||
* | Merged pull request #310 from beanieboi/master. | Aaron Patterson | 2011-04-26 | 2 | -0/+32 | |
|\ | | | | | Added support for tsvector datatype in postgres | |||||
| * | Added tsvector Datatype Support | Benjamin Fritsch | 2011-04-26 | 2 | -0/+32 | |
| | | | | | | Applied Patch from https://rails.lighthouseapp.com/projects/8994/tickets/5577-suport-from-tsvector-data-type-in-postgresql | |||||
* | | Merged pull request #308 from joshk/assign_attributes. | José Valim | 2011-04-25 | 1 | -0/+6 | |
|\ \ | | | | | | | deprecated the use of guard_protected_attributes with attributes= in AR | |||||
| * | | deprecated the use of the guard_protected_attributes argument with ↵ | Josh Kalderimis | 2011-04-25 | 1 | -0/+6 | |
| | | | | | | | | | | | | attributes= in AR in favor of assign_attributes(attrs, :without_protection => true) | |||||
* | | | Do not use SQL LIKE operator for case insensitive uniqueness validation | Raimonds Simanovskis | 2011-04-25 | 1 | -0/+26 | |
|/ / | | | | | It can result in wrong results if values contain special % or _ characters. It is safer to use SQL LOWER function and compare for equality. | |||||
* | | Added assign_attributes to Active Record which accepts a mass-assignment ↵ | Josh Kalderimis | 2011-04-24 | 3 | -2/+73 | |
| | | | | | | | | security scope using the :as option, while also allowing mass-assignment security to be bypassed using :with_protected | |||||
* | | Added test case and fix for proper eager loading associations | Pavel Forkert | 2011-04-22 | 1 | -0/+10 | |
|/ | ||||||
* | Bring back support for passing a callable object to the default_scope macro. ↵ | Jon Leighton | 2011-04-18 | 1 | -0/+12 | |
| | | | | You can also just use a block. | |||||
* | Un-deprecate using 'default_scope' as a macro, but if you are calling the ↵ | Jon Leighton | 2011-04-18 | 1 | -164/+17 | |
| | | | | macro multiple times that will give deprecation warnings, and in 3.2 we will simply overwrite the default scope when you call the macro multiple times. | |||||
* | Fix test_associate_existing in has_many_through_associations_test on mysql ↵ | Jon Leighton | 2011-04-17 | 1 | -1/+1 | |
| | | | | and postgresql | |||||
* | Revert "Deprecate defining scopes with a callable (lambda, proc, etc) via ↵ | Jon Leighton | 2011-04-17 | 1 | -6/+0 | |
| | | | | | | | | | | the scope class method. Just define a class method yourself instead." This reverts commit f0e198bfa1e3f9689e0cde1d194a44027fc90b3c. Conflicts: activerecord/test/models/post.rb | |||||
* | Bypass IdentityMap in PostgreSQL geometric tests. | Jason Weathered | 2011-04-17 | 1 | -2/+2 | |
| | | | | The identity map cache prevents us from seeing the DB formatted strings. | |||||
* | Return nil from read_attribute(:foo) if 'foo' is not present in the ↵ | Jon Leighton | 2011-04-15 | 1 | -1/+2 | |
| | | | | @attributes hash, but the _foo method has been defined. This brings the behaviour into line with the 3-0-stable branch and the master branch before 93641ed6c8c684f6b4db02b6c8a22fa9bc7f0eaf (there were previously no assertions about this which is why the change slipped through). Note that actually calling the 'foo' method will still raise an error if the attribute is not present. | |||||
* | Undo performances regressions I introduced in ↵ | Jon Leighton | 2011-04-15 | 1 | -0/+11 | |
| | | | | bbe0a507f287c20ab4ae8a244fbfc810665deda5 and add test for an edge case. Add comments to explain the intent of the code. | |||||
* | Refactor test to avoid hackery | Jon Leighton | 2011-04-15 | 1 | -4/+4 | |
| | ||||||
* | Remove unnecessary code from define_read_method and add assertion to make ↵ | Jon Leighton | 2011-04-15 | 1 | -0/+1 | |
| | | | | sure the underscored version is actually generated | |||||
* | mysql type cast should return integers when typecasting true / false | Aaron Patterson | 2011-04-14 | 2 | -0/+51 | |
| | ||||||
* | using the database adapter to typecast before executing prepared statement | Aaron Patterson | 2011-04-14 | 1 | -0/+19 | |
| | ||||||
* | inserting big decimals as strings works consistently among dbs, so use ↵ | Aaron Patterson | 2011-04-14 | 1 | -1/+1 | |
| | | | | string form | |||||
* | adding a type cast method for prepared statements | Aaron Patterson | 2011-04-14 | 1 | -0/+93 | |
| | ||||||
* | do not depend on to_yaml being called, but rather depend on YAML being dumped | Aaron Patterson | 2011-04-13 | 1 | -6/+7 | |
| | ||||||
* | use index based substitution for bind parameters | Aaron Patterson | 2011-04-13 | 4 | -6/+6 | |
| | ||||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 2 | -2/+2 | |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | |||||
* | Deprecate defining scopes with a callable (lambda, proc, etc) via the scope ↵ | Jon Leighton | 2011-04-12 | 1 | -0/+6 | |
| | | | | class method. Just define a class method yourself instead. | |||||
* | ActiveRecord::Base.scopes hash is not needed | Jon Leighton | 2011-04-12 | 1 | -11/+0 | |
| | ||||||
* | Evaluate default scopes at the last possible moment in order to avoid ↵ | Jon Leighton | 2011-04-12 | 3 | -17/+14 | |
| | | | | problems with default scopes getting included into other scopes and then being unable to remove the default part via unscoped. | |||||
* | Deprecated support for passing hashes and relations to default_scope, in ↵ | Jon Leighton | 2011-04-12 | 5 | -91/+192 | |
| | | | | favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details. | |||||
* | Removing the scope-caching which happens on association proxies, because the ↵ | Jon Leighton | 2011-04-12 | 1 | -10/+15 | |
| | | | | query is already cached by the query cacher. For formalised proof see http://www.youtube.com/watch?v=wDefXLb-FDs | |||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 2 | -2/+2 | |
| | | | | suggestion! | |||||
* | wrap the pg_get_serial_sequence function and reuse it for the default ↵ | Aaron Patterson | 2011-04-11 | 1 | -0/+25 | |
| | | | | sequence name | |||||
* | adding exec_insert for postgresql | Aaron Patterson | 2011-04-11 | 2 | -1/+39 | |
| | ||||||
* | fixing variable name in mysql test | Aaron Patterson | 2011-04-11 | 1 | -1/+1 | |
| | ||||||
* | adding mysql adapter test case | Aaron Patterson | 2011-04-11 | 1 | -0/+69 | |
| | ||||||
* | adding exec_insert to sqlite3 | Aaron Patterson | 2011-04-11 | 1 | -0/+12 | |
| | ||||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 4 | -6/+10 | |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | |||||
* | moving sqlite_adapter_tests to sqlite3_adapter_test so that the tests are ↵ | Aaron Patterson | 2011-04-08 | 2 | -229/+215 | |
| | | | | actually run. :bomb: | |||||
* | Disable IdentityMap in log tests, it's not important and when running tests ↵ | Emilio Tagua | 2011-04-05 | 1 | -0/+3 | |
| | | | | | | rake task it logs more messages in the tested buffer. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Destroying records via nested attributes works independent of reject_if: | Durran Jordan | 2011-04-05 | 1 | -0/+8 | |
| | | | | | | | | | | - When a :_destroy truthiness is provided in the attributes hash, the record should get destroyed regardless of the result of the proc or method supplied to :reject_if. (If :allow_destroy is true) [#6006 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Add log message when loading records from Identity Map. | Emilio Tagua | 2011-04-04 | 1 | -0/+9 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |