aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Add rename_index to change_table.Jarek Radosz2012-11-191-0/+7
| | |
* | | Ensure ordering to make the test pass with postgresqlCarlos Antonio da Silva2012-11-181-4/+5
| | |
* | | Add test to ensure preloading works as expected with "select" and "includes".Dieter Komendera2012-11-181-0/+13
| | | | | | | | | | | | This didn't work in rails 3.1. See #2303 for more information and original pull request.
* | | Remove not used require and some useless test commentsCarlos Antonio da Silva2012-11-171-12/+3
| | |
* | | Fix typo in module name and make #in_time_zone privateCarlos Antonio da Silva2012-11-173-3/+5
| | |
* | | Extract #in_time_zone helper method duplication to a moduleCarlos Antonio da Silva2012-11-173-24/+17
| | |
* | | Simplify helper method in attribute methods testCarlos Antonio da Silva2012-11-171-3/+1
| | |
* | | Remove return guardCarlos Antonio da Silva2012-11-171-1/+0
|/ /
* | Test for has_many bug on unsaved recordsGeorge Brocklehurst2012-11-161-0/+7
| | | | | | | | See issue #7950.
* | arel columns can be used for grouping so that "weird" column names are usableAaron Patterson2012-11-151-0/+6
| |
* | Assert the query result instead of checking for nothing raisedCarlos Antonio da Silva2012-11-131-4/+2
| | | | | | | | | | | | | | Nothing should be raised anyway :smile: Thanks @spastorino :heart: https://github.com/rails/rails/pull/8202/files#r2112067
* | Merge pull request #8202 from nikitug/regression_test_on_dynamic_finder_resultCarlos Antonio da Silva2012-11-131-0/+7
|\ \ | | | | | | Regression test for #7238
| * | Regression test for #7238Nikita Afanasenko2012-11-131-0/+7
| | |
* | | Merge pull request #8176 from senny/7551_pluck_with_selectRafael Mendonça França2012-11-131-0/+6
|\ \ \ | | | | | | | | `#pluck` can be used on a relation with `select` clause (#7551)
| * | | `#pluck` can be used on a relation with `select` clause.Yves Senn2012-11-121-0/+6
| | | | | | | | | | | | | | | | Closes #7551
* | | | Add a regression test on #8195Nikita Afanasenko2012-11-131-0/+7
| |/ / |/| |
* | | Merge and add tests related to 5215Vipul A M2012-11-123-18/+25
|/ /
* | Do not create useless database transaction when building `has_one` association.Bogdan Gusiev2012-11-101-0/+6
| |
* | Properly deprecate ConnectionHandler#connection_poolsJon Leighton2012-11-091-1/+7
| | | | | | | | | | | | | | | | Rather than just changing it and hoping for the best. Requested by @jeremy: https://github.com/rails/rails/commit/ba1544d71628abff2777c9c514142d7e9a159111#commitcomment-2106059
* | Merge pull request #8116 from senny/7993_configure_counter_cache_for_has_manyJon Leighton2012-11-091-0/+8
|\ \ | | | | | | :counter_cache option for to support custom named counter caches
| * | :counter_cache option for to support custom named counter caches. Closes #7993Yves Senn2012-11-041-0/+8
| | |
* | | Delegate all calculations to the scope.Jon Leighton2012-11-091-0/+1
| | | | | | | | | | | | | | | | | | | | | So that the scope may be a NullRelation and return a result without executing a query. Fixes #7928
* | | CollectionProxy#pluck issues no query for a new_record? ownerJon Leighton2012-11-091-0/+1
| | | | | | | | | | | | | | | | | | | | | Fixes #8102. I couldn't find a nicer way to deal with this than delegate the call to #scope, which will be a NullRelation when we want it to be.
* | | Relations built off collection associations with an unsaved owner should be ↵Jon Leighton2012-11-091-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | null relations For example, the following should not run any query on the database: Post.new.comments.where(body: 'omg').to_a # => [] Fixes #5215.
* | | Add test to avoid regression of 58e48d5292242f000dc8a87fdbb1c0ccdcf286d8Gabriel Sobrinho & Ricardo Henrique2012-11-081-0/+11
|/ /
* | Ensure nested attributes is restored in case of a test failureCarlos Antonio da Silva2012-11-031-1/+1
| |
* | Simplify query conditions a bit in nested attributes testCarlos Antonio da Silva2012-11-031-5/+3
| | | | | | | | Also refactor the test a bit.
* | Check if the options value is present before to send the deprecationRafael Mendonça França2012-11-031-2/+2
| | | | | | | | message
* | Deprecate passing a string as third argument of `add_index`Rafael Mendonça França2012-11-021-0/+10
| | | | | | | | | | | | | | This was there due historical reasons since 7dc45818dc43c163700efc9896a0f3feafa31138 to give the user the possibility to create unique indexes passing "UNIQUE" as the third argument
* | Raise an ArgumentError when passing an invalid option to add_indexRafael Mendonça França2012-11-021-0/+6
| | | | | | | | Closes #8104
* | Fix issue with collection associations and first(n)/last(n)Carlos Antonio da Silva2012-11-011-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When calling first(n) or last(n) in a collection, Active Record was improperly trying to set the inverse of instance in case that option existed. This change was introduced by fdf4eae506fa9895e831f569bed3c4aa6a999a22. In such cases we don't need to do that "manually", since the way collection will be loaded will already handle that, so we just skip setting the inverse association when any argument is given to first(n)/last(n). The test included ensures that these scenarios will have the inverse of instance set properly. Fixes #8087, Closes #8094. Squashed cherry-pick from d37d40b and c368b66. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/associations/collection_association.rb
* | Remove extre count, preheat already happens during setupCarlos Antonio da Silva2012-10-311-1/+0
| |
* | Fix find_in_batches against string IDs when start option is not specified.Alexis Bernard2012-10-311-0/+9
| |
* | Fix `attributes_before_type_cast` for serialised attributes.Nikita Afanasenko2012-10-311-3/+13
| | | | | | | | Public method `attributes_before_type_cast` used to return internal AR structure (ActiveRecord::AttributeMethods::Serialization::Attribute), patch fixes this. Now behaves like `read_attribute_before_type_cast` and returns unserialised values.
* | Fix #6951. Use query cache/uncache, when using not only database.yml but ↵kennyj2012-10-311-0/+11
| | | | | | | | also DATABASE_URL.
* | include_root_in_json allows inheritance.kennyj2012-10-311-0/+16
| |
* | Remove not assigned variable warning from sqlite3 adapter testCarlos Antonio da Silva2012-10-291-1/+1
| |
* | Fix bug when Column is trying to type cast boolean values to integer.Rafael Mendonça França2012-10-291-4/+4
| | | | | | | | | | | | | | | | | | | | | | This can occur if the user is using :integer columns to store boolean values. Now we are handling the boolean values but it still raises if the value can't type cast to integer and is not a boolean. See #7509. Fixes #8067. Conflicts: activerecord/CHANGELOG.md
* | Fix the skip code.Rafael Mendonça França2012-10-281-4/+4
| | | | | | | | Checking for the constant doesn't work
* | SQLite3Adapter#type_cast should not mutate argumentsStefan Rusterholz2012-10-281-0/+6
| |
* | ActiveRecord::Relation#none! method.Juanjo Bazán2012-10-281-0/+6
| |
* | loaded relations cannot be mutated by extending!Juanjo Bazán2012-10-281-0/+9
| |
* | Enable update_column(s) for the primary key attribute.Henrik N2012-10-281-0/+13
| | | | | | | | Didn't work before because it updated the model-in-memory first, so the DB query couldn't find the record.
* | raise `ArgumentError` when redefining the primary key column. Closes #6378Yves Senn2012-10-281-0/+20
| |
* | refactor `SQLite3Adapter#copy_table` to prevent primary key redefinitions. #6378Yves Senn2012-10-281-1/+8
| |
* | AR::AttributeMethods#[] raises AM::AttributeMissingError for missing attributes.Francesco Rodriguez2012-10-281-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following behaviour: class Person < ActiveRecord::Base belongs_to :company end # Before: person = Person.select('id').first person[:name] # => nil person.name # => ActiveModel::MissingAttributeError: missing_attribute: name person[:company_id] # => nil person.company # => nil # After: person = Person.select('id').first person[:name] # => ActiveModel::MissingAttributeError: missing_attribute: name person.name # => ActiveModel::MissingAttributeError: missing_attribute: name person[:company_id] # => ActiveModel::MissingAttributeError: missing_attribute: company_id person.company # => ActiveModel::MissingAttributeError: missing_attribute: company_id Fixes #5433.
* | Use the MySQL varbinary type when appropriate in migrations.Victor Costan2012-10-273-0/+34
| |
* | Decode attributes pulled from URI.parseShawn Veader2012-10-261-0/+8
| | | | | | | | | | | | | | The RFC indicates that username and passwords may be encoded. http://tools.ietf.org/html/rfc2396#section-3.2.2 Found this trying to use the mysql://username:password@host:port/db and having special characters in the password which needed to be URI encoded.
* | Remove ActiveRecord::ModelJon Leighton2012-10-2613-201/+43
| | | | | | | | | | | | | | | | | | | | In the end I think the pain of implementing this seamlessly was not worth the gain provided. The intention was that it would allow plain ruby objects that might not live in your main application to be subclassed and have persistence mixed in. But I've decided that the benefit of doing that is not worth the amount of complexity that the implementation introduced.
* | frozen state should be restored after txn is abortedAaron Patterson2012-10-221-0/+15
| |