aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Add teardown to reset_connection at MysqlTypeLookupTestYasuo Honda2017-06-071-0/+7
| | | | | to address `Mysql2BooleanTest#test_column_type_without_emulated_booleans` failure
* Load schema before assertionyuuji.yaginuma2017-06-061-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | Without this, test fails because the load schema when pluck is executed. Steps to reproduce: ``` bin/test -a postgresql -w --seed 61689 test/cases/*test.rb -n "/^(?:InheritanceComputeTypeTest#(?:test_inheritance_new_with_subclass_as_default)|CalculationsTest#(?:test_pluck_loaded_relation))$/" # Running: .F Failure: CalculationsTest#test_pluck_loaded_relation [/home/yaginuma/program/rails/master_y_yagi/rails/activerecord/test/cases/calculations_test.rb:722]: 1 instead of 0 queries were executed. Queries: SELECT c.relname FROM pg_class c LEFT JOIN pg_namespace n ON n.oid = c.relnamespace WHERE n.nspname = ANY (current_schemas(false)) AND c.relname = 'companies' AND c.relkind IN ('r','v','m'). Expected: 0 Actual: 1 bin/test test/cases/calculations_test.rb:7 ```
* Merge pull request #29341 from y-yagi/explicitly_clear_type_map_before_run_testMatthew Draper2017-06-042-10/+12
|\ | | | | Explicitly clear type map before run `test_only_reload_type_map_once_for_every_unknown_type`
| * Explicitly clear type map before run ↵yuuji.yaginuma2017-06-032-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `test_only_reload_type_map_once_for_every_unknown_type` Currently, the following test fails. ``` bin/test -a sqlite3_mem --seed 37473 test/cases/relation_test.rb ``` This is due to reset connection in `test_respond_to_for_non_selected_element` postprocessing. This reset is added with #29332 for `test_only_reload_type_map_once_for_every_unknown_type`. Since the above test expects the type map to be empty at the time of test run, I think that it is better to empty the type map before test run.
* | Reset the fixture cache after (re)loading the schemaMatthew Draper2017-06-031-0/+2
|/
* Merge pull request #29332 from yahonda/unlock-minitest_unknown_type_fixRafael França2017-06-021-0/+5
|\ | | | | Clean up `type_map` at the end of test_respond_to_for_non_selected_element
| * Clean up `type_map` at the end of test_respond_to_for_non_selected_elementYasuo Honda2017-06-021-0/+5
| | | | | | | | | | | | | | | | `test_only_reload_type_map_once_for_every_unknown_type` expects no one already registers unknown OID to `type_map`. However, `test_respond_to_for_non_selected_element` registers it and does not clean up it. Addresses #29331 at unlock-minitest branch
* | Merge branch 'master' into unlock-minitestRafael Mendonça França2017-06-0216-171/+224
|\ \ | |/ |/|
| * Merge pull request #29308 from koic/correct_a_has_many_association_testMatthew Draper2017-06-021-1/+1
| |\ | | | | | | Correct a has_many association test
| | * Correct a has_many association testKoichi ITO2017-06-011-1/+1
| | |
| * | Simplify `assert_no_match %r{colname.*limit:}` regexRyuta Kamizono2017-06-011-14/+4
| | | | | | | | | | | | | | | In `test_schema_dump_includes_limit_constraint_for_integer_columns`, unified `assert_match` and `assert_no_match` to simple regex.
| * | Merge pull request #29220 from kamipo/consolidate_database_specific_json_typesMatthew Draper2017-06-014-56/+87
| |\ \ | | | | | | | | Consolidate database specific JSON types to `Type::Json`
| | * | Consolidate database specific JSON types to `Type::Json`Ryuta Kamizono2017-05-304-56/+87
| | | |
| * | | Merge pull request #29293 from kamipo/fix_sti_with_default_scopeMatthew Draper2017-06-011-1/+6
| |\ \ \ | | |_|/ | |/| | Fix `default_scoped` with defined `default_scope` on STI model
| | * | Fix `default_scoped` with defined `default_scope` on STI modelRyuta Kamizono2017-05-311-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This regression is caused by d1249c1. If STI model is defined `default_scope`, `base_rel` is not respected. I fixed to merge `base_rel` in that case.
| * | | Merge pull request #26634 from kamipo/extract_numeric_dataRafael França2017-05-314-86/+73
| |\ \ \ | | | | | | | | | | Extract `NumericData` model for tests
| | * | | Extract `NumericDataTest` to `test/cases/numeric_data_test.rb`Ryuta Kamizono2016-12-222-68/+71
| | | | | | | | | | | | | | | | | | | | | | | | | To ease to find the numeric data tests, extract `NumericDataTest` to `test/cases/numeric_data_test.rb` dedicated file.
| | * | | Extract `NumericData` model for testsRyuta Kamizono2016-09-273-19/+3
| | | | | | | | | | | | | | | | | | | | Currently `NumericData` model is defined some places.
| * | | | Add missing `delegate :extending, to: :all`Ryuta Kamizono2017-06-011-0/+6
| | |/ / | |/| |
| * | | Remove a redundant test case of HABTM_associations_testKoichi ITO2017-05-311-13/+0
| | |/ | |/|
| * | Add an extra test showing why collections are cachedMatthew Draper2017-05-301-0/+7
| | | | | | | | | | | | | | | The assert_same above obviously guarantees this will pass, but this seems less likely to be deleted just because the implementation changed.
| * | Merge pull request #29098 from kamipo/fix_association_with_extension_issuesMatthew Draper2017-05-303-1/+20
| |\ \ | | | | | | | | | | | | Fix association with extension issues
| | * | Cache the association proxy objectRyuta Kamizono2017-05-281-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some third party modules expects that association returns same proxy object each time (e.g. for stubbing collection methods: https://github.com/rspec/rspec-rails/issues/1817). So I decided that cache the proxy object and reset scope in the proxy object each time. Related context: https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
| | * | Fix association with extension issuesRyuta Kamizono2017-05-282-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following issues. * `association_scope` doesn't include `default_scope`. Should use `scope` instead. * We can't use `method_missing` for customizing existing method. * We can't use `relation_delegate_class` for sharing extensions. Should extend per association.
| * | | Merge pull request #29273 from ↵Rafael França2017-05-291-0/+11
| |\ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/deserialize_raw_value_from_database_for_json Deserialize a raw value from the database in `changed_in_place?` for `AbstractJson`
| | * | | Deserialize a raw value from the database in `changed_in_place?` for ↵Ryuta Kamizono2017-05-301-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `AbstractJson` Structured type values sometimes caused representation problems (keys sort order, spaces, etc). A raw value from the database should be deserialized (normalized) to prevent the problems.
| * | | | Fix UUID column with `null: true` and `default: nil`Ryuta Kamizono2017-05-301-0/+10
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | `quote_default_expression` can be passed nil value when `null: true` and `default: nil`. This addressed in that case. Fixes #29222.
* | | | Use existing class in PersistenceTest::SaveTestAlex Kitchens2017-06-011-21/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Creating a new class for widgets was causing failing tests because it clashed with other widget classes. This test does not need to create its own class, so I changed it to an existing class. ``` ARCONN=mysql2 bin/test --seed 25364 test/cases/*test.rb -n \ "/^(?:PrimaryKeyIntegerTest#(?:test_primary_key_with_serial_integer_are_automatically_numbered)|PersistenceTest::SaveTest#(?:test_save_touch_false))$/" ```
* | | | Merge pull request #29287 from alexcameron89/fix-db-statement-test-48104Matthew Draper2017-06-011-0/+1
|\ \ \ \ | | | | | | | | | | Fix random minitest error: database_statements_test
| * | | | Reset primary key sequence in FixturesResetPkSequenceTestsAlex Kitchens2017-05-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The primary key sequence for each test in FixturesResetPkSequenceTest is reset. The state in some of the FixturesResetPkSequenceTest tests are leaking, causing failurse in others. Using a seed of `48104`, the `FixturesResetPkSequenceTest#test_resets_to_min_pk_with_specified_pk_and_sequence` runs before the `DatabaseStatementsTest` tests, and the tests fail with duplicate primary key errors: ``` Run options: --seed 48104 -n "/^(?:FixturesResetPkSequenceTest#(?:test_resets_to_min_pk_with_specified_pk_and_sequence)|DatabaseStatementsTest#(?:test_create_should_return_the_inserted_id|test_exec_insert|test_insert_should_return_the_inserted_id))$/" .EEE 1) Error: DatabaseStatementsTest#test_exec_insert: ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "accounts_pkey" DETAIL: Key (id)=(2) already exists. 2) Error: DatabaseStatementsTest#test_create_should_return_the_inserted_id: ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "accounts_pkey" DETAIL: Key (id)=(3) already exists. 3) Error: DatabaseStatementsTest#test_insert_should_return_the_inserted_id: ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "accounts_pkey" DETAIL: Key (id)=(4) already exists. ```
* | | | | Ensure fixtures are loaded for FoxyFixturesTestAlex Kitchens2017-05-311-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure that the fixtures are properly loaded for FoxyFixturesTest When tests are randomized, FoxyFixturesTest often fails due to unloaded fixtures.
* | | | | Make sure to disable extension after testyuuji.yaginuma2017-05-311-6/+2
|/ / / / | | | | | | | | | | | | | | | | If keep the extension, can not test properly to make sure that extension can be enabled.
* | | | Merge branch 'master' into unlock-minitestKasper Timm Hansen2017-05-2970-631/+618
|\| | |
| * | | Merge pull request #29248 from yawboakye/rename-should-rename-table-pkeyGuillermo Iguaran2017-05-291-0/+23
| |\ \ \ | | | | | | | | | | `rename_table` should rename primary key index name
| | * | | `rename_table` renames primary key index nameYaw Boakye2017-05-291-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Formerly, `rename_table` only renamed primary key index name if the column's data type was sequential (serial, etc in PostgreSQL). The problem with that is tables whose primary keys had other data types (e.g. UUID) maintained the old primary key name. So for example, if the `cats` table has a UUID primary key, and the table is renamed to `felines`, the primary key index will still be called `cats_pkey` instead of `felines_pkey`. This PR corrects it.
| * | | | Remove a redundant test assertionKoichi ITO2017-05-291-6/+0
| |/ / /
| * | | Merge pull request #29208 from ↵Guillermo Iguaran2017-05-281-0/+11
| |\ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/default_env_fall_back_to_default_env_when_rails_env_or_rack_env_is_empty_string `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is an empty string
| | * | | `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is ↵Ryuta Kamizono2017-05-251-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | an empty string Follow up of #27399.
| * | | | Deprecate passing arguments and block at the same time to `count` and `sum` ↵Ryuta Kamizono2017-05-291-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in `ActiveRecord::Calculations` `select`, `count`, and `sum` in `Relation` are also `Enumerable` method that can be passed block. `select` with block already doesn't take arguments since 4fc3366. This is follow up of that.
| * | | | Merge pull request #29258 from koic/remove_redundant_command_recorder_testMatthew Draper2017-05-291-5/+0
| |\ \ \ \ | | | | | | | | | | | | Remove a redundant test case of command_recorder_test
| | * | | | Remove a redundant test case of command_recorder_testKoichi ITO2017-05-291-5/+0
| | | |/ / | | |/| |
| * | | | Merge pull request #29253 from kamipo/prevent_extra_queryMatthew Draper2017-05-291-3/+9
| |\ \ \ \ | | | | | | | | | | | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype`
| | * | | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype`Ryuta Kamizono2017-05-281-3/+9
| | | | | |
| * | | | | Merge pull request #28969 from ↵Matthew Draper2017-05-281-2/+2
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/refactor_enum_to_use_value_instead_of_label Refactor enum to use `value` instead of `label` in the scope
| | * | | | | Refactor enum to use `value` instead of `label` in the scopeRyuta Kamizono2017-05-071-2/+2
| | | | | | |
| * | | | | | Merge pull request #29003 from kamipo/delegate_ast_and_locked_to_arel_explicitlyMatthew Draper2017-05-281-1/+1
| |\ \ \ \ \ \ | | |_|/ / / / | |/| | | | | Delegate `ast` and `locked` to `arel` explicitly
| | * | | | | Delegate `ast` and `locked` to `arel` explicitlyRyuta Kamizono2017-05-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `ast` and `locked` are used in the internal but delegating to `arel` is depend on `method_missing`. If a model class is defined these methods, `select_all` will be broken. It should be delegated to `arel` explicitly.
| * | | | | | Fix regression in Numericality validator where extra decimal places on Bradley Priest2017-05-271-0/+14
| | |_|/ / / | |/| | | | | | | | | | a user input for a decimal column were ignored by numerically validations
| * | | | | Remove a redundant test assertionKoichi ITO2017-05-271-1/+0
| | | | | |
| * | | | | Merge pull request #29176 from bogdanvlviv/define-path-with__dir__Matthew Draper2017-05-265-6/+6
| |\ \ \ \ \ | | | | | | | | | | | | | | Define path with __dir__
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 23:51:54 +0000