| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |/ /
| | | |
| | | |
| | | |
| | | | |
Other methods compare specific patterns, this method outputs
the actual sql query that is generated.
|
| |\ \ \
| | |/ /
| |/| | |
Fix polymorphic preloads on NOT NULL _type columns
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The new method relies on AR::Associations::Association knowing about both reflection and a model class.
AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
|
| | | |
| | | |
| | | |
| | | | |
Defer to Association#klass instead of having a custom/duplicate code.
|
| |/ /
| | |
| | |
| | | |
fixes #10613
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Follow-Up to https://github.com/rails/rails/pull/14400
This ensures that all tables are removed after each test and thereby
allowing us to run the tests in a random order.
|
| |\ \
| | | |
| | | |
| | | | |
Fix tests not unsubscribing from Notifications.
|
| | | |
| | | |
| | | |
| | | | |
See https://github.com/rails/rails/blob/master/activesupport/lib/active_support/notifications.rb#L131
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases,
this ensures we always return a boolean value. Also fixed a similar problem in
AR reflections.
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | | |
| | | | |
Pass a base relation to build_default_scope when joining
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This allows the default scope to be built using the current table alias.
Resolves #12770
|
| | | |
| | | |
| | | |
| | | | |
Swap Timestamp/Callbacks order in ActiveRecord::Base
|
| | | |
| | | |
| | | |
| | | | |
custom primary_key that didn't save due to validation error
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It's unintuitive to call '#valid?' when you want to run validations but
don't care about the return value.
The alias in ActiveRecord isn't strictly necessary (the ActiveModel
alias is still in effect), but it clarifies.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When the tests are executed in order, the dependency is loaded at the right time.
However this makes it impossible to execute a single test later down the line.
Let's require the dependecy at the beginning to get them working independent of the order.
This resolves the following error:
```
$ ARCONN=postgresql ruby -Itest /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb -n test_to_xml
Using postgresql
Run options: -n test_to_xml --seed 51819
E
Finished in 0.081320s, 12.2971 runs/s, 0.0000 assertions/s.
1) Error:
DatabaseConnectedXmlSerializationTest#test_to_xml:
NameError: uninitialized constant DatabaseConnectedXmlSerializationTest::REXML
/Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb:226:in `test_to_xml'
```
/cc @tgxworld fyi
|
| | | |
| | | |
| | | |
| | | | |
This will keep the test suite passing with older PG installations.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
It is supposed to raise ActiveRecord::InvalidForeignKey when the
database has a fk constraint.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
existence
Also:
- updates tests by stubbing table_exists? method
- adds entry for creating indexes in CREATE TABLE to changelog
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is important, because adding an index on a temporary table after
it has been created would commit the transaction
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
|
| |\ \ \
| | | | |
| | | | |
| | | | | |
Still touch associations when theres no timestamp
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Prior to Rails 4.0.4 when touching a object which doesn't have timestamp
attributes (updated_at / updated_on) rails would still touch all
associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates
associations but rollsback because `touch` would return nil since
there's no timestamp attribute
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing
changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a.
Conflicts:
activerecord/CHANGELOG.md
activerecord/test/cases/autosave_association_test.rb
|
|\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* master: (96 commits)
clarify CHANGELOG [ci skip].
Fix Generation of proper migration when ActiveRecord::Base.pluralize_table_names = false.
update comments to reflect that options support is not available
synchronize changelogs and 4.1 release notes. [ci skip]
do not rely on method_missing hitting arel
use ARel factory methods for building AST nodes
Fix date_select option overwriting html classes
- Rename `increment_or_decrement` to an apt `set_cache_value` since it actually doesn't increment/decrement in localstore.
Check if any sqlite files are not included in the gitignore
Remove sqlite3 lines from .gitignore if the application is not using sqlite3.
Adding active_model in Rails::Info
Clean up tables after each test.
Swapped parameters of assert_equal in assert_select
Update test helper to use latest Digestor API
Digestor should just rely on the finder to know about the format and the variant -- trying to pass it back in makes a mess of things (oh, and doesnt work)
Log the full path, including variant, that the digestor is trying to find
Fix for digestor to consider variants for partials -- this still needs more testing!!
fix log_tags request object grammar
Extract with_example_table into helper method.
test for structure:dump without schema information table. refs eafec46
...
Conflicts:
activerecord/test/cases/relation/where_chain_test.rb
|
| | | | |
| | | | |
| | | | |
| | | | | |
arel methods are not supposed to be public API for ActiveRecord
|
| | | | |
| | | | |
| | | | |
| | | | | |
This abstracts us from the actual construction of the nodes
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Follow-Up to https://github.com/rails/rails/pull/14400
This ensures that all tables are removed after each test and thereby
allowing us to run the tests in a random order.
|
| | | | |
| | | | |
| | | | |
| | | | | |
This setups the helper method which other tests can benefit from.
|
| |\ \ \ \
| | | | | |
| | | | | | |
Postgres schema: Constrain sequence search classid
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The pk_an_sequence_for query previously joined against pg_class's oid
for rows in pg_depend, but pg_depend's objid may point to other system
tables, such as pg_attrdef. If a row in one of those other tables
coincidentally has the same oid as an (unrelated) sequence, that
sequence name may be returned instead of the real one.
This ensures that only the pg_depend entries pointing to pg_class are
considered.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
assert_raise + assert_equal on the returned exception message work
just fine, there is no need for extra work, specially like this overly
complicated helper.
|
| |/ / / / |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Backport test from #14410
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously, any of the connection checkouts could have failed, and this
test would pass.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
.. not a general timeout.
Now, if a thread checks out a connection then dies, we can immediately
recover that connection and re-use it.
This should alleviate the pool exhaustion discussed in #12867. More
importantly, it entirely avoids the potential issues of the reaper
attempting to check whether connections are still active: as long as the
owning thread is alive, the connection is its business alone.
As a no-op reap is now trivial (only entails checking a thread status
per connection), we can also perform one in-line any time we decide to
sleep for a connection.
|
| | | | |
| | | | |
| | | | |
| | | | | |
It wasn't doing anything beyond clearing the statement cache.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #14406.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Allows fixtures to use their $LABEL as part of a string instead
of limiting use to the entire value.
mark:
first_name: $LABEL
username: $LABEL1973
email: $LABEL@$LABELmail.com
users(:mark).first_name # => mark
users(:mark).username # => mark1973
users(:mark).email # => mark@markmail.com
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
tgxworld/use_teardown_helper_method_in_activerecord
Use teardown helper method.
|
| | |/ / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Follow-Up to https://github.com/rails/rails/pull/14348
Ensure that SQLCounter.clear_log is called after each test.
This is a step to prevent side effects when running tests. This will allow us to run them in random order.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #14383.
|
| |/ / /
| | | |
| | | |
| | | | |
mitigates #14323
|
| |\ \ \
| | | | |
| | | | | |
Make select_all on query cache accept a Relation without binds.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
[fixes #14361]
[related #13886]
|