aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | The Association Relation should use `empty?` and `size` from Relation.Lauro Caetano2014-04-141-0/+11
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 968c581ea34b5236af14805e6a77913b1cb36238 have introduced this bug #14744 on Association Relation when the method `empty?` or `size` was called. Example: # Given an author that does have 3 posts, but none of them with the # title 'Some Title' Author.last.posts.where(title: 'Some Title').size # => 3 It was occurring, because the Association Relation had implemented these methods based on `@association`, this way giving wrong results. To fix it, was necessary to remove the methods `empty?` and `size` from Association Relation. It just have to use these methods from Relation. Example: # Given an author that does have 3 posts, but none of them with the # title 'Some Title' Author.last.posts.where(title: 'Some Title').size # => 0 # Now it will return the correct value. Fixes #14744.
* | | | | Merge branch 'master' into adequaterecordAaron Patterson2014-04-1416-17/+158
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (70 commits) [ci skip] Added link to ruby-lang.org installation. Use the index on hidden field `collection_check_boxes` respects `:index` option for the hidden filed name. docs, double meaning of `serialize` argument. Closes #14284. Just call read_attribute, no need to use `send`. - Fix lingering reference to `:text` instead of the newer `:plain` - Section references `form_tag` instead of the `form_for` used in the example again, read_attribute is public, so just call it read_attribute is public, so we should just call it Disable assest cache store in docs [ci skip] Make counter cache decrementation on destroy idempotent Write the failing test case for concurrent counter cache [ci skip] Use plain underscore instead of "\_". Update documentation to use Rails.application instead Add a changelog entry for #14546 [ci skip] Move tests for deep_dup and duplicable to object directory Missing 'are' in note - [ci skip] CollectionHelpers now accepts a readonly option Fix a few typos [ci skip] Bundle tzinfo-data on :x64_mingw (64-bit Ruby on Windows). don't bother with an offset if the offset is zero ...
| * | | | Merge pull request #14735 from byroot/idempotent-counter-cachesAaron Patterson2014-04-141-0/+21
| |\ \ \ \ | | | | | | | | | | | | Idempotent counter caches, fix concurrency issues with counter caches
| | * | | | Write the failing test case for concurrent counter cacheJean Boussier2014-04-131-0/+21
| | | | | |
| * | | | | Just call read_attribute, no need to use `send`.Lauro Caetano2014-04-142-7/+7
| |/ / / / | | | | | | | | | | | | | | | Follow up to af549a1ad6692d7e2c756750651f0e1b293f5185
| * | | | Ensure that the comparison between 'CollectionProxy' and ↵Lauro Caetano2014-04-121-0/+9
| | | | | | | | | | | | | | | | | | | | 'AssociationRelation' is consistent.
| * | | | Make the comparison between 'Relation' and 'AssociationRelation'Lauro Caetano2014-04-121-0/+9
| | | | | | | | | | | | | | | | | | | | consistent.
| * | | | The comparison between `Relation` and `CollectionProxy` should be consistent.Lauro Caetano2014-04-111-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: author.posts == Post.where(author_id: author.id) # => true Post.where(author_id: author.id) == author.posts # => true Fixes #13506
| * | | | Use assert_notRafael Mendonça França2014-04-111-1/+1
| | | | |
| * | | | :scissors:Rafael Mendonça França2014-04-112-5/+5
| | | | |
| * | | | Merge pull request #14711 from ↵Rafael Mendonça França2014-04-112-0/+18
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | swoker/activerecord_fix_aggregate_methods_with_select Activerecord fix aggregate methods with select
| | * | | | fix exception on polymorphic associations with predicatesSimon Woker2014-04-111-0/+8
| | | | | |
| | * | | | Fix error for aggregate methods with select, see issue #13648Simon Woker2014-04-101-0/+10
| | | | | |
| * | | | | PostgreSQL, warn once per connection per missing OID. Closes #14275.Yves Senn2014-04-111-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | [Yves Senn & Matthew Draper]
| * | | | | PostgreSQL, adapter automatically reloads it's type map. Closes #14678.Yves Senn2014-04-114-6/+28
| | | | | | | | | | | | | | | | | | | | | | | | [Yves Senn & Matthew Draper]
| * | | | | Merge pull request #12829 from iantropov/issue_insert_via_hmt_scope_3548Rafael Mendonça França2014-04-102-1/+17
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix insertion of records for hmt association with scope Conflicts: activerecord/CHANGELOG.md
| | * | | | | Fix insertion of records for hmt association with scope, fix #3548Ivan Antropov2013-11-172-1/+17
| | | | | | |
| * | | | | | Remove warning of unused variableRafael Mendonça França2014-04-101-1/+1
| | | | | | |
| * | | | | | Merge branch 'master' into rm-uuid-fixturesRafael Mendonça França2014-04-1010-32/+160
| |\ \ \ \ \ \ | | | |/ / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md activesupport/CHANGELOG.md
| | * | | | | Make sure the reflection test is passing a String to the reflectionLauro Caetano2014-04-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | cache.
| * | | | | | Merge pull request #12016 from roderickvd/uuid_fixesRafael Mendonça França2014-04-043-1/+19
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Auto-generate stable fixture UUIDs on PostgreSQL Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/fixtures.rb activerecord/test/cases/adapters/postgresql/uuid_test.rb activesupport/CHANGELOG.md
| | * | | | | | Auto-generate stable fixture UUIDs on PostgreSQL.Roderick van Domburg2014-01-074-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #11524
* | | | | | | | use an array for bind params to simplify substitutionAaron Patterson2014-04-121-10/+10
| | | | | | | |
* | | | | | | | propogate bind values collected in arel to SQL generationAaron Patterson2014-04-111-0/+8
| | | | | | | |
* | | | | | | | decouple the factory method from the constructing modelAaron Patterson2014-04-101-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The factory method only requires the constructing model to get the connection object. Since the model is available when calling the factory method, we can just pass the appropriate connection in.
* | | | | | | | remove intelligence from StatementCache#initializeAaron Patterson2014-04-101-5/+5
| | | | | | | |
* | | | | | | | stop caching the class on the statement cache objectAaron Patterson2014-04-101-8/+8
| | | | | | | |
* | | | | | | | remove the bind visitor since the collector handles substituting bind valuesAaron Patterson2014-04-091-3/+3
| | | | | | | |
* | | | | | | | all tests passing on mysql2Aaron Patterson2014-04-091-3/+3
| | | | | | | |
* | | | | | | | remove the bind substitution visitor. to_sql should never return bind valuesAaron Patterson2014-04-091-3/+1
| | | | | | | |
* | | | | | | | Merge branch 'master' into adequaterecordAaron Patterson2014-04-092-33/+73
|\ \ \ \ \ \ \ \ | | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (26 commits) Avoid URI parsing Add missing require so requiring `active_support/cache` works again. depend_on_asset is not required anymore on sprockets-rails 2.1.2 upgrading section for 4.1 is no longer WIP. [ci skip] Expand explanation of how to set secrets.yml. [ci skip] Guides: minor typo fixed [ci skip] Fixed problem where `1.day.eql?(1.day)` is false new CHANGELOGs entries are in the top [ci skip] Updates the maintenance policy with new Rails versions Dont abbreviate that which needs no abbreviation Dont encourage aliases now that we have variants Use short-form for the scaffold render calls and drop the needless test Drop in @jeremy's new database.yml template text Don't deprecate after all Less ambition, more deprecation Ensure we correctly and immediately load all ENV entries Give a deprecation message even when the lookup fails Rearrange the config merger some more entry is always a Hash Check env_url only once ... Conflicts: Gemfile
| * | | | | | | Drop in @jeremy's new database.yml template textMatthew Draper2014-04-091-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In passing, allow multi-word adapters to be referenced in a URL: underscored_name must become hyphened-name.
| * | | | | | | Don't deprecate after allMatthew Draper2014-04-091-11/+9
| | | | | | | |
| * | | | | | | Less ambition, more deprecationMatthew Draper2014-04-091-59/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "DATABASE_URL_*" idea was moving in the wrong direction. Instead, let's deprecate the situation where we end up using ENV['DATABASE_URL'] at all: the Right Way is to explicitly include it in database.yml with ERB.
| * | | | | | | Ensure we correctly and immediately load all ENV entriesMatthew Draper2014-04-081-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. even when the supplied config made no hint that name was relevant.
| * | | | | | | Give a deprecation message even when the lookup failsMatthew Draper2014-04-081-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the supplied string doesn't contain a colon, it clearly cannot be a database URL. They must have intended to do a key lookup, so even though it failed, give the explanatory deprecation warning, and raise the exception that lists the known configs. Conveniently, this also simplifies our logical behaviour: if the string matches a known configuration, or doesn't contain a colon (and is therefore clearly not a URL), then we output a deprecation warning, and behave exactly as we would if it were a symbol.
| * | | | | | | Test DATABASE_URL has precendance over DATABASE_URL_#{environment}Rafael Mendonça França2014-04-081-0/+9
| | | | | | | |
| * | | | | | | Make sure DEFAULT_URL only override current environment databaseRafael Mendonça França2014-04-081-9/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | configuration
| * | | | | | | Only apply DATABASE_URL for Rails.envMatthew Draper2014-04-081-17/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As we like ENV vars, also support DATABASE_URL_#{env}, for more obscure use cases.
| * | | | | | | Follow up to bbe7fe41 to fix enum leakage across classes.Godfrey Chan2014-04-071-7/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original attempt didn't really fix the problem and wasn't testing the problematic area. This commit corrected those issues in the original commit. Also removed the private `enum_mapping_for` method. As `defined_enums` is now a method, this method doesn't provide much value anymore.
* | | | | | | | working against arel/collector branchAaron Patterson2014-04-091-3/+3
| | | | | | | |
* | | | | | | | Merge branch 'master' into adequaterecordAaron Patterson2014-04-0745-367/+836
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (122 commits) Rails.application should be set inside before_configuration hook remove check for present? from delete_all Remove useless begin..end Build the reverse_order on its proper method. Use connection-specific bytea escaping Ignore order when doing count. make enums distinct per class Remove unused `subclass_controller_with_flash_type_bar` var from flash test. fix CollectionProxy delete_all documentation Added OS X specific commands to installation guide [ci skip] Recommended using homebrew for installing MySQL and PostgreSQL Fix setup of adding _flash_types test. Use SVG version of travis build status badge [skip ci] W3C CSP document moved to gihub.io URL [ci skip] sprockets-rails was released Fix the test defining the models in the right place Add CHANGELOG entry for #11650 [ci skip] Declare the assets dependency Use sass-rails 4.0.3 Make possible to use sprockets-rails 2.1 add missing parentheses to validates_with documentation [skip ci] ...
| * | | | | | | Build the reverse_order on its proper method.Lauro Caetano2014-04-072-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The reverse_order method was using a flag to control if the order should be reversed or not. Instead of using this variable just build the reverse order inside its proper method. This implementation was leading to an unexpected behavior when using reverse_order and then applying reorder(nil). Example: Before Post.order(:name).reverse_order.reorder(nil) # => SELECT "posts".* FROM "posts" ORDER BY "posts"."id" DESC After Post.order(:name).reverse_order.reorder(nil) # => SELECT "posts".* FROM "posts"
| * | | | | | | Merge pull request #14632 from matthewd/escape_byteaRafael Mendonça França2014-04-071-0/+17
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Use connection-specific bytea escaping
| | * | | | | | | Use connection-specific bytea escapingMatthew Draper2014-04-081-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In our normal usage, it's rare for this to make a difference... but is more technically correct. As well as a spec that proves this is a good idea, let's also add a more sane-looking one that just covers basic to_sql functionality. There aren't many places where we actually use escape_bytea, but that's one that won't be going away.
| * | | | | | | | Ignore order when doing count.Lauro Caetano2014-04-071-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is necessary because Postgresql doesn't play nice with ORDER BY and no GROUP BY. Fixes #14621.
| * | | | | | | | make enums distinct per classEvan Whalen2014-04-071-0/+15
| |/ / / / / / /
| * | | | | | | Merge pull request #14579 from senny/pg/remove_string_limitRafael Mendonça França2014-04-043-2/+10
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PostgreSQL, remove varchar limit. Conflicts: activerecord/CHANGELOG.md
| | * | | | | | | test, show current adapter behavior for `add_column limit: nil`.Yves Senn2014-04-041-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an illustration of https://github.com/rails/rails/pull/13435#issuecomment-33789752 Removing the limit from the PG and SQLite adapter solves the issue. MySQL is still affected by the issue.
| | * | | | | | | PostgreSQL and SQLite, remove varchar limit. [Vladimir Sazhin & Toms Mikoss ↵Yves Senn2014-04-042-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | & Yves Senn] There is no reason for the PG adapter to have a default limit of 255 on :string columns. See this snippet from the PG docs: Tip: There is no performance difference among these three types, apart from increased storage space when using the blank-padded type, and a few extra CPU cycles to check the length when storing into a length-constrained column. While character(n) has performance advantages in some other database systems, there is no such advantage in PostgreSQL; in fact character(n) is usually the slowest of the three because of its additional storage costs. In most situations text or character varying should be used instead.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 04:07:12 +0000