Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | string IDs are now quoted correctly [#5064 state:resolved] | Will St. Clair + Neeraj Singh | 2010-07-13 | 1 | -1/+11 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | renaming test name to fix accidently override | Subba Rao Pasupuleti | 2010-07-13 | 1 | -1/+1 | |
| | | | | | | [#5076 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | enable AS::JSON.encode to encode AR::Relation by providing `as_json` method | Mislav Marohnić | 2010-07-13 | 1 | -0/+7 | |
| | | | | | | [#5073 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | with this fix touch method - does not call validations - doest not call ↵ | Neeraj Singh | 2010-07-13 | 1 | -0/+10 | |
| | | | | | | | | callbacks - updates updated_at/on along with attribute if attribute is provided - marks udpated_at/on and attribute as NOT changed [#2520 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | primary key behavioral tests | Aaron Patterson | 2010-07-10 | 1 | -0/+17 | |
| | ||||||
* | behavioral tests for sqlite adapter | Aaron Patterson | 2010-07-10 | 1 | -4/+77 | |
| | ||||||
* | adding more behavioral tests for the sqlite adapter | Aaron Patterson | 2010-07-09 | 1 | -0/+20 | |
| | ||||||
* | Return from ActiveRecord::Base#attributes= unless value is a hash [#4070 ↵ | David Trasbo | 2010-07-08 | 1 | -0/+7 | |
| | | | | | | state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | reset_counter should work with non-traditional belongs_to and polymorphic ↵ | Neeraj Singh | 2010-07-08 | 1 | -3/+16 | |
| | | | | | | | | belongs_to [#4984 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | This patch changes update_attribute implementatino so: | Neeraj Singh | 2010-07-08 | 3 | -13/+52 | |
| | | | | | | | | | | - it will only save the attribute it has been asked to save and not all dirty attributes - it does not invoke callbacks - it does change updated_at/on Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Eager loading :through associations will join the :source model if there are ↵ | Grant Ammons | 2010-07-08 | 1 | -0/+6 | |
| | | | | | | :conditions. [#2362 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fix the #using_limitable_reflections? helper to work correctly by not ↵ | Ken Collins | 2010-07-08 | 1 | -0/+10 | |
| | | | | | | examining the length of an array which contains false/true, hence always passing. [#4869 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Tests to specify the behaviour of ActiveRecord::Migrator.get_all_versions() ↵ | Thiago Pradi | 2010-07-08 | 1 | -0/+14 | |
| | | | | | | [#5066 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | fix ActiveRecord `destroy_all` so it returns destroyed records | Mislav Marohnić | 2010-07-08 | 2 | -8/+19 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | mass_assignment_security moved from AR to AMo, and minor test cleanup | Josh Kalderimis | 2010-07-08 | 6 | -185/+10 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | minor changes to mass assignment security patch to bring it in line with ↵ | Josh Kalderimis | 2010-07-08 | 3 | -131/+103 | |
| | | | | | | rails standards Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Mass assignment security refactoring | Eric Chapweske | 2010-07-08 | 5 | -13/+135 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | This test never runs and it has never run. Since the day this file | Neeraj Singh | 2010-07-08 | 1 | -4/+0 | |
| | | | | | | | | was created this test has name not beginning with test_. Also this test is trying to use has_many on another has_many which is not supported. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fixed gruoped_by_title spelling [#5063 state:committed] | Ben Somers | 2010-07-08 | 1 | -2/+2 | |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | |||||
* | adding some behavioral tests for the sqlite adapter. [#5065 state:resolved] | Aaron Patterson | 2010-07-07 | 1 | -0/+100 | |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
* | Don't remove scheduled destroys when loading an association. [#4642 ↵ | James Le Cuirot | 2010-07-01 | 1 | -0/+6 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | AssociationCollection#create_by_*, find_or_create_by_* work properly now. ↵ | Aaron Patterson | 2010-06-29 | 1 | -0/+62 | |
| | | | | | | [#1108 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Test that adding an index also doesn't raise an exception. | J. Pablo Fernández | 2010-06-29 | 1 | -1/+1 | |
| | | | | | | [#4809 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Replaced statement in comment with an assertion | Paul Barry | 2010-06-29 | 1 | -2/+3 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fixed error when removing an index from a table name values, which is a ↵ | J. Pablo Fernández | 2010-06-29 | 1 | -0/+16 | |
| | | | | | | reserved word, with test. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Push a failing test for issues [#4994] and [#5003]. | José Valim | 2010-06-29 | 1 | -0/+6 | |
| | ||||||
* | Remove ActiveRecord::Base#class_name [#379 state:committed] | David Trasbo | 2010-06-29 | 1 | -19/+0 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add scoping and unscoped as the syntax to replace the old with_scope and ↵ | José Valim | 2010-06-29 | 5 | -206/+405 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with_exclusive_scope. A few examples: * with_scope now should be scoping: Before: Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end After: Comment.where(:post_id => 1).scoping do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end * with_exclusive_scope now should be unscoped: class Post < ActiveRecord::Base default_scope :published => true end Post.all #=> SELECT * FROM posts WHERE published = true Before: Post.with_exclusive_scope do Post.all #=> SELECT * FROM posts end After: Post.unscoped do Post.all #=> SELECT * FROM posts end Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values: Post.unscoped.all #=> SELECT * FROM posts | |||||
* | with_exclusive_scope does not work properly if ARel is passed. It does work ↵ | Neeraj Singh | 2010-06-29 | 1 | -0/+6 | |
| | | | | | | | | nicely if hash is passed. Blow up if user is attempting it pass ARel to with_exclusive_scope. [#3838 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Move sqlite to sqlite3 for this tests to be run only on sqlite3 adapter | Santiago Pastorino | 2010-06-28 | 2 | -0/+0 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fixes #2415 by creating a new instance of the Model when saving attributes ↵ | George Montana Harkin | 2010-06-27 | 1 | -13/+15 | |
| | | | | | | to that model and the associated attributes already exist. Tests included. [#2415 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | adding adapter tests, avoiding private apis, fixing code in 1.9 [#4986 ↵ | Aaron Patterson | 2010-06-26 | 1 | -0/+56 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | blocks removed from all the ActiveRelation query_methods, extend method ↵ | Santiago Pastorino | 2010-06-26 | 1 | -1/+1 | |
| | | | | | | added instead Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Merge branch 'tago' | José Valim | 2010-06-26 | 2 | -7/+107 | |
|\ | ||||||
| * | Add column and index query methods to ActiveRecord::Schema | Andrew White | 2010-06-26 | 2 | -7/+107 | |
| | | | | | | | | | | | | [#4219 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | index dump should not include full text indexes. Thanks Ken Mayer for the ↵ | Aaron Patterson | 2010-06-26 | 1 | -0/+4 | |
| | | | | | | | | | | | | original patch! [#4949 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | reorder method added to ActiveRelation | Santiago Pastorino | 2010-06-26 | 1 | -0/+6 | |
| | | | | | | | | | | | | [#4972 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | Test for concatenated orders added | Santiago Pastorino | 2010-06-26 | 1 | -0/+6 | |
| | | | | | | | | | | | | [#4972] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | reorganizing adapter specific tests. [#4974 state:resolved] | Aaron Patterson | 2010-06-25 | 12 | -2/+2 | |
|/ | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Order is not guaranteed here, ordering by id of people table makes it work | Santiago Pastorino | 2010-06-25 | 1 | -2/+2 | |
| | ||||||
* | Support for multiple selects added | Neeraj Singh and Santiago Pastorino | 2010-06-25 | 2 | -3/+11 | |
| | | | | [#4841 state:committed] | |||||
* | Remove deprecated block usage in composed_of. | Emilio Tagua | 2010-06-24 | 1 | -28/+0 | |
| | ||||||
* | Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵ | José Valim | 2010-06-24 | 1 | -5/+4 | |
| | | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] | |||||
* | Add tests for relation count. Fix other tests that were conceptually wrong. | Emilio Tagua | 2010-06-24 | 2 | -2/+6 | |
| | | | | | | [#4882 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | adding fix for to_xml for ActiveRecord relation object | Neeraj Singh | 2010-06-23 | 1 | -0/+5 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | ActiveRecord's relation object should respond to to_json and to_yaml | Neeraj Singh | 2010-06-23 | 1 | -0/+10 | |
| | | | | | | [#4547 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | adding column named 'group' to ensure that nothing breaks given that 'group' ↵ | Neeraj Singh | 2010-06-23 | 2 | -6/+6 | |
| | | | | | | | | is sql reserved word [#4945 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Don't clone associations [#4894 state:resolved] | Paul Gillard | 2010-06-23 | 1 | -0/+8 | |
| | | | | | | Cloning an active record object should be shallow in that it should copy attributes but not associations. This was no longer true as a result of #3164. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | remove_column should raise an ArgumentError when no columns are passed ↵ | Jeff Dean | 2010-06-23 | 1 | -0/+4 | |
| | | | | | | [#4803 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Avoid method redefined warning | Santiago Pastorino | 2010-06-22 | 1 | -1/+4 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |