Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove the deprecation of update_column. | Rafael Mendonça França | 2012-07-30 | 1 | -38/+17 |
| | | | | | | update_column was suggested as replacement of update_attribute at the last release of 3-2-stable, so deprecating it now will confuse the users. | ||||
* | Merge pull request #7196 from ↵ | Aaron Patterson | 2012-07-29 | 1 | -1/+5 |
|\ | | | | | | | | | rimidl/fix-incorrect-require-mysql-in-mysql_rake_test Fix incorrect usage `require mysql` in the activerecord/.../mysql_rake_test | ||||
| * | fix incorrect usage `require mysql` in the ↵ | Vladimir Strakhov | 2012-07-29 | 1 | -1/+5 |
| | | | | | | | | activerecord/test/.../mysql_rake_test.rb | ||||
* | | More polite cleanup for sqlite tests | Bogdan Gusiev | 2012-07-29 | 1 | -4/+4 |
|/ | |||||
* | Revert "Removing composed_of from ActiveRecord." | Rafael Mendonça França | 2012-07-27 | 5 | -0/+422 |
| | | | | | | | | | | | This reverts commit 14fc8b34521f8354a17e50cd11fa3f809e423592. Reason: we need to discuss a better path from this removal. Conflicts: activerecord/lib/active_record/reflection.rb activerecord/test/cases/base_test.rb activerecord/test/models/developer.rb | ||||
* | Merge pull request #6827 from zephyr-dev/master | José Valim | 2012-07-27 | 1 | -0/+44 |
|\ | | | | | Validates_presence_of associated object marked for destruction | ||||
| * | AR has a subclass of AM:PresenceValidator. | Brent Wheeldon & Nick Monje | 2012-07-20 | 1 | -0/+44 |
| | | | | | | | | | | | | | | This allows us to mark the parent object as invalid if all associated objects in a presence validated association are marked for destruction. See: https://github.com/rails/rails/issues/6812 | ||||
* | | Deprecate Relation#all. | Jon Leighton | 2012-07-27 | 2 | -5/+5 |
| | | | | | | | | | | | | It has been moved to active_record_deprecated_finders. Use #to_a instead. | ||||
* | | Deprecate ActiveRecord::Base.scoped. | Jon Leighton | 2012-07-27 | 31 | -476/+476 |
| | | | | | | | | | | | | | | It doesn't serve much purpose now that ActiveRecord::Base.all returns a Relation. The code is moved to active_record_deprecated_finders. | ||||
* | | ActiveRecord::Base.all returns a Relation. | Jon Leighton | 2012-07-27 | 28 | -305/+313 |
| | | | | | | | | | | | | | | | | | | | | | | Previously it returned an Array. If you want an array, call e.g. `Post.to_a` rather than `Post.all`. This is more explicit. In most cases this should not break existing code, since Relations use method_missing to delegate unknown methods to #to_a anyway. | ||||
* | | Refactor ActiveRecord::Inheritance.base_class logic | beerlington | 2012-07-26 | 2 | -12/+30 |
| | | | | | | | | | | | | | | | | | | Moved logic from class_of_active_record_descendant(class) to the base_class method. This method was confusing because it required an argument, but that argument was 'self'. Moved base_class tests to inheritance_test.rb and added some test coverage for some untested cases. | ||||
* | | Merge pull request #6654 from stevecj/postgresql-auto-reconnect-2 | Aaron Patterson | 2012-07-25 | 1 | -0/+72 |
|\ \ | | | | | | | Postgresql auto reconnect 2 | ||||
| * | | Stop being silly with formatting of method aliasing. | Steve Jorgensen | 2012-07-16 | 1 | -3/+3 |
| | | | |||||
| * | | Simulated & actual (manual/skipped) PostgreSQL auto-reconnection tests. | Steve Jorgensen | 2012-07-16 | 1 | -0/+72 |
| | | | |||||
* | | | Deprecate update_column in favor of update_columns. | Rafael Mendonça França | 2012-07-24 | 12 | -43/+64 |
| | | | | | | | | | | | | Closes #1190 | ||||
* | | | Use update_columns to implemente the update_column | Rafael Mendonça França | 2012-07-24 | 1 | -2/+36 |
| | | | |||||
* | | | New #update_columns method. | Sebastian Martinez | 2012-07-24 | 1 | -0/+57 |
| | | | |||||
* | | | Restore connection_id on error. | kennyj | 2012-07-23 | 1 | -0/+12 |
| | | | |||||
* | | | rm unnecessary test | Jon Leighton | 2012-07-20 | 1 | -7/+0 |
| | | | | | | | | | | | | | | | interpolation is no longer a thing separate from "normal" assoc conditions. | ||||
* | | | rm redundant test | Jon Leighton | 2012-07-20 | 1 | -7/+0 |
| | | | | | | | | | | | | now everything is converted to the new style, this is not needed | ||||
* | | | Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql. | Jon Leighton | 2012-07-20 | 3 | -173/+2 |
| | | | |||||
* | | | Merge pull request #7078 from kennyj/logging_query_plan | Rafael Mendonça França | 2012-07-19 | 1 | -0/+10 |
|\ \ \ | | | | | | | | | Log query plan when we use count_by_sql method. | ||||
| * | | | Log query plan when we use count_by_sql method. | kennyj | 2012-07-18 | 1 | -0/+10 |
| | | | | |||||
* | | | | revert Default timestamps to non-null | Dave Kroondyk | 2012-07-18 | 2 | -6/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 3dbedd2 added NOT NULL constraints to timestamps. Commit fcef728 started to revert this, but was incomplete. With this commit, 3dbedd2 should be fully reverted and timestamps will no longer default to NOT NULL. | ||||
* | | | | Merge pull request #7028 from lexmag/join_table_indexes | José Valim | 2012-07-18 | 1 | -3/+17 |
|\ \ \ \ | | | | | | | | | | | Add indexes to create_join_table method | ||||
| * | | | | Add join table migration generator | Aleksey Magusev | 2012-07-18 | 1 | -3/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For instance, running rails g migration CreateMediaJoinTable artists musics:uniq will create a migration with create_join_table :artists, :musics do |t| # t.index [:artist_id, :music_id] t.index [:music_id, :artist_id], unique: true end | ||||
* | | | | | AR::Integration must be included after AM::Conversion | John Firebaugh | 2012-07-17 | 1 | -0/+6 |
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | Integration's definition of #to_param must override Conversion's. Otherwise, there is a regression from 3.1 in the behavior of a non-persisted AR::Base instance which nevertheless has an id. | ||||
* | | | | Merge pull request #7076 from kennyj/fix_class_eval | Aaron Patterson | 2012-07-17 | 2 | -3/+3 |
|\ \ \ \ | | | | | | | | | | | Fix class_eval without __FILE__ and __LINE__. | ||||
| * | | | | Fix class_eval without __FILE__ and __LINE__. | kennyj | 2012-07-18 | 2 | -3/+3 |
| | |/ / | |/| | | |||||
* / | | | Fixes "Cannot visit ..." with validates_uniqueness_of | beerlington | 2012-07-17 | 1 | -0/+16 |
|/ / / | | | | | | | | | | | | | | | | Fixes issue with overrding ActiveRecord reader methods with a composed object and using that attribute as the scope of a validates_uniqueness_of validation. | ||||
* | | | Fix SqlBypass.data_column= problem. SqlBypass.find_by_session_id method ↵ | kennyj | 2012-07-15 | 1 | -0/+14 |
| | | | | | | | | | | | | didn't use this assignment. | ||||
* | | | teaching the mysql adapter how to typecast strings returned from the database | Aaron Patterson | 2012-07-13 | 1 | -2/+2 |
| | | | |||||
* | | | fixing tests to deal with data differences between prepared statements and ↵ | Aaron Patterson | 2012-07-13 | 3 | -3/+8 |
| | | | | | | | | | | | | | | | | | | | | | non-prepared statements Conflicts: activerecord/test/cases/query_cache_test.rb | ||||
* | | | fix association :extend option | Jon Leighton | 2012-07-13 | 2 | -3/+6 |
| | | | |||||
* | | | stop using class_attribute where methods/inheritance will suffice. | Jon Leighton | 2012-07-13 | 1 | -16/+0 |
| | | | |||||
* | | | Represent association scope options as AR::Relations insternally. | Jon Leighton | 2012-07-13 | 2 | -19/+38 |
| | | | |||||
* | | | fix assertion arguments order | Jon Leighton | 2012-07-13 | 1 | -2/+2 |
| | | | |||||
* | | | Allow associations to take a lambda which builds the scope | Jon Leighton | 2012-07-13 | 3 | -23/+30 |
| | | | |||||
* | | | support relations created with a table alias | Jon Leighton | 2012-07-13 | 1 | -0/+10 |
| | | | |||||
* | | | Add teardown method to AR::Mig::RenameTableTest | Robb Kidd | 2012-07-10 | 1 | -18/+13 |
| | | | | | | | | | | | | | | | | | | | | | Dry up reseting the renamed table after each test. Also made use of the AR::Base.connection object already available from AR::MigrationTest#connection. | ||||
* | | | Merge pull request #6874 from robbkidd/rename_sequences_too | Aaron Patterson | 2012-07-10 | 1 | -0/+13 |
|\ \ \ | |/ / |/| | | Rename default sequence when table is renamed? [AR:postgres] | ||||
| * | | Update psql adapter to rename a default pkey sequence when renaming a table. | Robb Kidd | 2012-06-27 | 1 | -0/+13 |
| | | | |||||
* | | | Merge pull request #6838 from kennyj/added_registration_task | Carlos Antonio da Silva | 2012-07-07 | 1 | -0/+16 |
|\ \ \ | | | | | | | | | Allow to register database tasks from different adapters | ||||
| * | | | Added a feature to add a database task. e.g. OracleDatabaseTasks | kennyj | 2012-06-24 | 1 | -0/+16 |
| | | | | |||||
* | | | | Relation#inspect handles doesn't perform a new query on an already-loaded ↵ | Jon Leighton | 2012-07-07 | 1 | -1/+12 |
| | | | | | | | | | | | | | | | | relation | ||||
* | | | | Merge pull request #6997 from kennyj/fix_stored_attributes | José Valim | 2012-07-07 | 2 | -0/+14 |
|\ \ \ \ | | | | | | | | | | | Added *instance_writer: false* to stored/serialized attributes. | ||||
| * | | | | Added *instance_writer: false* for stored/serialized attributes. | kennyj | 2012-07-07 | 2 | -0/+14 |
| | | | | | |||||
* | | | | | Limit the number of records in Relation#inspect | Damien Mathieu | 2012-07-06 | 1 | -0/+5 |
|/ / / / | | | | | | | | | | | | | While it's interesting to have the results array, it can make a console or a webpage freeze if there are a lot of them. So this limits the number of records displayed in #inspect to 10 and tells how much were effectively found. | ||||
* | | | | Merge pull request #6985 from sidonath/disable-query-cache-for-locks | Rafael Mendonça França | 2012-07-06 | 1 | -0/+8 |
|\ \ \ \ | | | | | | | | | | | Disable query cache for lock queries | ||||
| * | | | | Disable query cache for lock queries | Damir Zekic | 2012-07-06 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | Fixes #867 |