aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* prefer `drop_table if_exists: true` over raw SQL.Yves Senn2015-02-1812-12/+12
| | | | | | | /cc @yahonda This makes it easier for third party adapters to run our tests, even if that database does not support IF EXISTS.
* Rm `Type#type_cast`Sean Griffin2015-02-172-2/+2
| | | | | | | | | This helper no longer makes sense as a separate method. Instead I'll just have `deserialize` call `cast` by default. This led to a random infinite loop in the `JSON` pg type, when it called `super` from `deserialize`. Not really a great way to fix that other than not calling super, or continuing to have the separate method, which makes the public API differ from what we say it is.
* `type_cast_from_user` -> `cast`Sean Griffin2015-02-1712-90/+90
|
* `type_cast_for_database` -> `serialize`Sean Griffin2015-02-1714-46/+46
|
* `Type#type_cast_from_database` -> `Type#deserialize`Sean Griffin2015-02-1716-44/+44
|
* Fix test failures on Mysql 5.5Sean Griffin2015-02-171-1/+1
|
* Update code which depended on methods added by 1502caefSean Griffin2015-02-171-1/+1
|
* Revert "Allow `:precision` option for time type columns"Sean Griffin2015-02-171-65/+0
| | | | | | | | | | This reverts commit 1502caefd30b137fd1a0865be34c5bbf85ba64c1. The test suite for the mysql adapter broke when this commit was used with MySQL 5.6. Conflicts: activerecord/CHANGELOG.md
* Deprecated passing of `start` value to `find_in_batches` and `find_each` in ↵Vipul A M2015-02-171-7/+28
| | | | favour of `begin_at` value.
* Merge pull request #18662 from estum/foreign-key-existsYves Senn2015-02-161-0/+21
|\ | | | | | | Add `foreign_key_exists?` method.
| * Add `foreign_key_exists?` method.Anton2015-01-241-0/+21
| |
* | Add a global type registry, used to lookup and register typesSean Griffin2015-02-152-0/+172
| | | | | | | | | | | | | | | | As per previous discussions, we want to give users the ability to reference their own types with symbols, instead of having to pass the object manually. This adds the class that will be used to do so. ActiveRecord::Type.register(:money, MyMoneyType)
* | Mention `where.not` in the exampleGodfrey Chan2015-02-141-0/+4
| | | | | | | | | | | | | | ...so it doesn't look like you *have* to use SQL strings for that case (not anymore!). Would like to replace the SQL string example with something that you cannot do with the "normal" query API, but I could not come up with a short, realistic example. Suggestions welcome!
* | Fixed a bug where NULLs are casted into the first enum valueGodfrey Chan2015-02-131-3/+8
| |
* | Partially revert ae33aeaGodfrey Chan2015-02-131-4/+0
| | | | | | | | | | Using enum names in SQL strings doesn't actually work, the test was wrong (fixed in 3dfd1ba).
* | Break up these testsGodfrey Chan2015-02-131-4/+23
| | | | | | | | Make sure we have coverage for both the find/build cases
* | oops, 'format' is not a real enumGodfrey Chan2015-02-131-8/+8
| |
* | Enums should be referred to by symbolsGodfrey Chan2015-02-131-1/+14
| | | | | | | | | | Also updated the documentation about the new ability to query them normally, and added test to make sure they work!
* | Do not overwrite secret token value when already present.Wojciech Wnętrzak2015-02-121-0/+7
| | | | | | | | | | | | | | ``` user = User.create(token: "custom-secure-token") user.token # => "custom-secure-token" ```
* | Merge pull request #18915 from kamipo/extract_date_time_precision_testRafael Mendonça França2015-02-124-271/+102
|\ \ | | | | | | Extract `DateTimePrecisionTest`
| * | Extract `DateTimePrecisionTest`Ryuta Kamizono2015-02-134-271/+102
| | | | | | | | | | | | The datetime precision tests for any adapters is duplicated.
* | | Optimize none? and one? relation query methods to use LIMIT and COUNT.Eugene Gilburg2015-02-122-0/+110
|/ / | | | | | | | | | | | | | | Use SQL COUNT and LIMIT 1 queries for none? and one? methods if no block or limit is given, instead of loading the entire collection to memory. The any? and many? methods already follow this behavior. [Eugene Gilburg & Rafael Mendonça França]
* | Merge pull request #18886 from kamipo/allow_precision_option_for_time_columnRafael Mendonça França2015-02-121-0/+65
|\ \ | | | | | | Allow `:precision` option for time type columns
| * | Allow `:precision` option for time type columnsRyuta Kamizono2015-02-121-0/+65
| | |
* | | get rid of transaction warning when running PG tests.Yves Senn2015-02-121-1/+1
| | | | | | | | | | | | | | | This finally removes the warning "WARNING: there is no transaction in progress" when running Active Record tests using PostgreSQL.
* | | pg tests, be clear about the missing type that causes a test skip.Yves Senn2015-02-122-15/+8
| | | | | | | | | | | | Also removed some cruft in the `setup` and `teardown` methods.
* | | tests, remove unused requires.Yves Senn2015-02-122-2/+0
|/ / | | | | | | | | | | "active_support/testing/stream" is already required in `test_case.rb`. Furthermore the test "test/cases/migration_test.rb" could no longer be executed directly.
* | Refactor enum to be defined in terms of the attributes APISean Griffin2015-02-111-1/+16
| | | | | | | | | | | | | | | | | | | | | | In addition to cleaning up the implementation, this allows type casting behavior to be applied consistently everywhere. (#where for example). A good example of this was the previous need for handling value to key conversion in the setter, because the number had to be passed to `where` directly. This is no longer required, since we can just pass the string along to where. (It's left around for backwards compat) Fixes #18387
* | `current_scope` shouldn't pollute sibling STI classesSean Griffin2015-02-111-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | It looks like the only reason `current_scope` was thread local on `base_class` instead of `self` is to ensure that when we call a named scope created with a proc on the parent class, it correctly uses the default scope of the subclass. The reason this wasn't happening was because the proc captured `self` as the parent class, and we're not actually defining a real method. Using `instance_exec` fixes the problem. Fixes #18806
* | Remove the SQLite3 Binary subclassSean Griffin2015-02-111-10/+0
| | | | | | | | | | | | As far as I can tell, the original reason that this behavior was added has been sufficiently resolved elsewhere, as we no longer remove the encoding of strings coming out of the database.
* | Merge pull request #18883 from ↵Sean Griffin2015-02-111-22/+39
|\ \ | | | | | | | | | | | | kamipo/fix_datetime_precision_dumping_zero_for_postgresql The datetime precision with zero should be dumped
| * | The datetime precision with zero should be dumpedRyuta Kamizono2015-02-111-22/+39
| | | | | | | | | | | | | | | `precision: 0` was not dumped by f1a0fa9e19b7e4ccaea191fc6cf0613880222ee7. However, `precision: 0` is valid value for PostgreSQL timestamps.
* | | prefer `drop_table :table, if_exists: true` over explicit checks.Yves Senn2015-02-111-2/+2
| | |
* | | add test to ensure `remove_reference` with index and fk is invertable.Yves Senn2015-02-111-0/+5
| | |
* | | fix `remove_reference` with `foreign_key: true` on MySQL. #18664.Yves Senn2015-02-111-0/+10
|/ / | | | | | | | | | | | | | | | | | | MySQL rejects to remove an index which is used in a foreign key constraint: ``` ActiveRecord::StatementInvalid: Mysql2::Error: Cannot drop index 'index_copies_on_title_id': needed in a foreign key constraint: ALTER TABLE `copies` DROP `title_id` ``` Removing the constraint before removing the column (and the index) solves this problem.
* | Merge pull request #12257 from vipulnsward/end_on_find_in_batchesRafael Mendonça França2015-02-101-0/+9
|\ \ | | | | | | Add an option `end` to `find_in_batches`
| * | Add an option `end_at` to `find_in_batches`Vipul A M2015-02-091-0/+9
| | | | | | | | | | | | that complements the `start`parameter to specify where to stop batch processing
* | | Refactor microsecond precision to be database agnosticSean Griffin2015-02-105-24/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The various databases don't actually need significantly different handling for this behavior, and they can achieve it without knowing about the type of the object. The old implementation was returning a string, which will cause problems such as breaking TZ aware attributes, and making it impossible for the adapters to supply their logic for time objects.
* | | Maintain a consistent order in `ActiveRecord::Base#attributes`Sean Griffin2015-02-101-0/+10
|/ / | | | | | | Fixes #18871
* | Remove debug codeCarlos Antonio da Silva2015-02-081-5/+0
| | | | | | | | Added by 101c19f55f5f1d86d35574b805278f11e9a1a48e.
* | Fix rounding problem for PostgreSQL timestamp columnRyuta Kamizono2015-02-081-0/+16
| | | | | | | | | | If timestamp column have the precision, it need to format according to the precision of timestamp column.
* | Merge pull request #18602 from kamipo/respect_database_charset_and_collationAndrew White2015-02-081-4/+12
|\ \ | | | | | | Respect the database default charset for `schema_migrations` table.
| * | Respect the database default charset for `schema_migrations` table.Ryuta Kamizono2015-02-081-4/+12
| | | | | | | | | | | | | | | | | | The charset of `version` column in `schema_migrations` table is depend on the database default charset and collation rather than the encoding of the connection.
* | | Merge pull request #18848 from kamipo/add_auto_increment_methodAndrew White2015-02-081-1/+1
|\ \ \ | | | | | | | | Add `auto_increment?` instead of `extra == 'auto_increment'`
| * | | Add `auto_increment?` instead of `extra == 'auto_increment'`Ryuta Kamizono2015-02-081-1/+1
| |/ /
* / / Remove unused lineRyuta Kamizono2015-02-081-1/+0
|/ /
* | rm `Type#number?`Sean Griffin2015-02-0714-19/+0
| | | | | | | | | | This predicate is only used in `query_attribute`, and is relatively easy to remove without adding a bunch of is a checks.
* | Push multi-parameter assignement into the typesSean Griffin2015-02-071-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | This allows us to remove `Type::Value#klass`, as it was only used for multi-parameter assignment to reach into the types internals. The relevant type objects now accept a hash in addition to their previous accepted arguments to `type_cast_from_user`. This required minor modifications to the tests, since previously they were relying on the fact that mulit-parameter assignement was reaching into the internals of time zone aware attributes. In reaility, changing those properties at runtime wouldn't change the accessor methods for all other forms of assignment.
* | Raise ArgumentError when passing nil to Relation#mergeRafael Mendonça França2015-02-061-0/+16
| | | | | | | | | | | | nil or false should not be valid argument to the merge method. Closes #12264
* | Allow a symbol to be passed to `attribute`, in place of a type objectSean Griffin2015-02-069-18/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The same is not true of `define_attribute`, which is meant to be the low level no-magic API that sits underneath. The differences between the two APIs are: - `attribute` - Lazy (the attribute will be defined after the schema has loaded) - Allows either a type object or a symbol - `define_attribute` - Runs immediately (might get trampled by schema loading) - Requires a type object This was the last blocker in terms of public interface requirements originally discussed for this feature back in May. All the implementation blockers have been cleared, so this feature is probably ready for release (pending one more look-over by me).
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 21:30:39 +0000