aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Get rid of hack for freezing time on AR testsCarlos Antonio da Silva2013-12-122-23/+5
| | | | | We can now make use of the existent #travel/#travel_to helper methods added to AS test case and available in all tests.
* Merge pull request #13264 from ↵Rafael Mendonça França2013-12-111-0/+8
|\ | | | | | | | | laurocaetano/fix_dynamic_finder_with_reserved_words Prevent invalid code when using dynamic finders with reserved ruby word.
| * Prevent invalid code when using dynamic finders with Ruby's reserved words.Lauro Caetano2013-12-111-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The dynamic finder was creating the method signature with the parameters name, which may have reserved words and this way creating invalid Ruby code. Closes: #13261 Example: # Before Dog.find_by_alias('dog name') # Was creating this method def self.find_by_alias(alias, options = {}) # After Dog.find_by_alias('dog name') # Will create this method def self.find_by_alias(_alias, options = {})
* | Revert the whole refactoring in the association builder classes.Rafael Mendonça França2013-12-111-1/+2
| | | | | | | | This is to get activerecord-deprecated_finders work again
* | Revert "Merge pull request #12518 from vipulnsward/remove_count_options"Rafael Mendonça França2013-12-111-1/+1
|/ | | | | | | It is needed for activerecord-depecated_finders This reverts commit dcff027a5242b20c0c90eb062dddb22ccf51aed9, reversing changes made to 3a2093984ff49d86db1efeff0c7581e788ecfb9f.
* Merge pull request #13236 from jetthoughts/13230_type_cast_bug_in_agr_functionsYves Senn2013-12-101-0/+4
|\ | | | | Fix type cast on group sum with custom expression
| * Fix type cast on group sum with custom expressionPaul Nikitochkin2013-12-101-0/+4
| | | | | | | | | | | | | | | | For PG adapters with custom expression and grouped result of aggregate functions have not found correct column type for it. Extract column type from query result. Closes: #13230
* | Fix warnings on mysql2 explain testCarlos Antonio da Silva2013-12-101-3/+3
| |
* | Merge pull request #13248 from yahonda/support_mysql573_explainJeremy Kemper2013-12-091-3/+3
|\ \ | | | | | | Support MySQL 5.7 explain
| * | Support MySQL 5.7 explainYasuo Honda2013-12-101-3/+3
| |/
* / Remove `DEFAULT NULL` for primary key column to support MySQL 5.7.3Yasuo Honda2013-12-102-6/+6
|/ | | | Since MySQL 5.7.3 m13 does now allow primary key column is null.
* Add integration test for #12459George Guimarães2013-12-051-0/+8
|
* Remove deprecated call to Relation#allCarlos Antonio da Silva2013-12-051-1/+1
|
* polymorphic belongs_to association with touch: true updates old record correctlySeverin Schoepke2013-12-051-16/+42
| | | | | | | | | Example: Given you have a comments model with a polymorphic commentable association (e.g. books and songs) with the touch option set. Every time you update a comment its commentable should be touched. This was working when you changed attributes on the comment or when you moved the comment from one book to another. However, it was not working when moving a comment from a book to a song. This is now fixed.
* Merge pull request #12403 from thedarkone/attr-method-missing-fixRafael Mendonça França2013-12-041-2/+33
|\ | | | | | | | | | | | | Fix AR#method_missing re-dispatching into overwritten attribute methods Conflicts: activerecord/lib/active_record/attribute_methods.rb
| * Fix AR#method_missing re-dispatching into overwritten attribute methods.thedarkone2013-09-291-2/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This was happening when a `super` call in an overwritten attribute method was triggering a method_missing fallback, because attribute methods haven't been generated yet. class Topic < ActiveRecord::Base def title # `super` would re-invoke this method if define_attribute_methods # hasn't been called yet resulting in double '!' appending super + '!' end end
* | Fix offset with last.Lauro Caetano2013-12-031-0/+9
| | | | | | | | Closes #7441
* | `connection.type_to_sql` returns a `String` for unmapped types.Yves Senn2013-12-031-0/+4
| | | | | | | | | | | | | | | | | | | | Closes #13146. This fixes an error when using: ``` change_colum :table, :column, :bigint, array: true ```
* | Fix bad usage of #select with hashCarlos Antonio da Silva2013-12-031-1/+1
| |
* | Currently, we clear query_cache in cache block finish, even if we may ↵Vipul A M2013-12-031-0/+9
| | | | | | | | | | | | already have cache true. This commit takes into account the last cache_enabled value, before clearing query_cache.
* | Introduce a context for rendering fixtures ERB.Victor Costan2013-12-031-0/+55
| | | | | | | | | | | | | | | | | | | | Fixture files are passed through an ERB renderer before being read as YAML. The rendering is currently done in the context of the main object, so method definitons leak into other fixtures, and there is no clean place to define fixture helpers. After this commit, the ERB renderer will use a new subclass of ActiveRecord::FixtureSet.context_class each time a fixture is rendered.
* | Make the tests break againRafael Mendonça França2013-12-021-2/+0
| | | | | | | | We need to fix this test
* | Merge pull request #13111 from akshay-vishnoi/typoCarlos Antonio da Silva2013-11-301-1/+1
|\ \ | | | | | | Typo fixes [ci skip]
| * | Typo fixes [ci skip]Akshay Vishnoi2013-11-301-1/+1
| | |
* | | Raise `ArgumentError` when `has_one` is used with `counter_cache`Godfrey Chan2013-11-292-0/+16
|/ / | | | | | | | | | | | | | | | | Previously, the `has_one` macro incorrectly accepts the `counter_cache` option due to a bug, although that options was never supported nor functional on `has_one` and `has_one ... through` relationships. It now correctly raises an `ArgumentError` when passed that option. For reference, this bug was introduced in 52f8e4b9.
* | updating options documentation for associationsKuldeep Aggarwal2013-11-291-8/+3
| | | | | | | | removed unnecessary test case and improved test case for belongs_to having invalid options
* | Merge pull request #13054 from senny/remove_oracle_testsYves Senn2013-11-271-17/+0
|\ \ | | | | | | Remove leftover Oracle tests.
| * | the oracle adapter lives in a gem. Tests should live there as well.Yves Senn2013-11-261-17/+0
| | |
* | | Merge pull request #13061 from ↵Rafael Mendonça França2013-11-261-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | laurocaetano/fix-uniqueness-validation-for-aliased-attribute Fix bug when validating the uniqueness of an aliased attribute. Conflicts: activerecord/CHANGELOG.md
* | | changed update counter to act on unscoped modelheruku2013-11-261-0/+8
| | |
* | | remove leftover firebird adapter tests.Yves Senn2013-11-263-148/+0
|/ /
* | `rename_index`: add the new index before removing the old one.Yves Senn2013-11-261-6/+19
| | | | | | | | | | | | | | | | | | | | | | This prevents the following error when a MySQL index on a foreign key column is renamed: ``` ActiveRecord::StatementInvalid: Mysql2::Error: Cannot drop index 'index_engines_on_car_id': needed in a foreign key constraint: DROP INDEX `index_engines_on_car_id` ON `engines` ``` refs: #13038.
* | Raise `RecordNotDestroyed` when children can't be replacedBrian Thomas Storti2013-11-251-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #12812 Raise `ActiveRecord::RecordNotDestroyed` when a child marked with `dependent: destroy` can't be destroyed. The following code: ```ruby class Post < ActiveRecord::Base has_many :comments, dependent: :destroy end class Comment < ActiveRecord::Base before_destroy do return false end end post = Post.create!(comments: [Comment.create!]) post.comments = [Comment.create!] ```` would result in a `post` with two `comments`. With this commit, the same code would raise a `RecordNotDestroyed` exception, keeping the `post` with the same `comment`.
* | require the files we testAaron Patterson2013-11-251-0/+1
| |
* | Merge pull request #13034 from vipulnsward/some_typosRafael Mendonça França2013-11-251-1/+1
|\ \ | | | | | | Fix some minor typos
| * | Fix some minor typos [ci skip]Vipul A M2013-11-261-1/+1
| | |
* | | Merge pull request #13029 from akshay-vishnoi/documentationYves Senn2013-11-251-4/+4
|\ \ \ | |/ / |/| | `delgated` => `delegated`
| * | `delgated` => `delegated`Akshay Vishnoi2013-11-251-4/+4
| | |
* | | Fix validation on uniqueness of empty associationEvgeny Li2013-11-221-0/+19
| | |
* | | replace custom Time stubbing with `travel` and `travel_to`.Yves Senn2013-11-211-37/+7
| | |
* | | Fix ActiveRecord::Relation#unscopeJon Leighton2013-11-203-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm pretty confused about the addition of this method. The documentation says that it was intended to allow the removal of values from the default scope (in contrast to #except). However it behaves exactly the same as except: https://gist.github.com/jonleighton/7537008 (other than having a slightly enhanced syntax). The removal of the default scope is allowed by 94924dc32baf78f13e289172534c2e71c9c8cade, which was not a change we could make until 4.1 due to the need to deprecate things. However after that change #unscope still gives us nothing that #except doesn't already give us. However there *is* a desire to be able to unscope stuff in a way that persists across merges, which would allow associations to be defined which unscope stuff from the default scope of the associated model. E.g. has_many :comments, -> { unscope where: :trashed } So that's what this change implements. I've also corrected the documentation. I removed the guide references to #except as I think unscope really supercedes #except now. While we're here, there's also a potential desire to be able to write this: has_many :comments, -> { unscoped } However, it doesn't make sense and would not be straightforward to implement. While with #unscope we're specifying exactly what we want to be removed from the relation, with "unscoped" we're just saying that we want it to not have some things which were added earlier on by the default scope. However in the case of an association, we surely don't want *all* conditions to be removed, otherwise the above would just become "SELECT * FROM comments" with no foreign key constraint. To make the above work, we'd have to somehow tag the relation values which get added when evaluating the default scope in order to differentiate them from other relation values. Which is way too much complexity and therefore not worth it when most use cases can be satisfied with unscope. Closes #10643, #11061.
* | | swap arguments for some `assert_equal` statements => `expected, actual`Yves Senn2013-11-201-6/+6
| | |
* | | use arel nodes to represent non-string `order_values`.Yves Senn2013-11-192-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a bug when merging relations of different classes. ``` Given: Post.joins(:author).merge(Author.order(name: :desc)).to_sql Before: SELECT "posts".* FROM "posts" INNER JOIN "authors" ON "authors"."id" = "posts"."author_id" ORDER BY "posts"."name" DESC After: SELECT "posts".* FROM "posts" INNER JOIN "authors" ON "authors"."id" = "posts"."author_id" ORDER BY "authors"."name" DESC ```
* | | Revert "Properly require database tasks so we have access to the raised ↵Rafael Mendonça França2013-11-193-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | constant" This reverts commit fbcd46b1a0d255a34d29caa77bbd31c287446333. This is not needed anymore. See 7280965
* | | Revert "Explicitly exit with status "1" for create and drop failures"Rafael Mendonça França2013-11-193-18/+6
|/ / | | | | | | | | | | | | | | | | | | This reverts commit 22f80ae57b26907f662b7fd50a7270a6381e527e. See https://github.com/rails/rails/commit/22f80ae57b26907f662b7fd50a7270a6381e527e#commitcomment-4640676 Conflicts: activerecord/CHANGELOG.md
* | Do not count query for all_constraints and all_tab_cols in OracleYasuo Honda2013-11-181-1/+1
| |
* | Address test_merging_where_relations failure by adding `order("posts.id")`Yasuo Honda2013-11-181-1/+1
| |
* | Properly require database tasks so we have access to the raised constantCarlos Antonio da Silva2013-11-173-0/+3
| | | | | | | | Fix travis failures.
* | Merge pull request #12918 from versioncontrol/rails-12866Rafael Mendonça França2013-11-161-0/+4
|\ \ | | | | | | | | | | | | | | | | | | Checks to see if the record contains the foreign_key to set the inverse automatically Conflicts: activerecord/CHANGELOG.md
| * | Checks to see if the record contains the foreign_key to set the inverse ↵Edo Balvers2013-11-161-0/+4
| | | | | | | | | | | | automatically
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-15 11:33:54 +0000