aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix that after commit callbacks on update does not triggered when optimistic ↵Ryuta Kamizono2018-03-061-0/+22
| | | | | | | | | | | | | | | | | | locking is enabled This issue is caused by `@_trigger_update_callback` won't be updated due to `_update_record` in `Locking::Optimistic` doesn't call `super` when optimistic locking is enabled. Now optimistic locking concern when updating is supported by `_update_row` low level API, therefore overriding `_update_record` is no longer necessary. Removing the method just fix the issue. Closes #29096. Closes #29321. Closes #30823.
* `id_in_database` should be respected as primary key value for persisted recordsRyuta Kamizono2018-03-051-0/+39
| | | | | | | | | | | | Currently primary key value can not be updated if a record has a locking column because of `_update_record` in `Locking::Optimistic` doesn't respect `id_in_database` as primary key value unlike in `Persistence`. And also, if a record has dirty primary key value, it may destroy any other record by the lock version of dirty record itself. When updating/destroying persisted records, it should identify themselves by `id_in_database`, not by dirty primary key value.
* Fix occurrences Fixnum|Bignumbogdanvlviv2018-03-042-14/+6
| | | | Related to https://github.com/rails/rails/commit/d4eb0dc89ee6b476e2e10869dc282a96f956c6c7#r27830891
* Eager loading with polymorphic associations should behave consistentlyRyuta Kamizono2018-03-041-2/+4
| | | | | | | | | | This reverts ignoring polymorphic error introduced at 02da8ae. What the ignoring want to solve was caused by force eager loading regardless of whether it is necessary, but it has been fixed by #29043. The ignoring is now only causing a mismatch of `exists?` behavior with `to_a`, `count`, etc. It should behave consistently.
* Extract all `base_class.name` as `polymorphic_name`Ryuta Kamizono2018-03-041-9/+23
| | | | | | | This is an alternative of #29722, and follow up of #32048. This does not change the current behavior, but makes it easier to modify all polymorphic names consistently.
* Remove unnecessary `respond_to?(:report_on_exception)` checkingyuuji.yaginuma2018-03-023-6/+6
| | | | Since Rails 6 requires Ruby 2.4.1+.
* Use `with_partial_writes` helper in `activerecord/test/cases/dirty_test.rb`bogdanvlviv2018-02-281-5/+1
| | | | Related to 948b931925febac3c965ab13470065ced68f7b53
* Fix `#columsn_for_distinct` of MySQL and PostgreSQLkg8m2018-02-273-15/+20
| | | | | | | Prevent `ActiveRecord::FinderMethods#limited_ids_for` from using correct primary key values even if `ORDER BY` columns include other table's primary key. Fixes #28364.
* Merge pull request #32005 from maschwenk/ar-distinct-order-count-regressionRyuta Kamizono2018-02-272-0/+12
|\ | | | | | | Active Record distinct & order #count regression
| * Distinct with order #count regressionMax Schwenk2018-02-251-0/+8
| |
* | Merge pull request #31189 from ↵Rafael França2018-02-271-0/+19
|\ \ | | | | | | | | | | | | tgxworld/raise_error_when_advisory_lock_is_not_releases Raise an error if advisory lock in migrator was not released.
| * | Raise an error if advisory lock in migrator was not released.Guo Xiang Tan2017-11-211-0/+19
| | |
* | | Ensure we don't write virtual attributes on update, tooSean Griffin2018-02-261-1/+4
| | | | | | | | | | | | See 948b931925febac3c965ab13470065ced68f7b53 for context
* | | Never attempt to write virtual attributes to the databaseSean Griffin2018-02-261-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the place where we limit what gets sent to the database is in the implementation for `partial_writes`. We should also be restricting it to column names when partial writes are turned off. Note that we're using `&` instead of just defaulting to `self.class.column_names`, as the instance version of `attribute_names` does not include attributes which are uninitialized (were not included in the select clause)
* | | Fix "NameError: uninitialized constant Categorization::Category"yuuji.yaginuma2018-02-261-0/+1
| |/ |/| | | | | | | | | | | | | Since #31895, build of 2.5 and AR combination failed. https://travis-ci.org/rails/rails/jobs/346064349#L1638 It seems to be the reason that model is not loading properly, so I added require. But I'm not sure if this is correct
* | Merge pull request #31895 from ↵Ryuta Kamizono2018-02-261-0/+10
|\ \ | | | | | | | | | | | | kamipo/do_not_attempt_to_find_inverse_of_polymorphic Make `reflection.klass` raise if `polymorphic?` not to be misused
| * | Make `reflection.klass` raise if `polymorphic?` not to be misusedRyuta Kamizono2018-02-191-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an alternative of #31877 to fix #31876 caused by #28808. This issue was caused by a combination of several loose implementation. * finding automatic inverse association of polymorphic without context (caused by #28808) * returning `klass` even if `polymorphic?` (exists before #28808) * loose verification by `valid_inverse_reflection?` (exists before #28808) This makes `klass` raise if `polymorphic?` not to be misused. This issue will not happen unless polymorphic `klass` is misused. Fixes #31876. Closes #31877.
* | | Association creation and finding should work consistently (#32048)Ryuta Kamizono2018-02-261-5/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an alternative of #29722, and revert of #29601 and a1fcbd9. Currently, association creation and normal association finding doesn't respect `store_full_sti_class`. But eager loading and preloading respect the setting. This means that if set `store_full_sti_class = false` (`true` by default), eager loading and preloading can not find created polymorphic records. Association creation and finding should work consistently.
* | | More exercise range predicate builderRyuta Kamizono2018-02-231-0/+9
| | | | | | | | | | | | | | | * Add test case for open-ended range. * Add test case for numeric range for string column.
* | | PostgreSQL: Allow BC dates like datetime consistentlyRyuta Kamizono2018-02-231-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | BC dates are supported by both date and datetime types. https://www.postgresql.org/docs/current/static/datatype-datetime.html Since #1097, new datetime allows year zero as 1 BC, but new date does not. It should be allowed even in new date consistently.
* | | PostgreSQL: Treat infinite values in date like datetime consistentlyRyuta Kamizono2018-02-232-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The values infinity and -infinity are supported by both date and timestamp types. https://www.postgresql.org/docs/current/static/datatype-datetime.html#DATATYPE-DATETIME-SPECIAL-TABLE And also, it can not be known whether a value is infinity correctly unless cast a value. I've added `QueryAttribute#infinity?` to handle that case. Closes #27585.
* | | Revert "Merge pull request #32075 from eileencodes/delete-default-configuration"eileencodes2018-02-221-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 16f279ebd474626577ced858e3626ac4535a33df, reversing changes made to 6c6a30a7c357ce1eafa093d77d2b08684fe50887. The config can be named anything, not just default (although all generated apps will be named default). We can't just delete configs that don't have a database because that will break three-tier configs. Oh well.
* | | Properly escape column name embedded into regexpAndreas Bühmann2018-02-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | SQLServerAdapter (gem `activerecord-sqlserver-adapter`) uses square brackets for quoting column names (e.g. `[id]`). Those brackets must not be misinterpreted in regular expressions. Failure: Expected /SELECT [developers].[id].* FROM developers/ to match "SELECT [developers].[id], [developers].[name], [developers].[salary], [developers].[firm_id], [developers].[mentor_id], [developers].[created_at], [developers].[updated_at], [developers].[created_on], [developers].[updated_on] FROM developers".
* | | Add cop for preferring 'Foo.method' over 'Foo::method'Andrew White2018-02-221-1/+1
| | |
* | | Merge pull request #32075 from eileencodes/delete-default-configurationEileen M. Uchitelle2018-02-211-16/+0
|\ \ \ | | | | | | | | Delete default configuration
| * | | Delete default configurationeileencodes2018-02-211-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Because of this default configuration we're constantly checking if the database exists when looping through configurations. This is unnecessary and we should just delete it before we need to loop through configurations.
* | | | Use the query cache when connection is already connectedyuuji.yaginuma2018-02-191-0/+11
| |/ / |/| | | | | | | | Fixes #32021.
* | | Association scope's own order should be prioritized over through scope's orderRyuta Kamizono2018-02-181-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3acc5d6 was changed the order of scope evaluation from through scope to the association's own scope to be prioritized over the through scope. But the sorting order will be prioritized that is evaluated first. It is unintentional effect, association scope's sorting order should be prioritized as well. Fixes #32008.
* | | Deprecate update_attributes and update_attributes!Eddie Lebow2018-02-1712-58/+35
| | | | | | | | | | | | Closes #31998
* | | Add chop removed in 89bcca5Rafael Mendonça França2018-02-161-1/+1
| | |
* | | Remove usage of strip_heredoc in the framework in favor of <<~Rafael Mendonça França2018-02-164-45/+43
|/ / | | | | | | | | Some places we can't remove because Ruby still don't have a method equivalent to strip_heredoc to be called in an already existent string.
* | Add #create_or_find_by to lean on unique constraints (#31989)David Heinemeier Hansson2018-02-141-0/+29
| | | | | | Add #create_or_find_by to lean on unique constraints
* | Add test to make sure pick works in a NullRelationRafael Mendonça França2018-02-121-0/+2
| |
* | Merge pull request #31133 from ↵Matthew Draper2018-02-111-0/+15
|\ \ | | | | | | | | | | | | mohsen-alizadeh/sanitize_empty_and_nil_parameters_passed_to_select sanitize empty and nil parameters to select #31059
| * | add test case to relation selectMohsen Alizadeh2017-12-031-0/+15
| | |
* | | Add Relation#pick as short-hand for single-value plucks (#31941)David Heinemeier Hansson2018-02-091-0/+10
| | | | | | | | | * Add Relation#pick as short-hand for single-value plucks
* | | Merge pull request #31934 from fatkodima/fix-has_many_through-dumpingRyuta Kamizono2018-02-091-0/+5
|\ \ \ | | | | | | | | | | | | Fix marshaling of models with `has_many :through` associations
| * | | Fix marshaling of models with `has_many :through` associationsfatkodima2018-02-081-0/+6
| | | |
* | | | Fix `test_counter_cache_with_touch_and_lock_version` failurebogdanvlviv2018-02-071-1/+3
|/ / / | | | | | | | | | | | | | | | https://travis-ci.org/rails/rails/jobs/338338927#L1043 Related to daf15f58b943d85d8fb726590ae94f77ca0a5d5f
* | | Invoke `load_schema` in `_default_attributes`Ryuta Kamizono2018-02-061-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `_default_attributes` doesn't work unless `load_schema` is called before. The `MissingAttributeError` is caused by `reload_schema_from_cache` is invoked by `serialize`. I added `load_schema` in `_default_attributes` to `_default_attributes` works without any dependency like `attribute_types` etc. Closes #31905.
* | | Merge pull request #31814 from fatkodima/index-nulls-orderRafael França2018-01-292-0/+34
|\ \ \ | | | | | | | | Dump correctly index nulls order for PostgreSQL
| * | | Dump correctly index nulls order for postgresqlfatkodima2018-01-282-0/+34
| | | |
* | | | Deprecate `expand_hash_conditions_for_aggregates`Ryuta Kamizono2018-01-291-0/+7
| | | | | | | | | | | | | | | | | | | | This can not expand an array of aggregated objects correctly, and is no longer used internally since 159b21b5.
* | | | Merge pull request #31615 from cben/type_for_attribute-symbolRyuta Kamizono2018-01-291-0/+14
|\ \ \ \ | | | | | | | | | | Allow type_for_attribute(:symbol)
| * | | | Allow type_for_attribute(:symbol)Beni Cherniavsky-Paskin2018-01-011-0/+14
| | | | | | | | | | | | | | | | | | | | Closes #31611.
* | | | | Fix expanding an array of `composed_of` objects which have multiple mappingsRyuta Kamizono2018-01-291-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #31724. If `composed_of` objects have multiple mappings, array predicate handler can not correctly handle the expanded condition. We need to handle it like polymorphic association objects.
* | | | | Merge pull request #31724 from orekyuu/fix-expand-composed-object-arrayRyuta Kamizono2018-01-291-0/+18
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | Fix not expanded problem when passing an Array object as argument to the where method using composed_of column.
| * | | | Allow expanding an array of `composed_of` objectsRyuta Kamizono2018-01-291-3/+2
| | | | |
| * | | | Fix not expanded problem when passing an Array object as argument to the ↵orekyuu2018-01-261-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | where method using composed_of column. Fixes #31723 ``` david_balance = customers(:david).balance Customer.where(balance: [david_balance]).to_sql # Before: WHERE `customers`.`balance` = NULL # After : WHERE `customers`.`balance` = 50 ```
* | | | | Remove extra whitespaceDaniel Colson2018-01-258-46/+46
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 06:15:52 +0000