Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix typo. This test isn't executed in even postgresql. | kennyj | 2013-09-22 | 1 | -1/+1 |
| | |||||
* | remove unused variable | Aaron Patterson | 2013-09-18 | 1 | -1/+0 |
| | |||||
* | support objects with blank string primary keys | Aaron Patterson | 2013-09-18 | 1 | -0/+6 |
| | |||||
* | ActiveRecord::Base#<=> has been removed. Primary keys may not be in order, | Aaron Patterson | 2013-09-18 | 1 | -7/+0 |
| | | | | | | | | | | | or even be numbers, so sorting by id doesn't make sense. Please use `sort_by` and specify the attribute you wish to sort with. For example, change: Post.all.to_a.sort to: Post.all.to_a.sort_by(&:id) | ||||
* | do what the superclass does in the case that objects do not match | Aaron Patterson | 2013-09-18 | 1 | -0/+8 |
| | |||||
* | Merge pull request #12011 from jetthoughts/11963_fix_join_with_association_scope | Rafael Mendonça França | 2013-09-16 | 1 | -0/+5 |
|\ | | | | | | | | | | | | | Collapse where constraints to the Arel::Nodes::And node Conflicts: activerecord/CHANGELOG.md | ||||
| * | Collapse where constraints to one where constraint | Paul Nikitochkin | 2013-09-13 | 1 | -0/+5 |
| | | | | | | | | | | | | | | In order to remove duplication with joining arel where constraints with `AND`, all constraints on `build_arel` are collapsed into one head node: `Arel::Nodes::And` Closes: #11963 | ||||
* | | Merge pull request #12129 from Empact/deprecate-array-bang-delegation | Rafael Mendonça França | 2013-09-12 | 3 | -144/+245 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | Deprecate the delegation of Array bang methods in ActiveRecord::Delegation Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/relation_test.rb | ||||
| * | | Deprecate the delegation of Array bang methods in ActiveRecord::Delegation | Ben Woosley | 2013-09-04 | 1 | -0/+97 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The primary means of returning results for Array bang methods is to modify the array in-place. When you call these methods on a relation, that array is created, modified, and then thrown away. Only the secondary return value is exposed to the caller. Removing this delegation is a straight-forward way to reduce user error by forcing callers to first explicitly call #to_a in order to expose the array to be acted on by the bang method. | ||||
| * | | Pull the RelationMutationTests from cases/relation_test to ↵ | Ben Woosley | 2013-09-03 | 2 | -135/+139 |
| | | | | | | | | | | | | cases/relation/mutation_test. | ||||
* | | | Merge pull request #12137 from lann/fix_association_first_last | Rafael Mendonça França | 2013-09-12 | 1 | -3/+5 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Make CollectionAssociation first/last with integer fetch with query Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | Make CollectionAssociation first/last with integer fetch with query | Lann Martin | 2013-09-09 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When first or last is called with an integer on an unloaded association, the entire collection is loaded. This differs surprisingly from the behavior of Relation#first/last, which translate the call into a limit query. For large collections this can make a big difference in performance. Change CollectionAssociation#fetch_first_or_last_using_find? to make this kind of call delegate to Relation. | ||||
* | | | | Merge pull request #12156 from rywall/from-copy-binds | Rafael Mendonça França | 2013-09-12 | 1 | -0/+7 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow Relation#from to accept other relations with bind values. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | | Allow Relation#from to accept other relations with bind values. | Ryan Wallace | 2013-09-08 | 1 | -0/+7 |
| | | | | | |||||
* | | | | | Remove unnecessary loop | Vipul A M | 2013-09-13 | 1 | -5/+2 |
| | | | | | |||||
* | | | | | these are not real developer objects, so counting them doesn't make | Aaron Patterson | 2013-09-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | sense. Let's load the object to ensure it's an array and count the array. | ||||
* | | | | | Check if the SQL is not a prepared statement | Rafael Mendonça França | 2013-09-11 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023 | ||||
* | | | | | Merge pull request #12188 from SamSaffron/master | Aaron Patterson | 2013-09-11 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | Perf: avoid dupes add fallback logic for coders | ||||
| * | | | | | Perf: avoid dupes add fallback logic for coders | Sam | 2013-09-11 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Merge pull request #12135 from dylanahsmith/avoid_empty_transaction | Rafael Mendonça França | 2013-09-11 | 1 | -0/+2 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid empty transaction from setting has_one association on new record. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | | | | Avoid empty transaction from setting has_one association on new record. | Dylan Thacker-Smith | 2013-09-11 | 1 | -0/+2 |
| | | | | | | | |||||
* | | | | | | | Merge pull request #12194 from thedarkone/readonly-merger-fix | Rafael Mendonça França | 2013-09-11 | 1 | -0/+8 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Relation#merge should not lose readonly(false) flag. | ||||
| * | | | | | | | Relation#merge should not lose readonly(false) flag. | thedarkone | 2013-09-11 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original code ignores the `false` value because `false.blank? # => true`. | ||||
* | | | | | | | | fix deleting join models with no pk | Aaron Patterson | 2013-09-11 | 1 | -5/+47 |
| |/ / / / / / |/| | | | | | | |||||
* | | | | | | | add a comment for sanity of other people to come | Aaron Patterson | 2013-09-10 | 1 | -0/+8 |
|/ / / / / / | |||||
* | | | | | | make @bitsweat happy. :heart: | Aaron Patterson | 2013-09-09 | 1 | -0/+6 |
| | | | | | | |||||
* | | | | | | stop using deprecated api in the tests | Aaron Patterson | 2013-09-09 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Fix fixtures regression that required table names to map to classes only, ↵ | Jeremy Kemper | 2013-09-08 | 1 | -1/+1 |
| |/ / / / |/| | | | | | | | | | | | | | | not class names | ||||
* | | | | | hm:t join tables may not have a primary key | Aaron Patterson | 2013-09-06 | 1 | -0/+18 |
| | | | | | |||||
* | | | | | auto link hm:t fixture join tables like habtm | Aaron Patterson | 2013-09-06 | 1 | -0/+35 |
| |_|_|/ |/| | | | |||||
* | | | | Add a test case for exists? with multiple values | Rafael Mendonça França + Kassio Borges | 2013-09-04 | 1 | -0/+1 |
| |/ / |/| | | |||||
* | | | Merge pull request #11958 from jetthoughts/extract_pre_process_orders_args | Yves Senn | 2013-09-04 | 3 | -2/+32 |
|\ \ \ | |_|/ |/| | | Re-use order arguments pre-processing for reorder | ||||
| * | | Extracted from `order` processing of arguments, and use it for `reorder` to ↵ | Paul Nikitochkin | 2013-09-04 | 3 | -2/+32 |
| | | | | | | | | | | | | be consistent. | ||||
* | | | adding a hm:t test for singleton ar objects | Aaron Patterson | 2013-09-03 | 1 | -0/+27 |
| | | | |||||
* | | | support anonymous classes on has_many associations | Aaron Patterson | 2013-09-03 | 1 | -0/+18 |
| | | | |||||
* | | | clear all connections before forking | Aaron Patterson | 2013-08-31 | 1 | -0/+3 |
| | | | |||||
* | | | Revert "Do not dup the binds when visiting the AST" | Rafael Mendonça França + Kassio Borges | 2013-08-31 | 1 | -8/+0 |
| | | | | | | | | | | | | | | | | | | This reverts commit 71ff7d9c6592b93e2c810a1f464943dd7bd02c7f. Reason: I need to check with @jeremy if we can do this. | ||||
* | | | Don't need to check if the scope respond to call | Rafael Mendonça França + Kassio Borges | 2013-08-31 | 2 | -2/+2 |
| | | | | | | | | | | | | | | | We are checking this when defining the default scope and raising an ArgumentError | ||||
* | | | Revert "reconnect after the fork returns" | Rafael Mendonça França | 2013-08-31 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit baf5f47b8768c7ec0164ed5ab60e369cdd936d71. Reason: This is breaking the sqlite3 tests with a missing transacion. Could not investigate right now. cc @tenderlove | ||||
* | | | Do not dup the binds when visiting the AST | Rafael Mendonça França | 2013-08-31 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023 | ||||
* | | | reconnect after the fork returns | Aaron Patterson | 2013-08-30 | 1 | -0/+2 |
| | | | |||||
* | | | remove unused variable | Aaron Patterson | 2013-08-30 | 1 | -1/+1 |
| | | | |||||
* | | | move the cache to the AR models and populate it on inherited | Aaron Patterson | 2013-08-30 | 1 | -4/+19 |
| | | | |||||
* | | | add a failing test for marshal + cache problems | Aaron Patterson | 2013-08-30 | 1 | -0/+26 |
| | | | |||||
* | | | add missing fixtures file | Aaron Patterson | 2013-08-30 | 1 | -1/+2 |
| | | | |||||
* | | | make sure there are actually some categories when running the test | Aaron Patterson | 2013-08-29 | 1 | -0/+1 |
| | | | |||||
* | | | pk should not be required for hm:t associations | Aaron Patterson | 2013-08-29 | 1 | -0/+7 |
| | | | |||||
* | | | Merge pull request #12051 from bcherry/preserve_datetime_milliseconds | Andrew White | 2013-08-28 | 1 | -0/+5 |
|\ \ \ | |/ / |/| | | ActiveRecord: Include usecs when quoting DateTime in PostgreSQL adapter | ||||
| * | | Test that PostgreSQL adapter includes `usec` when quoting `DateTime` | Ben Cherry | 2013-08-28 | 1 | -0/+5 |
| | | | |||||
* | | | query the association rather than send the method for the association name | Aaron Patterson | 2013-08-27 | 1 | -6/+4 |
|/ / |