Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #5720 from kennyj/should_use_klass_method | Jon Leighton | 2012-04-11 | 1 | -0/+1 |
|\ | | | | | Get a properly aliased_table_name, when we use a polymorphic association. | ||||
| * | Get a properly aliased_table_name, when we use a polymorphic association. | kennyj | 2012-04-04 | 1 | -0/+1 |
| | | |||||
* | | Override AR::Relation methods in NullRelation. | Juanjo Bazán | 2012-04-11 | 1 | -0/+33 |
| | | | | | | So a NullRelation (Relation#none) is chainable with database methods. | ||||
* | | Fix delete_all when chained with joins. | Rafael Mendonça França | 2012-04-10 | 1 | -1/+19 |
| | | | | | | | | Closes #5202 and #919 | ||||
* | | Adds test to check that circular preloading does not modify Model.unscoped ↵ | Benedikt Deicke | 2012-04-03 | 2 | -4/+6 |
| | | | | | | | | (as described in #5667) | ||||
* | | Removes caching from ActiveRecord::Core::ClassMethods#relation | Benedikt Deicke | 2012-04-03 | 1 | -0/+4 |
|/ | | | | | | | | | | | The #relation method gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone was ActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place. The four places with calls to relations are: activerecord/lib/active_record/scoping/default.rb:110:in `block in build_default_scope'" activerecord/lib/active_record/scoping/default.rb:42:in `unscoped'" activerecord/lib/active_record/scoping/named.rb:38:in `scoped'" activerecord/lib/active_record/scoping/named.rb:52:in `scope_attributes'" | ||||
* | Fix #5667. Preloading should ignore scoping. | Jon Leighton | 2012-03-30 | 1 | -0/+11 |
| | |||||
* | fix test | Jon Leighton | 2012-03-30 | 1 | -1/+2 |
| | |||||
* | whitespace :scissors: | Jon Leighton | 2012-03-30 | 1 | -4/+3 |
| | |||||
* | Merge pull request #5334 from courtland/master | Jon Leighton | 2012-03-30 | 1 | -1/+11 |
|\ | | | | | Fix deleting from a HABTM join table upon destroying an object of a model with optimistic locking enabled. | ||||
| * | Tests for removing a HABTM association when optimistic locking is enabled. | Nick Rogers | 2012-03-07 | 1 | -1/+11 |
| | | |||||
* | | Add Relation#find_by and Relation#find_by! | Jon Leighton | 2012-03-30 | 2 | -0/+48 |
| | | |||||
* | | Merge pull request #2945 from Casecommons/nested_attributes_module | Jon Leighton | 2012-03-30 | 1 | -0/+13 |
|\ \ | | | | | | | Nested attribute setters can be overridden. | ||||
| * | | Nested attribute setters can be overridden. | Jonathan Mukai & Peter Jaros | 2012-03-28 | 1 | -0/+13 |
| | | | | | | | | | | | | Overriding implementation can call super. | ||||
* | | | Deprecate Column#type_cast_code | Carlos Antonio da Silva | 2012-03-29 | 1 | -4/+0 |
| | | | |||||
* | | | Add ActiveRecord::Base#slice to slice method calls | Guillermo Iguaran | 2012-03-29 | 1 | -0/+12 |
|/ / | |||||
* | | attributes are cached by string keys, so to_s to support symbols. fixes #5549 | Aaron Patterson | 2012-03-27 | 1 | -1/+15 |
| | | |||||
* | | removed unused variables | Arun Agrawal | 2012-03-27 | 1 | -2/+2 |
| | | |||||
* | | ActiveRecord::Coders::YAMLColumn#dump should raise an error | Guten | 2012-03-26 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | closes #2737 Conflicts: activerecord/lib/active_record/coders/yaml_column.rb | ||||
* | | properly namespace the fixture exception | Aaron Patterson | 2012-03-22 | 1 | -1/+1 |
| | | |||||
* | | Deprecate eager-evaluated scopes. | Jon Leighton | 2012-03-21 | 1 | -10/+35 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions | ||||
* | | Remove valid_scope_name? check - use ruby | Jon Leighton | 2012-03-21 | 1 | -19/+0 |
| | | | | | | | | | | | | | | scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods. | ||||
* | | changed all.map to pluck | Sandeep | 2012-03-19 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #3329 from armstrjare/autosave_collection_new_record_bug | José Valim | 2012-03-18 | 1 | -0/+10 |
|\ \ | | | | | | | Autosave association doesn't save all records on a new record for a collection association if there are records marked for destruction | ||||
| * | | Fix bug with autosave collection association on new record with a marked for ↵ | Jared Armstrong | 2012-03-18 | 1 | -0/+10 |
| | | | | | | | | | | | | destroy record in autosave collection. | ||||
* | | | Fix typo in ActiveRecord::Relation#blank? test | Ruben Davila | 2012-03-17 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #5321 from pfeiffer/uniqueness_validator_conditions | José Valim | 2012-03-17 | 1 | -0/+12 |
|\ \ \ | | | | | | | | | Add :conditions option to uniqueness validator | ||||
| * | | | Change syntax to accept an AR::Relation instead of old conditions hash/array. | Mattias Pfeiffer | 2012-03-07 | 1 | -1/+1 |
| | | | | |||||
| * | | | Add :conditions option to uniqueness validator | Mattias Pfeiffer | 2012-03-07 | 1 | -0/+12 |
| | | | | |||||
* | | | | Fix ActiveRecord::Relation#blank? tests | Rafael Mendonça França | 2012-03-16 | 1 | -12/+15 |
| | | | | |||||
* | | | | Merge pull request #5469 from yakko/master | José Valim | 2012-03-16 | 1 | -0/+19 |
|\ \ \ \ | |_|/ / |/| | | | tests for Relation .present? .blank? | ||||
| * | | | test relation presence fix | Thiago Almeida | 2012-03-16 | 1 | -4/+4 |
| | | | | |||||
| * | | | tests for Relation .present? and .blank? are check cases and shouldn't force ↵ | Thiago Almeida | 2012-03-16 | 1 | -0/+19 |
| | | | | | | | | | | | | | | | | sql-count | ||||
* | | | | Merge pull request #5327 from kennyj/fix_explicitly_inheraitance_column | Aaron Patterson | 2012-03-15 | 1 | -0/+10 |
|\ \ \ \ | |/ / / |/| | | | Don't reset inheritance_column when setting explicitly. | ||||
| * | | | Don't reset inheritance_column when setting explicitly. | kennyj | 2012-03-08 | 1 | -0/+10 |
| |/ / | |||||
* | | | Address the dump file format for hstore | Yasuo Honda | 2012-03-15 | 1 | -1/+1 |
| | | | |||||
* | | | Fix GH #5430. A Payload name for schema_search_path should be SCHEMA. | kennyj | 2012-03-15 | 1 | -0/+7 |
| | | | |||||
* | | | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 11 | -694/+22 |
| | | | |||||
* | | | Fix GH #5399. connection_pools's keys are ↵ | kennyj | 2012-03-14 | 1 | -1/+7 |
| | | | | | | | | | | | | ActiveRecord::Base::ConnectionSpecification objects. | ||||
* | | | make sure connections returned after close are marked as in_use | Aaron Patterson | 2012-03-12 | 1 | -0/+10 |
| | | | |||||
* | | | Add dynamic find_or_create_by_{attribute}! method. | Andrew White | 2012-03-12 | 4 | -0/+52 |
| | | | |||||
* | | | fix activerecord query_method regression with offset into Fixnum | Denis Jean | 2012-03-12 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | add test to show offset query_methods on mysql & mysql2 change test to cover public API | ||||
* | | | In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] ↵ | Alexey Vakhov | 2012-03-09 | 1 | -0/+7 |
| | | | | | | | | | | | | correct | ||||
* | | | ensure that released connections move between threads | Aaron Patterson | 2012-03-08 | 1 | -0/+18 |
| | | | |||||
* | | | make active_connection? return true only if there is an open connection in ↵ | Aaron Patterson | 2012-03-08 | 1 | -0/+35 |
| | | | | | | | | | | | | use for the current thread. fixes #5330 | ||||
* | | | Merge pull request #5306 from kennyj/fix_69c7f02 | José Valim | 2012-03-08 | 2 | -2/+2 |
|\ \ \ | | | | | | | | | Change the message string to use in test case. | ||||
| * | | | Change the string to use in test case. | kennyj | 2012-03-07 | 2 | -2/+2 |
| |/ / | |||||
* | | | Merge pull request #5289 from rafaelfranca/fix-through-associations | Jon Leighton | 2012-03-08 | 1 | -4/+20 |
|\ \ \ | | | | | | | | | Fix has_many through associations when mass_assignment_sanitizer is strict | ||||
| * | | | Not need to pass join attributes to association build | Rafael Mendonça França | 2012-03-07 | 1 | -3/+2 |
| | | | | |||||
| * | | | Add test case to has_many through association when mass_assignment_sanitizer is | Rafael Mendonça França | 2012-03-05 | 1 | -4/+21 |
| |/ / | | | | | | | | | | :strict |