aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* fixing merge errorsAaron Patterson2011-01-042-78/+0
|
* Remove undocumented feature from has_one where you could pass false as the ↵Jon Leighton2011-01-032-36/+7
| | | | | | | | | | | | second parameter to build_assoc or create_assoc, and the existing associated object would be untouched (the foreign key would not be nullified, and it would not be deleted). If you want behaviour similar to this you can do the following things: * Use :dependent => :nullify (or don't specify :dependent) if you want to prevent the existing associated object from being deleted * Use has_many if you actually want multiple associated objects * Explicitly set the foreign key if, for some reason, you really need to have multiple objects associated with the same has_one. E.g. previous = obj.assoc obj.create_assoc previous.update_attributes(:obj_id => obj.id)
* ActiveRecord::Relation#primary_key should return a string, just like ↵Jon Leighton2011-01-031-0/+4
| | | | ActiveRecord::Base.primary_key does.
* Implement deprecated version of AssociationReflection#primary_key_name, ↵Jon Leighton2011-01-031-0/+12
| | | | which has been renamed to #foreign_key. Also bumping the deprecation_horizon in Active Support to 3.1.
* When preloading a belongs_to, the target should still be set (to nil) if ↵Jon Leighton2011-01-031-0/+9
| | | | there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations.
* Make Relation#create_with always merge rather than overwrite, not just when ↵Jon Leighton2011-01-031-0/+10
| | | | merging two relations. If you wish to overwrite, you can do relation.create_with(nil), or for a specific attribute, relation.create_with(:attr => nil).
* Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵Jon Leighton2011-01-033-14/+12
| | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
* Fix test_any in relations_test.rb, which was failing when relations_test.rb ↵Jon Leighton2011-01-031-0/+8
| | | | is run on its own (it passes when the entire suite is run). This is a hacky fix for a problem I didn't quite get to the bottom of, so I'd welcome a better solution...
* Allow assignment on has_one :through where the owner is a new record [#5137 ↵Jon Leighton2011-01-035-23/+60
| | | | | | | | | | state:resolved] This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct. Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to *does* change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things. Phew, long commit message!
* Have a proper AssociationReflection#foreign_type method rather than using ↵Jon Leighton2011-01-031-0/+6
| | | | options[:foreign_type]
* Some basic tests for the :foreign_type option on belongs_to, which was ↵Jon Leighton2011-01-032-1/+31
| | | | previously completely untested.
* herp derpricating add_limit_offset!Aaron Patterson2011-01-031-12/+0
|
* Added one more failing test for bug #6036Robert Pankowecki (Gavdi)2011-01-041-0/+6
|
* Rename AssociationReflection#primary_key_name to foreign_key, since the ↵Jon Leighton2010-12-311-3/+5
| | | | options key which it relates to is :foreign_key
* Support for :counter_cache on polymorphic belongs_toJon Leighton2010-12-311-0/+12
|
* Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵Jon Leighton2010-12-311-6/+36
| | | | inherit from it
* Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵Jon Leighton2010-12-311-0/+7
| | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query.
* Verify that when has_many associated objects are destroyed via :dependent => ↵Jon Leighton2010-12-311-0/+9
| | | | :destroy, when the parent is destroyed, the callbacks are run
* Refactor configure_dependency_for_has_many to use ↵Jon Leighton2010-12-311-3/+4
| | | | AssociationCollection#delete_all. It was necessary to change test_before_destroy in lifecycle_test.rb so that it checks topic.replies.size *before* doing the destroy, as afterwards it will now (correctly) be 0.
* Make serialized fixtures work againPratik Naik2010-12-293-4/+9
|
* Allow primary_key to be an attribute when the model is a new recordSantiago Pastorino2010-12-281-1/+1
|
* stop calling deprecated apisAaron Patterson2010-12-262-5/+5
|
* Fix dodgy tests which were effectively asserting nil == nilJon Leighton2010-12-261-3/+3
|
* using arel to compile sql statementsAaron Patterson2010-12-251-1/+1
|
* take more advantage of arel sql compilerAaron Patterson2010-12-251-1/+1
|
* stop redifining methods on every call to set_primary_keyAaron Patterson2010-12-242-4/+12
|
* Verify that there is no unwanted implicit readonly set on ↵oleg dashevskii2010-12-231-1/+13
| | | | Model.has_many_through.find(id) [#5442 state:resolved]
* Raise an error for associations which try to go :through a polymorphic ↵Jon Leighton2010-12-231-3/+8
| | | | association [#6212 state:resolved]
* If a has_many goes :through a belongs_to, and the foreign key of the ↵Jon Leighton2010-12-233-23/+68
| | | | belongs_to changes, then the has_many should be considered stale.
* Improved strategy for updating a belongs_to association when the foreign key ↵Jon Leighton2010-12-232-2/+5
| | | | changes. Rather than resetting each affected association when the foreign key changes, we should lazily check for 'staleness' (where fk does not match target id) when the association is accessed.
* Test to verify that #2189 (count with has_many :through and a named_scope) ↵Jon Leighton2010-12-231-0/+5
| | | | is fixed
* Revert "Optimize <association>_ids for hm:t with belongs_to source". The ↵Jon Leighton2010-12-231-6/+2
| | | | | | | | | | optimisation has too many edge cases, such as when the reflection, source reflection, or through reflection has conditions, orders, etc. [#6153 state:resolved] This reverts commit 373b053dc8b99dac1abc3879a17a2bf8c30302b5. Conflicts: activerecord/lib/active_record/associations.rb
* Test demonstrating problem with foo.association_ids where it's a has_many ↵Jon Leighton2010-12-231-0/+4
| | | | :through with :conditions, with a belongs_to as the source reflection
* When a has_many association is not :uniq, appending the same record multiple ↵Jon Leighton2010-12-231-0/+10
| | | | times should append it to the @target multiple times [#5964 state:resolved]
* Fix behaviour of foo.has_many_through_association.select('custom select') ↵Michał Łomnicki2010-12-231-0/+5
| | | | [#6089 state:resolved]
* Fix creation of has_many through records with custom primary_key option on ↵Szymon Nowak2010-12-231-1/+29
| | | | belongs_to [#2990 state:resolved]
* Verify that has_one :through preload respects the :conditions [#2976 ↵Will Bryant2010-12-231-0/+12
| | | | state:resolved]
* Don't allow a has_one association to go :through a collection association ↵Jon Leighton2010-12-231-5/+7
| | | | [#2976 state:resolved]
* Fix for default_scope tests to ensure comparing of equally sorted listsRaimonds Simanovskis2010-12-232-2/+2
| | | | | | This is additional fix for commit ebc47465a5865ab91dc7d058d2d8a0cc961510d7 Respect the default_scope on a join model when reading a through association which otherwise was failing on Oracle (as it returned fixture comments in different order).
* removing SQL interpolation, please use scoping and attribute conditionals as ↵Aaron Patterson2010-12-221-4/+0
| | | | a replacement
* define_attr_method must serialize nil correctlyAaron Patterson2010-12-203-0/+14
|
* if there is no base name, we cannot determine a primary keyAaron Patterson2010-12-201-0/+2
|
* has_many associations with :dependent => :delete_all should update the ↵Jon Leighton2010-12-201-0/+12
| | | | counter cache when deleting records
* Fix problem where wrong keys are used in JoinAssociation when an association ↵Jon Leighton2010-12-202-0/+12
| | | | goes :through a belongs_to [#2801 state:resolved]
* ActiveRecord::Base.joins should allow single nil argument [#6181 state:resolved]Piotr Sarnacki2010-12-161-0/+4
|
* Fix various issues with the :primary_key option in :through associations ↵Jon Leighton2010-12-152-0/+21
| | | | [#2421 state:resolved]
* Fix problem with duplicated records when a :uniq :through association is ↵Jon Leighton2010-12-152-2/+15
| | | | preloaded [#2447 state:resolved]
* Replace rudimentary named_scope with scope. [#6052 state:resolved]Pavel Gorbokon2010-12-153-25/+25
| | | | | | | * rename method names (actually in tests) * rename instance variable @_named_scopes_cache to @_scopes_cache * rename references in doc comments * don't touch CHANGELOG :)
* Provide test for #4840: to_xml doesn't work in such case: ↵Franck Verrot2010-12-151-0/+6
| | | | Event.select('title as t').to_xml
* test for eager load of has_one association with condition on the through tablePivotal Labs2010-12-161-1/+9
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 08:31:14 +0000