| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
jetthoughts/11288_remove_extra_queries_for_belongs_to_with_touch
#11288: Removed duplicated touching
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| |
| |
| |
| |
| | |
if belongs to model with touch option on touch
Closes #11288
|
| |/
|
|
|
|
|
|
|
|
| |
arunagw/disable_implicit_join_references_removed"
`disable_implicit_join_references=` was only deprecated on `master`,
not with rails 4.0. We can remove it after 4.1
This reverts commit 3c719ead414ffd29e71efce185698af979052abb, reversing
changes made to d5c3bf9722abd5733a769c8d789de3f74dbfb92d.
|
| |
|
|
| |
simplified logic to calculate number of queries by using assert_queries
|
| | |
|
| | |
|
| |
|
|
| |
Removed tests from deprecated code.
|
| |
|
|
|
| |
in favor of `begin_transaction`
with `:joinable` option.
|
| | |
|
| |\
| |
| | |
Remove deprecated SchemaStatements#distinct
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| |
|
|
| |
/cc @tenderlove
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The comment in the test pretty much summarizes the issue.
`FIXME these assertions bust a lot`
Adding any type of association in class `Firm` will break this test.
I removed some deprecated stuff and this test failed.
I do not think this test provides any useful value. First of all who
counted last that 39 is the right number of associations.
Secondly there are a large number of tests which depend on reflection
returning right information about associations. Those tests will start
failing if there is a bug in the code.
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
neerajdotname/delete_all_should_not_call_callbacks
Do not invoke callbacks when delete_all is called
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Method `delete_all` should not be invoking callbacks and this
feature was deprecated in Rails 4.0. This is being removed.
`delete_all` will continue to honor the `:dependent` option. However
if `:dependent` value is `:destroy` then the default deletion
strategy for that collection will be applied.
User can also force a deletion strategy by passing parameter to
`delete_all`. For example you can do `@post.comments.delete_all(:nullify)`
|
| | |
| |
| |
| | |
Calling default_scope without a proc will now raise `ArgumentError`.
|
| | |
| |
| |
| |
| | |
Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql`
have been deleted.
|
| | | |
|
| | | |
|
| |/
|
|
|
| |
Removed deprecated methods `partial_updates`, `partial_updates?` and
`partial_updates=`
|
| | |
|
| |\
| |
| |
| |
| | |
ActiveRecord find_in_batches should work without logger
When I set logger to nil both methods from Batches module find_in_batches or find_each should work anyway.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previous implementation was necessary in order to support stuff
like:
class Post < ActiveRecord::Base
default_scope where(published: true)
scope :ordered, order("created_at")
end
If we didn't evaluate the default scope at the last possible moment
before sending the SQL to the database, it would become impossible to
do:
Post.unscoped.ordered
This is because the default scope would already be bound up in the
"ordered" scope, and therefore wouldn't be removed by the
"Post.unscoped" part.
In 4.0, we have deprecated all "eager" forms of scopes. So now you must
write:
class Post < ActiveRecord::Base
default_scope { where(published: true) }
scope :ordered, -> { order("created_at") }
end
This prevents the default scope getting bound up inside the "ordered"
scope, which means we can now have a simpler/better/more natural
implementation of default scoping.
A knock on effect is that some things that didn't work properly now do.
For example it was previously impossible to use #except to remove a part
of the default scope, since the default scope was evaluated after the
call to #except.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For example:
class Post < ActiveRecord::Base
default_scope -> { where published: true }
end
class Comment
belongs_to :post
end
When calling `Comment.join(:post)`, we expect to receive only
comments on published posts, since that is the default scope for
posts.
Before this change, the default scope from `Post` was not applied,
so we'd get comments on unpublished posts.
|
| | |
| |
| |
| |
| | |
Oops. We need to estalish/remove the connection in the setup/teardown,
else it messes with the fixtures.
|
| | |
| |
| |
| | |
Clearly nobody uses this except me. It's fast people!
|
| | |
| |
| |
| | |
They were deprecated in 4.0, planned to remove in 4.1
|
| |\ \
| | |
| | |
| | |
| | | |
tkhr/add_test_for_AR__CounterCache#update_counters
Add test for AR::CounterCache.update_counters
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Remove Oracle / Sqlserver / Firebird database tasks were deprecated since 4.0.
|
| | | | |
| | | |
| | | |
| | | | |
3rd-party.
|
| | | | |
| | | |
| | | |
| | | | |
3rd-party.
|
| | | | |
| | | |
| | | |
| | | | |
3rd-party.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
When .find_each is called without a block, return an Enumerator.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
This lets us do things like call: .find_each.with_index
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Change Result#each to return an Enumerator when called without a block.
|
| | |/ / / /
| | | | |
| | | | |
| | | | | |
As with #10992, this lets us call #with_index, etc on the results.
|
| | | | | | |
|
| | | | | | |
|
