| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactoring revealed the need for another form of decoration, which
takes a proc to select which it applies to (There's a *lot* of cases
where this form can be used). To avoid duplication, we can re-implement
the old decoration in terms of the proc-based decoration.
The reason we're `instance_exec`ing the matcher is for cases such as
time zone aware attributes, where a decorator is defined in a parent
class, and a method called in the matcher is overridden by a child
class. The matcher will close over the parent, and evaluate in its
context, which is not the behavior we want.
|
|\
| |
| | |
Skip migration check if adapter doesn't support it
|
| | |
|
|\ \
| | |
| | | |
[ci skip] /mysql/i -> MySQL, Spell correct in continuation to #15555
|
| | | |
|
|/ /
| |
| |
| |
| | |
We've stopped using it internally, in favor of polymorphism. So should
you!
|
| |
| |
| |
| | |
Fixes #15705.
|
|\ \
| | |
| | | |
prevent bad automatic inverse_of association
|
| | |
| | |
| | |
| | | |
reflecting on wrong association
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
member = Member.new(club: Club.new)
member.save!
Before:
member.current_membership.club_id # => nil
After:
member.current_membership.club_id # => club's id
|
|\ \ \
| | | |
| | | | |
Detect in-place changes on mutable AR attributes
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We have several mutable types on Active Record now. (Serialized, JSON,
HStore). We need to be able to detect if these have been modified in
place.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We don't generally modify our classes at runtime like this. Let's create
the instance after the class is created. Original commit doesn't imply
that this was intentional behavior.
|
|\ \ \ \
| | | | |
| | | | | |
Ensure we always define attribute methods
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Introduce an Attribute object to handle the type casting dance
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There's a lot more that can be moved to these, but this felt like a good
place to introduce the object. Plans are:
- Remove all knowledge of type casting from the columns, beyond a
reference to the cast_type
- Move type_cast_for_database to these objects
- Potentially make them mutable, introduce a state machine, and have
dirty checking handled here as well
- Move `attribute`, `decorate_attribute`, and anything else that
modifies types to mess with this object, not the columns hash
- Introduce a collection object to manage these, reduce allocations, and
not require serializing the types
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We guarantee that `model.value` does not change after
`model.save && model.reload`. This requires type casting user input for
non-string types.
|
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Topics call `serialize :content`, which means that the values in the
database should be YAML encoded, and we would only expect to receive
YAML strings to `update_column` and `update_columns`.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The column name given by the adapter doesn't include the table
namespace, so going through the hashed version of the result set causes
overridden keys.
Fixes #15649
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The original patch that added this concept can be found
[here](https://web.archive.org/web/20090601022739/http://dev.rubyonrails.org/ticket/9767).
The current default behavior is to cache everything except serialized
columns, unless the user specified otherwise. If anyone were to specify
otherwise, many types would actually be completely broken. Still, the
method is left in place with a deprecation warning in case anyone is
actually still calling this method.
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix warnings in tests
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
```
activerecord/test/cases/adapters/postgresql/range_test.rb:159: warning: (...) interpreted as grouped expression
activerecord/test/cases/finder_test.rb:38: warning: shadowing outer local variable - e
activerecord/test/cases/finder_test.rb:43: warning: shadowing outer local variable - e
```
|
|/ / /
| | |
| | |
| | |
| | | |
On MySQL and PostgreSQL, the adapter does not type cast virtual columns
for us.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit dd3ea17191e316aeebddaa7b176f6cfeee7a6365 and add a
regression test.
Fixes #15418
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In some cases there is a difference between the two, we should always
be doing one or the other. For convenience, `type_cast` is still a
private method on type, so new types that do not need different behavior
don't need to implement two methods, but it has been moved to private so
it cannot be used accidentally.
|
|\ \ \
| | | |
| | | | |
Remove workaround for non-lazy serialize in tests
|
| | | |
| | | |
| | | |
| | | | |
`serialize` is now lazy, so the workaround is no longer needed.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- The following is now true for all types, all the time
- `model.attribute_before_type_cast == given_value`
- `model.attribute == model.save_and_reload.attribute`
- `model.attribute == model.dup.attribute`
- `model.attribute == YAML.load(YAML.dump(model)).attribute`
- Removes the remaining types implementing `type_cast_for_write`
- Simplifies the implementation of time zone aware attributes
- Brings tz aware attributes closer to being implemented as an attribute
decorator
- Adds additional point of control for custom types
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rename `property` to `attribute`
Conflicts:
activerecord/lib/active_record/attribute_methods/serialization.rb
activerecord/lib/active_record/base.rb
|
| | | |
| | | |
| | | |
| | | | |
For consistency with https://github.com/rails/rails/pull/15557
|
|\ \ \ \
| | | | |
| | | | | |
Don't query the database schema when calling `serialize`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We need to decorate the types lazily. This is extracted to a separate
API, as there are other refactorings that will be able to make use of
it, and to allow unit testing the finer points more granularly.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The times would be equivalent, even if they were in different time
zones. E.g. 12:00 UTC == 5:00 PDT
|
| |/ / /
|/| | |
| | | |
| | | | |
Millisecond inequality causes failures on Travis
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Add missing test cases for schema dumping defaults
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Before this patch, using `ActiveRecord::Base.primary_key_prefix_type`
with `:table_name_with_underscore` would change the `SchemaMigration` model
to have a primary key. This resulted in broken queries for PG because it tried
to return the inserted PK (which does not exist).
Closes #15051.
Closes #15419.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
/cc @zuhao
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
This adds a regression test for #14411, which was fixed by #15503.
Closes #14411
Closes #14595
|
|\ \ \
| | | |
| | | | |
Bring type casting behavior of hstore/json in line with serialized
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`@raw_attributes` should not contain the type-cast, mutable version of
the value.
|