aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #12137 from lann/fix_association_first_lastRafael Mendonça França2013-09-121-3/+5
|\ | | | | | | | | | | | | Make CollectionAssociation first/last with integer fetch with query Conflicts: activerecord/CHANGELOG.md
| * Make CollectionAssociation first/last with integer fetch with queryLann Martin2013-09-091-3/+5
| | | | | | | | | | | | | | | | | | | | | | When first or last is called with an integer on an unloaded association, the entire collection is loaded. This differs surprisingly from the behavior of Relation#first/last, which translate the call into a limit query. For large collections this can make a big difference in performance. Change CollectionAssociation#fetch_first_or_last_using_find? to make this kind of call delegate to Relation.
* | Merge pull request #12156 from rywall/from-copy-bindsRafael Mendonça França2013-09-121-0/+7
|\ \ | | | | | | | | | | | | | | | | | | Allow Relation#from to accept other relations with bind values. Conflicts: activerecord/CHANGELOG.md
| * | Allow Relation#from to accept other relations with bind values.Ryan Wallace2013-09-081-0/+7
| | |
* | | Remove unnecessary loopVipul A M2013-09-131-5/+2
| | |
* | | these are not real developer objects, so counting them doesn't makeAaron Patterson2013-09-111-1/+1
| | | | | | | | | | | | | | | sense. Let's load the object to ensure it's an array and count the array.
* | | Check if the SQL is not a prepared statementRafael Mendonça França2013-09-111-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023
* | | Merge pull request #12188 from SamSaffron/masterAaron Patterson2013-09-111-1/+1
|\ \ \ | | | | | | | | Perf: avoid dupes add fallback logic for coders
| * | | Perf: avoid dupes add fallback logic for codersSam2013-09-111-1/+1
| | | |
* | | | Merge pull request #12135 from dylanahsmith/avoid_empty_transactionRafael Mendonça França2013-09-111-0/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid empty transaction from setting has_one association on new record. Conflicts: activerecord/CHANGELOG.md
| * | | | Avoid empty transaction from setting has_one association on new record.Dylan Thacker-Smith2013-09-111-0/+2
| | | | |
* | | | | Merge pull request #12194 from thedarkone/readonly-merger-fixRafael Mendonça França2013-09-111-0/+8
|\ \ \ \ \ | | | | | | | | | | | | Relation#merge should not lose readonly(false) flag.
| * | | | | Relation#merge should not lose readonly(false) flag.thedarkone2013-09-111-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | The original code ignores the `false` value because `false.blank? # => true`.
* | | | | | fix deleting join models with no pkAaron Patterson2013-09-111-5/+47
| |/ / / / |/| | | |
* | | | | add a comment for sanity of other people to comeAaron Patterson2013-09-101-0/+8
|/ / / /
* | | | make @bitsweat happy. :heart:Aaron Patterson2013-09-091-0/+6
| | | |
* | | | stop using deprecated api in the testsAaron Patterson2013-09-091-1/+1
| | | |
* | | | Fix fixtures regression that required table names to map to classes only, ↵Jeremy Kemper2013-09-081-1/+1
| |/ / |/| | | | | | | | not class names
* | | hm:t join tables may not have a primary keyAaron Patterson2013-09-061-0/+18
| | |
* | | auto link hm:t fixture join tables like habtmAaron Patterson2013-09-061-0/+35
| | |
* | | Add a test case for exists? with multiple valuesRafael Mendonça França + Kassio Borges2013-09-041-0/+1
| |/ |/|
* | Merge pull request #11958 from jetthoughts/extract_pre_process_orders_argsYves Senn2013-09-043-2/+32
|\ \ | | | | | | Re-use order arguments pre-processing for reorder
| * | Extracted from `order` processing of arguments, and use it for `reorder` to ↵Paul Nikitochkin2013-09-043-2/+32
| | | | | | | | | | | | be consistent.
* | | adding a hm:t test for singleton ar objectsAaron Patterson2013-09-031-0/+27
| | |
* | | support anonymous classes on has_many associationsAaron Patterson2013-09-031-0/+18
| | |
* | | clear all connections before forkingAaron Patterson2013-08-311-0/+3
| | |
* | | Revert "Do not dup the binds when visiting the AST"Rafael Mendonça França + Kassio Borges2013-08-311-8/+0
| | | | | | | | | | | | | | | | | | This reverts commit 71ff7d9c6592b93e2c810a1f464943dd7bd02c7f. Reason: I need to check with @jeremy if we can do this.
* | | Don't need to check if the scope respond to callRafael Mendonça França + Kassio Borges2013-08-312-2/+2
| | | | | | | | | | | | | | | We are checking this when defining the default scope and raising an ArgumentError
* | | Revert "reconnect after the fork returns"Rafael Mendonça França2013-08-311-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit baf5f47b8768c7ec0164ed5ab60e369cdd936d71. Reason: This is breaking the sqlite3 tests with a missing transacion. Could not investigate right now. cc @tenderlove
* | | Do not dup the binds when visiting the ASTRafael Mendonça França2013-08-311-0/+8
| | | | | | | | | | | | | | | | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023
* | | reconnect after the fork returnsAaron Patterson2013-08-301-0/+2
| | |
* | | remove unused variableAaron Patterson2013-08-301-1/+1
| | |
* | | move the cache to the AR models and populate it on inheritedAaron Patterson2013-08-301-4/+19
| | |
* | | add a failing test for marshal + cache problemsAaron Patterson2013-08-301-0/+26
| | |
* | | add missing fixtures fileAaron Patterson2013-08-301-1/+2
| | |
* | | make sure there are actually some categories when running the testAaron Patterson2013-08-291-0/+1
| | |
* | | pk should not be required for hm:t associationsAaron Patterson2013-08-291-0/+7
| | |
* | | Merge pull request #12051 from bcherry/preserve_datetime_millisecondsAndrew White2013-08-281-0/+5
|\ \ \ | |/ / |/| | ActiveRecord: Include usecs when quoting DateTime in PostgreSQL adapter
| * | Test that PostgreSQL adapter includes `usec` when quoting `DateTime`Ben Cherry2013-08-281-0/+5
| | |
* | | query the association rather than send the method for the association nameAaron Patterson2013-08-271-6/+4
|/ /
* / check class hierarchy with is_a? in PredicateBuilder.expandMikhail Dieterle2013-08-271-0/+25
|/ | | | add changelog entry for #11945
* Add config to method calls in fixtures.wangjohn2013-08-261-1/+1
| | | | | | | Allows you to change your configuration for calls to `table_name_prefix`, `table_name_suffix`, and `pluralize_table_names`. The default configuration is still ActiveRecord::Base, but you are now able to change the configuration easily.
* PG adapter deals with negative money values formatted with parenthesis.Yves Senn2013-08-261-0/+8
| | | | Closes #11899.
* Removing instances of string class_names in fixtures.wangjohn2013-08-241-7/+7
| | | | | | | Also, constantizing the default_fixture_model_name when it gets loaded in from the file. Later, when the class_name is passed to a new FixtureSet, a deprecation warning will occur if the class_name is a string.
* Adding deprecation assertions for proper_table_name.wangjohn2013-08-241-7/+21
| | | | This prevents deprecation warnings from popping up.
* Making proper_table_name take in options.wangjohn2013-08-221-1/+28
| | | | | | | | | | | The options will specify the prefix and the suffix. Also, I'm moving the method to be an instance method on the +Migration+ instance. This makes more sense than being a class method on the +Migrator+ class because the only place that uses it is on a +Migration+ instance (in a method_missing hook). The logic for the Migrator shouldn't be doing any work to calculate the table name, it should be the Migration itself. Also made some small indentation fixes.
* Avoid compiling regexs in AR::Base.respond_to?John Hawthorn2013-08-211-0/+5
| | | | | Caches the patterns of ActiveRecord::DynamicMatchers in a class instance variable.
* Merge pull request #11922 from Empact/string-confusionYves Senn2013-08-201-1/+1
|\ | | | | Stop interpreting SQL 'string' columns as :string type.
| * Stop interpreting SQL 'string' columns as :string type.Ben Woosley2013-08-171-1/+1
| | | | | | | | | | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html
* | let AR::FinderMethods#exists? return singletons in all cases [closes #11592]Xavier Noria2013-08-191-27/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression. The documentation said in its introduction paragraph that the method returns truthy/falsy, but then below it was said that if there were no arguments you'd get `true` or `false`. Also when the argument is exactly `false` a singleton is documented to be returned. The method was not returning the singletons so it didn't conform to those special cases. The best solution here seems to be to just return singletons in all cases. This solution is backwards compatible. Also, the contract has been revised because it has no sense that the predicate varies that way depending on the input. I bet the previous contract was just an accident, not something mixed on purpose. Conflicts: activerecord/lib/active_record/relation/finder_methods.rb activerecord/test/cases/finder_test.rb
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-21 01:54:59 +0000