Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Add first/last methods to associations/named_scope. [#226 state:resolved] | Ryan Bates | 2008-05-20 | 5 | -2/+100 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Ensure add_column gives valid error for sqlite. [Gunnar Wolf, Pratik] [#197 ↵ | Pratik Naik | 2008-05-20 | 1 | -0/+26 | |
| | | | | | | | | state:resolved] SQLite#add_column executes "VACUUM", which fails if inside a live transaction. This patch ensures a valid exception is raised if add_column is executed within a live transaction for sqlite adapter. | |||||
* | Don't rely on association proxying object_id. [#225 state:resolved] | Jeremy Kemper | 2008-05-19 | 1 | -2/+2 | |
| | ||||||
* | Fixing test for named_scope through a has_many :through | Rodrigo Kochenburger | 2008-05-15 | 1 | -2/+2 | |
| | | | | | The test that checks if a has_many :through association has access to named_scope had a typo and didn't have the proper fixtures loaded. [#190 state:resolved] | |||||
* | DRY associations code and improve eager loading tests. | Pratik Naik | 2008-05-15 | 1 | -1/+4 | |
| | ||||||
* | Make sure needed table joins are included :select option. [#110 state:resolved] | John Devine | 2008-05-15 | 1 | -3/+6 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Add ActiveRecord option to store the full class name on STI's type column, ↵ | Rodrigo Kochenburger | 2008-05-13 | 1 | -0/+28 | |
| | | | | | | allowing one to have STI subclasses in different namespaces [#114] Signed-off-by: rick <technoweenie@gmail.com> | |||||
* | Fix tests broken by mocha absence [#186 state:resolved] | Tim Pope | 2008-05-13 | 1 | -9/+11 | |
| | | | | | | | Two ActiveRecord tests depended on mocha but were not marked as such. Place them in a use_mocha block so the test suite passes. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Dirty attributes aren't cleared if save fails. [#174 state:resolved] | Xavier Noria | 2008-05-12 | 1 | -1/+20 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | When preloading group by reflection rather than by class [#125 state:resolved] | Frederick Cheung | 2008-05-11 | 1 | -0/+6 | |
| | | | | | | | | This avoids extra queries when several subclasses inherit the association from their parent class, while still coping with subclasses redefining associations. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Fix blank conditions on AssociationCollection#find. [#104 state:resolved] | Jonathan Viney | 2008-05-11 | 1 | -1/+7 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Add test for named_scope#proxy_options. [#97 state:resolved] | Duncan Beevers | 2008-05-11 | 1 | -0/+6 | |
| | ||||||
* | Ensure hm:t preloading honours reflection options. [#137 state:resolved] | Frederick Cheung | 2008-05-11 | 1 | -0/+11 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Added protection against duplicate migration names (Aslak Hellesøy) [#112 ↵ | Aslak Hellesøy | 2008-05-11 | 1 | -0/+6 | |
| | | | | state:resolved] | |||||
* | Fix validates_uniqueness_of for SQL keywords [#23 state:resolved] | Alex MacCaw | 2008-05-11 | 1 | -0/+8 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | ActiveRecord time zone aware attributes: blank string is treated as nil when ↵ | gbuesing | 2008-05-08 | 1 | -0/+8 | |
| | | | | assigned to writer | |||||
* | Fix Time.zone.parse from stripping time zone information and make Time aware ↵ | Scott Fleckenstein | 2008-05-08 | 1 | -0/+27 | |
| | | | | attribute methods use Time.zone.parse instead of to_time | |||||
* | Calling ActiveRecord#inspect on an unloaded association won't wipe the ↵ | Andreas Neuhaus | 2008-05-08 | 1 | -0/+6 | |
| | | | | | | collection [#9 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | create_table :force => true no longer tries to drop a non-existing table | Tarmo Tänav | 2008-05-07 | 1 | -0/+18 | |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Added AbstractAdapter#table_exists? and made AbstractAdapter#table ↵ | Tarmo Tänav | 2008-05-07 | 2 | -116/+114 | |
| | | | | | | implementation non-optional Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Added logic to associations.rb to make sure select_for_limited_ids | John Devine | 2008-05-06 | 1 | -0/+9 | |
| | | | | | | | | | includes joins that are needed to reach tables listed in the :order or :conditions options if they are not joined directly to the main active_record table. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#109 state:resolved] | |||||
* | Ensure correct record is returned when preloading has_one where more than ↵ | Frederick Cheung | 2008-05-06 | 1 | -0/+4 | |
| | | | | | | | one row exists Signed-off-by: Michael Koziarski <michael@koziarski.com> [#73 state:closed] | |||||
* | Added change_table for migrations (Jeff Dean) [#71 state:resolved] | David Heinemeier Hansson | 2008-05-03 | 1 | -1/+207 | |
| | ||||||
* | Fix failing associate_with_create tests inserting null first_name | Jeremy Kemper | 2008-05-01 | 1 | -3/+3 | |
| | ||||||
* | Merge branch 'master' of git@github.com:rails/rails | David Heinemeier Hansson | 2008-05-01 | 4 | -1/+63 | |
|\ | ||||||
| * | Fixed AssociationsPreload such that it doesnt require foreign keys to be ↵ | David Heinemeier Hansson | 2008-04-30 | 1 | -1/+22 | |
| | | | | | | | | integers (fcheung) [#33 state:resolved] | |||||
| * | Added block-setting of attributes for Base.create like Base.new already has ↵ | David Heinemeier Hansson | 2008-04-30 | 2 | -0/+37 | |
| | | | | | | | | (Adam Meehan) [#39 state:resolved] | |||||
| * | Fixed fixture caching with prefixed or suffixed tables. | Rhett Sutphin | 2008-04-30 | 1 | -0/+4 | |
| | | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | | best solution? | Steven Soroka | 2008-05-01 | 1 | -0/+12 | |
|/ | | | | Signed-off-by: Steven Soroka <ssoroka78@gmail.com> | |||||
* | Fixed that pessimistic locking you reference the quoted table name (Josh ↵ | David Heinemeier Hansson | 2008-04-30 | 1 | -1/+8 | |
| | | | | Susser) [#67 state:resolved] | |||||
* | Change tests against all scope to base scope as all is now used as a finder ↵ | David Heinemeier Hansson | 2008-04-30 | 1 | -14/+14 | |
| | | | | alias | |||||
* | Let Base.all use conditions etc like first/last | David Heinemeier Hansson | 2008-04-28 | 1 | -0/+4 | |
| | ||||||
* | Ensure table names are quoted by the association preloading code. | Frederick Cheung | 2008-04-26 | 1 | -1/+27 | |
| | | | | | | [#45 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Fixes a subtle bug when using symbols for key definitions in habtm associations | David Dollar | 2008-04-23 | 1 | -0/+29 | |
| | ||||||
* | Fix include? on has_many collections with finder_sql to fall back to Array ↵ | Joshua Bates | 2008-04-23 | 1 | -0/+11 | |
| | | | | | | include? rather than try to use SQL. [#18 state:resolved] | |||||
* | Provide data for the key column otherwise adding a unique index will fail. ↵ | Frederick Cheung | 2008-04-23 | 1 | -0/+1 | |
| | | | | [#30 state:closed] | |||||
* | Use schema.rb for all databases | Frederick Cheung | 2008-04-22 | 4 | -54/+10 | |
| | | | | | | Move adapter specific schema into their own files Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Use define_callbacks helper for ActiveRecord validations. | Joshua Peek | 2008-04-20 | 1 | -9/+9 | |
| | ||||||
* | Fix migrations when migrating to a specified version number with a fresh ↵ | Ian White | 2008-04-17 | 1 | -1/+8 | |
| | | | | | | database [#1 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Revert "Ensure that save on child object fails for invalid belongs_to ↵ | Michael Koziarski | 2008-04-11 | 1 | -12/+0 | |
| | | | | | | association. Closes #11555. [rubyruy]" This reverts commit c67e985994362290308073ed2793dd8e7f2a76db. | |||||
* | Ensure that save on child object fails for invalid belongs_to association. ↵ | Pratik Naik | 2008-04-10 | 1 | -0/+12 | |
| | | | | | | Closes #11555. [rubyruy] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | Add support for interleaving migrations by storing which migrations have run ↵ | Rick Olson | 2008-04-09 | 3 | -14/+48 | |
| | | | | | | in the new schema_migrations table. Closes #11493 [jordi] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | ActiveRecord::Base#sum defaults to 0 if no rows are returned. Closes #11550 ↵ | Rick Olson | 2008-04-08 | 1 | -0/+4 | |
| | | | | | | [kamal] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | Improve ActiveRecord::Base#table_name unit tests for nested classes. Closes ↵ | Josh Peek | 2008-04-07 | 1 | -0/+5 | |
| | | | | | | #10289. [scott_willson] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | Ensure that respond_to? considers dynamic finder methods. Closes #11538. ↵ | Pratik Naik | 2008-04-06 | 2 | -11/+87 | |
| | | | | | | [floehopper] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | Split associations_test.rb into multiple files based on association type. ↵ | Pratik Naik | 2008-04-06 | 7 | -2382/+2445 | |
| | | | | | | [Pratik] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9233 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | Ensure that save on parent object fails for invalid has_one association. ↵ | Pratik Naik | 2008-04-06 | 1 | -0/+12 | |
| | | | | | | Closes #10518. [Pratik] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | Refactor HasManyThroughAssociation to inherit from HasManyAssociation. ↵ | Pratik Naik | 2008-04-06 | 2 | -8/+218 | |
| | | | | | | Association callbacks and <association>_ids= now work with hm:t. Closes #11516 [rubyruy] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | Ensure HABTM#create and HABTM#build do not load entire association. [Pratik] | Pratik Naik | 2008-04-05 | 1 | -13/+27 | |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | |||||
* | Make HABTM#create behave the same as << with after_add callbacks. Closes ↵ | Michael Koziarski | 2008-04-04 | 1 | -0/+15 | |
| | | | | | | #11374 [freels] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9224 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |