aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #9766 from senny/remove_ancient_todosCarlos Antonio da Silva2013-03-181-3/+0
|\ | | | | Remove ancient TODOs [ci skip]
| * remove ancient TODOs [ci skip].Yves Senn2013-03-181-3/+0
| |
* | move tests out from base_test.rbTakehiro Adachi2013-03-182-14/+14
|/ | | | | These tests should be in inheritance_test.rb since its testing a feature which is implemented in inheritance.rb
* `rake db:create` does not change permissions of root user.Yves Senn2013-03-171-2/+18
| | | | | | | | Closes #8079. I had to rework some of the tests because the mock allowed any arguments for `connection.exeucte`. I think this is very dangerous as there could anything be executed without the tests noticing it.
* sets limit 191 for schema_migrations#version in mysql2 if the encoding is ↵Xavier Noria2013-03-171-0/+26
| | | | | | "utf8mb4" Please, see rationale in the included CHANGELOG patch.
* Refactor Person/Friendship relationships to be more intuitiveMack Earnhardt2013-03-171-1/+1
| | | | | | | | PR #5210 added a Friendship model to illustrate a bug, but in doing so created a confusing structure because both belongs_to declarations in Friendship referred to the same side of the join. The new structure maintains the integrity of the bug test while changing the follower relationship to be more useful for other testing.
* If a counter_cache is defined, then using update_attributes and changingJohn Wang2013-03-151-0/+31
| | | | | the primary key on an association will make sure that the corresponding counter on the association is changed properly. Fixes #9722.
* Fix implicit join references option reversion in testCarlos Antonio da Silva2013-03-151-1/+2
|
* Merge pull request #9733 from ↵Jon Leighton2013-03-151-0/+9
|\ | | | | | | | | senny/9712_option_to_turn_references_deprecation_off make it possible to disable implicit join references.
| * make it possible to disable implicit join references.Yves Senn2013-03-151-0/+9
| | | | | | | | Closes #9712.
* | Cache the association proxy objectJon Leighton2013-03-151-0/+5
|/ | | | | | | | This reimplements the behaviour of Rails 3, as I couldn't see why we shouldn't cache the object, and @alindeman had a good use case for caching it: https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
* Merge pull request #9683 from senny/deprecate_count_distinct_optionJon Leighton2013-03-1510-18/+51
|\ | | | | rename `Relation#uniq` to `Relation#distinct`
| * Deprecate the `:distinct` option for `Relation#count`.Yves Senn2013-03-155-11/+21
| | | | | | | | | | | | | | We moved more and more away from passing options to finder / calculation methods. The `:distinct` option in `#count` was one of the remaining places. Since we can now combine `Relation#distinct` with `Relation#count` the option is no longer necessary and can be deprecated.
| * rename `Relation#uniq` to `Relation#distinct`. `#uniq` still works.Yves Senn2013-03-158-7/+30
| | | | | | | | | | | | | | | | The similarity of `Relation#uniq` to `Array#uniq` is confusing. Since our Relation API is close to SQL terms I renamed `#uniq` to `#distinct`. There is no deprecation. `#uniq` and `#uniq!` are aliases and will continue to work. I also updated the documentation to promote the use of `#distinct`.
* | Merge pull request #9686 from strzalek/cast_number_to_string_in_pgJon Leighton2013-03-151-0/+8
|\ \ | |/ |/| Cast number to string in Postgres
| * Cast number to string in PostgresŁukasz Strzałkowski2013-03-121-0/+8
| | | | | | | | fixes #9170
* | `#reset_counters` verifies counter names.Yves Senn2013-03-151-0/+7
| | | | | | | | | | | | | | Closes #9724. Raise an `ArgumentError` when the name of the counter does not match an association name.
* | hide more data in the schema cacheAaron Patterson2013-03-142-15/+12
| |
* | safely publish columns and columns hash infoAaron Patterson2013-03-141-9/+9
| |
* | you can provide uuid_generate_v4 as the default value for uuid columnsAaron Patterson2013-03-141-0/+43
| |
* | MOAR cleanups.Vipul A M2013-03-143-3/+2
|/
* Pass column to quote when copying a sqlite table.Matthew M. Boedicker2013-03-111-1/+5
| | | | To make quote escape binary data correctly it needs the column passed in.
* add an missing assertion to inheritance_test.rbTakehiro Adachi2013-03-111-0/+1
| | | | | | assertion for https://github.com/rails/rails/blob/ad624345e54bd20802de67b2b5c9ef29ecf5 d5f4/activerecord/lib/active_record/inheritance.rb#L32
* Address ActiveRecord::StatementInvalid: OCIError: ORA-00979Yasuo Honda2013-03-111-2/+2
|
* Change uniq validation with conditions examples to use where with hashesCarlos Antonio da Silva2013-03-091-2/+2
| | | | Take the opportunity to showcase where.not.
* Uniqueness validation uses a proc to specify the `:conditions` option.Yves Senn2013-03-091-1/+7
| | | | | This is a follow up to #5321 and follows the general direction in AR to make things lazy evaluated.
* Deprecate #connection in favour of accessing it via the classBen Moss2013-03-092-7/+6
| | | | | This allows end-users to have a `connection` method on their models without clashing with ActiveRecord internals.
* Preserve magic comments and content encoding of copied migrations.OZAWA Sakuro2013-03-091-0/+20
| | | | | During insertion of "# This migration comes from ... " comment at the beginning of a migration, presence of magic comment was not considered.
* Merge pull request #9497 from route/subclass_from_attrsRafael Mendonça França2013-03-081-0/+11
|\ | | | | | | | | | | | | Fix ActiveRecord `subclass_from_attrs` when eager_load is false. Conflicts: activerecord/CHANGELOG.md
| * Fix ActiveRecord `subclass_from_attrs` when eager_load is false.Dmitry Vorotilin2013-03-061-0/+11
| | | | | | | | | | It cannot find subclass because all classes are loaded automatically when it needs.
* | Refactored test case with standard variable namingAnupam Choudhury2013-03-081-40/+40
| |
* | Merge pull request #8868 from tehgeekmeister/masterRafael Mendonça França2013-03-081-0/+16
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Use the index name explicitly provided in a migration when reverting. Fixes #8868 Conflicts: activerecord/CHANGELOG.md
| * | If an index can't be found by column, use the index name.Ezekiel Smithburg2013-03-071-0/+16
| | | | | | | | | | | | schema_statements uses the column name by default to construct the index name, and then raises an exception if it doesn't exist, even if the name option is specified, which causes #8858. this commit makes index_name_for_remove fall back to constructing the index name to remove based on the name option.
* | | Merge pull request #8966 from ↵Rafael Mendonça França2013-03-081-0/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cfabianski/disable_prepared_statement_when_preparing_a_query Unprepared Visitor + unprepared_statement Conflicts: activerecord/CHANGELOG.md
| * | | Unprepared Visitor + unprepared_statementCédric FABIANSKI2013-03-081-0/+7
| |/ /
* | | Update test name to reflect change in how scopes merging worksCarlos Antonio da Silva2013-03-081-2/+2
| | | | | | | | | | | | | | | | | | | | | Introduced in f1082b8588a9144eedb34d511f0074031f692d98. Full changelog in 9f007d7fe5f90257c71baa2c4e7c76fb44512986. [ci skip]
* | | Combine scope conditions using ANDNeeraj Singh and John Leighton2013-03-071-3/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | | | Currently Post.active.inactive will result in Post.inactive since the last where clause wins when scopes are merged. This pull request will merge all scopes ( barring defaul scope) using AND. The default scope will be overridden if another scope acts on the same where clause. closes #7365
* | Merge pull request #9597 from senny/9110_serialized_not_null_defaultRafael Mendonça França2013-03-071-0/+7
|\ \ | | | | | | test case for `serialize` default values.
| * | test case for `serialize` default values.Yves Senn2013-03-071-0/+7
| | | | | | | | | | | | Closes #9110
* | | Merge pull request #9105 from bemurphy/cache_key_updated_onRafael Mendonça França2013-03-071-2/+20
|\ \ \ | |/ / |/| | | | | | | | | | | | | | cache_key consults updated_on timestamp if present Conflicts: activerecord/CHANGELOG.md
| * | cache_key consults updated_on timestamp if presentBrendon Murphy2013-02-261-2/+20
| | | | | | | | | | | | | | | - Extract max timestamp retrieval for cache_key - Update changelog for cache_key changes
* | | Merge pull request #9474 from HonoreDB/masterRafael Mendonça França2013-03-071-0/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | More helpful error message when instantiating an abstract class Conflicts: activerecord/CHANGELOG.md
| * | | More helpful error message when instantiating an abstract classAaron Weiner2013-03-031-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling a literal ActiveRecord::Base.new raises NoMethodError, since it ends up calling Class.abstract_class? which does not exist. Similarly, instantiating an actual abstract class hits the database, when conventionally it should immediately throw NotImplementedError. ActiveRecord::Base can't be made abstract without breaking many, many things, so check for it separately.
* | | | Refactored and removed unnecessary lines in the test caseAnupam Choudhury2013-03-071-3/+3
| | | |
* | | | Remove regression test added in 0268b5d8cdc3c5a1337462135f0a326a2654ba1aRafael Mendonça França2013-03-071-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | It was added because a regression caused by a712e08ebe21f6d8653a0e6602df2e0f5d40d9ca Closes #9255
* | | | rake db:structure:dump warns when `mysqldump` is not in PATH.Yves Senn2013-03-061-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9518. The rake task used to fail silently and left an empty `structure.sql`. It's confusing for users to get to the root of the problem. The warning message tells them where to look.
* | | | `Connection#structure_dump` is no longer used. #9518Yves Senn2013-03-063-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base.
* | | | Merge pull request #9507 from senny/9483_migrations_without_transactionsRafael Mendonça França2013-03-062-4/+40
|\ \ \ \ | |_|_|/ |/| | | Transactions can be turned off per Migration
| * | | transactions can be turned off per Migration.Yves Senn2013-03-052-1/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9483. There are SQL Queries that can't run inside a transaction. Since the Migrator used to wrap all Migrations inside a transaction there was no way to run these queries within a migration. This patch adds `self.disable_ddl_transaction!` to the migration to turn transactions off when necessary.
| * | | transactional migration test-case was broken.Yves Senn2013-03-051-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | The cleanup commit a85625d broke the test-case. The schema was no longer modified so there was no way to check that the rollback actually happened.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 23:14:24 +0000