Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Bump mocha requirement for Ruby 1.9 compat. Remove uses_mocha. | Jeremy Kemper | 2009-02-03 | 12 | -613/+570 | |
| | ||||||
* | Don't rely on the order in these tests | Michael Koziarski | 2009-02-01 | 1 | -2/+2 | |
| | ||||||
* | validate_length_of should use custom message if given when using in or within. | miloops | 2009-02-01 | 1 | -0/+13 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1057 state:committed] | |||||
* | Add support for nested object forms to ActiveRecord and the helpers in ↵ | Eloy Duran | 2009-02-01 | 4 | -1/+755 | |
| | | | | | | | | ActionPack Signed-Off-By: Michael Koziarski <michael@koziarski.com> [#1202 state:committed] | |||||
* | Sqlite adapter's copy_table incorrectly attempts to recreate a primary key ↵ | Jacob Dunphy | 2009-01-29 | 1 | -0/+11 | |
| | | | | | | | | | id (:id => true in the create_table) if an :id column is present, even if it isn't a primary_key. This fix sets :id => false if there is an :id column, but it's not the primary_key. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1766 state:committed] | |||||
* | Ensure whitespaces are stripped when merging string joins. [#1297 ↵ | Filip H.F. "FiXato" Slagter | 2009-01-28 | 1 | -0/+10 | |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Add array id support to Model.update_counters. [#1254 state:resolved] ↵ | Pratik Naik | 2009-01-28 | 1 | -0/+7 | |
| | | | | [Carlos Júnior] | |||||
* | Mysql#reconnect is set according to the 'reconnect' key in the connection spec. | Dov Murik | 2009-01-27 | 1 | -0/+26 | |
| | | | | | | | | | | | | The 'reconenct' boolean option is read from the connection specification and is used to set the reconnect attribute of Mysql. The default is false in order not to change existing application behaviour. Also, reconnect is set AFTER real_connect is called, so its value sticks (the mysql gem sets reconnect to false inside real_connect). Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1797 state:committed] | |||||
* | Make sure inner scope conditions get a preference over the outer ones | Pratik Naik | 2009-01-24 | 1 | -0/+20 | |
| | ||||||
* | Fix has_and_belongs_to_many_associations tests. #1738 | Pratik Naik | 2009-01-18 | 2 | -3/+3 | |
| | ||||||
* | Cache columns for has_and_belongs_to_many associations | lukeludwig | 2009-01-17 | 1 | -0/+11 | |
| | | | | | This avoids repeatedly calling SHOW COLUMNS when the association is queried [#1738 state:committed] | |||||
* | Fix dirty handling of nullable non-integer numeric columns [#1692 ↵ | Carlos Kozuszko | 2009-01-16 | 1 | -0/+24 | |
| | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
* | Make belongs_to :dependent => :destroy destroy self before associated ↵ | Ben VandenBos | 2009-01-16 | 1 | -1/+2 | |
| | | | | | | | | object [#1079 state:resolved] If foreign key constraints are in place then deleteing the associated object first will cause a foreign key violation Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
* | Fix the AR json serialization tests to comply with the earlier change to ↵ | Michael Koziarski | 2009-01-16 | 1 | -1/+1 | |
| | | | | quote keys correctly | |||||
* | Fixed broken after_save callback; was being called when before_create was ↵ | Michael Lovitt | 2009-01-16 | 1 | -3/+41 | |
| | | | | | | | canceled or before_update was canceled Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1735 state:committed] | |||||
* | Fixing bug on ActiveRecord::Dirty#field_changed? for nullable numeric ↵ | Carlos Kozuszko | 2009-01-16 | 1 | -1/+1 | |
| | | | | | | | columns, NULL gets stored in database for blank (i.e. '') values. Only integer columns were considered. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1692 state:committed] | |||||
* | Fix PostgreSQL unit test failures that only occur when using the old ↵ | Hongli Lai (Phusion) | 2009-01-13 | 1 | -2/+1 | |
| | | | | | | | | 'postgres' driver. [#1748 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Introduce transaction_joinable flag to mark that the fixtures transaction ↵ | Jeremy Kemper | 2009-01-10 | 1 | -4/+4 | |
| | | | | | | can't joined, a new savepoint is required even if :requires_new is not set. Use :requires_new option instead of :nest. Update changelog. [#383 state:committed] | |||||
* | Merge branch 'master' into savepoints | Jeremy Kemper | 2009-01-10 | 15 | -170/+482 | |
|\ | ||||||
| * | Merge commit 'fred/pullable' | Pratik Naik | 2008-12-30 | 2 | -0/+39 | |
| |\ | ||||||
| | * | Fix HasManyAssociation#create ignoring the :primary_key option [#1633 ↵ | Roman Shterenzon | 2008-12-27 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
| | * | Fix :include of has_one with :primary_key option | Frederick Cheung | 2008-12-26 | 1 | -0/+16 | |
| | | | ||||||
| | * | Fix :include of has_many associations with :primary_key option | Frederick Cheung | 2008-12-26 | 1 | -0/+17 | |
| | | | ||||||
| * | | Fix named scope tests for sqlite3 [#1667 state:resolved] | Mike Gunderloy | 2008-12-30 | 1 | -1/+1 | |
| | | | | | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | | Introduce dynamic scopes for ActiveRecord: you can now use class methods ↵ | Yaroslav Markin | 2008-12-28 | 1 | -0/+20 | |
| | | | | | | | | | | | | | | | | | | like scoped_by_user_name(user_name) and scoped_by_user_name_and_password(user_name, password) that will use the scoped method with attributes you supply. [#1648 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | |||||
| * | | ActiveRecord::Base#new_record? now returns false for existing records (was ↵ | Yaroslav Markin | 2008-12-27 | 1 | -0/+5 | |
| |/ | | | | | | | | | | | nil) [#1219 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | |||||
| * | Preload uses exclusive scope [#643 state:resolved] | Frederick Cheung | 2008-12-26 | 1 | -0/+15 | |
| | | | | | | | | | | | | | | | | | | With self referential associations, the scope for the the top level should not affect fetching of associations, for example when doing Person.male.find :all, :include => :friends we should load all of the friends for each male, not just the male friends. | |||||
| * | Association preloading no longer stops if it hits a nil object [#1630 ↵ | Pivotal Labs | 2008-12-26 | 1 | -0/+8 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
| * | Ensure of Model#create support custom updated_at and updated_on attributes ↵ | Luis Hurtado | 2008-12-22 | 1 | -0/+10 | |
| | | | | | | | | | | | | [#1612 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | Ensure Model#last doesn't affects order for another finders inside the same ↵ | Daniel Luz | 2008-12-21 | 1 | -0/+18 | |
| | | | | | | | | | | | | scope [#1499 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | Fix configure_dependency_for_has_many not quoting conditions properly [#1461 ↵ | Frederick Cheung | 2008-12-21 | 1 | -0/+13 | |
| | | | | | | | | state:resolved] | |||||
| * | Use explicit order to stop test failing randomly | Frederick Cheung | 2008-12-21 | 1 | -2/+2 | |
| | | ||||||
| * | Fix has many through not quoting table names [#1163 state:resolved] | Karthik Krishnan | 2008-12-20 | 1 | -0/+4 | |
| | | | | | | | | Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
| * | Add missing fixture to allow reload models test to run isolated [#1609 ↵ | Emilio Tagua | 2008-12-20 | 1 | -1/+3 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | Add repair_helper.rb file I forgot in previous commit 8a92cd | Pratik Naik | 2008-12-19 | 1 | -0/+50 | |
| | | ||||||
| * | Add a repair_helper to repair changes to the validations inside ↵ | Murray Steele | 2008-12-19 | 2 | -160/+195 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | validations_test.rb [#674 state:resolved] Many of the tests in validations_test would add a new validation to models. However, only Topic was being reset with a fairly aggressive clearing of all validations. None of the other models being used however were recieving the same treatment. Now we use repair_validations(Topic) for the whole test case because most test cases use Topic and then the block form of repair_validations(<other_models>) inside any tests that use other models. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | Fix preloading of has_one :through associations on belongs_to [#1507 ↵ | Matt Jones | 2008-12-18 | 1 | -1/+16 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
| * | Ensure :include checks joins when determining if it can preload [#528 ↵ | Frederick Cheung | 2008-12-18 | 1 | -0/+65 | |
| | | | | | | | | state:resolved] | |||||
| * | Add missing model files so tests can run isolated [#1506 state:resolved] | Emilio Tagua | 2008-12-18 | 1 | -0/+3 | |
| | | | | | | | | Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | |||||
| * | Fix preloading of belongs_to with null foreign key generating useless query ↵ | Frederick Cheung | 2008-12-18 | 1 | -1/+2 | |
| | | | | | | | | [#1027 state:resolved] | |||||
| * | Require mocha >= 0.9.3, older versions don't work anymore [#1579 state:resolved] | Hongli Lai (Phusion) | 2008-12-15 | 1 | -0/+1 | |
| | | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| * | Merge branch 'master' of git@github.com:rails/rails | Jeremy Kemper | 2008-12-10 | 1 | -0/+7 | |
| |\ | ||||||
| | * | Added a :camelize option to ActiveRecord and Hash to_xml serialization and ↵ | Bruce Krysiak | 2008-12-10 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | | | from_xml deserialization Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
| * | | Revert "Fix: counter_cache should decrement on deleting associated records." | Jeremy Kemper | 2008-12-10 | 2 | -34/+0 | |
| |/ | | | | | | | | | | | [#1196 state:open] This reverts commit 05f2183747c8e75c9e8bbaadb9573b4bdf41ecfc. | |||||
| * | Fix test names collision. | Emilio Tagua | 2008-12-10 | 1 | -4/+4 | |
| | | | | | | | | | | | | [#1549 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | Fix: counter_cache should decrement on deleting associated records. | Emilio Tagua | 2008-12-10 | 2 | -0/+34 | |
| | | | | | | | | | | | | [#1195 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | Rework ActiveSupport::OrderedHash to make lookups faster | Frederick Cheung | 2008-12-10 | 1 | -2/+3 | |
| | | | | | | | | | | | | [#1352 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | Merge commit 'origin/master' into savepoints | Hongli Lai (Phusion) | 2008-12-09 | 1 | -0/+12 | |
|\| | ||||||
| * | Change field_changed? method to handle the case where a nullable integer ↵ | Ben Symonds | 2008-12-08 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | | column is changed from 0 to '0' [#1530 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | Merge commit 'origin/master' into savepoints | Hongli Lai (Phusion) | 2008-12-03 | 22 | -228/+281 | |
|\| | | | | | | | | | | | Conflicts: activerecord/lib/active_record/fixtures.rb activerecord/test/cases/defaults_test.rb |