aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Foo.joins(:bar).includes(:bar) should result in a single query with :bar as ↵Jon Leighton2011-07-091-0/+8
| | | | a join. Related: #1873.
* Merge pull request #2017 from Casecommons/active_record_lintJosé Valim2011-07-081-0/+10
|\ | | | | ActiveRecord::Base subclasses should pass ActiveModel::Lint.
| * ActiveRecord::Base should pass ActiveModel::Lint.Grant Hutchins & Peter Jaros2011-07-081-0/+10
| |
* | Destroy association habtm record before destroying the record itself. Fixes ↵Tomas D'Stefano2011-07-081-0/+10
| | | | | | | | issue #402.
* | Ensure that the foreign key gets set when doing record.create_association or ↵Jon Leighton2011-07-081-0/+14
| | | | | | | | record.create_association. Fixes #1960.
* | Refactor PostgreSQLAdapter a bitDaniel Schierbeck2011-07-081-2/+2
|/ | | | | Move the private method #extract_schema_and_table into a separate Utils module so that it can be tested without resorting to #send.
* Use Enumerable#with_index. We're on Ruby > 1.8.7 (part II)Akira Matsuda2011-07-081-3/+1
|
* Make `ActiveRecord::Batches#find_each` to not return `self`.knapo2011-07-071-0/+7
| | | | This caused that `find_each` was producing extra db call taking all the records from db, and was less efficient than `ActiveRecord::Base#all`.
* Fix bug in collection_singular_ids on has many through association with ↵Anatoliy Lysenko2011-07-061-0/+5
| | | | | | | | | | | | | | | | conditions and includes, when condtions references tables from includes. Test fail because of invalid sql: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id: SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id" WHERE "readers"."person_id" = 1 AND (comments.id is null) Bug described in github#925 This commit will revert fix from https://github.com/rails/rails/commit/3436fdfc12d58925e3d981e0afa61084ea34736c , but tests is ok. Bug described in #6569 ticket.
* Merge pull request #1273 from jeremyf/feature-association-proxy-sendSantiago Pastorino2011-07-061-0/+9
|\ | | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handl
| * Addresses an inconsistency in the ActiveRecord::Base.method_missing handling ↵Jeremy Friesen2011-05-241-0/+9
| | | | | | | | of dynamic finder methods and the passing of the &block parameter for :find_by_attributes.
* | Merge pull request #1494 from anildigital/masterSantiago Pastorino2011-07-061-2/+2
|\ \ | | | | | | Fix failing test because of Timezone difference.
| * | Fix failing test because of Timezone difference.Anil Wadghule2011-06-051-2/+2
| | |
* | | Merge pull request #1979 from bogdan/association_sum_array_compatibilityJon Leighton2011-07-061-0/+4
|\ \ \ | | | | | | | | Fixed AR::Relation#sum compatibility with Array#sum
| * | | Fixed AR::Relation#sum compatibility with Array#sumBogdan Gusiev2011-07-051-0/+4
| | | | | | | | | | | | | | | | | | | | In order make Relation behavior closer to Array Made Relation#sum to accept block and delegate it to Array#sum
* | | | Merge pull request #1968 from bogdan/associations_find_array_compatibility2Santiago Pastorino2011-07-051-0/+4
|\ \ \ \ | |/ / / |/| | | Fixed CollectionAssociation#find to be compatible with Array#find
| * | | Fixed CollectionAssociation#find to be compatible with Array#findBogdan Gusiev2011-07-051-0/+4
| | | | | | | | | | | | | | | | | | | | In order to make CollectionAssociation behave closer to Array Add the ability to pass block to #find method just like Array#find does.
* | | | Only call set_owner_attributes for has_one association if target exists.Dieter Komendera2011-07-041-0/+11
|/ / /
* | | Reversing the changes done in c278a2c while still resolving #1857.Vijay Dev2011-07-021-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | The changes broke bulk migration tests and were fixed in 4d256bc6; however that brought back the issue of #1857 and so this commit goes back to the original scenario and just adds change_table to the list of methods which are to be recorded in the CommandRecorder. The method_missing now delegates all calls to the underlying connection as before.
* | | Assign the association attributes to the associated record before the ↵Jon Leighton2011-06-302-0/+14
| | | | | | | | | | | | before_initialize callback of the record runs. Fixes #1842.
* | | cache the plural name on the reflection so we do not pay pluralize costs on ↵Aaron Patterson2011-06-301-1/+1
| | | | | | | | | | | | joins
* | | CommandRecorder should delegate in method_missing where possible. Fixes some ↵Jon Leighton2011-06-301-1/+6
| | | | | | | | | | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce.
* | | Merge pull request #1574 from ↵Aaron Patterson2011-06-281-0/+12
|\ \ \ | | | | | | | | | | | | | | | | oriolgual/1571_ar_relation_order_no_longer_works_with_arel_nodes Fix #1571 ActiveRecord::Relation#order no longer works with arel ordering nodes
| * | | Add more test casesOriol Gual2011-06-281-0/+8
| | | |
| * | | Add failing testOriol Gual2011-06-281-0/+4
| | | |
* | | | Fix test_finding_with_cross_table_order_and_limit for OracleRaimonds Simanovskis2011-06-281-3/+3
|/ / / | | | | | | Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated.
* | | Merge pull request #1857 from vijaydev/irreversible-migrationAaron Patterson2011-06-281-3/+5
|\ \ \ | | | | | | | | IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration
| * | | record unsupported methods in CommandRecorder instead of letting the ↵Vijay Dev2011-06-251-3/+5
| | | | | | | | | | | | | | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations
* | | | Merge pull request #1860 from dmathieu/comparisonAaron Patterson2011-06-281-0/+13
|\ \ \ \ | | | | | | | | | | Allow comparison on model objects - Closes #1858
| * | | | comparing different classes returns nilDamien Mathieu2011-06-261-0/+6
| | | | |
| * | | | allow comparison on model objects - Closes #1858Damien Mathieu2011-06-261-0/+7
| |/ / /
* | | | oops! remove debugging codesAaron Patterson2011-06-271-1/+0
| | | |
* | | | default create_with_value to a hash so we can eliminate conditionals, add ↵Aaron Patterson2011-06-272-1/+9
|/ / / | | | | | | | | | test surrounding create_with(nil) behavior
* | | Merge pull request #1848 from raviolicode/postgresql_order_multiple_paramsSantiago Pastorino2011-06-241-0/+7
|\ \ \ | | | | | | | | Fix for complex ordering of multiple columns on postgresql
| * | | Improve ordering of multiple columns on postgresqlLucia Escanellas2011-06-241-0/+7
| | | | | | | | | | | | | | | | | | | | * Only on postgresql, order("first asc, second asc") was invalid * Closes #1720
* | | | Apply the default scope earlier when doing calculations. Fixes #1682.Jon Leighton2011-06-231-0/+7
|/ / /
* | | Merge pull request #1790 from ernie/reverse_sql_order_fixAaron Patterson2011-06-221-0/+12
|\ \ \ | | | | | | | | Support reversal of ARel orderings in reverse_sql_order
| * | | Support reversal of ARel orderings in reverse_sql_orderErnie Miller2011-06-201-0/+12
| | | |
* | | | Merge pull request #1632 from tardate/pg_schema_fuAaron Patterson2011-06-213-3/+213
|\ \ \ \ | |/ / / |/| | | Improving PostgreSQL adapter schema-awareness
| * | | Merge remote branch 'rails/master' into pg_schema_fuPaul Gallagher2011-06-194-37/+346
| |\ \ \
| * | | | Make PostgreSQL adapter view-compatiblePaul Gallagher2011-06-192-1/+49
| | | | | | | | | | | | | | | * amongst other things, allows meta_search to run against view-backed models
| * | | | make extract_schema_and_table a private methodPaul Gallagher2011-06-111-7/+7
| | | | |
| * | | | remove table quoting in primary_key methodPaul Gallagher2011-06-112-5/+47
| | | | | | | | | | | | | | | * add/cleanup tests
| * | | | apply private method indentation conventionPaul Gallagher2011-06-102-3/+3
| | | | | | | | | | | | | | | * tidy test code and fix my typo
| * | | | Improve PostgreSQL adapter schema-awarenessPaul Gallagher2011-06-102-2/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * table_exists? scoped by schema search path unless schema is explicitly named. Added tests and doc to clarify the behaviour * extract_schema_and_table tests and implementation extended to cover all cases * primary_key does not ignore schema information * add current_schema and schema_exists? methods * more robust table referencing in insert_sql and sql_for_insert methods
* | | | | Merge pull request #1763 from grantneufeld/schema_column_exists_options_hashJosé Valim2011-06-181-0/+12
|\ \ \ \ \ | | | | | | | | | | | | Fix default options argument on ActiveRecord::ConnectionAdaptors::Table#column_exists?
| * | | | | Changed the default value for the options argument on ↵Grant Neufeld2011-06-181-0/+12
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::ConnectionAdapters::Table#column_exists? from nil to an empty Hash {}. That method calls through to ActiveRecord::ConnectionAdapters::SchemaStatements##column_exists? expects options to be a Hash. When options was nil, an error would occur in cases where the column did exist because the called method attempted to perform a key lookup on options.
* / | | | Fix inconsistencies by being polite to the wrapped body. Needed for ↵Steve Hodgkiss2011-06-182-0/+18
|/ / / / | | | | | | | | | | | | Rack::Sendfile to function properly. See issue #1761.
* | | | Pass mass-assignment options to nested models - closes #1673.Andrew White2011-06-131-0/+245
| | | |
* | | | Rename tests to reflect associationsAndrew White2011-06-131-30/+30
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-20 00:49:45 +0000