aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #14428 from jnormore/reset_counters_aliasRafael Mendonça França2014-05-171-3/+13
|\ | | | | Updates reset_counters to allow counter name in params
| * Updates reset_counters to allow counter name in paramsJason Normore2014-05-161-3/+13
| | | | | | | | | | | | | | Add support for counter name to be passed as parameter on `CounterCache::ClassMethods#reset_counters`. This is to be consistent with the other methods in the module that all accept counter name.
* | Add missing tests for column type cast behaviorSean Griffin2014-05-171-0/+36
|/
* Merge pull request #15071 from leafac/issues/11985Rafael Mendonça França2014-05-161-1/+5
|\ | | | | Fix `Relation#delete_all` inconsistency
| * Fix `Relation#delete_all` inconsistencyLeandro Facchinetti2014-05-161-1/+5
| | | | | | | | | | | | | | | | | | When relation scopes include one of `uniq`, `group`, `having` or `offset`, the generated query ignores them and that causes unintended records to be deleted. This solves the issue by restricting the deletion when those scopes are present. rails/rails#11985
* | Clear transaction state if callback raise rollbackArthur Neves2014-05-151-0/+13
| |
* | Changed extract_limit in class Column to return correct mysql float and ↵Aaron Nelson2014-05-161-0/+38
| | | | | | | | double limits
* | Merge pull request #15088 from kares/shareable-modulesRafael Mendonça França2014-05-142-20/+15
|\ \ | | | | | | | | | [postgres] remove (outer) sub-class declarations with nested modules/classes
| * | PostgreSQLAdapter::Utils seems to be only used from a single spot - quite ↵kares2014-05-142-20/+15
| | | | | | | | | | | | redundant
* | | Merge pull request #14871 from kassio/kb-fixes-namespaced-habtmRafael Mendonça França2014-05-141-0/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix how to compute class name on habtm namespaced. Conflicts: activerecord/CHANGELOG.md
| * | | Fix how to compute class name on habtm namespaced.Kassio Borges2014-05-131-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | Thank's for @laurocaetano for the help with tests. :smiley: Fixes #14709
* | | | Merge pull request #15078 from nbudin/fix_merger_filter_binds_comparison_masterRafael Mendonça França2014-05-141-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make filter_binds filter out symbols that are equal to strings Conflicts: activerecord/CHANGELOG.md
| * | | | Make filter_binds filter out symbols that are equal to stringsNat Budin2014-05-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Relation::Merger's filter_binds method does not filter out bind variables when one of the attribute nodes has a string name, but the other has a symbol name, even when those names are actually equal. This can result in there being more bind variables than placeholders in the generated SQL. This is particularly an issue for PostgreSQL, where this is treated as an error. This patch changes the filter_binds method to make it convert both attribute names to strings before comparing.
* | | | | remove warning `ambiguous first argument; put parentheses or even spaces`Kuldeep Aggarwal2014-05-151-1/+1
| | | | |
* | | | | Fix inheritance of stored_attributes (fixes #14672)Jessica Yao2014-05-141-0/+16
| |_|/ / |/| | | | | | | | | | | [Brad Bennett, Jessica Yao, & Lakshmi Parthasarathy]
* | | | pg, clarify default behavior for composite types.Yves Senn2014-05-131-7/+94
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * by default composite types are mapped as `OID::Identity` and issue a warning * the user is advised to register his own `OID::Type` to make use of composite types Registering a new `OID::Type` does currently not allow to specify the type casting behavior when writing to the database. In order for it to work we need to use the values within `@attributes`. They are already being type casted and are ready to be written to the DB. See https://github.com/rails/rails/blob/57643c961feb24b662620d330e71103a830003e8/activerecord/lib/active_record/attribute_methods.rb#L460-L462
* | | test, move all pg array tests into `postgresql/array_test.rb`.Yves Senn2014-05-132-51/+29
|/ /
* | test, use `columns_hash[]` in place of `columns.find {}`.Yves Senn2014-05-128-12/+12
| |
* | pg, `change_column_default` accepts `[]`. Closes #11586.Yves Senn2014-05-121-1/+9
| |
* | pg, map `char` and `name` types as string. [dark-panda & Yves Senn]Yves Senn2014-05-121-0/+23
| | | | | | | | Closes #10802.
* | pg, fix Infinity and NaN values conversion.Innokenty Mihailov2014-05-121-0/+7
|/ | | | Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
* Handle other pk types in PostgreSQL gracefully.Patrick Robertson2014-05-121-0/+26
| | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.
* Merge pull request #14999 from yahonda/modify_bind_variable_nameYves Senn2014-05-121-2/+3
|\ | | | | | | | | | | | | Modify assert conditions not to be affected by each database bind variable naming conventions Closes #14999.
| * Modify assert conditions not to be affectedYasuo Honda2014-05-121-2/+3
| | | | | | | | by each database bind variable naming conventions
* | Merge pull request #10662 from ↵Carlos Antonio da Silva2014-05-111-9/+9
|\ \ | | | | | | | | | | | | take/change-test-name-for-ActiveRecord--Validations#valid- Refactor AR's validations_test.rb
| * | Refactor AR's validations_test.rbTakehiro Adachi2013-12-031-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `:context` switch feature is implemented in ActiveRecord::Validations#valid? method, so we should rename the test names, and execute `valid?` in the test. Change test name in AR's validations_test.rb This test is testing save method's code
* | | deprecate, join, preload, eager load of instance dependent associations.Yves Senn2014-05-101-4/+27
| | | | | | | | | | | | | | | | | | | | | Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior.
* | | test, regression test for has_many with instance dependent scope.Yves Senn2014-05-091-0/+10
| | |
* | | Reverts "Fix bugs with changed attributes tracking when transaction gets ↵Arthur Neves2014-05-091-42/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rollback" We are reverting these commits, because there are other caveats related to dirty attributes not being restored when a transaction is rollback. For instance, nested transactions cannot proper restore the dirty attributes state after a rollback. At the moment, the dirty attributes are scoped by the transaction. When we call `.save` on a record, the dirty attributes will be reset even if the transaction gets rollback. [related #13166] [related #15018] [related #15016] [closes #15019] This reverts commits * bab48f0a3d53a08bc23ea0887219e8deb963c3d9 * b0fa7cf3ff8432cc2eef3682b34763b7f8c93cc8. * 73fb39b6faa9de593ae75ad4e3b8e065ea0e53af * 37c238927fbed059de3f26a90d8923fb377568a5. * 8d8d4f1560264cd1c74364d67fa0501f6dd2c4fa Revert "Merge pull request #13166 from bogdan/transaction-magic"
* | | set a constant for the "anonymous" habtm model fixes #15022Aaron Patterson2014-05-081-0/+6
| | | | | | | | | | | | | | | I wanted the middle model to be anonymous, but we have to give it a name for marshal support. :'(
* | | test, regression test for unparsable PostgreSQL defaults.Yves Senn2014-05-081-0/+17
| | | | | | | | | | | | | | | This test was inspired by #14866. That PR would break this functionality and we should make sure we notice that in the future.
* | | Merge pull request #14992 from fredwu/habtm_relation_size_calculation_fixCarlos Antonio da Silva2014-05-081-0/+18
|\ \ \ | | | | | | | | Habtm relation size calculation fix. Fixes #14913, Fixes #14914.
| * | | Fixed HABTM's CollectionAssociation sizeFred Wu2014-05-081-0/+18
| | | | | | | | | | | | | | | | | | | | HABTM should fall back to using the normal CollectionAssociation's size calculation if the collection is not cached or loaded. This addresses both #14913 and #14914 for master.
* | | | test, reset changed state in PG's uuid tests.Yves Senn2014-05-081-2/+4
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This resulted in some unrelated errors on Traivs: 1) Error: PostgresqlUUIDTest#test_treat_blank_uuid_as_nil: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "thingy" of relation "uuid_data_type" does not exist LINE 1: INSERT INTO "uuid_data_type" ("thingy") VALUES ($1) RETURNIN... ^ : INSERT INTO "uuid_data_type" ("thingy") VALUES ($1) RETURNING "id" /cc @zuhao
* | | Keep track of dirty attrs after after rollback.Arthur Neves2014-05-071-18/+4
| | | | | | | | | | | | [related #13166]
* | | Merge pull request #13166 from bogdan/transaction-magicRafael Mendonça França2014-05-071-0/+56
|\ \ \ | | | | | | | | | | | | [Regression 3.2 -> 4.0] Fix bugs with changed attributes tracking when transaction gets rollback
| * | | Fix bugs with changed attributes tracking when transaction gets rollbackBogdan Gusiev2013-12-041-0/+56
| |/ /
* | / test, persist inherited class with different table name. Refs #14971.Yves Senn2014-05-071-0/+14
| |/ |/| | | | | | | This case prevents against regressions. The change was suggested in a recent PR but the all our tests passed.
* | Add support for module-level table_suffix in modelsJenner LaFave2014-05-051-0/+28
| | | | | | | | | | This makes table_name_suffix work the same as table_name_prefix when using namespaced models. Pretty much the same as 67d1cec.
* | Put back Relation#join method as a delegate to ArrayBogdan Gusiev2014-05-052-1/+5
| | | | | | | | | | | | | | | | This is a regression 4.0 -> 4.1 fix. In 4.1.0 Relation#join is delegated to Arel#SelectManager. In 4.0 series it is delegated to Array#join This patch puts back the behaviour of 4.0
* | Merge pull request #14946 from jcoleman/fix-null-binary-column-logging-exceptionRafael Mendonça França2014-05-041-0/+7
|\ \ | | | | | | | | | | | | | | | | | | Fix exception when logging SQL w/ nil binary value. Conflicts: activerecord/CHANGELOG.md
| * | Fix exception when logging SQL w/ nil binary value.James Coleman2014-05-021-0/+7
| | |
* | | Remove duplicated fixture additionCarlos Antonio da Silva2014-05-031-1/+1
| | |
* | | Refactor test to not care about the specific result of valid?Carlos Antonio da Silva2014-05-031-3/+4
| | | | | | | | | | | | | | | | | | Only care about its truthiness rather than asserting specific true/false values. If we need to check for the return value in particular, there will be a test for that.
* | | Merge pull request #14924 from eric-chahin/issue_13854Matthew Draper2014-05-031-0/+10
|\ \ \ | | | | | | | | | | | | Fixed custom validation context bug for child associations
| * | | Fixed custom validation context bug where childEric Chahin2014-05-011-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | associations were not being saved. Fixes #13854. [Eric Chahin, Aaron Nelson, & Kevin Casey]
* | | | Test typecasting on instance rather than class itselfAkshay Vishnoi2014-05-031-1/+1
| | | |
* | | | Add missing require to fix test :bomb:Carlos Antonio da Silva2014-05-021-0/+1
| | | |
* | | | Move dup destroyed test to specific file that tests dup logicCarlos Antonio da Silva2014-05-022-9/+10
| | | | | | | | | | | | | | | | | | | | Also change other related test to use existing record rather than creating new one.
* | | | push up bind params on "simple" subquery calculationsAaron Patterson2014-05-021-1/+7
| |/ / |/| | | | | | | | | | | bind parameters we not being propogated to simple subquery calculation calls. This fixes it
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-12 13:32:09 +0000