aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Fixed that serialized strings should never be type-casted (i.e. turning ↵David Heinemeier Hansson2008-10-271-0/+6
| | | | "Yes" to a boolean)(Andreas Korth) [#857 state:committed]
* "raise NoMethodError" raises NoMethodError. Raise it with NoMethodError.new ↵Mike Gunderloy2008-10-251-4/+7
| | | | | | instead. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixed issue where block is not called on the very first invocation of a ↵Ken Miller2008-10-241-0/+11
| | | | | | find_or_create_by_ automatic finder. [#1224 state:committed]
* Skip collection ids reader optimization if using :finder_sqlJeremy Kemper2008-10-231-0/+7
|
* Ensure association proxy responds to private class methods defined in ↵Pratik Naik2008-10-161-2/+8
| | | | associated class. [#1083]
* Allow class methods to be sent (via #send) to association proxy (fix for bug ↵Ian White2008-10-161-0/+4
| | | | | | introduced by 691aa20) [#1083] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure methods called on association proxies respect access control. [#1083 ↵Pratik Naik2008-10-133-0/+30
| | | | state:resolved] [Adam Milligan, Pratik]
* Remove the functionality introduce in 28d3390Michael Koziarski2008-10-102-33/+0
| | | | There are several situations it doesn't cater for, and the inconsistency isn't worth blocking 2.2.
* explicitly including child associations that are also included in the parent ↵Will Bryant2008-10-101-1/+41
| | | | | | | association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed]
* Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:resolved]Pratik Naik2008-10-041-3/+3
| | | | | Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string. Model.avg always returns big decimal.
* Introduce ActiveRecord::Reflection::ThroughReflection to simplify hm:t ↵Pratik Naik2008-10-041-0/+4
| | | | reflection logic
* Fix has_many :through when the source is a belongs_to association. [#323 ↵Zach Dennis2008-10-043-1/+26
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Try reloading model on class mismatch [#229 state:resolved]Lawrence Pit2008-10-041-0/+20
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Make sure recreate MySQL test database with the proper encoding and ↵Luca Guidi2008-10-031-0/+5
| | | | | | | collation [#1165 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1165 state:committed]
* Dynamic finders should use the ActiveRecord::Base::find method instead of ↵Eloy Duran2008-10-031-5/+22
| | | | | | | | | | | | ::find_initial, :find_last, and ::find_all. This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders. Associations for instance do go through ::find, so this makes it more consistent. Also removed the unnecessary deprecation silence blocks. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1162 state:committed]
* wrote a test showing eager loading's misbehavior (sanitizing against the ↵Will Bryant2008-09-291-0/+7
| | | | | | wrong table) when the association has a :conditions hash Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Changed ActiveRecord attributes to respect access control.Adam Milligan2008-09-241-4/+47
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1084 state:committed]
* Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join ↵Pivotal Labs2008-09-243-0/+47
| | | | | | | strings to avoid table aliasing problems. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1077 state:committed]
* Make AssociationCollection start transactions in the correct database.Hongli Lai (Phusion)2008-09-233-0/+27
| | | | | | | | | | AssociationCollection now starts transactions by calling AssociationCollection#transaction instead of @owner.transaction or @reflection.klass.transaction. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1081 state:committed]
* Merge branch 'patches' into multibyteMichael Koziarski2008-09-223-1/+40
|\
| * Association#first and last should not load the association if not needed. ↵Jan De Poorter2008-09-222-1/+14
| | | | | | | | | | | | [#1091 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Add Model#delete instance method, similar to Model.delete class method. ↵Hongli Lai (Phusion2008-09-211-0/+26
| | | | | | | | | | | | [#1086 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* | Change all calls to String#chars to String#mb_chars.Manfred Stienstra2008-09-212-6/+6
| |
* | Fix a test that assumes .mb_chars to always return an instance of the ↵Manfred Stienstra2008-09-211-7/+23
| | | | | | | | proxy_class.
* | Change all calls to String#chars to String#mb_chars. Remove a exception for ↵Manfred Stienstra2008-09-211-2/+2
|/ | | | Ruby <= 1.9.
* applied patch to fix the associations with blocks in modules bug from an old ↵Adeh DeSandies2008-09-201-0/+15
| | | | trac ticket
* I18n: Introduce I18n.load_path in favor of I18n.load_translations and change ↵Sven Fuchs2008-09-201-1/+5
| | | | | | Simple backend to load translations lazily. [#1048 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixed an error triggered by a reload followed by a foreign key assignment.Nathaniel Talbott2008-09-201-0/+8
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* When counting grouped records the target should be loaded to return a valid ↵miloops2008-09-151-0/+2
| | | | | | | | | groups count result. Without this change count_records will group for the count in the query and return erroneous results. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#937 state:committed]
* stop AR's debug.log filling with warnings about not being able to load ↵Frederick Cheung2008-09-141-0/+14
| | | | | | | | fixture classes [#1045 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Deal with MySQL's quirky handling of defaults and blob/text columnsFrederick Cheung2008-09-142-1/+36
| | | | | | [#1043 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Multiparameter attributes skip time zone conversion for time-only columns ↵gbuesing2008-09-141-0/+18
| | | | [#1030 state:resolved]
* Base.skip_time_zone_conversion_for_attributes uses ↵miloops2008-09-141-0/+9
| | | | class_inheritable_accessor, so that subclasses don't overwrite Base [#346 state:resolved]
* Allow for the dirty tracking to work with the aliased name of aliased ↵Rich Cavanaugh2008-09-131-0/+13
| | | | | | | attributes. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#812 state:committed]
* Support for updating a belongs to association from the foreign key (without ↵Jon Leighton2008-09-132-0/+25
| | | | | | | saving and reloading the record) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#142 state:committed]
* Use select and change test so new tests can work on postgres.miloops2008-09-121-2/+2
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Improve test coverage when using the group option in find, has_many or ↵miloops2008-09-114-2/+25
| | | | | | has_and_belongs_to_many. Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Fix ActiveRecord::Base.quote_bound_value for ActiveSupper::Multibyte::Chars ↵Manfred Stienstra2008-09-112-2/+35
| | | | | | | | | | values. - Adds String#acts_like_string? - Adds Chars#acts_like_string? Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1029 state:committed]
* Fixes validates_uniquness_of problem with case insensitive string containing ↵wmoxam2008-09-111-0/+7
| | | | | | newline characters Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Add missing assert_deprecated calls to prevent spam during test runsMichael Koziarski2008-09-111-2/+6
|
* add activerecord tests to make sure the deprecated %s and %d interpolation ↵Sven Fuchs2008-09-101-1/+15
| | | | | | | | syntax still works [#1016 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* add activerecord tests for deprecation of %s and %d in error messages (and ↵Sven Fuchs2008-09-101-0/+12
| | | | | | translations in general) Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* change activerecord validation tests to not use the deprecated interpolation ↵Sven Fuchs2008-09-101-29/+29
| | | | | | syntax any more Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* fixed association preloading to use = instead of IN when there's only one recordrsl2008-09-101-1/+1
| | | | | | [#1013 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Revert "Add :accessible option to Associations for allowing mass assignments ↵Pratik Naik2008-09-101-108/+0
| | | | | | | | | | | | using hash. [#474 state:resolved]" This reverts commit e0750d6a5c7f621e4ca12205137c0b135cab444a. Conflicts: activerecord/CHANGELOG activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_collection.rb
* Added :constructor and :converter options to composed_of and deprecated the ↵Rob Anderton2008-09-101-0/+35
| | | | | | conversion block Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Support :limit on update_all so that has_many with :limit can be safely updatedTarmo Tänav2008-09-101-4/+15
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Fixed test_find_last_by_one_attribute_caches_dynamic_finder for postgresql 8.3Tarmo Tänav2008-09-101-1/+1
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Added find_last_by dynamic finder [status:committed #762]miloops2008-09-091-4/+36
| | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
* Revert "Revert "Raise UnknownAttributeError when unknown attributes are ↵Jeremy Kemper2008-09-081-0/+8
| | | | | | supplied via mass assignment"" This reverts commit 41efd73887c00ffd228b05d9346ec47a1f3759b9.