Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Deprecate set_primary_key in favour of self.primary_key= | Jon Leighton | 2011-11-29 | 3 | -8/+29 |
| | |||||
* | Make sure the original_foo accessor still works (but deprecated) if we are ↵ | Jon Leighton | 2011-11-29 | 1 | -7/+55 |
| | | | | using self.foo= | ||||
* | Deprecate set_sequence_name in favour of self.sequence_name= | Jon Leighton | 2011-11-29 | 1 | -2/+6 |
| | |||||
* | Add tests for set_sequence_name etc | Jon Leighton | 2011-11-29 | 1 | -0/+22 |
| | |||||
* | Deprecate set_inheritance_column in favour of self.inheritance_column= | Jon Leighton | 2011-11-29 | 2 | -4/+9 |
| | |||||
* | Deprecate set_table_name in favour of self.table_name= or defining your own ↵ | Jon Leighton | 2011-11-29 | 13 | -34/+47 |
| | | | | method. | ||||
* | respond_to? information of AR is not the responsibility of the spec | Aaron Patterson | 2011-11-29 | 1 | -1/+1 |
| | | | | resolver. | ||||
* | Merge pull request #3636 from joshsusser/master | Jon Leighton | 2011-11-29 | 3 | -1/+46 |
|\ | | | | | association methods are now generated in modules | ||||
| * | don't change class definition in test case | Josh Susser | 2011-11-29 | 1 | -6/+0 |
| | | |||||
| * | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 2 | -1/+30 |
| | | |||||
| * | add test for super-ing to association methods | Josh Susser | 2011-11-15 | 1 | -2/+12 |
| | | |||||
| * | association methods are now generated in modules | Josh Susser | 2011-11-15 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods. | ||||
* | | Fix resolver_test.rb on travis (postgresql isn't setup, so it can't load the ↵ | Jon Leighton | 2011-11-29 | 1 | -6/+6 |
| | | | | | | | | connection adapter) | ||||
* | | Fix schema_cache_test.rb for sqlite3_mem | Jon Leighton | 2011-11-29 | 1 | -6/+0 |
| | | |||||
* | | Move connection resoluion logic to it's own testable class. | Aaron Patterson | 2011-11-28 | 2 | -34/+41 |
| | | |||||
* | | pools are 1:1 with spec now rather than 1:1 with class | Aaron Patterson | 2011-11-28 | 2 | -3/+0 |
| | | |||||
* | | break establish_connection to smaller methods | Aaron Patterson | 2011-11-28 | 1 | -3/+3 |
| | | |||||
* | | Merge pull request #3768 from janv/master | Aaron Patterson | 2011-11-28 | 1 | -0/+11 |
|\ \ | | | | | | | Test and fix for Issue 3450 | ||||
| * | | Test case and fix for rails/rails#3450 | Jan Varwig | 2011-11-27 | 1 | -0/+11 |
| | | | | | | | | | | | | Asssigning a parent id to a belongs_to association actually updates the object that is validated when the association has :validates => true | ||||
* | | | Merge pull request #3748 from samsonasu/has_many_custom_pk_new_record | Jon Leighton | 2011-11-27 | 1 | -1/+28 |
|\ \ \ | |/ / |/| | | New records should load has_many relationships with custom primary keys | ||||
| * | | load has_many associations keyed off a custom primary key if that key is ↵ | Brian Samson | 2011-11-25 | 1 | -1/+28 |
| | | | | | | | | | | | | present but the record is unsaved | ||||
* | | | add the query to AR::Relation#explain output | Xavier Noria | 2011-11-25 | 3 | -0/+9 |
|/ / | | | | | | | | | | | | | Rationale: this is more readable if serveral queries are involved in one call. Also, it will be possible to let AR log EXPLAINs automatically in production mode, where queries are not even around. | ||||
* | | fixing tests on ruby 1.8 | Aaron Patterson | 2011-11-20 | 1 | -1/+3 |
| | | |||||
* | | pushing caching and visitors down to the connection | Aaron Patterson | 2011-11-19 | 5 | -119/+56 |
| | | |||||
* | | Verify that #3690 has been closed by previous changes to the mysql | Jon Leighton | 2011-11-19 | 2 | -2/+10 |
| | | | | | | | | | | | | | | | | adapters. These tests fail on the v3.1.2 tag. Closes #3690. | ||||
* | | Revert "Merge pull request #1163 from amatsuda/sexier_migration_31" | Aaron Patterson | 2011-11-17 | 1 | -120/+0 |
| | | | | | | | | | | | | | | | | | | | | This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72. Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/migration_test.rb | ||||
* | | Revert "Merge pull request #3603 from vijaydev/change_table_without_block_arg" | Aaron Patterson | 2011-11-17 | 1 | -54/+0 |
| | | | | | | | | | | | | | | | | | | This reverts commit 81fad6a270ec3cbbb88553c9f2e8200c34fd4d13, reversing changes made to 23101de283de13517e30c4c3d1ecc65525264886. Conflicts: activerecord/test/cases/migration_test.rb | ||||
* | | `ActiveRecord::Base#becomes` should retain the errors of the original object. | James Adam | 2011-11-16 | 1 | -0/+8 |
| | | | | | | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance. | ||||
* | | fixing tests on PG | Aaron Patterson | 2011-11-16 | 1 | -1/+1 |
| | | |||||
* | | Fixes issue #3483, regarding using a mixture of ranges and discrete values ↵ | Ryan Naughton | 2011-11-14 | 1 | -1/+1 |
| | | | | | | | | in find conditions. Paired with Joey Schoblaska. | ||||
* | | Failing test case for issue #3483 | Gabriel Sobrinho | 2011-11-14 | 1 | -0/+4 |
|/ | |||||
* | Merge pull request #3371 from yahonda/fix_ora_00932_error | Aaron Patterson | 2011-11-14 | 1 | -1/+1 |
|\ | | | | | Fix ORA-00932 error when trying to insert 0 to DATE type columns. | ||||
| * | Fix ORA-00932 error when trying to insert 0 to DATE type columns. | Yasuo Honda | 2011-10-19 | 1 | -1/+1 |
| | | |||||
* | | change_table bulk test case should check if the connection supports bulk alter | Vijay Dev | 2011-11-11 | 1 | -13/+15 |
| | | |||||
* | | Modify change_table to remove the need for the block argument. | Vijay Dev | 2011-11-11 | 1 | -0/+52 |
| | | |||||
* | | Checking the arity of the block passed to create_table | Vijay Dev | 2011-11-10 | 1 | -0/+15 |
| | | | | | | | | | | | | A recent change made to create_table does away with the need for the block argument. Checking the arity will prevent the mixing up of the two syntaxes. | ||||
* | | exclude ORDER BY clause when querying Relation#exists? | Akira Matsuda | 2011-11-09 | 1 | -0/+5 |
| | | |||||
* | | revises EXPLAIN tests for SQLite3 | Xavier Noria | 2011-11-06 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | The output in Travis is a bit different. The SQLite documentation (http://www.sqlite.org/eqp.html) warns output may change dramatically between releases. I do not want to mock the result set because I want a real EXPLAIN to happen. I prefer a test that may fail in future releases than a test that may give false positives in future releases. | ||||
* | | Merge pull request #3521 from ↵ | Aaron Patterson | 2011-11-06 | 1 | -0/+4 |
| | | | | | | | | | | | | nulogy/fix_postgres_adapter_to_handle_spaces_between_schemas Fix postgres adapter to handle spaces between schemas | ||||
* | | Update ActiveRecord#attribute_present? to work as documented | Justin Mazzi | 2011-11-05 | 1 | -0/+18 |
| | | | | | | | | | | | | | | "Returns true if the specified attribute has been set by the user or by a database load and is neither nil nor empty?" Fixes #1613 | ||||
* | | implements AR::Relation#explain | Xavier Noria | 2011-11-05 | 3 | -0/+71 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a first implementation, EXPLAIN is highly dependent on the database and I have made some compromises. On one hand, the method allows you to run the most common EXPLAIN and that's it. If you want EXPLAIN ANALYZE in PostgreSQL you need to do it by hand. On the other hand, I've tried to construct a string as close as possible to the ones built by the respective shells. The rationale is that IMO the user should feel at home with the output and recognize it at first sight. Per database. I don't know whether this implementation is going to work well. Let's see whether people like it. | ||||
* | | Merge pull request #3525 from kennyj/fix_3440-1 | Jon Leighton | 2011-11-05 | 1 | -0/+5 |
|\ \ | | | | | | | Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440) | ||||
| * | | Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440) | kennyj | 2011-11-06 | 1 | -0/+5 |
| | | | |||||
* | | | Add ActiveRecord::Relation#uniq for toggling DISTINCT in the SQL query | Jon Leighton | 2011-11-05 | 3 | -1/+23 |
| | | | |||||
* | | | AR changes to support creating ordered (asc, desc) indexes | Vlad Jebelev | 2011-11-04 | 2 | -4/+24 |
|/ / | |||||
* | | Fix test as one more has_many added | Arun Agrawal | 2011-11-04 | 1 | -1/+1 |
| | | |||||
* | | Allow the :class_name option for associations to take a symbol. | Jon Leighton | 2011-11-04 | 1 | -1/+5 |
| | | | | | | | | | | This is to avoid confusing newbies, and to be consistent with the fact that other options like :foreign_key already allow a symbol or a string. | ||||
* | | Merge pull request #1163 from amatsuda/sexier_migration_31 | Aaron Patterson | 2011-11-04 | 1 | -0/+20 |
|\ \ | | | | | | | Sexier migrations | ||||
| * | | Tests for new create_table DSL | Akira Matsuda | 2011-05-20 | 1 | -0/+20 |
| | | | |||||
* | | | Merge pull request #3507 from jmazzi/issue-3503 | Jeremy Kemper | 2011-11-03 | 1 | -0/+15 |
| | | | | | | | | | | | | Preserve SELECT columns on the COUNT for finder_sql when possible |