Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | applies new string literal convention in activerecord/test | Xavier Noria | 2016-08-06 | 1 | -5/+5 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Move the appropriate type tests to the Active Model suite | Sean Griffin | 2015-09-21 | 1 | -14/+0 |
| | | | | | | | | | Any tests for a type which is not overridden by Active Record, and does not test the specifics of the attributes API interacting in more complex ways have no reason to be in the Active Record suite. Doing this revealed that the implementation of the date and time types in AM was actually completely broken, and incapable of returning any value other than `nil`. | ||||
* | `type_cast_from_user` -> `cast` | Sean Griffin | 2015-02-17 | 1 | -4/+4 |
| | |||||
* | `Type#type_cast_from_database` -> `Type#deserialize` | Sean Griffin | 2015-02-17 | 1 | -1/+1 |
| | |||||
* | Revert the behavior of booleans in string columns to that of 4.1 | Sean Griffin | 2014-11-09 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | Why are people assigning booleans to string columns? >_> We unintentionally changed the behavior on Sqlite3 and PostgreSQL. Boolean values should cast to the database's representation of true and false. This is 't' and 'f' by default, and "1" and "0" on Mysql. The implementation to make the connection adapter specific behavior is hacky at best, and should be re-visted once we decide how we actually want to separate the concerns related to things that should change based on the database adapter. That said, this isn't something I'd expect to change based on my database adapter. We're storing a string, so the way the database represents a boolean should be irrelevant. It also seems strange for us to give booleans special behavior at all in string columns. Why is `to_s` not sufficient? It's inconsistent and confusing. Perhaps we should consider deprecating in the future. Fixes #17571 | ||||
* | Detect in-place modifications on Strings | Sean Griffin | 2014-06-17 | 1 | -0/+36 |