Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | `ActiveRecord::Base.no_touching` no longer triggers callbacks or start empty ↵ | Lucas Mazza | 2014-04-23 | 1 | -1/+20 |
| | | | | | | transactions. Closes #14841. | ||||
* | Merge pull request #14469 from tiegz/timestamp_inheritance_fix | Rafael Mendonça França | 2014-03-27 | 1 | -0/+18 |
| | | | | Swap Timestamp/Callbacks order in ActiveRecord::Base | ||||
* | ActiveRecord#touch should accept multiple attributes #14423 | Thiago Pinto | 2014-03-19 | 1 | -0/+12 |
| | |||||
* | polymorphic belongs_to association with touch: true updates old record correctly | Severin Schoepke | 2013-12-05 | 1 | -16/+42 |
| | | | | | | | | | Example: Given you have a comments model with a polymorphic commentable association (e.g. books and songs) with the touch option set. Every time you update a comment its commentable should be touched. This was working when you changed attributes on the comment or when you moved the comment from one book to another. However, it was not working when moving a comment from a book to a song. This is now fixed. | ||||
* | swap arguments for some `assert_equal` statements => `expected, actual` | Yves Senn | 2013-11-20 | 1 | -6/+6 |
| | |||||
* | add #no_touching on ActiveRecord models | Damien Mathieu | 2013-11-13 | 1 | -0/+48 |
| | |||||
* | Removed unused associations | Andrew White | 2013-04-24 | 1 | -2/+0 |
| | |||||
* | added test cases for #10197 | Adam Gamble | 2013-04-24 | 1 | -0/+56 |
| | |||||
* | Revert "Revert "`belongs_to :touch` behavior now touches old association ↵ | Andrew White | 2013-04-24 | 1 | -0/+46 |
| | | | | | | | | | when transitioning to new association" until a proper fix is found for #10197" This reverts commit 7389df139a35436f00876c96d20e81ba23c93f0a. Conflicts: activerecord/test/cases/timestamp_test.rb | ||||
* | Remove test case also related to the belongs_to touch feature | David Heinemeier Hansson | 2013-04-23 | 1 | -20/+0 |
| | |||||
* | Revert "`belongs_to :touch` behavior now touches old association when ↵ | David Heinemeier Hansson | 2013-04-23 | 1 | -26/+0 |
| | | | | transitioning to new association" until a proper fix is found for #10197 | ||||
* | Improve `belongs_to touch: true` timestamp test | Andrew White | 2013-04-05 | 1 | -7/+21 |
| | | | | | | Round off time to a whole second value to compensate for databases that don't support fractional timestamps. Also add a assertion to check that the old record is touched when the association is cleared. | ||||
* | Use inspect when writing the foreign key from the reflection | Andrew White | 2013-04-05 | 1 | -0/+6 |
| | | | | | | If we don't use inspect inside the class_eval block then the foreign key is written without quotes causing us to fetch the foreign key value and not the column name. | ||||
* | Modifies belong_to touch callback to touch old associations also #9091 | Adam Gamble | 2013-03-14 | 1 | -10/+2 |
| | |||||
* | + Add test for auto timestamps update of both old & new parent records | PikachuEXE | 2013-03-14 | 1 | -0/+34 |
| | |||||
* | Fix touching an invalid parent record for belongs_to | Olek Janiszewski | 2013-02-26 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | | | If the parent of a `belongs_to` record fails to be saved due to validation errors, `touch` will be called on a new record, which causes an exception (see https://github.com/rails/rails/pull/9320). Example: class Owner < ActiveRecord::Base validates_presence_of :name end class Pet < ActiveRecord::Base belongs_to :owner, touch: true end pet = Pet.new(owner: Owner.new) # Before, this line would raise ActiveRecord::ActiveRecordError # "can not touch on a new record object" pet.save | ||||
* | Use method compilation for association methods | Jon Leighton | 2012-08-10 | 1 | -13/+15 |
| | | | | | | | | | Method compilation provides better performance and I think the code comes out cleaner as well. A knock on effect is that methods that get redefined produce warnings. I think this is a good thing. I had to deal with a bunch of warnings coming from our tests, though. | ||||
* | Deprecate update_column in favor of update_columns. | Rafael Mendonça França | 2012-07-24 | 1 | -3/+3 |
| | | | | Closes #1190 | ||||
* | Remove update_attribute. | Steve Klabnik | 2012-06-14 | 1 | -2/+2 |
| | | | | | | | | | | | Historically, update_attribute and update_attributes are similar, but with one big difference: update_attribute does not run validations. These two methods are really easy to confuse given their similar names. Therefore, update_attribute is being removed in favor of update_column. See the thread on rails-core here: https://groups.google.com/forum/?fromgroups#!topic/rubyonrails-core/BWPUTK7WvYA | ||||
* | Allow instances to disable record_timestamps | Pratik Naik | 2011-10-26 | 1 | -0/+10 |
| | |||||
* | fix typo | Alexandr Zykov | 2011-06-08 | 1 | -1/+1 |
| | |||||
* | This way asserting that updated_at was changed in touch look more obvious. | Dmitriy Kiriyenko | 2011-06-07 | 1 | -0/+1 |
| | |||||
* | Do not use default_scope in ActiveRecord::Persistence#touch. | Dmitriy Kiriyenko | 2011-06-07 | 1 | -0/+9 |
| | |||||
* | please use ruby -I lib:test path/to/test.rb, or export RUBY_OPT | Aaron Patterson | 2011-06-06 | 1 | -1/+1 |
| | |||||
* | Refactor Active Record test connection setup. Please see the ↵ | Jon Leighton | 2011-06-04 | 1 | -1/+1 |
| | | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. | ||||
* | Isolated PostgreSQL test into PostgreSQL folder | Prem Sichanugrist | 2011-05-31 | 1 | -20/+0 |
| | |||||
* | Reduce test noise | Jon Leighton | 2011-05-31 | 1 | -20/+14 |
| | |||||
* | supporting infinity and -infinity for timestamps in PG. fixes #544 | Aaron Patterson | 2011-05-13 | 1 | -0/+26 |
| | |||||
* | Added new #update_column method. | Sebastian Martinez | 2011-03-27 | 1 | -1/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Revert "Removed #update_attribute method. New #update_column method." | Sebastian Martinez | 2011-03-27 | 1 | -4/+2 |
| | | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Removed #update_attribute method. New #update_column method. | Sebastian Martinez | 2011-03-26 | 1 | -2/+4 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Implement and test private method all_timestamp_attributes_in_model | Franck Verrot | 2011-02-02 | 1 | -0/+5 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Test timestamp_attributes_for_update_in_model that was already in place | Franck Verrot | 2011-02-02 | 1 | -0/+5 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Added timestamp_attributes_for_create_in_model | Franck Verrot | 2011-02-02 | 1 | -0/+5 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Test private method all_timestamp_attributes | Franck Verrot | 2011-02-02 | 1 | -0/+5 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Test private method timestamp_attributes_for_update | Franck Verrot | 2011-02-02 | 1 | -0/+5 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Test private method timestamp_attributes_for_create | Franck Verrot | 2011-02-02 | 1 | -0/+5 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | removing many unused variables | Aaron Patterson | 2010-11-16 | 1 | -1/+1 |
| | |||||
* | restore behavior of touch for models without :updated_xx [#5439 state:resolved] | tnp | 2010-09-24 | 1 | -5/+13 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | @user.touch should not fail if User does not have updated_at/updated_on column. | Neeraj Singh | 2010-08-24 | 1 | -1/+7 |
| | | | | | | [#5439 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add test case for ActiveRecord::Base.record_timestamps = false | Wincent Colaiuta | 2010-08-24 | 1 | -0/+10 |
| | | | | | | | | This is a failing test case for Lighthouse ticket #5440: https://rails.lighthouseapp.com/projects/8994/tickets/5440 Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Restore pet -> owner relationship to the previous state | Santiago Pastorino | 2010-08-16 | 1 | -1/+1 |
| | | | | [#5365] | ||||
* | added testcase for belongs_to with a counter_cache and touch | Mark Turner | 2010-08-16 | 1 | -0/+16 |
| | | | | | | [#5365 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -14/+14 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | move reload after touch | Brian Lopez | 2010-08-02 | 1 | -1/+1 |
| | |||||
* | reload the owner model after update | Brian Lopez | 2010-08-02 | 1 | -0/+1 |
| | |||||
* | Add an internal (private API) after_touch callback. [#5271 state:resolved] | José Valim | 2010-08-02 | 1 | -4/+4 |
| | |||||
* | added failing touch propagation test | Jakub Kuźma | 2010-08-02 | 1 | -0/+17 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | with this fix touch method - does not call validations - doest not call ↵ | Neeraj Singh | 2010-07-13 | 1 | -0/+10 |
| | | | | | | | | callbacks - updates updated_at/on along with attribute if attribute is provided - marks udpated_at/on and attribute as NOT changed [#2520 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Final iteration of use better testing methods | Neeraj Singh | 2010-05-19 | 1 | -8/+8 |
| | | | | | | [#4652 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> |