rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
*	Delegate #unscope query method	Carlos Antonio da Silva	2013-04-28	1	-0/+10
\|
*	Fix scope chaining + STI	Jon Leighton	2013-04-05	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	See #9869 and #9929. The problem arises from the following example: class Project < ActiveRecord::Base scope :completed, -> { where completed: true } end class MajorProject < Project end When calling: MajorProject.where(tasks_count: 10).completed This expands to: MajorProject.where(tasks_count: 10).scoping { MajorProject.completed } However the lambda for the `completed` scope is defined on Project. This means that when it is called, `self` is Project rather than MajorProject. So it expands to: MajorProject.where(tasks_count: 10).scoping { Project.where(completed: true) } Since the scoping was applied on MajorProject, and not Project, this fails to apply the tasks_count condition. The solution is to make scoping apply across STI classes. I am slightly concerned about the possible side-effects of this, but no tests fail and it seems ok. I guess we'll see.
*	failing test for #9869	Neeraj Singh	2013-04-05	1	-0/+5
\|
*	split relation_scoping_test.rb's default scoping tests into another file	Takehiro Adachi	2013-03-30	2	-357/+360
\|
*	rename named_scope_test.rb to a proper file name	Takehiro Adachi	2013-03-30	1	-1/+1
\| \| \| \| \|	The file name should be name_scoping_test.rb and the class should be `NamedScopingTest` according to ActiveRecord::Scoping::Name
*	move tests for NamedScope and DefaultScope under test/cases/scoping/	Takehiro Adachi	2013-03-30	2	-0/+1150
	The scoping/default.rb and scoping/named.rb got moved under scoping/ in commit 2b22564c4efaa63d4bbc006762838c4025c1bdca, but the tests never did.