rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
*	Add test to 57daaef	Rafael Mendonça França	2015-05-28	1	-1/+1
\|
*	Put back Relation#join method as a delegate to Array	Bogdan Gusiev	2014-05-05	1	-1/+1
\| \| \| \| \| \| \| \|	This is a regression 4.0 -> 4.1 fix. In 4.1.0 Relation#join is delegated to Arel#SelectManager. In 4.0 series it is delegated to Array#join This patch puts back the behaviour of 4.0
*	Create a blacklist to disallow mutator methods to be delegated to `Array`.	Lauro Caetano	2013-12-17	1	-4/+11
\| \| \| \| \| \| \| \|	This change was necessary because the whitelist wouldn't work. It would be painful for users trying to update their applications. This blacklist intent to prevent odd bugs and confusion in code that call mutator methods directely on the `Relation`.
*	Add a bunch of Relation -> Array delegate methods to the whitelist. This ↵	Jeremy Kemper	2013-12-12	1	-28/+14
\| \| \| \|	won't last - aim to switch back to a blacklist for mutator methods.
*	Use `public_send` instead of just use `send`.	Lauro Caetano	2013-12-12	1	-4/+4
\|
*	Use a whitelist to delegate methods to array	Lauro Caetano	2013-12-12	1	-57/+32
\|
*	`delgated` => `delegated`	Akshay Vishnoi	2013-11-25	1	-4/+4
\|
*	Avoid sorting an Array including objects from different Classes	Akira Matsuda	2013-11-11	1	-1/+1
\| \| \| \|	addresses "ArgumentError: comparison of VerySpecialComment with SpecialComment failed" in ActiveRecord::DelegationRelationTest#test_#sort!_delegation_is_deprecated
*	Load test fixtures where data are needed	Akira Matsuda	2013-11-11	1	-0/+2
\| \| \| \|	Without this, some tests here were not actually testing anything.
*	A tiny grammatical fix	Akira Matsuda	2013-11-11	1	-1/+1
\| \| \| \|	[ci skip]
*	Allow methods arity below -1 in assert_responds.	Federico Ravasio	2013-10-08	1	-3/+4
\| \| \| \| \| \| \| \|	Every method from MRI's core classes is written in C. This means Method#arity always returns -1 for methods with a variable number of arguments. This is not the case with Rubinius, where, for example Array#slice! is implemented in Ruby and has arity -2, since is defined as def slice!(start, length = undefined)
*	Deprecate the delegation of Array bang methods in ActiveRecord::Delegation	Ben Woosley	2013-09-04	1	-0/+97
	The primary means of returning results for Array bang methods is to modify the array in-place. When you call these methods on a relation, that array is created, modified, and then thrown away. Only the secondary return value is exposed to the caller. Removing this delegation is a straight-forward way to reduce user error by forcing callers to first explicitly call #to_a in order to expose the array to be acted on by the bang method.