Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix "warning: assigned but unused variable - task" | Ryuta Kamizono | 2016-08-26 | 1 | -1/+1 |
| | |||||
* | Test that AR query cache isn't busted when types are not same object | James Coleman | 2016-08-24 | 1 | -0/+20 |
| | | | | | | | | | | This is fixed in 5.0 as an ancillary part of 574f255629a45cd67babcfb9bb8e163e091a53b8 but here I also add a test for the condition. I'd previously backported the fix (and added a test) in the below commit; this brings the fix back up to master. (cherry picked from commit fce3dbf30241f2a65c777e192a7171b0eea81453) | ||||
* | applies new string literal convention in activerecord/test | Xavier Noria | 2016-08-06 | 1 | -21/+21 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Fix `payload[:class_name]` to `payload[:spec_name]` | Ryuta Kamizono | 2016-07-17 | 1 | -0/+2 |
| | | | | | | Follow up to #20818. `retrieve_connection` is passed `spec_name` instead of `klass` since #24844. | ||||
* | Remove unused `ActiveRecord::Base.connection_id` | Sean Griffin | 2016-06-29 | 1 | -12/+0 |
| | | | | | | | | This method appears to have been partially used in connection pool caching, but it was introduced without much reasoning or any tests. One edge case test was added later on, but it was focused on implementation details. This method is no longer used outside of tests, and as such is removed. | ||||
* | Fix postgresql query_cache test | Arthur Neves | 2016-06-14 | 1 | -0/+1 |
| | |||||
* | Respect the current `connected?` method when calling `cache` | Arthur Neves | 2016-06-14 | 1 | -0/+15 |
| | | | | | | Before we enable query caching we check if the connection is connected. Before this fix we were always checking against the main connection, and not the model connection. | ||||
* | Remove not needed line on test | Arthur Neves | 2016-06-14 | 1 | -1/+0 |
| | |||||
* | Support for unified Integer class in Ruby 2.4+ | Jeremy Daer | 2016-05-18 | 1 | -3/+2 |
| | | | | | | | | Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer. | ||||
* | Publish AS::Executor and AS::Reloader APIs | Matthew Draper | 2016-03-02 | 1 | -43/+13 |
| | | | | | | These should allow external code to run blocks of user code to do "work", at a similar unit size to a web request, without needing to get intimate with ActionDipatch. | ||||
* | Removed mocha from Active Record Part 1 | Ronak Jangir | 2015-08-25 | 1 | -32/+37 |
| | |||||
* | PostgreSQL, Fix OID based type casts in C for primitive types. | Lars Kanis | 2015-03-25 | 1 | -1/+1 |
| | | | | | | | | | | The type map was introduced in aafee23, but wasn't properly filled. This mainly adjusts many locations, that expected strings instead of integers or boolean. add_pg_decoders is moved after setup of the StatementPool, because execute_and_clear could potentially make use of it. | ||||
* | Revert ":cut: remove unnecessary rescue Exceptions" | Yves Senn | 2015-03-06 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | This reverts commit ff18049ca6f27deb7e7f955478e1464f8d756332. This broke the AR build for every adapter: 1) Error: AssociationCallbacksTest#test_dont_add_if_before_callback_raises_exception: Exception: You can't add a post 2) Failure: QueryCacheTest#test_query_cache_doesnt_leak_cached_results_of_rolled_back_queries [/Users/senny/Projects/rails/activerecord/test/cases/query_cache_test.rb:235]: Expected: 1 Actual: 0 I'm reverting to get the build green again. | ||||
* | :cut: remove unnecessary rescue Exceptions | Aaron Patterson | 2015-03-05 | 1 | -1/+1 |
| | |||||
* | Restore query cache on rollback | Florian Weingarten | 2014-12-01 | 1 | -0/+32 |
| | |||||
* | Make select_all on query cache accept a Relation without binds. | Arthur Neves | 2014-03-13 | 1 | -0/+8 |
| | | | | | [fixes #14361] [related #13886] | ||||
* | use `teardown` for cleanup, not `setup`. | Yves Senn | 2014-01-16 | 1 | -5/+2 |
| | | | | | | | | | | | | This solves order dependent issues where the last test leaked the query cache state. This resulted in the following error: ``` QueryCacheExpiryTest#test_cache_is_expired_by_habtm_delete [test/cases/query_cache_test.rb:275]: not all expectations were satisfied unsatisfied expectations: - expected exactly twice, invoked once: #<ActiveRecord::ConnectionAdapters::SQLite3Adapter:0x7f93e0c65838>.clear_query_cache(any_parameters) ``` | ||||
* | Currently, we clear query_cache in cache block finish, even if we may ↵ | Vipul A M | 2013-12-03 | 1 | -0/+9 |
| | | | | | | already have cache true. This commit takes into account the last cache_enabled value, before clearing query_cache. | ||||
* | Standardize the use of current_adapter? | Rafael Mendonça França | 2013-01-01 | 1 | -1/+1 |
| | |||||
* | Fix #6951. Use query cache/uncache, when using not only database.yml but ↵ | kennyj | 2012-10-31 | 1 | -0/+11 |
| | | | | also DATABASE_URL. | ||||
* | Cleanup trailing whitespaces | dfens | 2012-10-12 | 1 | -1/+1 |
| | |||||
* | Restore connection_id on error. | kennyj | 2012-07-23 | 1 | -0/+12 |
| | |||||
* | fixing tests to deal with data differences between prepared statements and ↵ | Aaron Patterson | 2012-07-13 | 1 | -1/+1 |
| | | | | | | | non-prepared statements Conflicts: activerecord/test/cases/query_cache_test.rb | ||||
* | Disable query cache for lock queries | Damir Zekic | 2012-07-06 | 1 | -0/+8 |
| | | | | Fixes #867 | ||||
* | Remove warnings and unused code | Rafael Mendonça França | 2012-06-11 | 1 | -5/+0 |
| | |||||
* | current AR::ConnectionAdapters::SQLite3Adapter supports only SQLite3 ~> 1.3.6 | Akira Matsuda | 2012-06-12 | 1 | -1/+1 |
| | |||||
* | remove calls to find(:first), find(:last) and find(:all) | Jon Leighton | 2012-04-26 | 1 | -3/+3 |
| | |||||
* | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 1 | -1/+1 |
| | |||||
* | use Rack::BodyProxy in activerecord middlewares | Sergey Nartimov | 2012-01-16 | 1 | -13/+6 |
| | |||||
* | Added failing test case for changing schema in migration not clearing the ↵ | Joe Van Dyk | 2011-10-27 | 1 | -0/+12 |
| | | | | prepared statement cache | ||||
* | Fixed BodyProxy.new for tests! for wrong argument | Arun Agrawal | 2011-10-08 | 1 | -1/+1 |
| | |||||
* | fix test error when running with postgresql. | Arun Agrawal | 2011-09-18 | 1 | -2/+4 |
| | | | | | This Sqlite3 should be in if block. Was giving error because sqlite3 is not loaded | ||||
* | Fixed test for JRuby. | Arun Agrawal | 2011-09-18 | 1 | -1/+2 |
| | | | for Sqlite3 in AR-JDBC.It's Jdbc::SQLite3::VERSION | ||||
* | fixing typo | Aaron Patterson | 2011-08-28 | 1 | -1/+1 |
| | |||||
* | clear and disable query cache when an exception is raised from called middleware | Aaron Patterson | 2011-08-28 | 1 | -1/+27 |
| | |||||
* | Fix inconsistencies by being polite to the wrapped body. Needed for ↵ | Steve Hodgkiss | 2011-06-18 | 1 | -0/+11 |
| | | | | Rack::Sendfile to function properly. See issue #1761. | ||||
* | please use ruby -I lib:test path/to/test.rb, or export RUBY_OPT | Aaron Patterson | 2011-06-06 | 1 | -1/+1 |
| | |||||
* | Refactor Active Record test connection setup. Please see the ↵ | Jon Leighton | 2011-06-04 | 1 | -1/+1 |
| | | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. | ||||
* | ensure query cache is cleared when Rack body is closed, fixes bug reported ↵ | Aaron Patterson | 2011-05-04 | 1 | -0/+11 |
| | | | | on 951e18abea9c116fc5d6b330ca1dcd2890abe006 | ||||
* | introduce a body proxy to ensure that query cache is enabled during streaming | Aaron Patterson | 2011-05-02 | 1 | -0/+26 |
| | |||||
* | more tests around caching | Aaron Patterson | 2011-05-02 | 1 | -1/+10 |
| | |||||
* | add a couple test cases surrounding query cache middleware | Aaron Patterson | 2011-05-02 | 1 | -0/+18 |
| | |||||
* | Use IM when trying to load records using ID. | Emilio Tagua | 2011-04-04 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | use SQLite3::VERSION rather than the deprecated class | Aaron Patterson | 2011-01-10 | 1 | -1/+1 |
| | |||||
* | removing many unused variables | Aaron Patterson | 2010-11-16 | 1 | -1/+0 |
| | |||||
* | fisting test name | Aaron Patterson | 2010-10-27 | 1 | -1/+1 |
| | |||||
* | making query cache work with prepared statements | Aaron Patterson | 2010-10-27 | 1 | -0/+6 |
| | |||||
* | one more mysql test left! | Aaron Patterson | 2010-10-26 | 1 | -1/+1 |
| | |||||
* | update tests for mysql2 support | Brian Lopez | 2010-08-02 | 1 | -1/+1 |
| | |||||
* | removing unused models from tests | Subba Rao Pasupuleti | 2010-07-21 | 1 | -2/+0 |
| | | | | | | [#5153 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> |