aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/persistence_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Remove warningsRafael Mendonça França2013-01-061-2/+1
|
* Unscope update_column(s) query to ignore default scopeCarlos Antonio da Silva2012-12-061-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When applying default_scope to a class with a where clause, using update_column(s) could generate a query that would not properly update the record due to the where clause from the default_scope being applied to the update query. class User < ActiveRecord::Base default_scope where(active: true) end user = User.first user.active = false user.save! user.update_column(:active, true) # => false In this situation we want to skip the default_scope clause and just update the record based on the primary key. With this change: user.update_column(:active, true) # => true Backport of #8436 fix. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/persistence.rb activerecord/test/cases/persistence_test.rb
* relaxes assertionXavier Noria2012-10-311-1/+1
| | | | | | | | | This method returns the status of the operation, but as we generally do in the code base it does not commit to any particular exact value. Hence, we do not have to check for a singleton, because if the implementation changes and returns some other true value the test should pass.
* Fix ActiveRecord#update_column return valuesaksmlz2012-10-311-0/+6
|
* Merge pull request #8053 from henrik/update_columns_with_primary_keyCarlos Antonio da Silva2012-10-291-0/+8
| | | | | | | | Unbreak update_column/update_columns for the primary key attribute. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/persistence.rb activerecord/test/cases/persistence_test.rb
* Do not use update_column where update_attribute is not interchangeableRafael Mendonça França2012-08-151-27/+8
| | | | | | | | | | | | Revert "Deprecate update_attribute." This reverts commit b081f6b59fb3f15d12043072ad9b331ffd2bc56e. Reason: Since the new deprecation policy we removed the deprecation of update_attribute but we didn't reverted the changes to use update_column. Fixes #7306
* Revert "Add update_columns and the suggestion of using update_columnsRafael Mendonça França2012-07-301-57/+0
| | | | | | | | | | | | | | | | instead of update_column" This reverts commit 9fa06c3d9811113259cb6e00a3a8454b3974add7. This reverts commit 17a64de4980683da3ca3c185205013a29a8cf88d. This reverts commit def9c85ffbdcf63e6c412b6bd4abafaa32ccdb5c, reversing changes made to 6b7d26cf3c061907aedc44f7f36776c9b36950fd. Reason: This was supposed to be released with 3.2.7 before the suggestion to use update_column. Since it was not release now is not good to suggest to use another method because it will confusing the people.
* Fix AR#update_columns tests on Ruby 1.8.7Carlos Antonio da Silva2012-07-251-7/+7
|
* New #update_columns method.Sebastian Martinez2012-07-261-0/+57
|
* Remove waning of unused variableRafael Mendonça França2012-06-211-1/+0
|
* Deprecate update_attribute.Steve Klabnik2012-06-141-7/+27
| | | | | | | | | | | Historically, update_attribute and update_attributes are similar, but with one big difference: update_attribute does not run validations. These two methods are really easy to confuse given their similar names. Therefore, update_attribute is being deprecated in favor of update_column, and will be removed in Rails 4. See the discussion on rails-core here: https://groups.google.com/d/topic/rubyonrails-core/BWPUTK7WvYA/discussion
* Add order to tests that rely on db ordering, to fix failing tests on pgCarlos Antonio da Silva2012-03-221-5/+6
| | | | | | | Also skip persistente tests related to UPDATE + ORDER BY for postgresql PostgreSQL does not support updates with order by, and these tests are failing randomly depending on the fixture loading order now.
* Raise error when using write_attribute with a non-existent attribute.Jon Leighton2011-09-131-6/+11
| | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing.
* Bring back the ability to provide :order for update_all.thedarkone2011-07-251-0/+20
|
* please use ruby -I lib:test path/to/test.rb, or export RUBY_OPTAaron Patterson2011-06-061-1/+1
|
* Refactor Active Record test connection setup. Please see the ↵Jon Leighton2011-06-041-1/+1
| | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
* Ensure assign_attributes and update_attributes do not fail on nil, closes #478.José Valim2011-05-101-0/+4
|
* some test renaming to avoid collisions, and some annoying issues between dbsJosh Kalderimis2011-04-271-7/+7
|
* final corrections to the mass-assignment security testsJosh Kalderimis2011-04-271-4/+4
|
* fix mass-assignment security tests, this was due to a string column limit ↵Josh Kalderimis2011-04-271-6/+6
| | | | which doesn't cause issues on sqlite
* AR update_attributes api is updated to reflect the addition of assign_attributesJosh Kalderimis2011-04-261-0/+40
|
* Added assign_attributes to Active Record which accepts a mass-assignment ↵Josh Kalderimis2011-04-241-1/+1
| | | | security scope using the :as option, while also allowing mass-assignment security to be bypassed using :with_protected
* oracle stores this with microseconds, so convert to seconds before comparingAaron Patterson2011-03-291-1/+1
|
* Added new #update_column method.Sebastian Martinez2011-03-271-0/+86
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Revert "Removed #update_attribute method. New #update_column method."Sebastian Martinez2011-03-271-42/+46
| | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Removed #update_attribute method. New #update_column method.Sebastian Martinez2011-03-261-46/+42
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* removing many unused variablesAaron Patterson2010-11-161-2/+1
|
* STI type is now updated when calling AR::Base.becomes on subclasses [#5953 ↵Franck Verrot2010-11-121-0/+9
| | | | state:resolved]
* Fixing typo [#5485 state:resolved]Thiago Pradi2010-08-281-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-2/+2
| | | | 's/[ \t]*$//' -i {} \;)
* Make update_attribute behave as in Rails 2.3 and document the behavior ↵José Valim2010-08-121-17/+24
| | | | intrinsic to its implementation.
* Making Active Record base_test.rb thinner by moving testsNeeraj Singh2010-08-031-0/+113
| | | | | | | | | | | | to relevant files. Number of assertions before refactoring: 2391 tests, 7579 assertions, 0 failures, 0 errors Number of assertions after refactoring: 2391 tests, 7579 assertions, 0 failures, 0 errors Signed-off-by: José Valim <jose.valim@gmail.com>
* removing unused models from testsSubba Rao Pasupuleti2010-07-211-7/+0
| | | | | | [#5153 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* update_attribute should not update readonly attributesNeeraj Singh2010-07-211-1/+7
| | | | | | [#5106 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Makes this test don't trust on the speed of executionSantiago Pastorino2010-07-171-4/+5
|
* moving persistence related tests to a new fileNeeraj Singh2010-07-161-0/+357
Before refactoring test result from AR: 2291 tests, 7180 assertions, 0 failures, 0 errors After the refactoring test result from AR: 2291 tests, 7180 assertions, 0 failures, 0 errors Signed-off-by: José Valim <jose.valim@gmail.com>