Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #6695 from kennyj/fix_6635 | Rafael Mendonça França | 2012-06-10 | 1 | -0/+9 |
| | | | | Fix #6635. We should call Scoping methods, before calling Array methods. | ||||
* | call scope within unscoped to prevent duplication of where values | Sergey Nartimov | 2011-12-17 | 1 | -0/+5 |
| | |||||
* | #first doesn't take an order in this test | Damien Mathieu | 2011-09-06 | 1 | -1/+1 |
| | |||||
* | first and last orders the records by id | Damien Mathieu | 2011-09-06 | 1 | -2/+2 |
| | |||||
* | Refactor test case to use anonymous class - Thank you @tenderlove | Prem Sichanugrist | 2011-07-18 | 1 | -13/+8 |
| | |||||
* | Raise an ArgumentError if user passing less number of argument in the ↵ | Prem Sichanugrist | 2011-07-17 | 1 | -0/+15 |
| | | | | | | | | | | | | | dynamic finder The previous behavior was unintentional, and some people was relying on it. Now the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.) So if you were doing this and expecting the second argument to be nil: User.find_by_username_and_group("sikachu") You'll now get `ArgumentError: wrong number of arguments (1 for 2).` You'll then have to do this: User.find_by_username_and_group("sikachu", nil) | ||||
* | please use ruby -I lib:test path/to/test.rb, or export RUBY_OPT | Aaron Patterson | 2011-06-06 | 1 | -1/+1 |
| | |||||
* | Merge pull request #1462 from arunagw/test_added_for_namedscope | José Valim | 2011-06-05 | 1 | -0/+8 |
|\ | | | | | Test added for namedscope target. | ||||
| * | Test added for namedscope target. | Arun Agrawal | 2011-06-03 | 1 | -0/+8 |
| | | |||||
* | | Refactor Active Record test connection setup. Please see the ↵ | Jon Leighton | 2011-06-04 | 1 | -1/+1 |
|/ | | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. | ||||
* | Modified NamedScopeTest to use CollectionAssociation. | Michael Ebens | 2011-05-11 | 1 | -1/+1 |
| | |||||
* | Revert "Deprecate defining scopes with a callable (lambda, proc, etc) via ↵ | Jon Leighton | 2011-04-17 | 1 | -6/+0 |
| | | | | | | | | | | the scope class method. Just define a class method yourself instead." This reverts commit f0e198bfa1e3f9689e0cde1d194a44027fc90b3c. Conflicts: activerecord/test/models/post.rb | ||||
* | Deprecate defining scopes with a callable (lambda, proc, etc) via the scope ↵ | Jon Leighton | 2011-04-12 | 1 | -0/+6 |
| | | | | class method. Just define a class method yourself instead. | ||||
* | ActiveRecord::Base.scopes hash is not needed | Jon Leighton | 2011-04-12 | 1 | -11/+0 |
| | |||||
* | Removing the scope-caching which happens on association proxies, because the ↵ | Jon Leighton | 2011-04-12 | 1 | -10/+15 |
| | | | | query is already cached by the query cacher. For formalised proof see http://www.youtube.com/watch?v=wDefXLb-FDs | ||||
* | Delegate first!, last!, any? and many? to scoped | Andrew White | 2011-03-29 | 1 | -1/+16 |
| | |||||
* | fixes: ActiveRecord::Base.scopes includes all scopes defined in all subclasses | Eric Allam | 2011-02-24 | 1 | -0/+4 |
| | |||||
* | Split AssociationProxy into an Association class (and subclasses) which ↵ | Jon Leighton | 2011-02-18 | 1 | -1/+1 |
| | | | | manages the association, and a CollectionProxy class which is *only* a proxy. Singular associations no longer have a proxy. See CHANGELOG for more. | ||||
* | Replace rudimentary named_scope with scope. [#6052 state:resolved] | Pavel Gorbokon | 2010-12-15 | 1 | -21/+21 |
| | | | | | | | * rename method names (actually in tests) * rename instance variable @_named_scopes_cache to @_scopes_cache * rename references in doc comments * don't touch CHANGELOG :) | ||||
* | Models should be equals even after destroyed | Santiago Pastorino | 2010-11-16 | 1 | -1/+1 |
| | | | | [#5978 state:committed] | ||||
* | scopes can take an object that responds to `call` | Aaron Patterson | 2010-10-19 | 1 | -0/+6 |
| | |||||
* | Cleanup deprecation warnings in active record | Carlos Antonio da Silva | 2010-09-06 | 1 | -4/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | code gardening: we have assert_(nil|blank|present), more concise, with ↵ | Xavier Noria | 2010-08-17 | 1 | -2/+2 |
| | | | | better default failure messages - let's use them | ||||
* | Dynamic finder method like scoped_by_* create methods so that | Neeraj Singh | 2010-08-03 | 1 | -0/+6 |
| | | | | | | | method_missing is not hit next time. Adding a test for this scenario. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | renaming tests by removing proxy_options from names | Neeraj Singh | 2010-07-21 | 1 | -5/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Push a failing test for issues [#4994] and [#5003]. | José Valim | 2010-06-29 | 1 | -0/+6 |
| | |||||
* | Add scoping and unscoped as the syntax to replace the old with_scope and ↵ | José Valim | 2010-06-29 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with_exclusive_scope. A few examples: * with_scope now should be scoping: Before: Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end After: Comment.where(:post_id => 1).scoping do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end * with_exclusive_scope now should be unscoped: class Post < ActiveRecord::Base default_scope :published => true end Post.all #=> SELECT * FROM posts WHERE published = true Before: Post.with_exclusive_scope do Post.all #=> SELECT * FROM posts end After: Post.unscoped do Post.all #=> SELECT * FROM posts end Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values: Post.unscoped.all #=> SELECT * FROM posts | ||||
* | removes Array#random_element and backports Array#sample from Ruby 1.9, ↵ | Xavier Noria | 2010-06-05 | 1 | -1/+1 |
| | | | | thanks to Marc-Andre Lafortune | ||||
* | Properly cache association_collection#scopes calls having arguments | Pratik Naik | 2010-06-04 | 1 | -0/+13 |
| | |||||
* | Change on Array extension from rand => random_element [#4555 state:committed] | Santiago Pastorino | 2010-05-16 | 1 | -1/+1 |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | STI should not ignore type condition while applying scopes from parent class ↵ | Neeraj Singh | 2010-05-15 | 1 | -0/+5 |
| | | | | | | | | scopes [#4507 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Reset named scope cache whenever the @target is reset | Pratik Naik | 2010-04-07 | 1 | -0/+10 |
| | |||||
* | Memoize association.named_scope calls | Pratik Naik | 2010-04-05 | 1 | -0/+9 |
| | |||||
* | Named scopes shouldn't test equality using to_a if it's not an Array, this ↵ | Emilio Tagua | 2010-03-30 | 1 | -3/+9 |
| | | | | | | was causing records to be loaded before they were needed. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | defining a named_scope which overwrites an existing method is now allowed we ↵ | Matthew Rudy Jacobs | 2010-03-28 | 1 | -2/+15 |
| | | | | | | | | | just log a warning. This was motivated by the fact that :open is defined on all classes as such the named_scope "open" can never be used, without hacking ActiveRecord with an "undef_method" [#4083 state:resolved] Signed-off-by: wycats <wycats@gmail.com> | ||||
* | cleaning up a bunch of parse time warnings in AR [#4186 state:resolved] | Aaron Patterson | 2010-03-15 | 1 | -2/+2 |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Allow calling class methods on a Relation | Pratik Naik | 2010-01-22 | 1 | -0/+9 |
| | |||||
* | Give preference to to_a over arel from Relation#method_missing | Pratik Naik | 2010-01-19 | 1 | -0/+6 |
| | |||||
* | Rename named_scope to scope | Pratik Naik | 2010-01-18 | 1 | -1/+5 |
| | |||||
* | Inherit named scope class Scope from Relation | Pratik Naik | 2010-01-18 | 1 | -11/+6 |
| | |||||
* | Ensure that Scope#proxy_scope is always klass. Rename proxy_scope to klass too. | Pratik Naik | 2010-01-18 | 1 | -4/+4 |
| | |||||
* | Make sure named_scope names are not used as method names already | Pratik Naik | 2010-01-17 | 1 | -5/+11 |
| | |||||
* | Add new finder methods to association collection. | Pratik Naik | 2009-12-27 | 1 | -2/+2 |
| | |||||
* | Merge commit 'rails/master' | Emilio Tagua | 2009-08-10 | 1 | -0/+6 |
|\ | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/calculations.rb activerecord/lib/active_record/connection_adapters/mysql_adapter.rb activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb | ||||
| * | Prevent overwriting of table name in merging SQL conditions [#2949 ↵ | Tristan Dunn | 2009-08-10 | 1 | -0/+6 |
| | | | | | | | | state:resolved] | ||||
* | | Merge commit 'rails/master' | Emilio Tagua | 2009-08-08 | 1 | -1/+2 |
|\| | | | | | | | | | | | Conflicts: activerecord/test/cases/adapter_test.rb activerecord/test/cases/method_scoping_test.rb | ||||
| * | always sort lists by id before comparison to avoid errors because of ↵ | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+2 |
| | | | | | | | | different sorting of same results (on Oracle database) | ||||
* | | Merge commit 'rails/master' | Emilio Tagua | 2009-07-31 | 1 | -4/+0 |
|\| | | | | | | | | | Conflicts: activerecord/lib/active_record/associations.rb | ||||
| * | Revert "Methods invoked within named scope Procs should respect the scope ↵ | Jeremy Kemper | 2009-07-29 | 1 | -4/+0 |
| | | | | | | | | | | | | | | | | | | | | stack. [#1267 state:resolved]" This reverts commit 6a13376525f34a00e013fc3a6022838329dfe856. Conflicts: activerecord/test/cases/named_scope_test.rb | ||||
* | | Introduced ActiveRecord::Relation, a layer between an ARel relation and an ↵ | Emilio Tagua | 2009-07-21 | 1 | -4/+4 |
|/ | | | | AR relation |