Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Replace rudimentary named_scope with scope. [#6052 state:resolved] | Pavel Gorbokon | 2010-12-15 | 1 | -21/+21 |
| | | | | | | | * rename method names (actually in tests) * rename instance variable @_named_scopes_cache to @_scopes_cache * rename references in doc comments * don't touch CHANGELOG :) | ||||
* | Models should be equals even after destroyed | Santiago Pastorino | 2010-11-16 | 1 | -1/+1 |
| | | | | [#5978 state:committed] | ||||
* | scopes can take an object that responds to `call` | Aaron Patterson | 2010-10-19 | 1 | -0/+6 |
| | |||||
* | Cleanup deprecation warnings in active record | Carlos Antonio da Silva | 2010-09-06 | 1 | -4/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | code gardening: we have assert_(nil|blank|present), more concise, with ↵ | Xavier Noria | 2010-08-17 | 1 | -2/+2 |
| | | | | better default failure messages - let's use them | ||||
* | Dynamic finder method like scoped_by_* create methods so that | Neeraj Singh | 2010-08-03 | 1 | -0/+6 |
| | | | | | | | method_missing is not hit next time. Adding a test for this scenario. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | renaming tests by removing proxy_options from names | Neeraj Singh | 2010-07-21 | 1 | -5/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Push a failing test for issues [#4994] and [#5003]. | José Valim | 2010-06-29 | 1 | -0/+6 |
| | |||||
* | Add scoping and unscoped as the syntax to replace the old with_scope and ↵ | José Valim | 2010-06-29 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with_exclusive_scope. A few examples: * with_scope now should be scoping: Before: Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end After: Comment.where(:post_id => 1).scoping do Comment.first #=> SELECT * FROM comments WHERE post_id = 1 end * with_exclusive_scope now should be unscoped: class Post < ActiveRecord::Base default_scope :published => true end Post.all #=> SELECT * FROM posts WHERE published = true Before: Post.with_exclusive_scope do Post.all #=> SELECT * FROM posts end After: Post.unscoped do Post.all #=> SELECT * FROM posts end Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values: Post.unscoped.all #=> SELECT * FROM posts | ||||
* | removes Array#random_element and backports Array#sample from Ruby 1.9, ↵ | Xavier Noria | 2010-06-05 | 1 | -1/+1 |
| | | | | thanks to Marc-Andre Lafortune | ||||
* | Properly cache association_collection#scopes calls having arguments | Pratik Naik | 2010-06-04 | 1 | -0/+13 |
| | |||||
* | Change on Array extension from rand => random_element [#4555 state:committed] | Santiago Pastorino | 2010-05-16 | 1 | -1/+1 |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | STI should not ignore type condition while applying scopes from parent class ↵ | Neeraj Singh | 2010-05-15 | 1 | -0/+5 |
| | | | | | | | | scopes [#4507 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Reset named scope cache whenever the @target is reset | Pratik Naik | 2010-04-07 | 1 | -0/+10 |
| | |||||
* | Memoize association.named_scope calls | Pratik Naik | 2010-04-05 | 1 | -0/+9 |
| | |||||
* | Named scopes shouldn't test equality using to_a if it's not an Array, this ↵ | Emilio Tagua | 2010-03-30 | 1 | -3/+9 |
| | | | | | | was causing records to be loaded before they were needed. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | defining a named_scope which overwrites an existing method is now allowed we ↵ | Matthew Rudy Jacobs | 2010-03-28 | 1 | -2/+15 |
| | | | | | | | | | just log a warning. This was motivated by the fact that :open is defined on all classes as such the named_scope "open" can never be used, without hacking ActiveRecord with an "undef_method" [#4083 state:resolved] Signed-off-by: wycats <wycats@gmail.com> | ||||
* | cleaning up a bunch of parse time warnings in AR [#4186 state:resolved] | Aaron Patterson | 2010-03-15 | 1 | -2/+2 |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Allow calling class methods on a Relation | Pratik Naik | 2010-01-22 | 1 | -0/+9 |
| | |||||
* | Give preference to to_a over arel from Relation#method_missing | Pratik Naik | 2010-01-19 | 1 | -0/+6 |
| | |||||
* | Rename named_scope to scope | Pratik Naik | 2010-01-18 | 1 | -1/+5 |
| | |||||
* | Inherit named scope class Scope from Relation | Pratik Naik | 2010-01-18 | 1 | -11/+6 |
| | |||||
* | Ensure that Scope#proxy_scope is always klass. Rename proxy_scope to klass too. | Pratik Naik | 2010-01-18 | 1 | -4/+4 |
| | |||||
* | Make sure named_scope names are not used as method names already | Pratik Naik | 2010-01-17 | 1 | -5/+11 |
| | |||||
* | Add new finder methods to association collection. | Pratik Naik | 2009-12-27 | 1 | -2/+2 |
| | |||||
* | Merge commit 'rails/master' | Emilio Tagua | 2009-08-10 | 1 | -0/+6 |
|\ | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/calculations.rb activerecord/lib/active_record/connection_adapters/mysql_adapter.rb activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb | ||||
| * | Prevent overwriting of table name in merging SQL conditions [#2949 ↵ | Tristan Dunn | 2009-08-10 | 1 | -0/+6 |
| | | | | | | | | state:resolved] | ||||
* | | Merge commit 'rails/master' | Emilio Tagua | 2009-08-08 | 1 | -1/+2 |
|\| | | | | | | | | | | | Conflicts: activerecord/test/cases/adapter_test.rb activerecord/test/cases/method_scoping_test.rb | ||||
| * | always sort lists by id before comparison to avoid errors because of ↵ | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+2 |
| | | | | | | | | different sorting of same results (on Oracle database) | ||||
* | | Merge commit 'rails/master' | Emilio Tagua | 2009-07-31 | 1 | -4/+0 |
|\| | | | | | | | | | Conflicts: activerecord/lib/active_record/associations.rb | ||||
| * | Revert "Methods invoked within named scope Procs should respect the scope ↵ | Jeremy Kemper | 2009-07-29 | 1 | -4/+0 |
| | | | | | | | | | | | | | | | | | | | | stack. [#1267 state:resolved]" This reverts commit 6a13376525f34a00e013fc3a6022838329dfe856. Conflicts: activerecord/test/cases/named_scope_test.rb | ||||
* | | Introduced ActiveRecord::Relation, a layer between an ARel relation and an ↵ | Emilio Tagua | 2009-07-21 | 1 | -4/+4 |
|/ | | | | AR relation | ||||
* | Add missing models and fixtures [#2673 state:resolved] | Emilio Tagua | 2009-05-19 | 1 | -1/+3 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Implement #many? for NamedScope and AssociationCollection using #size [#1500 ↵ | Chris Kampmeier | 2009-05-17 | 1 | -0/+34 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Cherry-pick core extensions | Jeremy Kemper | 2009-05-13 | 1 | -1/+2 |
| | |||||
* | Returning nil from named scope lambda is equivalent to an empty hash [#1773 ↵ | Elijah Miller | 2009-03-12 | 1 | -0/+6 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure ActiveRecord::Base.find_in_batches fires doesnt fire an extra query ↵ | Pratik Naik | 2009-03-11 | 1 | -1/+1 |
| | | | | unless needed | ||||
* | Add NamedScope#find_each tests [#2201 state:resolved] | Pratik Naik | 2009-03-11 | 1 | -1/+15 |
| | |||||
* | Ensure nested with_scope merges conditions inside out [#2193 state:resolved] | Manfred Stienstra | 2009-03-10 | 1 | -8/+14 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Methods invoked within named scope Procs should respect the scope stack. ↵ | jvoorhis | 2009-03-06 | 1 | -0/+4 |
| | | | | | | [#1267 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed bug that makes named_scopes _forgot_ current scope | Diego Algorta | 2009-02-25 | 1 | -0/+9 |
| | |||||
* | Make sure inner scope conditions get a preference over the outer ones | Pratik Naik | 2009-01-24 | 1 | -0/+20 |
| | |||||
* | Fix named scope tests for sqlite3 [#1667 state:resolved] | Mike Gunderloy | 2008-12-30 | 1 | -1/+1 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Introduce dynamic scopes for ActiveRecord: you can now use class methods ↵ | Yaroslav Markin | 2008-12-28 | 1 | -0/+20 |
| | | | | | | like scoped_by_user_name(user_name) and scoped_by_user_name_and_password(user_name, password) that will use the scoped method with attributes you supply. [#1648 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join ↵ | Pivotal Labs | 2008-09-24 | 1 | -0/+6 |
| | | | | | | | strings to avoid table aliasing problems. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1077 state:committed] | ||||
* | Make NamedScope#size behave identically to AssociationCollection#size. [#933 ↵ | Tom Stuart | 2008-08-29 | 1 | -0/+15 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix parentheses warnings | Michael Koziarski | 2008-08-29 | 1 | -1/+1 |
| | |||||
* | Fix NamedScope regex so methods containing "an" get delegated to ↵ | Jan De Poorter | 2008-08-29 | 1 | -0/+4 |
| | | | | | | proxy_found. [#901 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix incorrect signature for NamedScope#respond_to? [#852 state:resolved] | Tom Lea | 2008-08-21 | 1 | -0/+5 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix generated WHERE IN query for named scopes. [#583 state:resolved] | Philip Hallstrom | 2008-08-21 | 1 | -0/+5 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> |