Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | make `change_column_null` reversible. Closes #13576. | Yves Senn | 2014-01-08 | 1 | -0/+16 |
| | | | | Closes #13623. | ||||
* | Make change_table use object of current database adapter | Nishant Modak | 2014-01-07 | 1 | -1/+2 |
| | | | | | | | | | - Earlier, change_table was creating database-agnostic object. - After this change, it will create correct object based on current database adapter. - This will ensure that create_table and change_table will get same objects. - This makes update_table_definition method public and nodoc. - Fixes #13577 and #13503 | ||||
* | Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵ | Vipul A M | 2013-12-18 | 1 | -1/+1 |
| | | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt | ||||
* | Remove more skip | Rafael Mendonça França | 2013-11-08 | 2 | -9/+7 |
| | |||||
* | Don't skip tests if we don't need to. | Rafael Mendonça França | 2013-11-08 | 6 | -132/+119 |
| | | | | | | | We can conditional define the tests depending on the adapter or connection. Lets keep the skip for fail tests that need to be fixed. | ||||
* | Make 'enable_extension' revertible | Eric Tipton | 2013-08-10 | 1 | -0/+10 |
| | | | | | If 'enable_extension' is used in a migration's 'change' method, use 'disable_extension' on down migration (and vice-versa). | ||||
* | removes the obsolete private method column_methods_hash [Closes #11406] | Xavier Noria | 2013-07-16 | 1 | -15/+6 |
| | |||||
* | Removed unused test for DateTime.local_offset | Arun Agrawal | 2013-07-07 | 1 | -20/+0 |
| | | | | see discussion here #11274 | ||||
* | Fixes #10432 add_column not creating array columns in PostgreSQL | Adam Anderson | 2013-06-04 | 1 | -0/+29 |
| | | | | | | When then PostgreSQL visitor was [added](https://github.com/rails/rails/commit/6b7fdf3bf3675a14eae74acc5241089308153a34) `add_column` was no longer receiving the column options directly. This caused the options to be lost along the way. | ||||
* | Remove behavior that deals with a string as third argument of `add_index`, ↵ | kennyj | 2013-06-02 | 1 | -10/+0 |
| | | | | | | because this was deprecated. Some testcases is failed, so I replaced nil to empty hash in add_reference. | ||||
* | Fix class and method name typos | Vipul A M | 2013-05-12 | 1 | -1/+1 |
| | |||||
* | anual_salary => annual_salary | Vipul A M | 2013-03-28 | 1 | -3/+3 |
| | |||||
* | respect auto_increment in rename_column for mysql | Vipul A M | 2013-03-27 | 1 | -0/+7 |
| | |||||
* | transactions can be turned off per Migration. | Yves Senn | 2013-03-05 | 1 | -1/+1 |
| | | | | | | | | | | | Closes #9483. There are SQL Queries that can't run inside a transaction. Since the Migrator used to wrap all Migrations inside a transaction there was no way to run these queries within a migration. This patch adds `self.disable_ddl_transaction!` to the migration to turn transactions off when necessary. | ||||
* | Oracle enhanced adapter shortens its name if it is longer than 30 bytes | Yasuo Honda | 2013-02-24 | 1 | -2/+10 |
| | | | | because of Oracle database index length spec. | ||||
* | also rename the test-case class inside columns_test.rb | Yves Senn | 2013-02-24 | 1 | -1/+1 |
| | |||||
* | rename_column_test.rb -> columns_test.rb to reveal intent. | Yves Senn | 2013-02-23 | 1 | -0/+0 |
| | | | | | | | | I renamed the test to better communicate it's intention. Since it also tests: - add_column - remove_column - change_column There is no reason to call it rename_column_test. | ||||
* | forwardport #9388 rename/remove column preserves custom PK. | Yves Senn | 2013-02-23 | 1 | -1/+15 |
| | |||||
* | Fix warning | Rafael Mendonça França | 2013-02-21 | 1 | -1/+1 |
| | |||||
* | also rename indexes when a table or column is renamed | Yves Senn | 2013-02-20 | 2 | -3/+34 |
| | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed. | ||||
* | reserve index name chars for internal rails operations | Yves Senn | 2013-02-20 | 2 | -5/+34 |
| | | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved. | ||||
* | Remove extra sort from test | Vipul A M | 2013-01-21 | 1 | -3/+3 |
| | | | | Cleanup change_schema tests to remove extra sorts on columns. | ||||
* | Standardize the use of current_adapter? | Rafael Mendonça França | 2013-01-01 | 1 | -2/+2 |
| | |||||
* | Address a failure test_remove_column_with_multi_column_index with Oracle ↵ | Yasuo Honda | 2013-01-02 | 1 | -2/+3 |
| | | | | | | | database Not only PostgreSQL, Oracle database adapter drops the multi-column index if any of the indexed columns dropped by remove_column. | ||||
* | Alias refute methods to assert_not and perfer assert_not on tests | Rafael Mendonça França | 2012-12-31 | 5 | -26/+26 |
| | |||||
* | Add active_support/testing/autorun | Rafael Mendonça França | 2012-12-31 | 1 | -0/+1 |
| | | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails | ||||
* | work off FIXME comments in AR rename_column_test.rb | Yves Senn | 2012-12-28 | 1 | -9/+22 |
| | | | | | | There were a couple of tests, which had FIXME comments in palce of assertions. I replaced these FIXME comments with actual assertions to get more feedback from our test suite. | ||||
* | Remove duplicated methods in command recorder and duplicated test name | Carlos Antonio da Silva | 2012-12-21 | 1 | -1/+1 |
| | |||||
* | Make execute, change_column and remove_columns methods actually irreversible | Marc-Andre Lafortune | 2012-12-21 | 1 | -1/+7 |
| | | | | [#8267] | ||||
* | Make change_table reversible when possible [#8267] | Marc-Andre Lafortune | 2012-12-21 | 1 | -0/+20 |
| | |||||
* | Factorize methods that are easily reversible [#8267] | Marc-Andre Lafortune | 2012-12-21 | 1 | -8/+8 |
| | |||||
* | Make remove_index reversible [#8267] | Marc-Andre Lafortune | 2012-12-21 | 1 | -3/+24 |
| | |||||
* | Differentiate between remove_column and remove_columns. Make remove_column ↵ | Marc-Andre Lafortune | 2012-12-21 | 2 | -3/+14 |
| | | | | | | reversible. [#8267] | ||||
* | Make drop_table reversible [#8267] | Marc-Andre Lafortune | 2012-12-21 | 1 | -11/+24 |
| | |||||
* | Add drop_join_table [#8267] | Marc-Andre Lafortune | 2012-12-21 | 2 | -4/+52 |
| | |||||
* | Allow reverting of migration commands with Migration#revert [#8267] | Marc-Andre Lafortune | 2012-12-21 | 1 | -48/+51 |
| | |||||
* | Simplify change_table and avoid duplicated logic | Marc-Andre Lafortune | 2012-12-21 | 1 | -26/+5 |
| | |||||
* | Keep index names when using with sqlite3 | Yves Senn | 2012-12-19 | 1 | -0/+10 |
| | |||||
* | Move to the schema-migrations-metadata branch. | Jeremy Kemper | 2012-12-09 | 2 | -2/+24 |
| | | | | | | | | | | | | | | | | | | | | | | | | Pending work on graceful app upgrades. Revert "Merge pull request #8439 from joshsusser/fixes" This reverts commit ce8ac39338f86388e70356b3a470b3ea443802ae, reversing changes made to b0e7b6f67c984d4b1502e801781ed75fad681633. Revert "Merge pull request #8431 from joshsusser/schemadump" This reverts commit 036d3e1c2b65c4b8cbd23de2e20ad67b9b756182, reversing changes made to 0c692f4d121792117b6a71e5ed590a31c3b9d12e. Revert "Merge branch 'joshsusser-master' into merge" This reverts commit 0c692f4d121792117b6a71e5ed590a31c3b9d12e, reversing changes made to 2e299fca715b083a60222a85e48f9d3b8dd8ce93. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/schema_dumper_test.rb | ||||
* | Remove method redefined warnings | Carlos Antonio da Silva | 2012-12-06 | 1 | -1/+1 |
| | |||||
* | Add metadata to schema_migrations | Josh Susser | 2012-12-01 | 2 | -25/+3 |
| | | | | | migrated_at: timestamp when migration run fingerprint: md5 hash of migration source name: filename without version or extension | ||||
* | Move migration test together with other join table tests | Carlos Antonio da Silva | 2012-11-21 | 1 | -0/+6 |
| | |||||
* | Initialize accessors to remove some warnings in Ruby 2.0 | Carlos Antonio da Silva | 2012-11-19 | 1 | -4/+2 |
| | |||||
* | Add rename_index to change_table. | Jarek Radosz | 2012-11-19 | 1 | -0/+7 |
| | |||||
* | Check if the options value is present before to send the deprecation | Rafael Mendonça França | 2012-11-03 | 1 | -2/+2 |
| | | | | message | ||||
* | Deprecate passing a string as third argument of `add_index` | Rafael Mendonça França | 2012-11-02 | 1 | -0/+10 |
| | | | | | | | This was there due historical reasons since 7dc45818dc43c163700efc9896a0f3feafa31138 to give the user the possibility to create unique indexes passing "UNIQUE" as the third argument | ||||
* | Raise an ArgumentError when passing an invalid option to add_index | Rafael Mendonça França | 2012-11-02 | 1 | -0/+6 |
| | | | | Closes #8104 | ||||
* | raise `ArgumentError` when redefining the primary key column. Closes #6378 | Yves Senn | 2012-10-28 | 1 | -0/+20 |
| | |||||
* | Cleanup trailing whitespaces | dfens | 2012-10-12 | 1 | -1/+1 |
| | |||||
* | column default extraction should handle newlines. | Aaron Patterson | 2012-08-17 | 1 | -0/+8 |
| | | | | Fixes #7374 |