Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix invalid schema dump when primary key column has a comment | Guilherme Goettems Schneider | 2019-06-03 | 1 | -1/+21 |
| | | | | | | | | Before this fix it would either generate an invalid schema, passing `comment` option twice to `create_table`, or it move the comment from primary key column to the table if table had no comment when the dump was generated. The situation now is that a comment on primary key will be ignored (not present on schema). Fixes #29966 | ||||
* | Fix table comment also being applied to the primary key column | Guilherme Goettems Schneider | 2019-05-31 | 1 | -0/+5 |
| | |||||
* | Return nil if table comment is blank | Ryuta Kamizono | 2017-09-22 | 1 | -1/+1 |
| | |||||
* | Implement change_table_comment and change_column_comment for MySql Adapter | Alecs Popa | 2017-09-22 | 1 | -0/+22 |
| | |||||
* | Prefer to place a table options before `force: :cascade` (#28005) | Ryuta Kamizono | 2017-08-27 | 1 | -1/+1 |
| | | | | | | I was added a table options after `force: :cascade` in #17569 for not touching existing tests (reducing diff). But `force: :cascade` is not an important information. So I prefer to place a table options before `force: :cascade`. | ||||
* | Remove redundant `unless current_adapter?(:OracleAdapter)` | Ryuta Kamizono | 2017-07-28 | 1 | -2/+0 |
| | |||||
* | Merge pull request #28695 from koic/integer_type_has_precision_option_in_oracle | Akira Matsuda | 2017-07-27 | 1 | -1/+5 |
|\ | | | | | Fix an AR test of schema dump when using Oracle | ||||
| * | Fix an AR test of schema dump when using Oracle | Koichi ITO | 2017-04-07 | 1 | -1/+5 |
| | | |||||
* | | Use frozen-string-literal in ActiveRecord | Kir Shatrov | 2017-07-19 | 1 | -0/+2 |
| | | |||||
* | | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
|/ | |||||
* | Ignore AR tests of index comment when using Oracle | Koichi ITO | 2017-04-05 | 1 | -5/+9 |
| | |||||
* | Omit redundant `using: :btree` for schema dumping | Ryuta Kamizono | 2017-02-13 | 1 | -1/+1 |
| | |||||
* | Fix that `change_column` lose a comment | Ryuta Kamizono | 2016-12-05 | 1 | -2/+1 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -104/+104 |
| | |||||
* | applies new string literal convention in activerecord/test | Xavier Noria | 2016-08-06 | 1 | -33/+33 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Treat blank comments as no comment for indexes | Ryuta Kamizono | 2016-04-29 | 1 | -1/+10 |
| | | | | | | Follow up of 1683410. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | Dump indexes in `create_table` for generates SQL in one query | Ryuta Kamizono | 2016-04-20 | 1 | -2/+2 |
| | | | | | If the adapter supports indexes in create table, it generates SQL in one query. | ||||
* | Remove unecessary comment | Jon Moss | 2016-04-19 | 1 | -1/+1 |
| | |||||
* | Database comments: Treat blank comments as no comment. Don't dump blank ↵ | Jeremy Daer | 2016-04-19 | 1 | -55/+96 |
| | | | | comments. | ||||
* | Database comments: switch to keyword args for new table options | Jeremy Daer | 2016-04-18 | 1 | -3/+1 |
| | | | | | | * Switch to keyword args where we can without breaking compat. * Use add_table_options! for :options, too. * Some code polish. | ||||
* | Add support for specifying comments for tables, columns, and indexes. | Andrey Novikov | 2016-04-16 | 1 | -0/+91 |
Comments are specified in migrations, stored in database itself (in its schema), and dumped into db/schema.rb file. This allows to generate good documentation and explain columns and tables' purpose to everyone from new developers to database administrators. For PostgreSQL and MySQL only. SQLite does not support comments at the moment. See docs for PostgreSQL: http://www.postgresql.org/docs/current/static/sql-comment.html See docs for MySQL: http://dev.mysql.com/doc/refman/5.7/en/create-table.html |