Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Do not serialize nil in serialized attribute. | Kirill Lashuk | 2012-01-31 | 1 | -1/+14 |
| | |||||
* | Merge pull request #4742 from petervandenabeele/master | Aaron Patterson | 2012-01-31 | 1 | -0/+3 |
|\ | | | | | Set the timezone correctly for a test in activerecord/../base_test.rb | ||||
| * | Set default_timezone explicitly for a test in activerecord/../base_test.rb | Peter Vandenabeele | 2012-01-29 | 1 | -0/+3 |
| | | |||||
* | | Replaced all 'for' loops with Enumerable#each | Nathan Broadbent | 2012-01-30 | 1 | -1/+1 |
|/ | |||||
* | call to_s on value passed to table_name= | Sergey Nartimov | 2012-01-26 | 1 | -0/+5 |
| | |||||
* | Merge pull request #4558 from stephencelis/type-cast-unknown-should-fail | Aaron Patterson | 2012-01-23 | 1 | -5/+3 |
|\ | | | | | Don't type-cast unknown types to YAML. | ||||
| * | Don't type-cast unknown types to YAML. | Stephen Celis | 2012-01-20 | 1 | -5/+3 |
| | | |||||
* | | Fix typo | Jari Jokinen | 2012-01-22 | 1 | -1/+1 |
| | | |||||
* | | change AR default_timezone to :utc since it's the default for AR::Railtie | Akira Matsuda | 2012-01-21 | 1 | -2/+2 |
|/ | |||||
* | adding tests for previous_changes hash | Aaron Patterson | 2012-01-19 | 1 | -0/+25 |
| | |||||
* | Fix table_name in ActiveRecord with more than one abstract ancestors | Piotr Sarnacki | 2012-01-12 | 1 | -0/+11 |
| | | | | | | | | | | | | | | | | | When subclassing abstract_class table_name should be always computed based on class name, no matter if superclass is subclassing base or another abstract_class. So: class FirstAbstract < ActiveRecord::Base self.abstract_class = true end class SecondAbstract < FirstAbstract self.abstract_class = true end class Post < SecondAbstract self.table_name #=> 'posts' (not 'second_abstracts') end | ||||
* | Support establishing connection on ActiveRecord::Model. | Jon Leighton | 2011-12-28 | 1 | -4/+15 |
| | | | | | This is the 'top level' connection, inherited by any models that include ActiveRecord::Model or inherit from ActiveRecord::Base. | ||||
* | Ensure attribute methods are included after all the AR stuff | Jon Leighton | 2011-12-24 | 1 | -0/+1 |
| | |||||
* | Fix #4046. | Jon Leighton | 2011-12-23 | 1 | -0/+1 |
| | |||||
* | serialize fails on subclass | Alvaro Bautista | 2011-12-23 | 1 | -1/+21 |
| | |||||
* | remove deprecated set and original methods for table_name, primary_key, etc | Sergey Nartimov | 2011-12-21 | 1 | -161/+0 |
| | |||||
* | Removed test which works only < 1.9 | Arun Agrawal | 2011-12-21 | 1 | -16/+0 |
| | |||||
* | No Ruby 1.8 stuff. No more checks in code. | Arun Agrawal | 2011-12-21 | 1 | -15/+0 |
| | |||||
* | remove more uses of deprecated loggers | Karunakar (Ruby) | 2011-12-21 | 1 | -2/+2 |
| | |||||
* | remove more uses of deprecated logger methods | Aaron Patterson | 2011-12-19 | 1 | -4/+2 |
| | |||||
* | Don't store defaults in the schema cache | Jon Leighton | 2011-12-16 | 1 | -0/+1 |
| | |||||
* | Cache columns at the model level. | Jon Leighton | 2011-12-16 | 1 | -2/+2 |
| | | | | Allows two models to use the same table but have different primary keys. | ||||
* | Split out most of the AR::Base code into separate modules :cake: | Jon Leighton | 2011-12-15 | 1 | -13/+0 |
| | |||||
* | Fix sequence name with abstract classes. | Edgars Beigarts | 2011-12-04 | 1 | -0/+10 |
| | |||||
* | Create method with known identifier then alias into place. | Jon Leighton | 2011-12-01 | 1 | -0/+2 |
| | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.) | ||||
* | Deprecated `define_attr_method` in `ActiveModel::AttributeMethods` | Jon Leighton | 2011-11-29 | 1 | -21/+12 |
| | | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated. | ||||
* | Deprecate set_primary_key in favour of self.primary_key= | Jon Leighton | 2011-11-29 | 1 | -2/+26 |
| | |||||
* | Make sure the original_foo accessor still works (but deprecated) if we are ↵ | Jon Leighton | 2011-11-29 | 1 | -7/+55 |
| | | | | using self.foo= | ||||
* | Deprecate set_sequence_name in favour of self.sequence_name= | Jon Leighton | 2011-11-29 | 1 | -2/+6 |
| | |||||
* | Add tests for set_sequence_name etc | Jon Leighton | 2011-11-29 | 1 | -0/+22 |
| | |||||
* | Deprecate set_inheritance_column in favour of self.inheritance_column= | Jon Leighton | 2011-11-29 | 1 | -2/+7 |
| | |||||
* | Deprecate set_table_name in favour of self.table_name= or defining your own ↵ | Jon Leighton | 2011-11-29 | 1 | -7/+20 |
| | | | | method. | ||||
* | Merge pull request #3636 from joshsusser/master | Jon Leighton | 2011-11-29 | 1 | -0/+9 |
|\ | | | | | association methods are now generated in modules | ||||
| * | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 1 | -0/+9 |
| | | |||||
* | | `ActiveRecord::Base#becomes` should retain the errors of the original object. | James Adam | 2011-11-16 | 1 | -0/+8 |
|/ | | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance. | ||||
* | Add ActiveRecord::Relation#uniq for toggling DISTINCT in the SQL query | Jon Leighton | 2011-11-05 | 1 | -0/+6 |
| | |||||
* | Revert "Raise error on unknown primary key." | Jon Leighton | 2011-10-05 | 1 | -0/+4 |
| | | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07. | ||||
* | Raise error on unknown primary key. | Jon Leighton | 2011-10-05 | 1 | -4/+0 |
| | | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307. | ||||
* | Rename first_or_new to first_or_initialize. | Jon Leighton | 2011-09-13 | 1 | -10/+2 |
| | | | | | For consistency with find_or_initialize_by. Also remove first_or_build alias. | ||||
* | Add missing require in base_test.rb, fixes isolated test | Guillermo Iguaran | 2011-09-09 | 1 | -0/+1 |
| | |||||
* | Merge pull request #2757 from andmej/first_or_create_pull_request | Jon Leighton | 2011-09-08 | 1 | -0/+31 |
|\ | | | | | Add first_or_create family of methods to Active Record | ||||
| * | Adding first_or_create, first_or_create!, first_or_new and first_or_build to ↵ | Andrés Mejía | 2011-08-30 | 1 | -0/+31 |
| | | | | | | | | | | | | | | | | | | | | Active Record. This let's you write things like: User.where(:first_name => "Scarlett").first_or_create!(:last_name => "Johansson", :hot => true) Related to #2420. | ||||
* | | Disable active record marshalling tests on Ruby 1.8.7 on Travis CI, as they ↵ | Jon Leighton | 2011-09-06 | 1 | -0/+15 |
| | | | | | | | | have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys. | ||||
* | | Need to add here to pass the test | Arun Agrawal | 2011-09-03 | 1 | -0/+1 |
|/ | | | As in previous commit it's removed. | ||||
* | Merge pull request #2750 from rsim/fix_test_column_names_are_escaped_for_oracle | Jon Leighton | 2011-08-30 | 1 | -1/+7 |
| | | | | Fix test column names are escaped for oracle | ||||
* | do not compute table names for abstract classes | Akira Matsuda | 2011-08-24 | 1 | -0/+4 |
| | |||||
* | prevent sql injection attacks by escaping quotes in column names | Aaron Patterson | 2011-08-16 | 1 | -0/+17 |
| | |||||
* | Work around for lolruby bug. (Read on for explanation.) | Jon Leighton | 2011-08-13 | 1 | -3/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were experiencing CI test failures, for example: * 3-1-stable: http://travis-ci.org/#!/rails/rails/builds/79473/L407 * master: http://travis-ci.org/#!/rails/rails/builds/79507/L80 These failures only happened on 1.8.7-p352, and we were only able to reproduce on the Travis CI VM worker. We even tried creating a new 32 bit Ubuntu VM and running the tests on that, and it all worked fine. After some epic trial and error, we discovered that replacing the following: fuu = Marshal.load(Marshal.dump(fuu)) with: marshalled = Marshal.dump(fuu) fuu = Marshal.load(marshalled) seemed to prevent the failure. We have NO IDEA why this is. If anyone has some great insight to contribute then that is welcome. Otherwise, hopefully this will just help us get the CI green again. Many thanks to @joshk for help with sorting this out. | ||||
* | Fully marshal AR::Base objects. Fixes #2431. | Jon Leighton | 2011-08-08 | 1 | -0/+13 |
| | |||||
* | Make it the responsibility of the connection to hold onto an ARel visitor ↵ | Jon Leighton | 2011-08-08 | 1 | -19/+0 |
| | | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now. |