Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Fix broken test. You know, the merge button will be the end of us... | Jon Leighton | 2011-06-01 | 1 | -3/+3 | |
| | ||||||
* | Adding comment | Arun Agrawal | 2011-06-01 | 1 | -0/+1 | |
| | ||||||
* | AttributeMethodTest test fix #jruby | Vishnu Atrai | 2011-06-01 | 1 | -1/+5 | |
| | ||||||
* | Test AR::Base#inspect on an allocated object not yet initialized | Franck Verrot | 2011-05-25 | 1 | -0/+8 | |
| | ||||||
* | Undo performances regressions I introduced in ↵ | Jon Leighton | 2011-04-15 | 1 | -0/+11 | |
| | | | | bbe0a507f287c20ab4ae8a244fbfc810665deda5 and add test for an edge case. Add comments to explain the intent of the code. | |||||
* | Remove unnecessary code from define_read_method and add assertion to make ↵ | Jon Leighton | 2011-04-15 | 1 | -0/+1 | |
| | | | | sure the underscored version is actually generated | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 | |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | |||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 | |
| | | | | suggestion! | |||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 | |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | |||||
* | cleaning up typecast test a little | Aaron Patterson | 2011-03-26 | 1 | -6/+8 | |
| | ||||||
* | refactoring tz to a variable rather than repeating it | Aaron Patterson | 2011-03-26 | 1 | -2/+4 | |
| | ||||||
* | adding a test for attributes after type cast. thanks nragaz. :heart: | Aaron Patterson | 2011-03-26 | 1 | -0/+17 | |
| | ||||||
* | fixing whitespace errors. :bomb: | Aaron Patterson | 2011-03-25 | 1 | -2/+2 | |
| | ||||||
* | Fix before_type_cast for timezone aware attributes by caching converted ↵ | Adam Meehan | 2011-03-23 | 1 | -15/+11 | |
| | | | | value on write. Also remove read method reload arg on timezone attributes. | |||||
* | bugfix for serialized_attributes to be class specific | Raimonds Simanovskis | 2011-02-09 | 1 | -0/+5 | |
| | | | | previously serialized_attributes were kept as class attribute of ActiveRecord::Base - if some attribute was defined as serialized in one subclass then it was serialized in all other subclasses as well (if it had the same name) | |||||
* | do not to_s where you are testing that a string value is stored for the ↵ | Akira Matsuda | 2011-02-07 | 1 | -1/+1 | |
| | | | | | | before_type_cast Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | avoid nil.dup | Akira Matsuda | 2011-02-07 | 1 | -0/+8 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | fix for test_read_attributes_before_type_cast_on_datetime - Oracle adapter ↵ | Raimonds Simanovskis | 2011-02-02 | 1 | -2/+2 | |
| | | | | also returns Time value | |||||
* | Make before_type_cast available for datetime fields | Akira Matsuda | 2011-02-01 | 1 | -16/+15 | |
| | | | | | | [#3973 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Add test for e0e3adf | Jeremy Kemper | 2011-01-07 | 1 | -0/+6 | |
| | ||||||
* | Allow primary_key to be an attribute when the model is a new record | Santiago Pastorino | 2010-12-28 | 1 | -1/+1 | |
| | ||||||
* | fixing space errors | Aaron Patterson | 2010-12-02 | 1 | -3/+1 | |
| | ||||||
* | Work around a strange piece of Syck behaviour where it checks ↵ | Michael Koziarski | 2010-12-02 | 1 | -0/+11 | |
| | | | | | | Model#respond_to? before initializing the object. Things like YAML.load(YAML.dump(@post)) won't work without this. | |||||
* | removing many unused variables | Aaron Patterson | 2010-11-16 | 1 | -1/+1 | |
| | ||||||
* | mysql tests are mostly passing | Aaron Patterson | 2010-10-26 | 1 | -3/+3 | |
| | ||||||
* | Fewer object allocations | Jeremy Kemper | 2010-09-09 | 1 | -3/+3 | |
| | ||||||
* | Cache unserialized attributes | Jeremy Kemper | 2010-09-09 | 1 | -9/+12 | |
| | ||||||
* | Do not use time zone in test_read_attributes_before_type_cast_on_datetime ↵ | Raimonds Simanovskis | 2010-08-22 | 1 | -3/+3 | |
| | | | | | | for Oracle database As currently string_to_time method is not doing time zone conversion to database time zone | |||||
* | Both tests are using the same model, move the model to another file and add ↵ | Santiago Pastorino | 2010-08-14 | 1 | -1/+2 | |
| | | | | the missing require | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -4/+4 | |
| | | | | 's/[ \t]*$//' -i {} \;) | |||||
* | ignore this test for mysql2 | Brian Lopez | 2010-08-09 | 1 | -13/+15 | |
| | ||||||
* | Making Active Record base_test.rb thinner by moving tests | Neeraj Singh | 2010-08-03 | 1 | -2/+276 | |
| | | | | | | | | | | | | to relevant files. Number of assertions before refactoring: 2391 tests, 7579 assertions, 0 failures, 0 errors Number of assertions after refactoring: 2391 tests, 7579 assertions, 0 failures, 0 errors Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Use better assertion methods for testing | Neeraj Singh | 2010-05-19 | 1 | -1/+1 | |
| | | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | 1=2 is invalid expression in Oracle SELECT | Raimonds Simanovskis | 2009-08-06 | 1 | -2/+12 | |
| | ||||||
* | Extract generic attribute method generation to AMo | Joshua Peek | 2009-08-04 | 1 | -47/+0 | |
| | ||||||
* | Modified ActiveRecord::AttributeMethods to allow classes to specify ↵ | Paul Gillard | 2009-08-04 | 1 | -15/+79 | |
| | | | | | | attribute method prefixes and/or suffixes. Previously only suffixes were allowed. Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Undefine id and let it automatically be generated | Joshua Peek | 2009-07-30 | 1 | -4/+0 | |
| | ||||||
* | Restore DangerousAttributeError | Joshua Peek | 2009-07-30 | 1 | -0/+14 | |
| | ||||||
* | Generate methods for all suffixes | Joshua Peek | 2009-07-30 | 1 | -14/+0 | |
| | ||||||
* | Make it so AR attributes which conflict with object-private methods (e.g. ↵ | Sam Goldstein | 2009-07-09 | 1 | -0/+16 | |
| | | | | | | | | | system) don't 'randomly' cause NoMethodErrors Previously if you called this attribute before others, you'd get exceptions. But if it was the second-or-subsequent attribute you retrieved you'd get the correct behaviour. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2808 state:committed] | |||||
* | Ruby 1.9 compat: rename deprecated assert_raises to assert_raise. | Jeremy Kemper | 2009-03-08 | 1 | -1/+1 | |
| | | | | [#1617 state:resolved] | |||||
* | Support true/false in query_attribute for calculated columns | Max Lapshin | 2009-02-06 | 1 | -0/+12 | |
| | | | | | Signed-off-by: Tarmo Tänav <tarmo@itech.ee> Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | "raise NoMethodError" raises NoMethodError. Raise it with NoMethodError.new ↵ | Mike Gunderloy | 2008-10-25 | 1 | -4/+7 | |
| | | | | | | instead. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Changed ActiveRecord attributes to respect access control. | Adam Milligan | 2008-09-24 | 1 | -4/+47 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1084 state:committed] | |||||
* | Base.skip_time_zone_conversion_for_attributes uses ↵ | miloops | 2008-09-14 | 1 | -0/+9 | |
| | | | | class_inheritable_accessor, so that subclasses don't overwrite Base [#346 state:resolved] | |||||
* | Fix file permissions | Tarmo Tänav | 2008-07-31 | 1 | -0/+0 | |
| | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Namespace Inflector, Dependencies, OrderedOptions, and TimeZone under ↵ | Joshua Peek | 2008-06-03 | 1 | -10/+10 | |
| | | | | ActiveSupport [#238 state:resolved] | |||||
* | ActiveRecord time zone aware attributes: blank string is treated as nil when ↵ | gbuesing | 2008-05-08 | 1 | -0/+8 | |
| | | | | assigned to writer | |||||
* | Fix Time.zone.parse from stripping time zone information and make Time aware ↵ | Scott Fleckenstein | 2008-05-08 | 1 | -0/+27 | |
| | | | | attribute methods use Time.zone.parse instead of to_time | |||||
* | Removing unnecessary uses_tzinfo helper from tests, given that TZInfo is now ↵ | Geoff Buesing | 2008-03-30 | 1 | -39/+37 | |
| | | | | | | bundled git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |