aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | Don't save through records twiceSean Griffin2014-06-171-0/+19
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | If the through record gets created in an `after_create` hook that is defined before the association is defined (therefore after its `after_create` hook) get saved twice. This ensures that the through records are created only once, regardless of the order of the hooks.
* | | | | Merge pull request #15747 from sgrif/sg-trolololol-this-is-so-brokenRafael Mendonça França2014-06-191-0/+30
|\ \ \ \ \ | | | | | | | | | | | | Always update counter caches in memory when adding records
| * | | | | Always update counter caches in memory when adding recordsSean Griffin2014-06-161-0/+30
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before, calling `size` would only work if it skipped the cache, and would return a different result from the cache, but only if: - The association was previously loaded - Or you called size previously - But only if the size was 0 when you called it This ensures that the counter is appropriately updated in memory.
* | | | | Merge pull request #15772 from nbudin/sti_through_bugRafael Mendonça França2014-06-191-0/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Don't include inheritance column in the through_scope_attributes
| * | | | | Don't include inheritance column in the through_scope_attributesNat Budin2014-06-171-0/+8
| |/ / / /
* | | | | Use a better test descriptionRafael Mendonça França2014-06-191-1/+1
| | | | |
* | | | | Fix has_and_belongs_to_many in a namespaced model pointing to a non ↵Rafael Mendonça França2014-06-191-0/+9
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | namespaced model Now the following case will work fine class Tag < ActiveRecord::Base end class Publisher::Article < ActiveRecord::Base has_and_belongs_to_many :tags end Fixes #15761
* | | | Merge pull request #15343 from dontfidget/fix_polymorphic_automatic_inverse_ofRafael Mendonça França2014-06-131-0/+11
|\ \ \ \ | | | | | | | | | | prevent bad automatic inverse_of association
| * | | | use name specified by 'as' for automatic inverse association to avoid ↵Andrew S. Brown2014-06-101-0/+11
| | |_|/ | |/| | | | | | | | | | reflecting on wrong association
* | | | Through associations should set both parent ids on join modelsSean Griffin2014-06-132-0/+27
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | member = Member.new(club: Club.new) member.save! Before: member.current_membership.club_id # => nil After: member.current_membership.club_id # => club's id
* | | Fix inverse associations testLeandro Facchinetti2014-06-041-1/+1
| | | | | | | | | | | | | | | | | | `InverseHasManyTests#test_parent_instance_should_be_shared_within_create_block_of_new_child` was mistakenly the same as `InverseHasManyTests#test_parent_instance_should_be_shared_within_build_block_of_new_child`.
* | | Fix regression on eager loading association based on SQL query ratherLauro Caetano2014-06-031-0/+4
| | | | | | | | | | | | | | | | | | than existing column. Fixes #15480.
* | | just use `assert`Aaron Patterson2014-06-021-1/+1
| | |
* | | Merge pull request #14834 from al2o3cr/issue14155Aaron Patterson2014-05-271-0/+10
|\ \ \ | | | | | | | | Correctly alias table names when joining more than once
| * | | WIP: pass existing joins to construct_join_dependencyMatt Jones2014-05-161-0/+10
| | | |
* | | | Fix redefine a has_and_belongs_to_many inside inherited classArthur Neves2014-05-271-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After ad7b5efb55bcc2e0ccd3e7f22a81e984df8676d1, which changed how has_an_belongs_to_many used to work, we start raising an error when redefining the same has_an_belongs_to_many association. This commits fix that regression. [Fixes #14983]
* | | | Fix syntax error from 5eae77cZachary Scott2014-05-261-1/+1
| | | |
* | | | Move test to the proper fileRafael Mendonça França2014-05-261-0/+7
| | | | | | | | | | | | | | | | All preload tests are in the eager_test file
* | | | Add test case for b13d260Rafael Mendonça França2014-05-261-0/+9
| |/ / |/| |
* | | Fix polymorphic eager load with foreign_key as String.Lauro Caetano2014-05-201-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | The foreign_key could be `String` and just doing `owners_map[owner_key]` could return `nil`. To prevent this bug, we should `to_s` both keys if their types are different. Fixes #14734.
* | | Prevented belongs_to: touch propagating up if there are no changes being savedBrock Trappitt2014-05-211-0/+7
| | |
* | | Remove dead test code for unsupported adaptersSean Griffin2014-05-171-17/+3
|/ /
* | Fix how to compute class name on habtm namespaced.Kassio Borges2014-05-131-0/+12
| | | | | | | | | | | | Thank's for @laurocaetano for the help with tests. :smiley: Fixes #14709
* | deprecate, join, preload, eager load of instance dependent associations.Yves Senn2014-05-101-4/+27
| | | | | | | | | | | | | | Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior.
* | test, regression test for has_many with instance dependent scope.Yves Senn2014-05-091-0/+10
| |
* | set a constant for the "anonymous" habtm model fixes #15022Aaron Patterson2014-05-081-0/+6
| | | | | | | | | | I wanted the middle model to be anonymous, but we have to give it a name for marshal support. :'(
* | Fixed HABTM's CollectionAssociation sizeFred Wu2014-05-081-0/+18
| | | | | | | | | | HABTM should fall back to using the normal CollectionAssociation's size calculation if the collection is not cached or loaded. This addresses both #14913 and #14914 for master.
* | Remove duplicated fixture additionCarlos Antonio da Silva2014-05-031-1/+1
| |
* | Refactor test to not care about the specific result of valid?Carlos Antonio da Silva2014-05-031-3/+4
| | | | | | | | | | | | Only care about its truthiness rather than asserting specific true/false values. If we need to check for the return value in particular, there will be a test for that.
* | Merge pull request #14924 from eric-chahin/issue_13854Matthew Draper2014-05-031-0/+10
|\ \ | | | | | | | | | Fixed custom validation context bug for child associations
| * | Fixed custom validation context bug where childEric Chahin2014-05-011-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | associations were not being saved. Fixes #13854. [Eric Chahin, Aaron Nelson, & Kevin Casey]
* | | push up bind params on "simple" subquery calculationsAaron Patterson2014-05-021-1/+7
| | | | | | | | | | | | | | | bind parameters we not being propogated to simple subquery calculation calls. This fixes it
* | | Remove unused variableRafael Mendonça França2014-05-011-1/+1
|/ /
* | add test to check that loaded and non laoded are the sameeileencodes2014-04-281-0/+13
| | | | | | | | | | | | | | Test checks that SQL is the same for a loaded vs not loaded association (category.categorizations, category.categorization.delete_all vs category.cartegroization.delete_al). This was fixed for delete_all dependency but was not fixed for no (:nullify, or nil) dependency).
* | clear shouldnt fire callbacks so remove order testeileencodes2014-04-281-3/+0
| | | | | | | | | | | | Since clear shouldn't fire callbacks the order doesn't matter since it was never updated. Remove the portion of this test that tests for order after clear.
* | rewrite test to correctly test clear methodeileencodes2014-04-281-2/+2
| | | | | | | | | | | | | | Clear should not call callbacks because it clear calls delete_all and then returns self. It should behave the same as delete_all. This test clarifies the goal of the test and tests the correct outcome.
* | Merge pull request #14853 from kassio/kb-fix-custom-join-table-habtmYves Senn2014-04-251-0/+5
|\ \ | | | | | | Fix to use custom join table in habtm
| * | Fix custom join_table name on habtm reflectionsKassio Borges2014-04-251-0/+5
| | | | | | | | | | | | | | | | | | When used a custom join_table name on a habtm, rails was not saving it on Reflections. This causes a problem when rails loads fixtures, because it uses the reflections to set database with fixtures.
* | | Merge branch 'master' into adequaterecordAaron Patterson2014-04-251-4/+16
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (28 commits) move AR length validation tests into separate test-case. No need for trailing slash on migration path. reset `@arel` when modifying a Relation in place. PostgreSQL Timestamps always map to `:datetime`. [ci skip] Improve formatting and yml Fix a typo in the doc of forty_two AR FinderMethod Improve readability of contributing to rails guide. [ci skip] Precompile the image we're referencing, too. `ActiveRecord::Base.no_touching` no longer triggers callbacks or start empty transactions. Fixed an issue with migrating legacy json cookies. Correct comment [ci skip] Perfer to define methods instead of calling test Fix syntax error Add CHANGELOG entry for #14757 [ci skip] Fix run-on sentences and improve grammar [skip ci] Add test for using ActionView::Helpers::FormHelper.label with block and html select! renamed to avoid name collision Array#select! Rearrange deck chairs on the titanic. Organize connection handling test cases. Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon. ActionController::Renderers documentation fix ...
| * | Perfer to define methods instead of calling testRafael Mendonça França2014-04-221-4/+4
| | | | | | | | | | | | This file is using this pattern already
| * | Fix syntax errorRafael Mendonça França2014-04-221-0/+1
| | |
| * | Merge pull request #14573 from habermann24/has_many_through_fixRafael Mendonça França2014-04-221-0/+11
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Properly handle scoping with has_many :through. Fixes #14537. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/associations/has_many_through_associations_test.rb
| | * | Properly handle scoping with has_many :through. Fixes #14537.Jan Habermann2014-04-031-0/+12
| | | |
* | | | Merge branch 'master' into adequaterecordAaron Patterson2014-04-143-4/+45
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (70 commits) [ci skip] Added link to ruby-lang.org installation. Use the index on hidden field `collection_check_boxes` respects `:index` option for the hidden filed name. docs, double meaning of `serialize` argument. Closes #14284. Just call read_attribute, no need to use `send`. - Fix lingering reference to `:text` instead of the newer `:plain` - Section references `form_tag` instead of the `form_for` used in the example again, read_attribute is public, so just call it read_attribute is public, so we should just call it Disable assest cache store in docs [ci skip] Make counter cache decrementation on destroy idempotent Write the failing test case for concurrent counter cache [ci skip] Use plain underscore instead of "\_". Update documentation to use Rails.application instead Add a changelog entry for #14546 [ci skip] Move tests for deep_dup and duplicable to object directory Missing 'are' in note - [ci skip] CollectionHelpers now accepts a readonly option Fix a few typos [ci skip] Bundle tzinfo-data on :x64_mingw (64-bit Ruby on Windows). don't bother with an offset if the offset is zero ...
| * | | Merge pull request #14735 from byroot/idempotent-counter-cachesAaron Patterson2014-04-141-0/+21
| |\ \ \ | | | | | | | | | | Idempotent counter caches, fix concurrency issues with counter caches
| | * | | Write the failing test case for concurrent counter cacheJean Boussier2014-04-131-0/+21
| | | | |
| * | | | Just call read_attribute, no need to use `send`.Lauro Caetano2014-04-141-3/+3
| |/ / / | | | | | | | | | | | | Follow up to af549a1ad6692d7e2c756750651f0e1b293f5185
| * | | :scissors:Rafael Mendonça França2014-04-111-2/+2
| | | |
| * | | Merge pull request #14711 from ↵Rafael Mendonça França2014-04-111-0/+8
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | swoker/activerecord_fix_aggregate_methods_with_select Activerecord fix aggregate methods with select
| | * | | fix exception on polymorphic associations with predicatesSimon Woker2014-04-111-0/+8
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-29 06:23:05 +0000