aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations
Commit message (Collapse)AuthorAgeFilesLines
* ActiveRecord: Fix eager loading so that giving a blank order clause ↵Elliot Winkler2011-07-181-0/+12
| | | | generates valid SQL
* Fix exception if old and new targets are both nil. Fixes #1471.Jon Leighton2011-07-121-0/+9
|
* Foo.joins(:bar).includes(:bar) should result in a single query with :bar as ↵Jon Leighton2011-07-091-0/+8
| | | | a join. Related: #1873.
* Ensure that the foreign key gets set when doing record.create_association or ↵Jon Leighton2011-07-081-0/+14
| | | | record.create_association. Fixes #1960.
* Fix bug in collection_singular_ids on has many through association with ↵Anatoliy Lysenko2011-07-061-0/+5
| | | | | | | | | | | | | | | | conditions and includes, when condtions references tables from includes. Test fail because of invalid sql: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id: SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id" WHERE "readers"."person_id" = 1 AND (comments.id is null) Bug described in github#925 This commit will revert fix from https://github.com/rails/rails/commit/3436fdfc12d58925e3d981e0afa61084ea34736c , but tests is ok. Bug described in #6569 ticket.
* Merge pull request #1968 from bogdan/associations_find_array_compatibility2Santiago Pastorino2011-07-051-0/+4
|\ | | | | Fixed CollectionAssociation#find to be compatible with Array#find
| * Fixed CollectionAssociation#find to be compatible with Array#findBogdan Gusiev2011-07-051-0/+4
| | | | | | | | | | In order to make CollectionAssociation behave closer to Array Add the ability to pass block to #find method just like Array#find does.
* | Only call set_owner_attributes for has_one association if target exists.Dieter Komendera2011-07-041-0/+11
|/
* Assign the association attributes to the associated record before the ↵Jon Leighton2011-06-302-0/+14
| | | | before_initialize callback of the record runs. Fixes #1842.
* Make assert_no_queries literally enforce that there are no queries. As in, ↵Jon Leighton2011-06-121-15/+0
| | | | not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries.
* Refactor tests to be less brittleJon Leighton2011-06-121-25/+58
|
* Don't wrap operations on collection associations in transactions when they ↵benedikt2011-06-121-0/+45
| | | | are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database.
* Do not hardcode :id as it was ignored by mass assignment filterRaimonds Simanovskis2011-06-081-2/+2
| | | As a result test was failing on Oracle where ids are assigned by default from 1000
* Allow polymorphic has_one to work when the association is set before the ↵Jon Leighton2011-06-081-0/+11
| | | | owner has been saved. Fixes #1524.
* When you add a record to a polymorphic has_one, you should be able to access ↵Jon Leighton2011-06-081-1/+4
| | | | the owner from the associated record
* Merge pull request #1474 from ganeshkumar/update_column_changesJosé Valim2011-06-071-0/+9
|\ | | | | added tests for update_column
| * added more tests for update_columnganesh2011-06-041-0/+9
| |
* | please use ruby -I lib:test path/to/test.rb, or export RUBY_OPTAaron Patterson2011-06-0619-19/+19
| |
* | Refactor Active Record test connection setup. Please see the ↵Jon Leighton2011-06-0419-20/+20
|/ | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
* added an alias for new to build to the AR collection proxy, this corrects an ↵Josh Kalderimis2011-06-012-0/+25
| | | | issue where the collection proxies were not consistent
* Tests for issue #1360Farley Knight2011-05-311-0/+9
|
* Opening class CascadedEagerLoadingTest at once.Arun Agrawal2011-05-311-7/+3
|
* fixing test for mysql2Aaron Patterson2011-05-271-5/+2
|
* adding a test for #1322Aaron Patterson2011-05-261-0/+15
|
* Merge pull request #1323 from fx/association_primary_keyJon Leighton2011-05-261-0/+10
|\ | | | | use association_primary_key in AssociationScope#add_constraints
| * added assertion for non-standard primary_key on models used in the ↵Marian Rudzynski2011-05-261-0/+3
| | | | | | | | primary_key test
| * use association_primary_key in AssociationScope#add_constraintsMarian Rudzynski2011-05-261-0/+7
| |
* | Removes a now needless test - via GithubMohammad Typaldos2011-05-261-8/+0
| |
* | Removes the restriction on primary key when joining in a habtm && test that ↵Mohammad El-Abid2011-05-261-5/+4
|/ | | | it was properly removed
* removed deprecated methods, and related tests, from ActiveRecordJosh Kalderimis2011-05-251-9/+0
|
* Merge pull request #1254 from pixeltrix/ignore-includes-in-through-scopeJon Leighton2011-05-241-0/+6
|\ | | | | Ignore :includes on through associations
| * Ignore :includes on through associationsAndrew White2011-05-241-0/+6
| |
* | Failing tests for #1233.Andrew White2011-05-241-0/+40
| |
* | add tests surrounding behavior of save and save! for associations that have ↵Aaron Patterson2011-05-241-0/+26
| | | | | | | | validation errors
* | adding a test for create! with invalid associationsAaron Patterson2011-05-241-0/+9
| |
* | do not bother with assert_nothing_raised, the test will fail and we get a ↵Aaron Patterson2011-05-241-3/+1
| | | | | | | | better trace without it
* | Add failing test case for issue 796Joey Butler2011-05-241-0/+9
|/
* Fix problem with loading polymorphic associations which have been defined in ↵Jon Leighton2011-05-221-0/+7
| | | | an abstract superclass. Fixes #552.
* Handle polymorphic_type NOT NULL-able columns as well.thedarkone2011-05-211-0/+11
|
* Refactoring test_has_many_with_pluralize_table_names_false testGuillermo Iguaran2011-05-201-4/+1
|
* Add block setting of attributes to singular associationsAndrew White2011-05-172-0/+42
|
* Pass the attribute and option hashes to build_associationAndrew White2011-05-172-0/+29
| | | | | | | The build_association method was added as an API for plugins to hook into in 1398db0. This commit restores this API and the ability to override class.new to return a subclass based on a virtual attribute in the attributes hash.
* Fixed InnerJoinAssociationTest. Need to load essays fixture.Arun Agrawal2011-05-171-1/+1
|
* Adding missing requireGuillermo Iguaran2011-05-161-0/+1
|
* Merge pull request #560 from guilleiguaran/fix_pluralize_table_names_falseJon Leighton2011-05-161-0/+11
|\ | | | | Fixing has_many when ActiveRecord::Base.pluralize_table_names is false
| * Fixing has_many association when ActiveRecord::Base.pluralize_table_names is ↵Guillermo Iguaran2011-05-151-0/+11
| | | | | | | | false. fixes #557
* | CollectionAssociation#merge_target_lists should write to the underlying ↵Jon Leighton2011-05-141-0/+10
|/ | | | attributes when copying, rather than using the assignment method
* Don't use mass-assignment protection when setting foreign keys or ↵Jon Leighton2011-05-121-0/+33
| | | | association conditions on singular associations. Fixes #481 (again).
* Merge pull request #512 from pivotalneutron/fix_eager_load_with_calculationsJon Leighton2011-05-111-1/+3
|\ | | | | Bug fixes for calculations with includes
| * Bug fixes:Fadzril Muhamad & Joseph Palermo2011-05-121-1/+3
| | | | | | | | | | | | - If doing a count on a relation that has an :include and a :join, it does a distinct even though it should not. - When doing a count on a relation that has an :include, it always falls back to a old style left join when performing the count. Looks like it was broken here: https://github.com/rails/rails/commit/b9599502c9e738a5a1513e75d08f8d40ed408265