Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make assert_no_queries literally enforce that there are no queries. As in, ↵ | Jon Leighton | 2011-06-12 | 1 | -15/+0 |
| | | | | not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries. | ||||
* | Refactor tests to be less brittle | Jon Leighton | 2011-06-12 | 1 | -25/+58 |
| | |||||
* | Don't wrap operations on collection associations in transactions when they ↵ | benedikt | 2011-06-12 | 1 | -0/+45 |
| | | | | are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database. | ||||
* | Do not hardcode :id as it was ignored by mass assignment filter | Raimonds Simanovskis | 2011-06-08 | 1 | -2/+2 |
| | | | As a result test was failing on Oracle where ids are assigned by default from 1000 | ||||
* | Allow polymorphic has_one to work when the association is set before the ↵ | Jon Leighton | 2011-06-08 | 1 | -0/+11 |
| | | | | owner has been saved. Fixes #1524. | ||||
* | When you add a record to a polymorphic has_one, you should be able to access ↵ | Jon Leighton | 2011-06-08 | 1 | -1/+4 |
| | | | | the owner from the associated record | ||||
* | Merge pull request #1474 from ganeshkumar/update_column_changes | José Valim | 2011-06-07 | 1 | -0/+9 |
|\ | | | | | added tests for update_column | ||||
| * | added more tests for update_column | ganesh | 2011-06-04 | 1 | -0/+9 |
| | | |||||
* | | please use ruby -I lib:test path/to/test.rb, or export RUBY_OPT | Aaron Patterson | 2011-06-06 | 19 | -19/+19 |
| | | |||||
* | | Refactor Active Record test connection setup. Please see the ↵ | Jon Leighton | 2011-06-04 | 19 | -20/+20 |
|/ | | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. | ||||
* | added an alias for new to build to the AR collection proxy, this corrects an ↵ | Josh Kalderimis | 2011-06-01 | 2 | -0/+25 |
| | | | | issue where the collection proxies were not consistent | ||||
* | Tests for issue #1360 | Farley Knight | 2011-05-31 | 1 | -0/+9 |
| | |||||
* | Opening class CascadedEagerLoadingTest at once. | Arun Agrawal | 2011-05-31 | 1 | -7/+3 |
| | |||||
* | fixing test for mysql2 | Aaron Patterson | 2011-05-27 | 1 | -5/+2 |
| | |||||
* | adding a test for #1322 | Aaron Patterson | 2011-05-26 | 1 | -0/+15 |
| | |||||
* | Merge pull request #1323 from fx/association_primary_key | Jon Leighton | 2011-05-26 | 1 | -0/+10 |
|\ | | | | | use association_primary_key in AssociationScope#add_constraints | ||||
| * | added assertion for non-standard primary_key on models used in the ↵ | Marian Rudzynski | 2011-05-26 | 1 | -0/+3 |
| | | | | | | | | primary_key test | ||||
| * | use association_primary_key in AssociationScope#add_constraints | Marian Rudzynski | 2011-05-26 | 1 | -0/+7 |
| | | |||||
* | | Removes a now needless test - via Github | Mohammad Typaldos | 2011-05-26 | 1 | -8/+0 |
| | | |||||
* | | Removes the restriction on primary key when joining in a habtm && test that ↵ | Mohammad El-Abid | 2011-05-26 | 1 | -5/+4 |
|/ | | | | it was properly removed | ||||
* | removed deprecated methods, and related tests, from ActiveRecord | Josh Kalderimis | 2011-05-25 | 1 | -9/+0 |
| | |||||
* | Merge pull request #1254 from pixeltrix/ignore-includes-in-through-scope | Jon Leighton | 2011-05-24 | 1 | -0/+6 |
|\ | | | | | Ignore :includes on through associations | ||||
| * | Ignore :includes on through associations | Andrew White | 2011-05-24 | 1 | -0/+6 |
| | | |||||
* | | Failing tests for #1233. | Andrew White | 2011-05-24 | 1 | -0/+40 |
| | | |||||
* | | add tests surrounding behavior of save and save! for associations that have ↵ | Aaron Patterson | 2011-05-24 | 1 | -0/+26 |
| | | | | | | | | validation errors | ||||
* | | adding a test for create! with invalid associations | Aaron Patterson | 2011-05-24 | 1 | -0/+9 |
| | | |||||
* | | do not bother with assert_nothing_raised, the test will fail and we get a ↵ | Aaron Patterson | 2011-05-24 | 1 | -3/+1 |
| | | | | | | | | better trace without it | ||||
* | | Add failing test case for issue 796 | Joey Butler | 2011-05-24 | 1 | -0/+9 |
|/ | |||||
* | Fix problem with loading polymorphic associations which have been defined in ↵ | Jon Leighton | 2011-05-22 | 1 | -0/+7 |
| | | | | an abstract superclass. Fixes #552. | ||||
* | Handle polymorphic_type NOT NULL-able columns as well. | thedarkone | 2011-05-21 | 1 | -0/+11 |
| | |||||
* | Refactoring test_has_many_with_pluralize_table_names_false test | Guillermo Iguaran | 2011-05-20 | 1 | -4/+1 |
| | |||||
* | Add block setting of attributes to singular associations | Andrew White | 2011-05-17 | 2 | -0/+42 |
| | |||||
* | Pass the attribute and option hashes to build_association | Andrew White | 2011-05-17 | 2 | -0/+29 |
| | | | | | | | The build_association method was added as an API for plugins to hook into in 1398db0. This commit restores this API and the ability to override class.new to return a subclass based on a virtual attribute in the attributes hash. | ||||
* | Fixed InnerJoinAssociationTest. Need to load essays fixture. | Arun Agrawal | 2011-05-17 | 1 | -1/+1 |
| | |||||
* | Adding missing require | Guillermo Iguaran | 2011-05-16 | 1 | -0/+1 |
| | |||||
* | Merge pull request #560 from guilleiguaran/fix_pluralize_table_names_false | Jon Leighton | 2011-05-16 | 1 | -0/+11 |
|\ | | | | | Fixing has_many when ActiveRecord::Base.pluralize_table_names is false | ||||
| * | Fixing has_many association when ActiveRecord::Base.pluralize_table_names is ↵ | Guillermo Iguaran | 2011-05-15 | 1 | -0/+11 |
| | | | | | | | | false. fixes #557 | ||||
* | | CollectionAssociation#merge_target_lists should write to the underlying ↵ | Jon Leighton | 2011-05-14 | 1 | -0/+10 |
|/ | | | | attributes when copying, rather than using the assignment method | ||||
* | Don't use mass-assignment protection when setting foreign keys or ↵ | Jon Leighton | 2011-05-12 | 1 | -0/+33 |
| | | | | association conditions on singular associations. Fixes #481 (again). | ||||
* | Merge pull request #512 from pivotalneutron/fix_eager_load_with_calculations | Jon Leighton | 2011-05-11 | 1 | -1/+3 |
|\ | | | | | Bug fixes for calculations with includes | ||||
| * | Bug fixes: | Fadzril Muhamad & Joseph Palermo | 2011-05-12 | 1 | -1/+3 |
| | | | | | | | | | | | | - If doing a count on a relation that has an :include and a :join, it does a distinct even though it should not. - When doing a count on a relation that has an :include, it always falls back to a old style left join when performing the count. Looks like it was broken here: https://github.com/rails/rails/commit/b9599502c9e738a5a1513e75d08f8d40ed408265 | ||||
* | | Add missing requires | Santiago Pastorino | 2011-05-11 | 1 | -0/+1 |
| | | |||||
* | | Don't remove the target if it has already been destroyed | Andrew White | 2011-05-11 | 1 | -0/+9 |
|/ | |||||
* | Don't use select() values from the join model of a through association. ↵ | Jon Leighton | 2011-05-11 | 1 | -0/+4 |
| | | | | Fixes #508. | ||||
* | Bring back obj.association_loaded? as a deprecated method. Fixes #472. | Jon Leighton | 2011-05-11 | 1 | -0/+9 |
| | |||||
* | Add test to specify that attributes from an association's conditions should ↵ | Jon Leighton | 2011-05-10 | 1 | -4/+23 |
| | | | | be assigned without mass-assignment protection when a record is built on the association. | ||||
* | Don't use mass-assignment protection when applying the ↵ | Jon Leighton | 2011-05-10 | 1 | -0/+9 |
| | | | | scoped.scope_for_create. Fixes #481. | ||||
* | Add failing tests according to #479. | José Valim | 2011-05-10 | 1 | -0/+15 |
| | |||||
* | Add failing tests, according to #480. | José Valim | 2011-05-10 | 1 | -0/+14 |
| | |||||
* | Merge pull request #399 from ernie/join_conditions_on_join | Jon Leighton | 2011-05-05 | 1 | -0/+11 |
|\ | | | | | Add association join conditions to JOIN clause, not WHERE |