aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #12011 from jetthoughts/11963_fix_join_with_association_scopeRafael Mendonça França2013-09-161-0/+5
|\ | | | | | | | | | | | | Collapse where constraints to the Arel::Nodes::And node Conflicts: activerecord/CHANGELOG.md
| * Collapse where constraints to one where constraintPaul Nikitochkin2013-09-131-0/+5
| | | | | | | | | | | | | | In order to remove duplication with joining arel where constraints with `AND`, all constraints on `build_arel` are collapsed into one head node: `Arel::Nodes::And` Closes: #11963
* | Merge pull request #12137 from lann/fix_association_first_lastRafael Mendonça França2013-09-121-3/+5
|\ \ | | | | | | | | | | | | | | | | | | Make CollectionAssociation first/last with integer fetch with query Conflicts: activerecord/CHANGELOG.md
| * | Make CollectionAssociation first/last with integer fetch with queryLann Martin2013-09-091-3/+5
| |/ | | | | | | | | | | | | | | | | | | | | When first or last is called with an integer on an unloaded association, the entire collection is loaded. This differs surprisingly from the behavior of Relation#first/last, which translate the call into a limit query. For large collections this can make a big difference in performance. Change CollectionAssociation#fetch_first_or_last_using_find? to make this kind of call delegate to Relation.
* | these are not real developer objects, so counting them doesn't makeAaron Patterson2013-09-111-1/+1
| | | | | | | | | | sense. Let's load the object to ensure it's an array and count the array.
* | Merge pull request #12135 from dylanahsmith/avoid_empty_transactionRafael Mendonça França2013-09-111-0/+2
|\ \ | | | | | | | | | | | | | | | | | | Avoid empty transaction from setting has_one association on new record. Conflicts: activerecord/CHANGELOG.md
| * | Avoid empty transaction from setting has_one association on new record.Dylan Thacker-Smith2013-09-111-0/+2
| | |
* | | fix deleting join models with no pkAaron Patterson2013-09-111-5/+47
|/ /
* | add a comment for sanity of other people to comeAaron Patterson2013-09-101-0/+8
| |
* | hm:t join tables may not have a primary keyAaron Patterson2013-09-061-0/+18
|/
* Merge pull request #11958 from jetthoughts/extract_pre_process_orders_argsYves Senn2013-09-041-2/+5
|\ | | | | Re-use order arguments pre-processing for reorder
| * Extracted from `order` processing of arguments, and use it for `reorder` to ↵Paul Nikitochkin2013-09-041-2/+5
| | | | | | | | be consistent.
* | adding a hm:t test for singleton ar objectsAaron Patterson2013-09-031-0/+27
| |
* | support anonymous classes on has_many associationsAaron Patterson2013-09-031-0/+18
| |
* | Don't need to check if the scope respond to callRafael Mendonça França + Kassio Borges2013-08-311-1/+1
| | | | | | | | | | We are checking this when defining the default scope and raising an ArgumentError
* | add missing fixtures fileAaron Patterson2013-08-301-1/+2
| |
* | make sure there are actually some categories when running the testAaron Patterson2013-08-291-0/+1
| |
* | pk should not be required for hm:t associationsAaron Patterson2013-08-291-0/+7
|/
* query the association rather than send the method for the association nameAaron Patterson2013-08-271-6/+4
|
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-08-171-1/+1
|\ | | | | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md
| * Revert "Merge branch 'master' of github.com:rails/docrails"Vijay Dev2013-08-171-1/+1
| | | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake.
* | Fixing multi-word automatic inverse detection.wangjohn2013-08-151-0/+14
| | | | | | | | | | Currently, ActiveRecord models with multiple words cannot have their inverse associations detected automatically.
* | using assert_not instead of refuteRajarshi Das2013-08-131-1/+1
| |
* | add a test for concat on hm:t associationsAaron Patterson2013-08-021-0/+7
| |
* | association builder classes no longer need the modelAaron Patterson2013-08-011-1/+1
| | | | | | | | | | decouple the builder classes from the model. Builder objects should be easier to reuse now.
* | no need to define the constant twiceAaron Patterson2013-08-011-1/+0
| |
* | assert that constants have been set rather than the namesAaron Patterson2013-08-011-6/+8
| |
* | Merge pull request #11668 from neerajdotname/make_test_order_independent_2Rafael Mendonça França2013-07-301-1/+3
|\ \ | | | | | | Make test order independent
| * | assert_no_queries should ignore certain sqlsNeeraj Singh2013-07-301-1/+3
| | | | | | | | | | | | | | | postgresql test if randomly executed then executes "SHOW max_identifier_length". Hence the need to ignore certain predefined sqls that deal with system calls.
* | | Revert change on ActiveRecord::Relation#order method that prepends newRafael Mendonça França2013-07-292-4/+4
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | order on the old ones The previous behavior added a major backward incompatibility since it impossible to have a upgrade path without major changes on the application code. We are taking the most conservative path to be consistent with the idea of having a smoother upgrade on Rails 4. We are reverting the behavior for what was in Rails 3.x and, if needed, we will implement a new API to prepend the order clauses in Rails 4.1.
* | Clear class ivar before testingAkira Matsuda2013-07-291-0/+2
| |
* | Unneeded assertionAkira Matsuda2013-07-291-1/+1
| |
* | make test not depend on orderNeeraj Singh2013-07-281-0/+1
|/ | | | | | | `NestedThroughAssociationsTest` adds records to `member_details` table. When test performs `@member_details[0]` then the order of record is not guaranteed. Hence it is best to start with a clean slate by deleting unwanted records.
* used flat_map instead of map.flattenKarunakar (Ruby)2013-07-251-1/+1
|
* Make sure that a joins Relation can be merged with has_many :through + ↵Akira Matsuda2013-07-101-0/+6
| | | | | | association proxy Closes #11248.
* Remove redundant test about `push_with_attributes` removal.Vipul A M2013-07-091-7/+0
|
* #11288: Removed duplicated touchingPaul Nikitochkin2013-07-051-1/+42
| | | | | | if belongs to model with touch option on touch Closes #11288
* Cleanup belongs to testsPaul Nikitochkin2013-07-051-2/+1
| | | | simplified logic to calculate number of queries by using assert_queries
* Dropped deprecated option `:restrict` for `:dependent` in associationsNeeraj Singh2013-07-032-31/+0
|
* Removed support for deprecated `delete_sql` in associations.Neeraj Singh2013-07-031-25/+0
|
* Removed support for deprecated `finder_sql` in associations.Neeraj Singh2013-07-022-140/+0
|
* Removed support for deprecated `counter_sql`Neeraj Singh2013-07-022-45/+0
|
* Merge pull request #10604 from ↵Rafael Mendonça França2013-07-012-2/+59
|\ | | | | | | | | | | | | | | | | neerajdotname/delete_all_should_not_call_callbacks Do not invoke callbacks when delete_all is called Conflicts: activerecord/CHANGELOG.md
| * Do not invoke callbacks when delete_all is calledNeeraj Singh2013-06-302-2/+59
| | | | | | | | | | | | | | | | | | | | | | Method `delete_all` should not be invoking callbacks and this feature was deprecated in Rails 4.0. This is being removed. `delete_all` will continue to honor the `:dependent` option. However if `:dependent` value is `:destroy` then the default deletion strategy for that collection will be applied. User can also force a deletion strategy by passing parameter to `delete_all`. For example you can do `@post.comments.delete_all(:nullify)`
* | Removed deprecated options for assocationsNeeraj Singh2013-07-022-22/+0
|/ | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted.
* remove deprecated implicit join references.Yves Senn2013-06-291-15/+5
|
* Apply default scope when joining associations.Jon Leighton2013-06-281-0/+8
| | | | | | | | | | | | | | | | | | | For example: class Post < ActiveRecord::Base default_scope -> { where published: true } end class Comment belongs_to :post end When calling `Comment.join(:post)`, we expect to receive only comments on published posts, since that is the default scope for posts. Before this change, the default scope from `Post` was not applied, so we'd get comments on unpublished posts.
* Remove depreacted findersŁukasz Strzałkowski2013-06-281-2/+2
| | | | They were deprecated in 4.0, planned to remove in 4.1
* Fix `another_contract` not being used warningVipul A M2013-06-241-1/+1
|
* test-case to prevent regressions described in #10901.Jared Armstrong2013-06-241-0/+27
|