Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | quarantine deprecated tests | Jon Leighton | 2012-05-18 | 4 | -151/+9 | |
| | | ||||||
* | | Merge pull request #5453 from ↵ | Aaron Patterson | 2012-05-16 | 1 | -0/+6 | |
|\ \ | | | | | | | | | | | | | JonRowe/patch_uniq_has_and_belongs_to_many_when_already_loaded When Active Record has already loaded a unique association `.size` returns the wrong number. | |||||
| * | | when using a preloaded array and the uniq flag is set then return the size ↵ | Jon Rowe | 2012-03-15 | 1 | -0/+6 | |
| | | | | | | | | | | | | of the uniq array | |||||
* | | | Fix CollectionAssociation#replace to return new target (closes #6231) | Piotr Sarnacki | 2012-05-16 | 1 | -0/+12 | |
| | | | ||||||
* | | | Remove #=== quirk | Jon Leighton | 2012-05-11 | 2 | -11/+0 | |
| | | | | | | | | | | | | Makes it consistent with Relation. Can't see a use for this. | |||||
* | | | CollectionProxy < Relation | Jon Leighton | 2012-05-11 | 4 | -7/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This helps bring the interfaces of CollectionProxy and Relation closer together, and reduces the delegation backflips we need to perform. For example, first_or_create is defined thus: class ActiveRecord::Relation def first_or_create(...) first || create(...) end end If CollectionProxy < Relation, then post.comments.first_or_create will hit the association's #create method which will actually add the new record to the association, just as post.comments.create would. With the previous delegation, post.comments.first_or_create expands to post.comments.scoped.first_or_create, where post.comments.scoped has no knowledge of the association. | |||||
* | | | Fix issue with private kernel methods and collection associations. Closes #2508 | Carlos Antonio da Silva | 2012-05-02 | 1 | -0/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Change CollectionProxy#method_missing to use scoped.public_send, to avoid a problem described in issue #2508 when trying to use class methods with names like "open", that clash with private kernel methods. Also changed the dynamic matcher instantiator to send straight to scoped, to avoid another roundtrip to method_missing. | |||||
* | | | Remove unused assignments from activerecord tests | Mark Rushakoff | 2012-04-29 | 1 | -1/+0 | |
| | | | ||||||
* | | | remove deprecated calls | Jon Leighton | 2012-04-27 | 6 | -64/+64 | |
| | | | ||||||
* | | | more deprecations manually fixed | Jon Leighton | 2012-04-27 | 2 | -38/+38 | |
| | | | ||||||
* | | | find and replace deprecated keys | Jon Leighton | 2012-04-27 | 11 | -150/+150 | |
| | | | ||||||
* | | | %s/find(:\(first\|last\|all\), \([^()]*\))/scoped(\2).\1/gcI amongst other ↵ | Jon Leighton | 2012-04-27 | 11 | -209/+209 | |
| | | | | | | | | | | | | things | |||||
* | | | don't need this test | Jon Leighton | 2012-04-26 | 1 | -5/+0 | |
| | | | ||||||
* | | | remove calls to find(:first), find(:last) and find(:all) | Jon Leighton | 2012-04-26 | 8 | -52/+47 | |
| | | | ||||||
* | | | remove deprecate #all usage | Jon Leighton | 2012-04-26 | 1 | -1/+1 | |
| | | | ||||||
* | | | remove deprecated #first calls | Jon Leighton | 2012-04-26 | 1 | -12/+1 | |
| | | | ||||||
* | | | remove deprecate #calculate calls | Jon Leighton | 2012-04-26 | 6 | -23/+8 | |
| | | | ||||||
* | | | remove deprecated #find_in_batches calls | Jon Leighton | 2012-04-26 | 1 | -1/+1 | |
| | | | ||||||
* | | | fix #scoped deprecations | Jon Leighton | 2012-04-26 | 2 | -5/+5 | |
| | | | ||||||
* | | | remove tests for #with_scope (it's now deprecated) | Jon Leighton | 2012-04-25 | 2 | -41/+0 | |
| | | | ||||||
* | | | Merge remote-tracking branch 'kennyj/fix_5563' | Jon Leighton | 2012-04-25 | 1 | -0/+11 | |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: activerecord/test/cases/associations/belongs_to_associations_test.rb | |||||
| * | | | Fix #5563. Should reflect the most recent change to either of association / id. | kennyj | 2012-04-13 | 1 | -0/+11 | |
| | | | | ||||||
* | | | | add missing test | Jon Leighton | 2012-04-25 | 1 | -0/+12 | |
| | | | | ||||||
* | | | | fix tests | Jon Leighton | 2012-04-13 | 3 | -67/+66 | |
|/ / / | ||||||
* | | | Merge pull request #5720 from kennyj/should_use_klass_method | Jon Leighton | 2012-04-11 | 1 | -0/+1 | |
|\ \ \ | | | | | | | | | Get a properly aliased_table_name, when we use a polymorphic association. | |||||
| * | | | Get a properly aliased_table_name, when we use a polymorphic association. | kennyj | 2012-04-04 | 1 | -0/+1 | |
| | | | | ||||||
* | | | | Adds test to check that circular preloading does not modify Model.unscoped ↵ | Benedikt Deicke | 2012-04-03 | 1 | -0/+6 | |
|/ / / | | | | | | | | | | (as described in #5667) | |||||
* / / | Fix #5667. Preloading should ignore scoping. | Jon Leighton | 2012-03-30 | 1 | -0/+11 | |
|/ / | ||||||
* | | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 3 | -148/+10 | |
| | | ||||||
* | | In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] ↵ | Alexey Vakhov | 2012-03-09 | 1 | -0/+7 | |
| | | | | | | | | correct | |||||
* | | Merge pull request #5289 from rafaelfranca/fix-through-associations | Jon Leighton | 2012-03-08 | 1 | -4/+20 | |
|\ \ | | | | | | | Fix has_many through associations when mass_assignment_sanitizer is strict | |||||
| * | | Not need to pass join attributes to association build | Rafael Mendonça França | 2012-03-07 | 1 | -3/+2 | |
| | | | ||||||
| * | | Add test case to has_many through association when mass_assignment_sanitizer is | Rafael Mendonça França | 2012-03-05 | 1 | -4/+21 | |
| | | | | | | | | | | | | :strict | |||||
* | | | Add tests to test that through associations are not readonly, and we can ↵ | kuahyeow | 2012-03-08 | 1 | -0/+11 | |
|/ / | | | | | | | update the records we retrive from the association | |||||
* / | Fix #5069 - Protect foreign key from mass assignment throught association ↵ | Jean Boussier | 2012-03-05 | 2 | -0/+38 | |
|/ | | | | builder | |||||
* | Merge pull request #4543 from jdelStrother/find_or_init | Jon Leighton | 2012-02-01 | 1 | -0/+12 | |
|\ | | | | | Don't instantiate two objects in collection proxy / find_or_instantiate_by | |||||
| * | Don't instantiate two objects in collection proxy / find_or_instantiator_by | Jonathan del Strother | 2012-01-19 | 1 | -0/+12 | |
| | | ||||||
* | | Fix typo | Rafael Mendonça França | 2012-02-01 | 1 | -2/+2 | |
| | | ||||||
* | | Use human attribute name to show the dependent destroy message | Rafael Mendonça França | 2012-02-01 | 1 | -1/+25 | |
| | | ||||||
* | | fix has_one, has_many restrict error message | Manoj | 2012-02-01 | 2 | -2/+2 | |
| | | ||||||
* | | Merge pull request #4791 from gregolsen/reflection_test_fixed | José Valim | 2012-01-31 | 1 | -1/+1 | |
|\ \ | | | | | | | reflection test fixed | |||||
| * | | test_get_ids_for_ordered_association fixed | gregolsen | 2012-01-31 | 1 | -1/+1 | |
| | | | ||||||
* | | | Remove deprecation warnings from tests | Rafael Mendonça França | 2012-01-31 | 2 | -13/+25 | |
|/ / | ||||||
* | | Merge pull request #4783 from gregolsen/ids_reader_fix | Jon Leighton | 2012-01-31 | 1 | -0/+4 | |
|\ \ | | | | | | | ids_reader method fixed, test added to has_many association (for PostgreSQL) | |||||
| * | | ids_reader method fixed, test added to has_many association | gregolsen | 2012-01-31 | 1 | -0/+4 | |
| | | | ||||||
* | | | suggested fixes for :dependent => :restrict deprecation. | Manoj | 2012-01-31 | 2 | -32/+10 | |
| | | | ||||||
* | | | has_many/has_one, :dependent => :restrict, deprecation added. | Manoj | 2012-01-29 | 2 | -14/+101 | |
|/ / | ||||||
* / | The primary key is always initialized in the @attributes hash to nil (unless | Aaron Patterson | 2012-01-25 | 1 | -1/+1 | |
|/ | | | | another value has been specified). | |||||
* | Deprecate inferred JOINs with includes + SQL snippets. | Jon Leighton | 2012-01-16 | 6 | -36/+115 | |
| | | | | | | See the CHANGELOG for details. Fixes #950. | |||||
* | Revert "Deprecate implicit eager loading. Closes #950." | Jon Leighton | 2012-01-16 | 10 | -84/+64 | |
| | | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9. |