Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | wrote a test showing eager loading's misbehavior (sanitizing against the ↵ | Will Bryant | 2008-09-29 | 1 | -0/+7 |
| | | | | | | wrong table) when the association has a :conditions hash Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Make AssociationCollection start transactions in the correct database. | Hongli Lai (Phusion) | 2008-09-23 | 3 | -0/+27 |
| | | | | | | | | | | AssociationCollection now starts transactions by calling AssociationCollection#transaction instead of @owner.transaction or @reflection.klass.transaction. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1081 state:committed] | ||||
* | Association#first and last should not load the association if not needed. ↵ | Jan De Poorter | 2008-09-22 | 2 | -1/+14 |
| | | | | | | [#1091 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | applied patch to fix the associations with blocks in modules bug from an old ↵ | Adeh DeSandies | 2008-09-20 | 1 | -0/+15 |
| | | | | trac ticket | ||||
* | When counting grouped records the target should be loaded to return a valid ↵ | miloops | 2008-09-15 | 1 | -0/+2 |
| | | | | | | | | | groups count result. Without this change count_records will group for the count in the query and return erroneous results. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#937 state:committed] | ||||
* | Support for updating a belongs to association from the foreign key (without ↵ | Jon Leighton | 2008-09-13 | 1 | -0/+13 |
| | | | | | | | saving and reloading the record) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#142 state:committed] | ||||
* | Improve test coverage when using the group option in find, has_many or ↵ | miloops | 2008-09-11 | 2 | -0/+17 |
| | | | | | | has_and_belongs_to_many. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Fix tests that assumed implicit order by id | Jeremy Kemper | 2008-08-30 | 1 | -2/+2 |
| | |||||
* | Performance: Better query for ASSOCIATION_ids. Select only ids if the ↵ | miloops | 2008-08-30 | 3 | -16/+68 |
| | | | | | | association hasn't been loaded. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Refactored AssociationCollection#count for uniformity and Ruby 1.8.7 support. | Ernie Miller | 2008-08-28 | 1 | -0/+7 |
| | | | | | | [#831 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Implement count limit/offset support for has_many associations | Tarmo Tänav | 2008-08-27 | 1 | -0/+6 |
| | | | | | | [#348 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Alias included associations if needed when doing a count | Tarmo Tänav | 2008-08-27 | 1 | -0/+4 |
| | | | | | | [#302 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fix two has_one :through errors | pivotal | 2008-08-27 | 1 | -0/+9 |
| | | | | | | | | * Set the association target on assignment; * Reset target to nil on reset, rather than empty array. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#895 state:committed] | ||||
* | Fix yet another implicit order dependant test | Tarmo Tänav | 2008-08-26 | 1 | -3/+3 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | um.. yeah | Jeremy Kemper | 2008-08-26 | 1 | -2/+2 |
| | |||||
* | typo | Jeremy Kemper | 2008-08-26 | 1 | -2/+2 |
| | |||||
* | fix tests relying on implicit ordering | Jeremy Kemper | 2008-08-25 | 1 | -4/+2 |
| | |||||
* | Load the first and not the last has_one result when doing join-based eager ↵ | Tarmo Tänav | 2008-08-25 | 2 | -0/+16 |
| | | | | | | | | | | | loading This matters when the has_one is defined with an order in which case there is an expectation that the first one will be loaded. [#904 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Implement old-skool eagerloading for has_one :through | Frederick Cheung | 2008-08-25 | 1 | -0/+16 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fix preloading of has_one through associations | Frederick Cheung | 2008-08-25 | 1 | -5/+9 |
| | | | | | | [#903 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fixed ordering in ↵ | Tarmo Tänav | 2008-08-22 | 1 | -1/+1 |
| | | | | test_find_in_association_with_custom_finder_sql_and_multiple_interpolations | ||||
* | remember created records and select a random one instead of relying on ↵ | S. Brent Faulkner | 2008-08-21 | 1 | -12/+30 |
| | | | | | | sequential id values starting at 1 Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Don't interpret decimals as table names in ↵ | Peter Wagenet | 2008-08-21 | 1 | -0/+7 |
| | | | | | | ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix has_many#count_records. [#865 state:resolved] | Xavier Noria | 2008-08-21 | 1 | -0/+12 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix that has_one natural assignment to already associated record. [#854 ↵ | Jakub Kuźma | 2008-08-21 | 1 | -0/+10 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Test for eager loading of STI subclasses from htm associations | Tarmo Tänav | 2008-08-16 | 1 | -0/+7 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Updated has_and_belongs_to_many association to fix :finder_sql ↵ | Nathan Witmer | 2008-08-16 | 1 | -0/+7 |
| | | | | | | interpolation. [#848 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed STI type condition for eager loading of associations | Tarmo Tänav | 2008-08-16 | 1 | -0/+12 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed AssociationCollection#<< resulting in unexpected values in @target ↵ | Ernie Miller | 2008-08-08 | 1 | -0/+11 |
| | | | | | | when :uniq => true Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Added missing fixtures for tests which fail to run independently if run ↵ | Tarmo Tänav | 2008-08-04 | 4 | -4/+4 |
| | | | | | | after schema reset Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Fix file permissions | Tarmo Tänav | 2008-07-31 | 2 | -0/+0 |
| | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Fixed test_joins_with_namespaced_model_should_use_correct_type for postgresql | Tarmo Tänav | 2008-07-31 | 1 | -1/+1 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Fix HasManyThroughAssociationsTest tests. [#733 state:resolved] | miloops | 2008-07-31 | 1 | -3/+6 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Use klass.sti_name to make sure associations take store_full_sti_class into ↵ | Daniel Guettler | 2008-07-22 | 1 | -0/+18 |
| | | | | | | account. [#671 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Make sure association preloading works with full STI class name [#465 ↵ | Joachim Garth | 2008-07-18 | 1 | -0/+36 |
| | | | | | | state:Resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Add block syntax to HasManyAssociation#build. [#502 state:resolve] | Jason Dew | 2008-07-14 | 1 | -0/+31 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Add support for :primary_key option to has_one as well as has_many so that a ↵ | Brad Greenlee | 2008-07-06 | 1 | -0/+7 |
| | | | | | | key other than the default primary key can be used for the association Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Add has_many :primary_key option to allow setting the primary key on a has ↵ | Andre Arko | 2008-07-06 | 1 | -0/+4 |
| | | | | | | many association Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Ensure AssociationCollection#size considers all unsaved record. [#305 ↵ | Pratik Naik | 2008-07-02 | 1 | -0/+7 |
| | | | | | | state:resolved] [sds] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Make sure associated has_many/habtm objects get saved even when :validate => ↵ | Jan De Poorter | 2008-06-27 | 1 | -1/+18 |
| | | | | | | false is used. [#486 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | fix merge | rick | 2008-06-19 | 4 | -4/+57 |
|\ | |||||
| * | Fix quoting in test_counting_with_single_conditions | Jeremy Kemper | 2008-06-11 | 1 | -1/+1 |
| | | |||||
| * | Added some has_many tests | Jan De Poorter | 2008-06-11 | 1 | -3/+3 |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
| * | Add :validate option to associations. [#301 state:resolved] | Jan De Poorter | 2008-06-11 | 3 | -0/+42 |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
| * | Fix conditions and order on join tables with limited eager loading. [#372 ↵ | Tiago Macedo | 2008-06-08 | 1 | -1/+12 |
| | | | | | | | | state:resolved] | ||||
* | | fix eager loading with dynamic finders | Brandon Keepers | 2008-06-09 | 2 | -0/+12 |
|/ | |||||
* | belongs_to polymorphic association assignments update the foreign_id and ↵ | Tim Harper | 2008-05-31 | 1 | -1/+28 |
| | | | | | | | | | | | foreign_type fields regardless of whether the record being assigned is new or not. fixes the following scenarios: * I have validates_inclusion_of on the type field for a polymorphic belongs_to association. I assign a new record to the model's polymorphic relationship of the proper type. validation fails because the type field has not been updated. * I replace the value for a ppolymorphic association to a new record of another class. The type field still says its the previous class, and the id field points to the previous record as well. [#191 state:closed] | ||||
* | Ensure query assertion counts are the same when partial updates are enabled | Jeremy Kemper | 2008-05-30 | 2 | -0/+3 |
| | |||||
* | Ensure AssociationCollection#count works with empty condition. [#271 ↵ | Pratik Naik | 2008-05-29 | 1 | -0/+4 |
| | | | | state:resolved] [Jan De Poorter] | ||||
* | Fix faulty tests introduced in 8d0b4fa39 | Michael Koziarski | 2008-05-24 | 1 | -1/+1 |
| |