Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] ↵ | Alexey Vakhov | 2012-03-09 | 1 | -0/+7 |
| | | | | correct | ||||
* | Merge pull request #5289 from rafaelfranca/fix-through-associations | Jon Leighton | 2012-03-08 | 1 | -4/+20 |
|\ | | | | | Fix has_many through associations when mass_assignment_sanitizer is strict | ||||
| * | Not need to pass join attributes to association build | Rafael Mendonça França | 2012-03-07 | 1 | -3/+2 |
| | | |||||
| * | Add test case to has_many through association when mass_assignment_sanitizer is | Rafael Mendonça França | 2012-03-05 | 1 | -4/+21 |
| | | | | | | | | :strict | ||||
* | | Add tests to test that through associations are not readonly, and we can ↵ | kuahyeow | 2012-03-08 | 1 | -0/+11 |
|/ | | | | update the records we retrive from the association | ||||
* | Fix #5069 - Protect foreign key from mass assignment throught association ↵ | Jean Boussier | 2012-03-05 | 2 | -0/+38 |
| | | | | builder | ||||
* | Merge pull request #4543 from jdelStrother/find_or_init | Jon Leighton | 2012-02-01 | 1 | -0/+12 |
|\ | | | | | Don't instantiate two objects in collection proxy / find_or_instantiate_by | ||||
| * | Don't instantiate two objects in collection proxy / find_or_instantiator_by | Jonathan del Strother | 2012-01-19 | 1 | -0/+12 |
| | | |||||
* | | Fix typo | Rafael Mendonça França | 2012-02-01 | 1 | -2/+2 |
| | | |||||
* | | Use human attribute name to show the dependent destroy message | Rafael Mendonça França | 2012-02-01 | 1 | -1/+25 |
| | | |||||
* | | fix has_one, has_many restrict error message | Manoj | 2012-02-01 | 2 | -2/+2 |
| | | |||||
* | | Merge pull request #4791 from gregolsen/reflection_test_fixed | José Valim | 2012-01-31 | 1 | -1/+1 |
|\ \ | | | | | | | reflection test fixed | ||||
| * | | test_get_ids_for_ordered_association fixed | gregolsen | 2012-01-31 | 1 | -1/+1 |
| | | | |||||
* | | | Remove deprecation warnings from tests | Rafael Mendonça França | 2012-01-31 | 2 | -13/+25 |
|/ / | |||||
* | | Merge pull request #4783 from gregolsen/ids_reader_fix | Jon Leighton | 2012-01-31 | 1 | -0/+4 |
|\ \ | | | | | | | ids_reader method fixed, test added to has_many association (for PostgreSQL) | ||||
| * | | ids_reader method fixed, test added to has_many association | gregolsen | 2012-01-31 | 1 | -0/+4 |
| | | | |||||
* | | | suggested fixes for :dependent => :restrict deprecation. | Manoj | 2012-01-31 | 2 | -32/+10 |
| | | | |||||
* | | | has_many/has_one, :dependent => :restrict, deprecation added. | Manoj | 2012-01-29 | 2 | -14/+101 |
|/ / | |||||
* / | The primary key is always initialized in the @attributes hash to nil (unless | Aaron Patterson | 2012-01-25 | 1 | -1/+1 |
|/ | | | | another value has been specified). | ||||
* | Deprecate inferred JOINs with includes + SQL snippets. | Jon Leighton | 2012-01-16 | 6 | -36/+115 |
| | | | | | | See the CHANGELOG for details. Fixes #950. | ||||
* | Revert "Deprecate implicit eager loading. Closes #950." | Jon Leighton | 2012-01-16 | 10 | -84/+64 |
| | | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9. | ||||
* | get rid of using instance_variable_names method from AS | Sergey Nartimov | 2012-01-07 | 1 | -1/+1 |
| | | | | | - instance_variables return symbols in 1.9 - there is instance_variable_defined? method | ||||
* | Deprecate implicit eager loading. Closes #950. | Jon Leighton | 2011-12-29 | 10 | -64/+84 |
| | |||||
* | allow reorder to affect eager loading correctly | Matt Jones + Scott Walker | 2011-12-28 | 1 | -0/+10 |
| | |||||
* | remove requires of core_ext/array/random_access that no longer exists | lest | 2011-12-21 | 1 | -1/+0 |
| | |||||
* | More tests deep including through habtm | Arun Agrawal | 2011-12-21 | 1 | -0/+7 |
| | | | fixes #3183 | ||||
* | No Ruby 1.8 stuff. No more checks in code. | Arun Agrawal | 2011-12-21 | 1 | -10/+0 |
| | |||||
* | bypass preloading for ids_reader | Sergey Nartimov | 2011-12-18 | 1 | -0/+6 |
| | | | | | when fetching ids for a collection, bypass preloading to avoid the unnecessary performance overhead | ||||
* | Delete obsolete comment | Jon Leighton | 2011-12-16 | 1 | -1/+0 |
| | |||||
* | Cache columns at the model level. | Jon Leighton | 2011-12-16 | 1 | -2/+2 |
| | | | | Allows two models to use the same table but have different primary keys. | ||||
* | Remove that there copy/pasted code :bomb: | Jon Leighton | 2011-12-14 | 1 | -5/+0 |
| | |||||
* | Don't try to autosave nested assocs. Fixes #2961. | Jon Leighton | 2011-12-14 | 1 | -0/+14 |
| | |||||
* | Use `table_exists?` from the schema cache. | Aaron Patterson | 2011-12-09 | 1 | -3/+3 |
| | |||||
* | Fix #3890. (Calling proxy_association in scope chain.) | Jon Leighton | 2011-12-08 | 1 | -0/+6 |
| | |||||
* | reintroduce patch from #726 to handle nested eager loading via associations | Jay Levitt | 2011-11-30 | 1 | -0/+35 |
| | |||||
* | Deprecate set_table_name in favour of self.table_name= or defining your own ↵ | Jon Leighton | 2011-11-29 | 3 | -7/+7 |
| | | | | method. | ||||
* | Merge pull request #3636 from joshsusser/master | Jon Leighton | 2011-11-29 | 1 | -1/+21 |
|\ | | | | | association methods are now generated in modules | ||||
| * | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 1 | -1/+21 |
| | | |||||
* | | load has_many associations keyed off a custom primary key if that key is ↵ | Brian Samson | 2011-11-25 | 1 | -1/+28 |
|/ | | | | present but the record is unsaved | ||||
* | Merge pull request #3507 from jmazzi/issue-3503 | Jeremy Kemper | 2011-11-03 | 1 | -0/+15 |
| | | | | Preserve SELECT columns on the COUNT for finder_sql when possible | ||||
* | Remove all revelant through records. | Jon Leighton | 2011-11-03 | 1 | -0/+15 |
| | | | | | | | | | If a record is removed from a has_many :through, all of the join records relating to that record should also be removed from the through association's target. (Previously the records were removed in the database, but only one was removed from the in-memory target array.) | ||||
* | Fix adding multiple instances of the same record to a has_many :through. | Jon Leighton | 2011-11-03 | 1 | -0/+10 |
| | | | | Fixes #3425. | ||||
* | Fix #3247. | Jon Leighton | 2011-11-03 | 1 | -0/+5 |
| | | | | | Fixes creating records in a through association with a polymorphic source type. | ||||
* | Fixed failed test under 1.8.7 as map.keys order in indeterminable | Rocky Jaiswal | 2011-09-28 | 2 | -2/+2 |
| | |||||
* | Merge pull request #3030 from htanata/fix_habtm_select_query_method | Jon Leighton | 2011-09-26 | 2 | -0/+16 |
| | | | | Fix: habtm doesn't respect select query method | ||||
* | Fix belongs_to polymorphic with custom primary key on target. | Jon Leighton | 2011-09-26 | 1 | -0/+8 |
| | | | | Closes #3104. | ||||
* | CollectionProxy#replace should change the DB records rather than just ↵ | Jon Leighton | 2011-09-26 | 1 | -0/+11 |
| | | | | mutating the array. Fixes #3020. | ||||
* | Don't include any of includes, preload, joins, eager_load in the through ↵ | Jon Leighton | 2011-09-07 | 1 | -3/+5 |
| | | | | association scope. | ||||
* | Nested through associations: preloads from the default scope of a through ↵ | Jon Leighton | 2011-09-06 | 1 | -0/+9 |
| | | | | model should not be included in the association scope. (We're already excluding includes.) Fixes #2834. | ||||
* | Ensure we are not comparing a string with a symbol in ↵ | Jon Leighton | 2011-09-06 | 1 | -0/+10 |
| | | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be. |