aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations
Commit message (Collapse)AuthorAgeFilesLines
* Has many through - It is not necessary to manually merge in the conditions ↵Jon Leighton2011-01-301-1/+11
| | | | hash for the through record, because the creation is done directly on the through association, which will already handle setting the conditions.
* AssociationCollection#clear can basically just use #delete_all, except it ↵Jon Leighton2011-01-301-3/+6
| | | | should return self.
* AssociationCollection#to_ary should definitely dup the target! Also changed ↵Jon Leighton2011-01-301-0/+7
| | | | #replace which was previously incorrect, but the test passed due to the fact that to_a was not duping.
* DRY up first/last and hence make last benefit from the bugfix in firstJon Leighton2011-01-301-0/+6
|
* We shouldn't be using scoped.scoping { ... } to build associated records, as ↵Jon Leighton2011-01-302-1/+32
| | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved]
* Removed support for accessing attributes on a has_and_belongs_to_many join ↵Jon Leighton2011-01-161-83/+0
| | | | table. This has been documented as deprecated behaviour since April 2006. Please use has_many :through instead. A deprecation warning will be added to the 3-0-stable branch for the 3.0.4 release.
* belongs_to records should be initialized within the association scopeJon Leighton2011-01-161-0/+21
|
* Add create_association! for belongs_toJon Leighton2011-01-161-0/+17
|
* Add missing requireSantiago Pastorino2011-01-141-0/+1
|
* include_in_memory? should check against @target list in case of new records. ↵Aaron Patterson2011-01-121-0/+7
| | | | [#6257 state:resolved]
* adding a test for no method errorAaron Patterson2011-01-111-0/+52
|
* use underlying _read_attribute method rather than causing NoMethodErrorsAaron Patterson2011-01-111-1/+1
|
* Support for create_association! for has_one associationsJon Leighton2011-01-111-0/+18
|
* Get rid of set_association_target and association_loaded? as the parts of ↵Jon Leighton2011-01-111-1/+1
| | | | the code that need that can now just use association_proxy(:name).loaded?/target=
* Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵Jon Leighton2011-01-111-0/+13
| | | | replaced
* When assigning a has_one, if anything fails, the assignment should be rolled ↵Jon Leighton2011-01-111-2/+5
| | | | back entirely
* In a number of places in the tests, we only need to turn off transactional ↵Jon Leighton2011-01-111-1/+2
| | | | fixtures when the DB does not support savepoints. This speeds the test run up by about 8-9% on my computer, when running rake test_sqlite3_mem :)
* When assigning a has_one, if the new record fails to save, raise an errorJon Leighton2011-01-111-14/+14
|
* When assigning a has_one, if the existing record fails to be removed from ↵Jon Leighton2011-01-111-0/+12
| | | | the association, raise an error
* has_one should always remove the old record (properly), even if not saving ↵Jon Leighton2011-01-111-10/+25
| | | | the new record, so we don't get the database into a pickle
* Fix polymorphic belongs_to associationproxy raising errors when loading target.Ernie Miller2011-01-111-0/+9
|
* Don't not remove double negativesJon Leighton2011-01-071-1/+1
|
* Construct an actual ActiveRecord::Relation object for the association scope, ↵Jon Leighton2011-01-071-8/+0
| | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.
* just use a hash for doing association cachingAaron Patterson2011-01-071-2/+2
|
* fixing merge errorsAaron Patterson2011-01-042-78/+0
|
* Remove undocumented feature from has_one where you could pass false as the ↵Jon Leighton2011-01-032-36/+7
| | | | | | | | | | | | second parameter to build_assoc or create_assoc, and the existing associated object would be untouched (the foreign key would not be nullified, and it would not be deleted). If you want behaviour similar to this you can do the following things: * Use :dependent => :nullify (or don't specify :dependent) if you want to prevent the existing associated object from being deleted * Use has_many if you actually want multiple associated objects * Explicitly set the foreign key if, for some reason, you really need to have multiple objects associated with the same has_one. E.g. previous = obj.assoc obj.create_assoc previous.update_attributes(:obj_id => obj.id)
* When preloading a belongs_to, the target should still be set (to nil) if ↵Jon Leighton2011-01-031-0/+9
| | | | there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations.
* Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵Jon Leighton2011-01-031-7/+0
| | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
* Allow assignment on has_one :through where the owner is a new record [#5137 ↵Jon Leighton2011-01-033-22/+53
| | | | | | | | | | state:resolved] This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct. Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to *does* change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things. Phew, long commit message!
* Some basic tests for the :foreign_type option on belongs_to, which was ↵Jon Leighton2011-01-032-1/+31
| | | | previously completely untested.
* Support for :counter_cache on polymorphic belongs_toJon Leighton2010-12-311-0/+12
|
* Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵Jon Leighton2010-12-311-6/+36
| | | | inherit from it
* Verify that when has_many associated objects are destroyed via :dependent => ↵Jon Leighton2010-12-311-0/+9
| | | | :destroy, when the parent is destroyed, the callbacks are run
* Fix dodgy tests which were effectively asserting nil == nilJon Leighton2010-12-261-3/+3
|
* Raise an error for associations which try to go :through a polymorphic ↵Jon Leighton2010-12-231-3/+8
| | | | association [#6212 state:resolved]
* If a has_many goes :through a belongs_to, and the foreign key of the ↵Jon Leighton2010-12-233-23/+68
| | | | belongs_to changes, then the has_many should be considered stale.
* Test to verify that #2189 (count with has_many :through and a named_scope) ↵Jon Leighton2010-12-231-0/+5
| | | | is fixed
* Revert "Optimize <association>_ids for hm:t with belongs_to source". The ↵Jon Leighton2010-12-231-6/+2
| | | | | | | | | | optimisation has too many edge cases, such as when the reflection, source reflection, or through reflection has conditions, orders, etc. [#6153 state:resolved] This reverts commit 373b053dc8b99dac1abc3879a17a2bf8c30302b5. Conflicts: activerecord/lib/active_record/associations.rb
* Test demonstrating problem with foo.association_ids where it's a has_many ↵Jon Leighton2010-12-231-0/+4
| | | | :through with :conditions, with a belongs_to as the source reflection
* When a has_many association is not :uniq, appending the same record multiple ↵Jon Leighton2010-12-231-0/+10
| | | | times should append it to the @target multiple times [#5964 state:resolved]
* Fix behaviour of foo.has_many_through_association.select('custom select') ↵Michał Łomnicki2010-12-231-0/+5
| | | | [#6089 state:resolved]
* Fix creation of has_many through records with custom primary_key option on ↵Szymon Nowak2010-12-231-1/+29
| | | | belongs_to [#2990 state:resolved]
* Verify that has_one :through preload respects the :conditions [#2976 ↵Will Bryant2010-12-231-0/+12
| | | | state:resolved]
* Don't allow a has_one association to go :through a collection association ↵Jon Leighton2010-12-231-5/+7
| | | | [#2976 state:resolved]
* Fix for default_scope tests to ensure comparing of equally sorted listsRaimonds Simanovskis2010-12-232-2/+2
| | | | | | This is additional fix for commit ebc47465a5865ab91dc7d058d2d8a0cc961510d7 Respect the default_scope on a join model when reading a through association which otherwise was failing on Oracle (as it returned fixture comments in different order).
* removing SQL interpolation, please use scoping and attribute conditionals as ↵Aaron Patterson2010-12-221-4/+0
| | | | a replacement
* define_attr_method must serialize nil correctlyAaron Patterson2010-12-201-0/+4
|
* has_many associations with :dependent => :delete_all should update the ↵Jon Leighton2010-12-201-0/+12
| | | | counter cache when deleting records
* Fix problem where wrong keys are used in JoinAssociation when an association ↵Jon Leighton2010-12-201-0/+7
| | | | goes :through a belongs_to [#2801 state:resolved]
* Fix various issues with the :primary_key option in :through associations ↵Jon Leighton2010-12-151-0/+16
| | | | [#2421 state:resolved]
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 14:04:03 +0000