Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Deprecate Error#on(attribute) in favour of Errors#[attribute] | Pratik Naik | 2009-03-20 | 1 | -2/+2 |
| | |||||
* | Ensure AutosaveAssociation runs remove callbacks [#2146 state:resolved] | Luca Guidi | 2009-03-12 | 3 | -0/+69 |
| | | | | | Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure NoMethodError isn't raised when some of the nested eager loaded ↵ | Murray Steele | 2009-03-12 | 1 | -0/+29 |
| | | | | | | associations are empty [#1696 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed autosave checks on objects with hm:t in :include [#2213 state:resolved] | Will Bryant | 2009-03-12 | 3 | -0/+48 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Add tests for AssociationCollection#find_each and ↵ | Pratik Naik | 2009-03-11 | 1 | -0/+39 |
| | | | | AssociationCollection#find_in_batches | ||||
* | Ensure has_many :through works with changed primary keys [#736 state:resolved] | Jim Remsik and Tim Pope | 2009-03-09 | 1 | -1/+8 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix find_by_last when order is given [#2127 state:committed] | Jan De Poorter | 2009-03-09 | 1 | -0/+4 |
| | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Ruby 1.9 compat: rename deprecated assert_raises to assert_raise. | Jeremy Kemper | 2009-03-08 | 6 | -27/+27 |
| | | | | [#1617 state:resolved] | ||||
* | Fix RDoc grammar and ensure hm:t tests can run in isolation. [#1644 ↵ | Adam Milligan | 2009-03-07 | 1 | -0/+2 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure belongs_to association with a counter cache in name spaced model ↵ | Adam Cooper | 2009-03-06 | 1 | -0/+17 |
| | | | | | | works [#1678 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure replacing has_one associations respects the supplied :dependent ↵ | Dimitri Krassovski | 2009-03-06 | 1 | -0/+18 |
| | | | | | | option. [#1305 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure self referential HABTM associations raise an exception if ↵ | Tom Lea | 2009-03-06 | 1 | -0/+8 |
| | | | | | | association_foreign_key is missing. [#1252 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed that autosave should validate associations even if master is invalid ↵ | David Heinemeier Hansson | 2009-02-27 | 3 | -345/+0 |
| | | | | [#1930 status:committed] | ||||
* | Bump mocha requirement for Ruby 1.9 compat. Remove uses_mocha. | Jeremy Kemper | 2009-02-03 | 4 | -25/+17 |
| | |||||
* | Fix has_and_belongs_to_many_associations tests. #1738 | Pratik Naik | 2009-01-18 | 1 | -2/+2 |
| | |||||
* | Cache columns for has_and_belongs_to_many associations | lukeludwig | 2009-01-17 | 1 | -0/+11 |
| | | | | | This avoids repeatedly calling SHOW COLUMNS when the association is queried [#1738 state:committed] | ||||
* | Make belongs_to :dependent => :destroy destroy self before associated ↵ | Ben VandenBos | 2009-01-16 | 1 | -1/+2 |
| | | | | | | | | object [#1079 state:resolved] If foreign key constraints are in place then deleteing the associated object first will cause a foreign key violation Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Fix HasManyAssociation#create ignoring the :primary_key option [#1633 ↵ | Roman Shterenzon | 2008-12-27 | 1 | -0/+6 |
| | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Fix :include of has_one with :primary_key option | Frederick Cheung | 2008-12-26 | 1 | -0/+16 |
| | |||||
* | Fix :include of has_many associations with :primary_key option | Frederick Cheung | 2008-12-26 | 1 | -0/+17 |
| | |||||
* | Preload uses exclusive scope [#643 state:resolved] | Frederick Cheung | 2008-12-26 | 1 | -0/+15 |
| | | | | | | | | | With self referential associations, the scope for the the top level should not affect fetching of associations, for example when doing Person.male.find :all, :include => :friends we should load all of the friends for each male, not just the male friends. | ||||
* | Association preloading no longer stops if it hits a nil object [#1630 ↵ | Pivotal Labs | 2008-12-26 | 1 | -0/+8 |
| | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Fix configure_dependency_for_has_many not quoting conditions properly [#1461 ↵ | Frederick Cheung | 2008-12-21 | 1 | -0/+13 |
| | | | | state:resolved] | ||||
* | Use explicit order to stop test failing randomly | Frederick Cheung | 2008-12-21 | 1 | -2/+2 |
| | |||||
* | Fix has many through not quoting table names [#1163 state:resolved] | Karthik Krishnan | 2008-12-20 | 1 | -0/+4 |
| | | | | Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Fix preloading of has_one :through associations on belongs_to [#1507 ↵ | Matt Jones | 2008-12-18 | 1 | -1/+16 |
| | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Ensure :include checks joins when determining if it can preload [#528 ↵ | Frederick Cheung | 2008-12-18 | 1 | -0/+65 |
| | | | | state:resolved] | ||||
* | Add missing model files so tests can run isolated [#1506 state:resolved] | Emilio Tagua | 2008-12-18 | 1 | -0/+3 |
| | | | | Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Fix preloading of belongs_to with null foreign key generating useless query ↵ | Frederick Cheung | 2008-12-18 | 1 | -1/+2 |
| | | | | [#1027 state:resolved] | ||||
* | Revert "Fix: counter_cache should decrement on deleting associated records." | Jeremy Kemper | 2008-12-10 | 2 | -34/+0 |
| | | | | | | [#1196 state:open] This reverts commit 05f2183747c8e75c9e8bbaadb9573b4bdf41ecfc. | ||||
* | Fix: counter_cache should decrement on deleting associated records. | Emilio Tagua | 2008-12-10 | 2 | -0/+34 |
| | | | | | | [#1195 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Add :having option to find, to use in combination with grouped finds. Also ↵ | miloops | 2008-12-01 | 2 | -0/+10 |
| | | | | | | | added to has_many and has_and_belongs_to_many associations. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1028 state:committed] | ||||
* | Ensure hash conditions on referenced tables are considered when eager ↵ | Paul | 2008-11-26 | 1 | -2/+18 |
| | | | | | | loading with limit/offset. [#1404 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Remove SQL Server cases from tests for latest adapter work to pass rails ↵ | Ken Collins | 2008-11-19 | 1 | -1/+1 |
| | | | | | | expected behavior. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | fix assignment to has_one :through associations. | Matt Jones | 2008-11-15 | 1 | -1/+39 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Added tests for HABTM associations with counter_sql | Tekin Suleyman | 2008-11-07 | 1 | -0/+23 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1102 state:committed] | ||||
* | Skip collection ids reader optimization if using :finder_sql | Jeremy Kemper | 2008-10-23 | 1 | -0/+7 |
| | |||||
* | Ensure association proxy responds to private class methods defined in ↵ | Pratik Naik | 2008-10-16 | 1 | -2/+8 |
| | | | | associated class. [#1083] | ||||
* | Allow class methods to be sent (via #send) to association proxy (fix for bug ↵ | Ian White | 2008-10-16 | 1 | -0/+4 |
| | | | | | | introduced by 691aa20) [#1083] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure methods called on association proxies respect access control. [#1083 ↵ | Pratik Naik | 2008-10-13 | 3 | -0/+30 |
| | | | | state:resolved] [Adam Milligan, Pratik] | ||||
* | Remove the functionality introduce in 28d3390 | Michael Koziarski | 2008-10-10 | 1 | -13/+0 |
| | | | | There are several situations it doesn't cater for, and the inconsistency isn't worth blocking 2.2. | ||||
* | explicitly including child associations that are also included in the parent ↵ | Will Bryant | 2008-10-10 | 1 | -1/+41 |
| | | | | | | | association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed] | ||||
* | Fix has_many :through when the source is a belongs_to association. [#323 ↵ | Zach Dennis | 2008-10-04 | 3 | -1/+26 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | wrote a test showing eager loading's misbehavior (sanitizing against the ↵ | Will Bryant | 2008-09-29 | 1 | -0/+7 |
| | | | | | | wrong table) when the association has a :conditions hash Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Make AssociationCollection start transactions in the correct database. | Hongli Lai (Phusion) | 2008-09-23 | 3 | -0/+27 |
| | | | | | | | | | | AssociationCollection now starts transactions by calling AssociationCollection#transaction instead of @owner.transaction or @reflection.klass.transaction. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1081 state:committed] | ||||
* | Association#first and last should not load the association if not needed. ↵ | Jan De Poorter | 2008-09-22 | 2 | -1/+14 |
| | | | | | | [#1091 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | applied patch to fix the associations with blocks in modules bug from an old ↵ | Adeh DeSandies | 2008-09-20 | 1 | -0/+15 |
| | | | | trac ticket | ||||
* | When counting grouped records the target should be loaded to return a valid ↵ | miloops | 2008-09-15 | 1 | -0/+2 |
| | | | | | | | | | groups count result. Without this change count_records will group for the count in the query and return erroneous results. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#937 state:committed] | ||||
* | Support for updating a belongs to association from the foreign key (without ↵ | Jon Leighton | 2008-09-13 | 1 | -0/+13 |
| | | | | | | | saving and reloading the record) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#142 state:committed] | ||||
* | Improve test coverage when using the group option in find, has_many or ↵ | miloops | 2008-09-11 | 2 | -0/+17 |
| | | | | | | has_and_belongs_to_many. Signed-off-by: Michael Koziarski <michael@koziarski.com> |