aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations/has_many_associations_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Remove ActiveRelation#inspectBrian Cardarella2012-06-291-1/+1
|
* No need to cache table metadata in advance now that #6683 was merged.Rafael Mendonça França2012-06-111-5/+0
|
* Merge pull request #6492 from pmahoney/fair-connection-pool2Rafael Mendonça França2012-06-111-0/+3
|\ | | | | | | | | | | | | Fair connection pool2 Conflicts: activerecord/test/cases/associations/eager_test.rb
| * Make connection pool fair with respect to waiting threads.Patrick Mahoney2012-05-251-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The core of this fix is a threadsafe, fair Queue class. It is very similar to Queue in stdlib except that it supports waiting with a timeout. The issue this solves is that if several threads are contending for database connections, an unfair queue makes is possible that a thread will timeout even while other threads successfully acquire and release connections. A fair queue means the thread that has been waiting the longest will get the next available connection. This includes a few test fixes to avoid test ordering issues that cropped up during development of this patch.
* | Add support for CollectionAssociation#delete by Fixnum or StringFrancesco Rodriguez2012-05-281-3/+17
|/ | | | | | | | | | | | | | | | | | | | | | | | I found the next issue between CollectionAssociation `delete` and `destroy`. class Person < ActiveRecord::Base has_many :pets end person.pets.destroy(1) # => OK, returns the destroyed object person.pets.destroy("2") # => OK, returns the destroyed object person.pets.delete(1) # => ActiveRecord::AssociationTypeMismatch person.pets.delete("2") # => ActiveRecord::AssociationTypeMismatch Adding support for deleting with a fixnum or string like `destroy` method.
* Ensure that CollectionAssociation#replace returns proper targetPiotr Sarnacki2012-05-191-2/+2
| | | | | | | | The fix commited in e2a070c was returning the `new_target`, as a try to return whatever user replaced association with. The problem is, the resulting association target may be ordered differently. In such case we want to return the target that will be later used for that association.
* Perf: Don't load the association for #delete_all.Jon Leighton2012-05-181-0/+12
| | | | Bug #6289
* quarantine deprecated testsJon Leighton2012-05-181-121/+8
|
* Fix CollectionAssociation#replace to return new target (closes #6231)Piotr Sarnacki2012-05-161-0/+12
|
* Remove #=== quirkJon Leighton2012-05-111-6/+0
| | | | Makes it consistent with Relation. Can't see a use for this.
* CollectionProxy < RelationJon Leighton2012-05-111-4/+17
| | | | | | | | | | | | | | | | | | | | | This helps bring the interfaces of CollectionProxy and Relation closer together, and reduces the delegation backflips we need to perform. For example, first_or_create is defined thus: class ActiveRecord::Relation def first_or_create(...) first || create(...) end end If CollectionProxy < Relation, then post.comments.first_or_create will hit the association's #create method which will actually add the new record to the association, just as post.comments.create would. With the previous delegation, post.comments.first_or_create expands to post.comments.scoped.first_or_create, where post.comments.scoped has no knowledge of the association.
* Fix issue with private kernel methods and collection associations. Closes #2508Carlos Antonio da Silva2012-05-021-0/+5
| | | | | | | | Change CollectionProxy#method_missing to use scoped.public_send, to avoid a problem described in issue #2508 when trying to use class methods with names like "open", that clash with private kernel methods. Also changed the dynamic matcher instantiator to send straight to scoped, to avoid another roundtrip to method_missing.
* remove deprecated callsJon Leighton2012-04-271-2/+2
|
* find and replace deprecated keysJon Leighton2012-04-271-24/+24
|
* %s/find(:\(first\|last\|all\), \([^()]*\))/scoped(\2).\1/gcI amongst other ↵Jon Leighton2012-04-271-57/+57
| | | | things
* don't need this testJon Leighton2012-04-261-5/+0
|
* remove calls to find(:first), find(:last) and find(:all)Jon Leighton2012-04-261-11/+6
|
* remove deprecated #first callsJon Leighton2012-04-261-12/+1
|
* remove deprecate #calculate callsJon Leighton2012-04-261-9/+1
|
* remove deprecated #find_in_batches callsJon Leighton2012-04-261-1/+1
|
* In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] ↵Alexey Vakhov2012-03-091-0/+7
| | | | correct
* Fix #5069 - Protect foreign key from mass assignment throught association ↵Jean Boussier2012-03-051-0/+22
| | | | builder
* Merge pull request #4543 from jdelStrother/find_or_initJon Leighton2012-02-011-0/+12
|\ | | | | Don't instantiate two objects in collection proxy / find_or_instantiate_by
| * Don't instantiate two objects in collection proxy / find_or_instantiator_byJonathan del Strother2012-01-191-0/+12
| |
* | fix has_one, has_many restrict error messageManoj2012-02-011-1/+1
| |
* | Merge pull request #4791 from gregolsen/reflection_test_fixedJosé Valim2012-01-311-1/+1
|\ \ | | | | | | reflection test fixed
| * | test_get_ids_for_ordered_association fixedgregolsen2012-01-311-1/+1
| | |
* | | Remove deprecation warnings from testsRafael Mendonça França2012-01-311-7/+13
|/ /
* | Merge pull request #4783 from gregolsen/ids_reader_fixJon Leighton2012-01-311-0/+4
|\ \ | | | | | | ids_reader method fixed, test added to has_many association (for PostgreSQL)
| * | ids_reader method fixed, test added to has_many associationgregolsen2012-01-311-0/+4
| |/
* | suggested fixes for :dependent => :restrict deprecation.Manoj2012-01-311-16/+5
| |
* | has_many/has_one, :dependent => :restrict, deprecation added.Manoj2012-01-291-12/+55
|/
* allow reorder to affect eager loading correctlyMatt Jones + Scott Walker2011-12-281-0/+10
|
* load has_many associations keyed off a custom primary key if that key is ↵Brian Samson2011-11-251-1/+28
| | | | present but the record is unsaved
* Merge pull request #3507 from jmazzi/issue-3503Jeremy Kemper2011-11-031-0/+15
| | | | Preserve SELECT columns on the COUNT for finder_sql when possible
* Fixed failed test under 1.8.7 as map.keys order in indeterminableRocky Jaiswal2011-09-281-1/+1
|
* Merge pull request #3030 from htanata/fix_habtm_select_query_methodJon Leighton2011-09-261-0/+8
| | | | Fix: habtm doesn't respect select query method
* CollectionProxy#replace should change the DB records rather than just ↵Jon Leighton2011-09-261-0/+11
| | | | mutating the array. Fixes #3020.
* Ensure we are not comparing a string with a symbol in ↵Jon Leighton2011-09-061-0/+10
| | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be.
* Fixed CollectionAssociation#find to be compatible with Array#findBogdan Gusiev2011-07-051-0/+4
| | | | | In order to make CollectionAssociation behave closer to Array Add the ability to pass block to #find method just like Array#find does.
* Assign the association attributes to the associated record before the ↵Jon Leighton2011-06-301-0/+7
| | | | before_initialize callback of the record runs. Fixes #1842.
* Make assert_no_queries literally enforce that there are no queries. As in, ↵Jon Leighton2011-06-121-15/+0
| | | | not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries.
* Refactor tests to be less brittleJon Leighton2011-06-121-25/+58
|
* Don't wrap operations on collection associations in transactions when they ↵benedikt2011-06-121-0/+45
| | | | are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database.
* please use ruby -I lib:test path/to/test.rb, or export RUBY_OPTAaron Patterson2011-06-061-1/+1
|
* Refactor Active Record test connection setup. Please see the ↵Jon Leighton2011-06-041-1/+1
| | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
* added an alias for new to build to the AR collection proxy, this corrects an ↵Josh Kalderimis2011-06-011-0/+10
| | | | issue where the collection proxies were not consistent
* Tests for issue #1360Farley Knight2011-05-311-0/+9
|
* Fix problem with loading polymorphic associations which have been defined in ↵Jon Leighton2011-05-221-0/+7
| | | | an abstract superclass. Fixes #552.
* Pass the attribute and option hashes to build_associationAndrew White2011-05-171-0/+13
| | | | | | | The build_association method was added as an API for plugins to hook into in 1398db0. This commit restores this API and the ability to override class.new to return a subclass based on a virtual attribute in the attributes hash.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-27 15:34:03 +0000