Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Remove deprecation warnings from tests | Rafael Mendonça França | 2012-01-31 | 1 | -7/+13 | |
|/ / | ||||||
* | | Merge pull request #4783 from gregolsen/ids_reader_fix | Jon Leighton | 2012-01-31 | 1 | -0/+4 | |
|\ \ | | | | | | | ids_reader method fixed, test added to has_many association (for PostgreSQL) | |||||
| * | | ids_reader method fixed, test added to has_many association | gregolsen | 2012-01-31 | 1 | -0/+4 | |
| |/ | ||||||
* | | suggested fixes for :dependent => :restrict deprecation. | Manoj | 2012-01-31 | 1 | -16/+5 | |
| | | ||||||
* | | has_many/has_one, :dependent => :restrict, deprecation added. | Manoj | 2012-01-29 | 1 | -12/+55 | |
|/ | ||||||
* | allow reorder to affect eager loading correctly | Matt Jones + Scott Walker | 2011-12-28 | 1 | -0/+10 | |
| | ||||||
* | load has_many associations keyed off a custom primary key if that key is ↵ | Brian Samson | 2011-11-25 | 1 | -1/+28 | |
| | | | | present but the record is unsaved | |||||
* | Merge pull request #3507 from jmazzi/issue-3503 | Jeremy Kemper | 2011-11-03 | 1 | -0/+15 | |
| | | | | Preserve SELECT columns on the COUNT for finder_sql when possible | |||||
* | Fixed failed test under 1.8.7 as map.keys order in indeterminable | Rocky Jaiswal | 2011-09-28 | 1 | -1/+1 | |
| | ||||||
* | Merge pull request #3030 from htanata/fix_habtm_select_query_method | Jon Leighton | 2011-09-26 | 1 | -0/+8 | |
| | | | | Fix: habtm doesn't respect select query method | |||||
* | CollectionProxy#replace should change the DB records rather than just ↵ | Jon Leighton | 2011-09-26 | 1 | -0/+11 | |
| | | | | mutating the array. Fixes #3020. | |||||
* | Ensure we are not comparing a string with a symbol in ↵ | Jon Leighton | 2011-09-06 | 1 | -0/+10 | |
| | | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be. | |||||
* | Fixed CollectionAssociation#find to be compatible with Array#find | Bogdan Gusiev | 2011-07-05 | 1 | -0/+4 | |
| | | | | | In order to make CollectionAssociation behave closer to Array Add the ability to pass block to #find method just like Array#find does. | |||||
* | Assign the association attributes to the associated record before the ↵ | Jon Leighton | 2011-06-30 | 1 | -0/+7 | |
| | | | | before_initialize callback of the record runs. Fixes #1842. | |||||
* | Make assert_no_queries literally enforce that there are no queries. As in, ↵ | Jon Leighton | 2011-06-12 | 1 | -15/+0 | |
| | | | | not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries. | |||||
* | Refactor tests to be less brittle | Jon Leighton | 2011-06-12 | 1 | -25/+58 | |
| | ||||||
* | Don't wrap operations on collection associations in transactions when they ↵ | benedikt | 2011-06-12 | 1 | -0/+45 | |
| | | | | are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database. | |||||
* | please use ruby -I lib:test path/to/test.rb, or export RUBY_OPT | Aaron Patterson | 2011-06-06 | 1 | -1/+1 | |
| | ||||||
* | Refactor Active Record test connection setup. Please see the ↵ | Jon Leighton | 2011-06-04 | 1 | -1/+1 | |
| | | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. | |||||
* | added an alias for new to build to the AR collection proxy, this corrects an ↵ | Josh Kalderimis | 2011-06-01 | 1 | -0/+10 | |
| | | | | issue where the collection proxies were not consistent | |||||
* | Tests for issue #1360 | Farley Knight | 2011-05-31 | 1 | -0/+9 | |
| | ||||||
* | Fix problem with loading polymorphic associations which have been defined in ↵ | Jon Leighton | 2011-05-22 | 1 | -0/+7 | |
| | | | | an abstract superclass. Fixes #552. | |||||
* | Pass the attribute and option hashes to build_association | Andrew White | 2011-05-17 | 1 | -0/+13 | |
| | | | | | | | The build_association method was added as an API for plugins to hook into in 1398db0. This commit restores this API and the ability to override class.new to return a subclass based on a virtual attribute in the attributes hash. | |||||
* | CollectionAssociation#merge_target_lists should write to the underlying ↵ | Jon Leighton | 2011-05-14 | 1 | -0/+10 | |
| | | | | attributes when copying, rather than using the assignment method | |||||
* | Add test to specify that attributes from an association's conditions should ↵ | Jon Leighton | 2011-05-10 | 1 | -4/+23 | |
| | | | | be assigned without mass-assignment protection when a record is built on the association. | |||||
* | Don't use mass-assignment protection when applying the ↵ | Jon Leighton | 2011-05-10 | 1 | -0/+9 | |
| | | | | scoped.scope_for_create. Fixes #481. | |||||
* | Add failing tests according to #479. | José Valim | 2011-05-10 | 1 | -0/+15 | |
| | ||||||
* | Add failing tests, according to #480. | José Valim | 2011-05-10 | 1 | -0/+14 | |
| | ||||||
* | Fix for lighthouse #6741 | Nick Howard | 2011-05-01 | 1 | -0/+24 | |
| | | | | | | | - adds tests for find_or_create_by and find_or_initialize_by on has_many associations - changes the behavior of ActiveRecord::Associations::CollectionProxy#method_missing to differ to ActiveRecord::FinderMethods#find_or_instantiator_by_attributes for arg processing and saving so find_or_create_by's api on associations will be consistent w/ the api for model classes. | |||||
* | Deprecated support for passing hashes and relations to default_scope, in ↵ | Jon Leighton | 2011-04-12 | 1 | -7/+7 | |
| | | | | favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details. | |||||
* | Added new #update_column method. | Sebastian Martinez | 2011-03-27 | 1 | -3/+3 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Revert "Removed #update_attribute method. New #update_column method." | Sebastian Martinez | 2011-03-27 | 1 | -3/+3 | |
| | | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Removed #update_attribute method. New #update_column method. | Sebastian Martinez | 2011-03-26 | 1 | -3/+3 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Add interpolation of association conditions back in, in the form of proc { ↵ | Jon Leighton | 2011-02-14 | 1 | -1/+0 | |
| | | | | ... } rather than instance_eval-ing strings | |||||
* | Correctly update counter caches on deletion for has_many :through [#2824 ↵ | Jon Leighton | 2011-02-07 | 1 | -8/+14 | |
| | | | | state:resolved]. Also fixed a bunch of other counter cache bugs in the process, as once I fixed this one others started appearing like nobody's business. | |||||
* | AssociationCollection#clear can basically just use #delete_all, except it ↵ | Jon Leighton | 2011-01-30 | 1 | -3/+6 | |
| | | | | should return self. | |||||
* | AssociationCollection#to_ary should definitely dup the target! Also changed ↵ | Jon Leighton | 2011-01-30 | 1 | -0/+7 | |
| | | | | #replace which was previously incorrect, but the test passed due to the fact that to_a was not duping. | |||||
* | DRY up first/last and hence make last benefit from the bugfix in first | Jon Leighton | 2011-01-30 | 1 | -0/+6 | |
| | ||||||
* | We shouldn't be using scoped.scoping { ... } to build associated records, as ↵ | Jon Leighton | 2011-01-30 | 1 | -1/+17 | |
| | | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved] | |||||
* | Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵ | Jon Leighton | 2011-01-11 | 1 | -0/+13 | |
| | | | | replaced | |||||
* | has_many associations with :dependent => :delete_all should update the ↵ | Jon Leighton | 2010-12-20 | 1 | -0/+12 | |
| | | | | counter cache when deleting records | |||||
* | removing unused variables | Aaron Patterson | 2010-11-22 | 1 | -2/+1 | |
| | ||||||
* | reloading an association will properly set attributes of instantiated ↵ | Aaron Patterson | 2010-11-16 | 1 | -0/+21 | |
| | | | | objects. Thanks Brian Palmer [#5802 state:resolved] | |||||
* | if association is already loaded and if a find operation is performed on the ↵ | Neeraj Singh | 2010-11-15 | 1 | -0/+11 | |
| | | | | | | already loaded association list with an empty hash then do not perform another sql [#5972 state:resolved] | |||||
* | fisting a bunch of unused variable warnings | Aaron Patterson | 2010-11-15 | 1 | -9/+7 | |
| | ||||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 1 | -6/+6 | |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | AssociationCollection#include? working properly for objects added with build ↵ | Marcelo Giorgi | 2010-09-30 | 1 | -0/+6 | |
| | | | | method [#3472 state:resolved] | |||||
* | Set attributes properly for model built from association with conditions ↵ | Marcelo Giorgi | 2010-09-28 | 1 | -0/+12 | |
| | | | | | | [#5562 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Change relation merging to always append select, group and order values | Pratik Naik | 2010-08-31 | 1 | -20/+5 | |
| | ||||||
* | While creating a new record using has_many create method default scope of ↵ | Neeraj Singh | 2010-08-19 | 1 | -0/+19 | |
| | | | | | | | | | | | child should be respected. author.posts.create should take into account default_scope defined on post. [#3939: state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> |