Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Deprecated support for passing hashes and relations to default_scope, in ↵ | Jon Leighton | 2011-04-12 | 1 | -7/+7 |
| | | | | favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details. | ||||
* | Added new #update_column method. | Sebastian Martinez | 2011-03-27 | 1 | -3/+3 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Revert "Removed #update_attribute method. New #update_column method." | Sebastian Martinez | 2011-03-27 | 1 | -3/+3 |
| | | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Removed #update_attribute method. New #update_column method. | Sebastian Martinez | 2011-03-26 | 1 | -3/+3 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add interpolation of association conditions back in, in the form of proc { ↵ | Jon Leighton | 2011-02-14 | 1 | -1/+0 |
| | | | | ... } rather than instance_eval-ing strings | ||||
* | Correctly update counter caches on deletion for has_many :through [#2824 ↵ | Jon Leighton | 2011-02-07 | 1 | -8/+14 |
| | | | | state:resolved]. Also fixed a bunch of other counter cache bugs in the process, as once I fixed this one others started appearing like nobody's business. | ||||
* | AssociationCollection#clear can basically just use #delete_all, except it ↵ | Jon Leighton | 2011-01-30 | 1 | -3/+6 |
| | | | | should return self. | ||||
* | AssociationCollection#to_ary should definitely dup the target! Also changed ↵ | Jon Leighton | 2011-01-30 | 1 | -0/+7 |
| | | | | #replace which was previously incorrect, but the test passed due to the fact that to_a was not duping. | ||||
* | DRY up first/last and hence make last benefit from the bugfix in first | Jon Leighton | 2011-01-30 | 1 | -0/+6 |
| | |||||
* | We shouldn't be using scoped.scoping { ... } to build associated records, as ↵ | Jon Leighton | 2011-01-30 | 1 | -1/+17 |
| | | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved] | ||||
* | Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵ | Jon Leighton | 2011-01-11 | 1 | -0/+13 |
| | | | | replaced | ||||
* | has_many associations with :dependent => :delete_all should update the ↵ | Jon Leighton | 2010-12-20 | 1 | -0/+12 |
| | | | | counter cache when deleting records | ||||
* | removing unused variables | Aaron Patterson | 2010-11-22 | 1 | -2/+1 |
| | |||||
* | reloading an association will properly set attributes of instantiated ↵ | Aaron Patterson | 2010-11-16 | 1 | -0/+21 |
| | | | | objects. Thanks Brian Palmer [#5802 state:resolved] | ||||
* | if association is already loaded and if a find operation is performed on the ↵ | Neeraj Singh | 2010-11-15 | 1 | -0/+11 |
| | | | | | | already loaded association list with an empty hash then do not perform another sql [#5972 state:resolved] | ||||
* | fisting a bunch of unused variable warnings | Aaron Patterson | 2010-11-15 | 1 | -9/+7 |
| | |||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 1 | -6/+6 |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | AssociationCollection#include? working properly for objects added with build ↵ | Marcelo Giorgi | 2010-09-30 | 1 | -0/+6 |
| | | | | method [#3472 state:resolved] | ||||
* | Set attributes properly for model built from association with conditions ↵ | Marcelo Giorgi | 2010-09-28 | 1 | -0/+12 |
| | | | | | | [#5562 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Change relation merging to always append select, group and order values | Pratik Naik | 2010-08-31 | 1 | -20/+5 |
| | |||||
* | While creating a new record using has_many create method default scope of ↵ | Neeraj Singh | 2010-08-19 | 1 | -0/+19 |
| | | | | | | | | | | | child should be respected. author.posts.create should take into account default_scope defined on post. [#3939: state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | code gardening: we have assert_(nil|blank|present), more concise, with ↵ | Xavier Noria | 2010-08-17 | 1 | -2/+2 |
| | | | | better default failure messages - let's use them | ||||
* | fixed joining of attributes when using find_or_create_by with multiple ↵ | Jon Buda | 2010-07-28 | 1 | -0/+9 |
| | | | | | | attributes through an association Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove unintentional API changes. [#1108] | Pratik Naik | 2010-07-14 | 1 | -41/+9 |
| | |||||
* | count method should not take options if it is operated on has_many ↵ | Neeraj Singh | 2010-07-13 | 1 | -0/+26 |
| | | | | | | | | association which has finder_sql or counter_sql [#2395 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | renaming test name to fix accidently override | Subba Rao Pasupuleti | 2010-07-13 | 1 | -1/+1 |
| | | | | | | [#5076 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fix ActiveRecord `destroy_all` so it returns destroyed records | Mislav Marohnić | 2010-07-08 | 1 | -2/+5 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | AssociationCollection#create_by_*, find_or_create_by_* work properly now. ↵ | Aaron Patterson | 2010-06-29 | 1 | -0/+62 |
| | | | | | | [#1108 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | do order by id when finding first fixture to ensure that it is correct one | Raimonds Simanovskis | 2010-06-04 | 1 | -1/+1 |
| | | | | (as otherwise was failing under JRuby and oracle_enhanced adapter) | ||||
* | Use better assertion methods for testing | Neeraj Singh | 2010-05-19 | 1 | -10/+3 |
| | | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix for get_ids when including a belongs_to association on a has_many ↵ | Diego Algorta | 2010-05-15 | 1 | -0/+4 |
| | | | | | | association [#2896 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Add tests to prevent regression of lazy evaluation of has_many ..., ↵ | Andrew White | 2010-04-04 | 1 | -0/+18 |
| | | | | | | | | :dependent => :___ [#2627 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Add :dependent = to has_one and has_many [#3075 state:resolved] | Rizwan Reza | 2010-03-28 | 1 | -0/+8 |
| | |||||
* | Fix associations to call :destroy or :delete based on the right :dependent ↵ | Carlos Antonio da Silva | 2010-03-09 | 1 | -19/+1 |
| | | | | | | option Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Forgot to revert tests from that last commit | Joshua Peek | 2009-12-12 | 1 | -8/+0 |
| | |||||
* | Revert "Fix instance_eval calls to association proxies" | Joshua Peek | 2009-12-12 | 1 | -1/+0 |
| | | | | | | | | | | I think it may of broke the build. Lets see. This reverts commit 49e943c4f0ac3459bd53023167aaa08fc8e46733. Conflicts: activerecord/test/cases/associations/has_many_associations_test.rb | ||||
* | Fix postgresql AR test failure | John Pignata | 2009-12-11 | 1 | -2/+2 |
| | | | | | | | | Due to the ordering of the returning result set, the test fails under the postgresql adapter. Order results by id prior to checking the first item [#3542 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fix instance_eval calls to association proxies | Mat Brown | 2009-12-02 | 1 | -0/+8 |
| | | | | | | | | In the current stable, ActiveRecord::Associations::AssociationProxy#method_missing calls yield() if a block is given, causing the block to always be evaluated in its calling context. However, in the case of instance_eval, correct behavior requires that the block be passed directly to the @target, rather than being evaluated inside a different block. Incidentally, this also simplifies the code slightly. [#3412 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | delete correct records for a has_many with :primary_key and :dependent => ↵ | Matt Jones | 2009-11-10 | 1 | -0/+12 |
| | | | | | | :delete_all Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Changed ActiveRecord to use new callbacks and speed up observers by only ↵ | José Valim | 2009-09-08 | 1 | -1/+1 |
| | | | | | | notifying events that are actually being consumed. Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Fix test dependency on taggings | Jeremy Kemper | 2009-08-09 | 1 | -1/+2 |
| | |||||
* | Fix that counter_cache breaks with has_many :dependent => :nullify. | Gabe da Silveira | 2009-08-09 | 1 | -0/+25 |
| | | | | | | [#1196 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Enable has_many :through for going through a has_one association on the join ↵ | Gabe da Silveira | 2009-08-10 | 1 | -1/+1 |
| | | | | | | model [#2719 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Make sure association conditions work with :include and :joins [#358 ↵ | Vladimir Meremyanin | 2009-08-09 | 1 | -0/+6 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Added back support for destroying an association's object by id. [#2306 ↵ | Joshua Nichols | 2009-08-09 | 1 | -0/+22 |
| | | | | | | status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | added :order option to find :first methods and associations as otherwise ↵ | Raimonds Simanovskis | 2009-08-06 | 1 | -38/+42 |
| | | | | | | | | Oracle tests were failing Oracle stores '' string as NULL Oracle cannot have identifiers larger than 30 characters added missing fixtures to test setup method | ||||
* | Revert "Revert "Generate proper :counter_sql from :finder_sql when there is ↵ | Pratik Naik | 2009-07-01 | 1 | -0/+5 |
| | | | | | | | | | a newline character immediately following 'SELECT' [#2118 state:resolved]"" This reverts commit 80f1f863cd0f9cba89079511282de5710a2e1832. The feature doesn't work on Postgres, so don't test it on Postgres. Also, Postgres compatibility is irrelevant to the ticket/patch in question. | ||||
* | Revert "Generate proper :counter_sql from :finder_sql when there is a ↵ | Yehuda Katz + Carl Lerche | 2009-06-22 | 1 | -5/+0 |
| | | | | | | | | newline character immediately following 'SELECT' [#2118 state:resolved]" This reverts commit 4851ca9e13a4317342df02ae25b1929340523f7a. The tests do not pass for postgresql. | ||||
* | Generate proper :counter_sql from :finder_sql when there is a newline ↵ | Patrick Joyce | 2009-06-21 | 1 | -0/+5 |
| | | | | | | character immediately following 'SELECT' [#2118 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Implement #many? for NamedScope and AssociationCollection using #size [#1500 ↵ | Chris Kampmeier | 2009-05-17 | 1 | -0/+39 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> |