aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations/eager_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate ActiveRecord::Base.scoped.Jon Leighton2012-07-271-114/+114
| | | | | | | It doesn't serve much purpose now that ActiveRecord::Base.all returns a Relation. The code is moved to active_record_deprecated_finders.
* ActiveRecord::Base.all returns a Relation.Jon Leighton2012-07-271-76/+76
| | | | | | | | | | | Previously it returned an Array. If you want an array, call e.g. `Post.to_a` rather than `Post.all`. This is more explicit. In most cases this should not break existing code, since Relations use method_missing to delegate unknown methods to #to_a anyway.
* No need to cache table metadata in advance now that #6683 was merged.Rafael Mendonça França2012-06-111-11/+0
|
* Merge pull request #6492 from pmahoney/fair-connection-pool2Rafael Mendonça França2012-06-111-0/+4
|\ | | | | | | | | | | | | Fair connection pool2 Conflicts: activerecord/test/cases/associations/eager_test.rb
| * Cache metadata in advance to avoid extra sql statements while testing.Yasuo Honda2012-05-251-0/+7
| | | | | | | | | | Reason: If metadata is not cached extra sql statements will be executed, which causes failures tests with assert_queries().
* | Fix fragile #assert_queries implementation and usages.Steve Jorgensen2012-06-091-2/+0
|/ | | | | | | | | Several tests that passed when run in the order they are loaded by rake test were failing when run in different sequences due to problems with the implementation of assert_queries and assert_no_queries as well as incorrect assumptions made about how many queries might be executed by a database adapter in various cases.
* CollectionProxy < RelationJon Leighton2012-05-111-1/+1
| | | | | | | | | | | | | | | | | | | | | This helps bring the interfaces of CollectionProxy and Relation closer together, and reduces the delegation backflips we need to perform. For example, first_or_create is defined thus: class ActiveRecord::Relation def first_or_create(...) first || create(...) end end If CollectionProxy < Relation, then post.comments.first_or_create will hit the association's #create method which will actually add the new record to the association, just as post.comments.create would. With the previous delegation, post.comments.first_or_create expands to post.comments.scoped.first_or_create, where post.comments.scoped has no knowledge of the association.
* remove deprecated callsJon Leighton2012-04-271-46/+46
|
* more deprecations manually fixedJon Leighton2012-04-271-31/+31
|
* find and replace deprecated keysJon Leighton2012-04-271-63/+63
|
* %s/find(:\(first\|last\|all\), \([^()]*\))/scoped(\2).\1/gcI amongst other ↵Jon Leighton2012-04-271-79/+79
| | | | things
* remove calls to find(:first), find(:last) and find(:all)Jon Leighton2012-04-261-2/+2
|
* remove deprecate #calculate callsJon Leighton2012-04-261-2/+2
|
* remove tests for #with_scope (it's now deprecated)Jon Leighton2012-04-251-33/+0
|
* fix testsJon Leighton2012-04-131-62/+61
|
* Adds test to check that circular preloading does not modify Model.unscoped ↵Benedikt Deicke2012-04-031-0/+6
| | | | (as described in #5667)
* Fix #5667. Preloading should ignore scoping.Jon Leighton2012-03-301-0/+11
|
* Remove IdentityMapCarlos Antonio da Silva2012-03-131-10/+10
|
* Deprecate inferred JOINs with includes + SQL snippets.Jon Leighton2012-01-161-27/+94
| | | | | | See the CHANGELOG for details. Fixes #950.
* Revert "Deprecate implicit eager loading. Closes #950."Jon Leighton2012-01-161-42/+42
| | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9.
* Deprecate implicit eager loading. Closes #950.Jon Leighton2011-12-291-42/+42
|
* More tests deep including through habtmArun Agrawal2011-12-211-0/+7
| | | fixes #3183
* reintroduce patch from #726 to handle nested eager loading via associationsJay Levitt2011-11-301-0/+35
|
* ActiveRecord: Fix eager loading so that giving a blank order clause ↵Elliot Winkler2011-07-181-0/+12
| | | | generates valid SQL
* Foo.joins(:bar).includes(:bar) should result in a single query with :bar as ↵Jon Leighton2011-07-091-0/+8
| | | | a join. Related: #1873.
* please use ruby -I lib:test path/to/test.rb, or export RUBY_OPTAaron Patterson2011-06-061-1/+1
|
* Refactor Active Record test connection setup. Please see the ↵Jon Leighton2011-06-041-1/+1
| | | | RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
* fixing test for mysql2Aaron Patterson2011-05-271-5/+2
|
* adding a test for #1322Aaron Patterson2011-05-261-0/+15
|
* Merge pull request #1254 from pixeltrix/ignore-includes-in-through-scopeJon Leighton2011-05-241-0/+6
|\ | | | | Ignore :includes on through associations
| * Ignore :includes on through associationsAndrew White2011-05-241-0/+6
| |
* | Failing tests for #1233.Andrew White2011-05-241-0/+40
|/
* fixing more test warnings in 1.9.3Aaron Patterson2011-04-301-2/+2
|
* Added test case and fix for proper eager loading associationsPavel Forkert2011-04-221-0/+10
|
* When preloading has_and_belongs_to_many associations, we should only ↵Jon Leighton2011-03-041-0/+16
| | | | instantiate one AR object per actual record in the database. (Even when IM is off.)
* Merge branch 'master' into nested_has_many_throughJon Leighton2011-03-041-30/+84
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/class_methods/join_dependency.rb activerecord/lib/active_record/associations/class_methods/join_dependency/join_association.rb activerecord/lib/active_record/associations/has_many_association.rb activerecord/lib/active_record/associations/has_many_through_association.rb activerecord/lib/active_record/associations/has_one_association.rb activerecord/lib/active_record/associations/has_one_through_association.rb activerecord/lib/active_record/associations/through_association_scope.rb activerecord/lib/active_record/reflection.rb activerecord/test/cases/associations/has_many_through_associations_test.rb activerecord/test/cases/associations/has_one_through_associations_test.rb activerecord/test/cases/reflection_test.rb activerecord/test/cases/relations_test.rb activerecord/test/fixtures/memberships.yml activerecord/test/models/categorization.rb activerecord/test/models/category.rb activerecord/test/models/member.rb activerecord/test/models/reference.rb activerecord/test/models/tagging.rb
| * Rewrote AssociationPreload.Jon Leighton2011-02-281-15/+14
| |
| * Run tests without IdentityMap when IM=false is given.Emilio Tagua2011-02-151-7/+7
| |
| * Merge remote branch 'rails/master' into identity_mapEmilio Tagua2011-02-151-8/+48
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/examples/performance.rb activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/nested_attributes.rb activerecord/test/cases/relations_test.rb
| | * Add interpolation of association conditions back in, in the form of proc { ↵Jon Leighton2011-02-141-0/+8
| | | | | | | | | | | | ... } rather than instance_eval-ing strings
| | * the connection pool caches table_exists? callsAaron Patterson2011-02-071-0/+2
| | |
| | * When preloading a belongs_to, the target should still be set (to nil) if ↵Jon Leighton2011-01-031-0/+9
| | | | | | | | | | | | there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations.
| | * Allow assignment on has_one :through where the owner is a new record [#5137 ↵Jon Leighton2011-01-031-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | state:resolved] This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct. Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to *does* change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things. Phew, long commit message!
| | * Some basic tests for the :foreign_type option on belongs_to, which was ↵Jon Leighton2011-01-031-1/+12
| | | | | | | | | | | | previously completely untested.
| | * Fix dodgy tests which were effectively asserting nil == nilJon Leighton2010-12-261-3/+3
| | |
| | * removing SQL interpolation, please use scoping and attribute conditionals as ↵Aaron Patterson2010-12-221-4/+0
| | | | | | | | | | | | a replacement
| * | Merge remote branch 'rails/master' into identity_mapEmilio Tagua2010-12-201-9/+29
| |\| | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/persistence.rb
| | * Fix problem with duplicated records when a :uniq :through association is ↵Jon Leighton2010-12-151-1/+8
| | | | | | | | | | | | preloaded [#2447 state:resolved]
| | * test for eager load of has_one association with condition on the through tablePivotal Labs2010-12-161-1/+9
| | |
| * | Fix number of queries performed in tests.Emilio Tagua2010-11-191-6/+6
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 02:36:01 +0000