aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations/eager_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* When preloading a belongs_to, the target should still be set (to nil) if ↵Jon Leighton2011-01-031-0/+9
| | | | there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations.
* Allow assignment on has_one :through where the owner is a new record [#5137 ↵Jon Leighton2011-01-031-3/+17
| | | | | | | | | | state:resolved] This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct. Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to *does* change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things. Phew, long commit message!
* Some basic tests for the :foreign_type option on belongs_to, which was ↵Jon Leighton2011-01-031-1/+12
| | | | previously completely untested.
* Fix dodgy tests which were effectively asserting nil == nilJon Leighton2010-12-261-3/+3
|
* removing SQL interpolation, please use scoping and attribute conditionals as ↵Aaron Patterson2010-12-221-4/+0
| | | | a replacement
* Fix problem with duplicated records when a :uniq :through association is ↵Jon Leighton2010-12-151-1/+8
| | | | preloaded [#2447 state:resolved]
* test for eager load of has_one association with condition on the through tablePivotal Labs2010-12-161-1/+9
|
* preheating cache so that tests can run in isolationAaron Patterson2010-12-091-0/+5
|
* Removed ids_in_list_limit in favor of in_clause_length defined in ↵Alex Rothenberg2010-11-231-7/+7
| | | | database_limits.rb
* removing space errorsAaron Patterson2010-11-181-1/+1
|
* Adapters can specify maximum number of ids they support in a list of expressionsAlex Rothenberg2010-11-181-0/+52
| | | | | (default is nil meaning unlimited but Oracle imposes a limit of 1000) Limit is used to make multiple queries when preloading associated has_many or habtm records
* fisting a bunch of unused variable warningsAaron Patterson2010-11-151-6/+6
|
* Fixes queries using limits and punctuation in order, removes order("col1, ↵Santiago Pastorino2010-11-051-2/+2
| | | | | | col2") usage in favor of order(["col1", "col2"}) [#4597 state:committed]
* Add some tests for functionality in JoinAssociation which already exists but ↵Jon Leighton2010-10-131-4/+4
| | | | was previously untested
* Revert "porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to master"Aaron Patterson2010-09-281-6/+0
| | | | This reverts commit bee447a5b9fe1d683c6cc69aefb7fc22c2a9d9af.
* porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to masterAaron Patterson2010-09-281-0/+6
|
* Eager loading :through associations will join the :source model if there are ↵Grant Ammons2010-07-081-0/+6
| | | | | | :conditions. [#2362 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Use better assertion methods for testingNeeraj Singh2010-05-191-1/+1
| | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Dont try to load the record from the db if preloading didn't find anythingPratik Naik2010-03-311-0/+6
|
* cleaning up a bunch of parse time warnings in AR [#4186 state:resolved]Aaron Patterson2010-03-151-1/+1
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Don't publicize with_scope for tests since it may shadow public misuseJeremy Kemper2009-12-281-4/+4
|
* Add Model.from and association_collection#from finder methodsPratik Naik2009-12-281-8/+1
|
* Use finder options as relation method names to provide more familiarEmilio Tagua2009-08-181-5/+5
| | | | | naming. Use bang methods convention in methods that alter the relation.
* added :order option to find :first methods and associations as otherwise ↵Raimonds Simanovskis2009-08-061-1/+6
| | | | | | | | Oracle tests were failing Oracle stores '' string as NULL Oracle cannot have identifiers larger than 30 characters added missing fixtures to test setup method
* Fix eager association test related to different ordering on sqliteChad Woolley2009-05-211-1/+1
| | | | | | [#2686 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fixed limited eager loading associations with numbers in the name [#2668 ↵Benjamin Floering2009-05-181-0/+4
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixed eager load error on find with include => [:table_name] and hash ↵Anthony Crumley2009-05-101-0/+12
| | | | | | conditions like {:table_name => {:column => 'value'}} Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Ruby 1.9 compat: rename deprecated assert_raises to assert_raise.Jeremy Kemper2009-03-081-4/+4
| | | | [#1617 state:resolved]
* Fix :include of has_one with :primary_key optionFrederick Cheung2008-12-261-0/+16
|
* Fix :include of has_many associations with :primary_key optionFrederick Cheung2008-12-261-0/+17
|
* Preload uses exclusive scope [#643 state:resolved]Frederick Cheung2008-12-261-0/+15
| | | | | | | | | With self referential associations, the scope for the the top level should not affect fetching of associations, for example when doing Person.male.find :all, :include => :friends we should load all of the friends for each male, not just the male friends.
* Use explicit order to stop test failing randomlyFrederick Cheung2008-12-211-2/+2
|
* Ensure :include checks joins when determining if it can preload [#528 ↵Frederick Cheung2008-12-181-0/+65
| | | | state:resolved]
* Fix preloading of belongs_to with null foreign key generating useless query ↵Frederick Cheung2008-12-181-1/+2
| | | | [#1027 state:resolved]
* Ensure hash conditions on referenced tables are considered when eager ↵Paul2008-11-261-2/+18
| | | | | | loading with limit/offset. [#1404 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Remove SQL Server cases from tests for latest adapter work to pass rails ↵Ken Collins2008-11-191-1/+1
| | | | | | expected behavior. Signed-off-by: Michael Koziarski <michael@koziarski.com>
* explicitly including child associations that are also included in the parent ↵Will Bryant2008-10-101-1/+41
| | | | | | | association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed]
* Fix has_many :through when the source is a belongs_to association. [#323 ↵Zach Dennis2008-10-041-0/+9
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* wrote a test showing eager loading's misbehavior (sanitizing against the ↵Will Bryant2008-09-291-0/+7
| | | | | | wrong table) when the association has a :conditions hash Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Fix yet another implicit order dependant testTarmo Tänav2008-08-261-3/+3
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Load the first and not the last has_one result when doing join-based eager ↵Tarmo Tänav2008-08-251-0/+6
| | | | | | | | | | | loading This matters when the has_one is defined with an order in which case there is an expectation that the first one will be loaded. [#904 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Don't interpret decimals as table names in ↵Peter Wagenet2008-08-211-0/+7
| | | | | | ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Added missing fixtures for tests which fail to run independently if run ↵Tarmo Tänav2008-08-041-1/+1
| | | | | | after schema reset Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Fix conditions and order on join tables with limited eager loading. [#372 ↵Tiago Macedo2008-06-081-1/+12
| | | | state:resolved]
* When preloading group by reflection rather than by class [#125 state:resolved]Frederick Cheung2008-05-111-0/+6
| | | | | | | | This avoids extra queries when several subclasses inherit the association from their parent class, while still coping with subclasses redefining associations. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure hm:t preloading honours reflection options. [#137 state:resolved]Frederick Cheung2008-05-111-0/+11
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure correct record is returned when preloading has_one where more than ↵Frederick Cheung2008-05-061-0/+4
| | | | | | | one row exists Signed-off-by: Michael Koziarski <michael@koziarski.com> [#73 state:closed]
* Fixed AssociationsPreload such that it doesnt require foreign keys to be ↵David Heinemeier Hansson2008-04-301-1/+22
| | | | integers (fcheung) [#33 state:resolved]
* Ensure table names are quoted by the association preloading code.Frederick Cheung2008-04-261-1/+27
| | | | | | [#45 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Make sure ActiveRecord tests can run individually. Closes #11425 ↵Pratik Naik2008-03-281-1/+1
| | | | | | [thechrisoshow, h-lame] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 14:46:35 +0000