rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
*	Abandon TOP support.	Vladimir Kochnev	2018-09-25	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Initially, `TOP` was introduced to support `limit` for MSSQL database. Unlike PostgreSQL/MySQL/SQLite, MSSQL does not have native `LIMIT`/`OFFSET` support. The commit adding `TOP` is 1a246f71616cf246a75ef6cbdb56032e43d4e643. However, it figured out that `TOP` implementation was weak and it's not sufficient to also support `OFFSET`, then `TOP` was substituted with `ROW_NUMBER()` subquery in be48ed3071fd6524d0145c4ad3faeb4aafe3eda3. This is a well known trick in MSSQL - https://stackoverflow.com/questions/2135418/equivalent-of-limit-and-offset-for-sql-server. So now we don't need this `visit_Arel_Nodes_Top` at all. It does nothing useful but also adds an extra space after `SELECT` when `LIMIT` is being used for any database.
*	Fix a wrong correction	Kazuhiro Sera	2018-08-08	1	-1/+1
\|
*	Fix the obvious typos detected by github.com/client9/misspell	Kazuhiro Sera	2018-08-08	1	-1/+1
\|
*	Enable `Layout/EmptyLinesAroundBlockBody` to reduce review cost in the future	Ryuta Kamizono	2018-07-12	1	-11/+0
\| \| \| \| \| \| \|	We sometimes ask "✂️ extra blank lines" to a contributor in reviews like https://github.com/rails/rails/pull/33337#discussion_r201509738. It is preferable to deal automatically without depending on manpower.
*	Make `Arel::Test` subclass of `ActiveSupport::TestCase`	Yasuo Honda	2018-05-01	1	-1/+1
\| \| \| \| \| \| \| \| \| \|	not `Minitest::Test` to address `CustomCops/RefuteNot` and `CustomCops/AssertNot` offenses for Arel test cases Also including `ActiveSupport::Testing::Assertions` to `Arel::Spec` and add test/unit backwards compatibility methods Fixes #32720
*	Arel: rubocop -a	Matthew Draper	2018-02-24	1	-244/+244
\|
*	Merge Arel into Active Record	Matthew Draper	2018-02-24	1	-0/+1236